From unknown Sun Jun 22 07:38:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 12:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 58092@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16641963078937 (code B ref -1); Mon, 26 Sep 2022 12:46:01 +0000 Received: (at submit) by debbugs.gnu.org; 26 Sep 2022 12:45:07 +0000 Received: from localhost ([127.0.0.1]:49569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocnTv-0002K5-1Y for submit@debbugs.gnu.org; Mon, 26 Sep 2022 08:45:07 -0400 Received: from lists.gnu.org ([209.51.188.17]:46770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocnTo-0002JG-79 for submit@debbugs.gnu.org; Mon, 26 Sep 2022 08:45:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocnTo-0007qJ-1k for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 08:45:00 -0400 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]:47627) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocnTm-0005lZ-6b for bug-gnu-emacs@gnu.org; Mon, 26 Sep 2022 08:44:59 -0400 Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id AEAF1100009 for ; Mon, 26 Sep 2022 12:44:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1664196292; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type; bh=6BOhhlYxHruI43vr6wz1Pqga7EHYjCVm4FRmdeEseJA=; b=ArL4iCTOKqYmwAReuLeFo0tTWK3IA4w6cevZ4iYf7GbTFH3qJT0V5Pt5N42r7mkqPZtpr7 5hY35VfEBVSykpo3WUpYX818BSYUn7Hi5OVrOuq1c7NSUufMY5sL8E1HqA84dgDH0+1Hvp VwuIvLpRhRjqUOHy/jzSqjo5Tf7Vt3k9kIPhrTx+WzfL+g7Yq3lLnT8lSWAAawyhduCOSd 9rnOqf/LuZ+nRWgDg6dUDztMQoSkdHrX5YwqxTqopZ/yGslrTVAwVf1tHE7RoTmOU10tvb 9o/eq2+HU60dT33Yu/KWaxfX5zJ1GiavKMyZXwXMgh9BniaU3TPm8+/oVUf5Hg== From: Protesilaos Stavrou Date: Mon, 26 Sep 2022 15:44:50 +0300 Message-ID: <87bkr2mhj1.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: none client-ip=2001:4b98:dc4:8::231; envelope-from=info@protesilaos.com; helo=relay11.mail.gandi.net X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Dear maintainers, The attached patch replaces some hardcoded face properties in log-edit buffers with a named face. The named face allows users/themes to customise how this line is styled. What do you think? All the best, Protesilaos (or simply "Prot") -- Protesilaos Stavrou https://protesilaos.com --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-log-edit-summary-separator-face.patch >From ea287b3d918c6a2cf6181c5671187143b3774bd5 Mon Sep 17 00:00:00 2001 Message-Id: From: Protesilaos Stavrou Date: Mon, 26 Sep 2022 15:41:18 +0300 Subject: [PATCH] Add log-edit-summary-separator face * etc/NEWS: Report on it. * lisp/vc/log-edit.el (log-edit-summary-separator): Add new face. (log-edit-font-lock-keywords): Replace hardcoded face attributes with named face. --- etc/NEWS | 5 +++++ lisp/vc/log-edit.el | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/etc/NEWS b/etc/NEWS index 0a5b7bc29c..ced4ece35d 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1766,6 +1766,11 @@ Writing shorter summary lines avoids truncation in contexts in which Git commands display summary lines. See the two new user options 'vc-git-log-edit-summary-target-len' and 'vc-git-log-edit-summary-max-len'. +--- +*** New 'log-edit-summary-separator' face +Styles the line that separates the log-edit headers from the log-edit +summary. + ** Message --- diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el index 5290616302..25b47a75af 100644 --- a/lisp/vc/log-edit.el +++ b/lisp/vc/log-edit.el @@ -325,6 +325,10 @@ ;;; Actual code (defface log-edit-summary '((t :inherit font-lock-function-name-face)) "Face for the summary in `log-edit-mode' buffers.") +(defface log-edit-summary-separator '((t :height 0.1 :inverse-video t :extend t)) + "Face for the summary separator line in `log-edit-mode' buffers." + :version "29.1") + (defface log-edit-header '((t :inherit font-lock-keyword-face)) "Face for the headers in `log-edit-mode' buffers.") @@ -393,7 +397,7 @@ (defvar log-edit-font-lock-keywords nil lax)) ("^\n" (progn (goto-char (match-end 0)) (1+ (match-end 0))) nil - (0 '(face (:height 0.1 :inverse-video t :extend t) + (0 '(face log-edit-summary-separator display-line-numbers-disable t rear-nonsticky t)))) (log-edit--match-first-line (0 'log-edit-summary)))) -- 2.37.3 --=-=-=-- From unknown Sun Jun 22 07:38:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 13:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Protesilaos Stavrou Cc: 58092@debbugs.gnu.org Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.166419846912518 (code B ref 58092); Mon, 26 Sep 2022 13:22:02 +0000 Received: (at 58092) by debbugs.gnu.org; 26 Sep 2022 13:21:09 +0000 Received: from localhost ([127.0.0.1]:49627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oco2m-0003Fq-OV for submit@debbugs.gnu.org; Mon, 26 Sep 2022 09:21:08 -0400 Received: from quimby.gnus.org ([95.216.78.240]:41410) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oco2j-0003F0-T1 for 58092@debbugs.gnu.org; Mon, 26 Sep 2022 09:21:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ObCGcqicXU6BLPLJJL2Y3+ELtl0xVNVq/NMz9JWLdvc=; b=F9CNEXbRyl6T27q+Lw3ah3RNyv 0q88eRLs2MGCcZd09bBIG+bjKts1pGPrVbnElOpnAMU1oCWTOqBaDPu62e08XI6CEmMg5G4JOH4LO hmkCdEuTJ1AwN69tpi7Sfik/5E0l3bKOEYs/6PuXzS8imGE+CzHK07oS67E9WKXJUx2Q=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oco2b-0008JS-Br; Mon, 26 Sep 2022 15:20:59 +0200 From: Lars Ingebrigtsen In-Reply-To: <87bkr2mhj1.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Mon, 26 Sep 2022 15:44:50 +0300") References: <87bkr2mhj1.fsf@protesilaos.com> X-Now-Playing: Namasenda's _Unlimited Ammo - Infinity_: "No Regrets" Date: Mon, 26 Sep 2022 15:20:56 +0200 Message-ID: <87a66m6zlz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Protesilaos Stavrou writes: > The named face allows users/themes to customise how this line is styled. > > What do you think? Sounds good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Protesilaos Stavrou writes: > The named face allows users/themes to customise how this line is styled. > > What do you think? Sounds good to me. > +(defface log-edit-summary-separator '((t :height 0.1 :inverse-video t :extend t)) Minor nit pick: That's a too-long line. From unknown Sun Jun 22 07:38:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 13:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Protesilaos Stavrou , 58092@debbugs.gnu.org Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.166419853712645 (code B ref 58092); Mon, 26 Sep 2022 13:23:01 +0000 Received: (at 58092) by debbugs.gnu.org; 26 Sep 2022 13:22:17 +0000 Received: from localhost ([127.0.0.1]:49636 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oco3t-0003Ht-DB for submit@debbugs.gnu.org; Mon, 26 Sep 2022 09:22:17 -0400 Received: from mail-oi1-f182.google.com ([209.85.167.182]:46675) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oco3r-0003Hg-Ut for 58092@debbugs.gnu.org; Mon, 26 Sep 2022 09:22:16 -0400 Received: by mail-oi1-f182.google.com with SMTP id g130so8147247oia.13 for <58092@debbugs.gnu.org>; Mon, 26 Sep 2022 06:22:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :from:to:cc:subject:date; bh=vqmEObbO4l2pl4iWH60fy/di3NaUcwffs8B2UlqsMow=; b=EzlSTVR/3J2x3ki7kZnd22WpSNl55qIdA95PhFdDdeNkO61bRNAWjmSLdDUsw8/lC4 oq2rGm/Vt4FE7izHjAhR3HcF0jHthrj/w9aICudmtHq5rq08Ua+OkwhMdYogMAVGnCOW 0zqzXqBAzYmHHrIi1EwDrhUW1ld1aIciK6sg2pft6UHlePrO0Xvrab+mKCpz7hhv4FfX mc0qde/VyDfmZpnj6yxeiNtUi4LbKy/kvlLBoAPDG8X/ERcz9DrmZp6kE2kvwALruJam UX5yhnA/0O4HLMhRNOpMHRA+fw0cBBUYImjN2/xtR4iTuK7ZA3kZuCeVsoNNClEny3w0 HPbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:references:in-reply-to:from :x-gm-message-state:from:to:cc:subject:date; bh=vqmEObbO4l2pl4iWH60fy/di3NaUcwffs8B2UlqsMow=; b=lFOBCXHpdNY261+4kULpdpq6WHuBrOYd9Pj50DQGAMqzdYr7LtUx9qFPxk+xoAPRH1 1CuKScnv4nVj35DxPcBS4/fXc7W/Yyg9Q1SgtvT58u7+9hj0qs7RjH+3LmOnrt93wDgA rBFuI2WhTaMPKKMRCJoHbeu5vVYGdq7ALUpfpnt2KGV/cdco+Dleej2+VecrMJCTppE9 NossWjlyoGgXljkQHw4g1A72SPUOWNkiKTapsptUzIsSd5bOaefOMqy+GYWqw1A/RjD1 yvSyz95Ljct0F7Sh4BXPaGSV3mL3h9seGjl2rtRmpYVW61yYKBYuIk3B93zka1yzdg6x CWpw== X-Gm-Message-State: ACrzQf2iSxzPK0f4iTuCnlPI4t2NdC30PzWgArlLNbrqAL0dM/v46odg cVh7ss1pLtR+bReJ3bjA3fjujoMkM13Xj2d/toyyGPlh X-Google-Smtp-Source: AMsMyM4sBZLGrtGFfSZDNyAQfOXqvPX9qDgsdwZ6Kh454RbVFBJM6UZ4AIjSX9QLLbUh5Ow87zAcQLFSzV33a1NNmTc= X-Received: by 2002:a05:6808:1688:b0:345:ea9a:2954 with SMTP id bb8-20020a056808168800b00345ea9a2954mr14941451oib.199.1664198530259; Mon, 26 Sep 2022 06:22:10 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 26 Sep 2022 09:22:09 -0400 From: Stefan Kangas In-Reply-To: <87bkr2mhj1.fsf@protesilaos.com> References: <87bkr2mhj1.fsf@protesilaos.com> X-Hashcash: 1:20:220926:58092@debbugs.gnu.org::QctjnVY0uIqleEgz:4SrC MIME-Version: 1.0 Date: Mon, 26 Sep 2022 09:22:09 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Protesilaos Stavrou writes: > From ea287b3d918c6a2cf6181c5671187143b3774bd5 Mon Sep 17 00:00:00 2001 > Message-Id: > From: Protesilaos Stavrou > Date: Mon, 26 Sep 2022 15:41:18 +0300 > Subject: [PATCH] Add log-edit-summary-separator face > > * etc/NEWS: Report on it. This line is optional, but I'd put it below the main change and say something like "Announce the new face." > * lisp/vc/log-edit.el (log-edit-summary-separator): Add new face. > (log-edit-font-lock-keywords): Replace hardcoded face attributes with > named face. > --- > etc/NEWS | 5 +++++ > lisp/vc/log-edit.el | 6 +++++- > 2 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/etc/NEWS b/etc/NEWS > index 0a5b7bc29c..ced4ece35d 100644 > --- a/etc/NEWS > +++ b/etc/NEWS > @@ -1766,6 +1766,11 @@ Writing shorter summary lines avoids truncation in contexts in which > Git commands display summary lines. See the two new user options > 'vc-git-log-edit-summary-target-len' and 'vc-git-log-edit-summary-max-len'. > > +--- > +*** New 'log-edit-summary-separator' face > +Styles the line that separates the log-edit headers from the log-edit > +summary. I'd say: "It is used for the 'log-edit' headers ..." > + > ** Message > > --- > diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el > index 5290616302..25b47a75af 100644 > --- a/lisp/vc/log-edit.el > +++ b/lisp/vc/log-edit.el > @@ -325,6 +325,10 @@ ;;; Actual code > (defface log-edit-summary '((t :inherit font-lock-function-name-face)) > "Face for the summary in `log-edit-mode' buffers.") > > +(defface log-edit-summary-separator '((t :height 0.1 :inverse-video t :extend t)) Maybe put the value on a separate line (in case we want to extend it later)? > + "Face for the summary separator line in `log-edit-mode' buffers." > + :version "29.1") > + > (defface log-edit-header '((t :inherit font-lock-keyword-face)) > "Face for the headers in `log-edit-mode' buffers.") > > @@ -393,7 +397,7 @@ (defvar log-edit-font-lock-keywords > nil lax)) > ("^\n" > (progn (goto-char (match-end 0)) (1+ (match-end 0))) nil > - (0 '(face (:height 0.1 :inverse-video t :extend t) > + (0 '(face log-edit-summary-separator > display-line-numbers-disable t rear-nonsticky t)))) > (log-edit--match-first-line (0 'log-edit-summary)))) Other than those nits, LGTM (but I didn't test it). From unknown Sun Jun 22 07:38:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 13:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Protesilaos Stavrou , 58092@debbugs.gnu.org Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.166419895113190 (code B ref 58092); Mon, 26 Sep 2022 13:30:03 +0000 Received: (at 58092) by debbugs.gnu.org; 26 Sep 2022 13:29:11 +0000 Received: from localhost ([127.0.0.1]:49641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocoAZ-0003Qg-DZ for submit@debbugs.gnu.org; Mon, 26 Sep 2022 09:29:11 -0400 Received: from mail-wr1-f54.google.com ([209.85.221.54]:33705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocoAT-0003QH-Eh for 58092@debbugs.gnu.org; Mon, 26 Sep 2022 09:29:09 -0400 Received: by mail-wr1-f54.google.com with SMTP id s14so10318943wro.0 for <58092@debbugs.gnu.org>; Mon, 26 Sep 2022 06:29:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=E4THUbmswxcROGurRJITm9vRYYLUoDIanxvjFDs00Vs=; b=PNDsQYgx8DaSLqSBlv7vBKkYoQMmQvBYFwMkgFAwMOO4FemIS6r8hWUNlZn0DE//VW mFZ9IASp4vO9TF60y+ySGOOhP4wXDpTGwc2WVa0ugLoh9eFzjSHyv0Apw7w/BJoksD7G pTAZtiZF/MhFSK8J8faq8KsRqbch9Bvxzuhibw7T5OhImXOmxV3mu2OhmALjGiN3J+fT zASALrR0tFU2i95J3pRGlY+sw+bctJP8+gTXB0Q/oqnk2g+ka05CMZDmALqysjJwIxKc HjlNLwDlDpPBFrutpP/uo+mkochkcxYBHU+iOV+D2Q1cBHjT37a6qi815hhS4YDaN0vH VM1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=E4THUbmswxcROGurRJITm9vRYYLUoDIanxvjFDs00Vs=; b=NnjMbbe0uwyFaTE90mqmoBtaxcZdZnD64f0e2OEPm+ngA22vufYLceqSurKT4TnUIu rUf0DoiyU+tsdMbfiKWxVtSbrQQv9G4Scph7DJ8yuqTs8chep3lU+K29A8f1fS+sH5V3 mgnUTW25MDZwxCQFFROYSoQvug5l0WVGzd68Vag5ZpOvmraWxKSv6Iv3a7hPQK7++QCq NKOauqQIqmElmiNMpiq9NjWO8dEgkCFis9cAXn5aC/WJ2ALxSLUfaGG6sugm9LwiJYsX wy5kL7P4hwzzAcbR8/Zxl7X7f5/ECT5F5rs0amaUrz7W0Y0otPfDHQC9oJ7ZiPMCJrBl RF0g== X-Gm-Message-State: ACrzQf3WoavRh9tMDcHwkPc9zyXZP65aOIVV7mhldIbBuipxMotKuAPO tc5rJvCr89S4RT5Od+PwxZY= X-Google-Smtp-Source: AMsMyM45Htm7T0DpOCCPy0KJzDHvvDN4D2qw3zn0HleOsp9ehbhgdHa/JZnbOutgD9NX1yM28DoHtg== X-Received: by 2002:a5d:6c6e:0:b0:22a:c36d:e411 with SMTP id r14-20020a5d6c6e000000b0022ac36de411mr13174801wrz.183.1664198939434; Mon, 26 Sep 2022 06:28:59 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id p21-20020a1c5455000000b003b27f644488sm10856656wmi.29.2022.09.26.06.28.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 06:28:59 -0700 (PDT) Message-ID: Date: Mon, 26 Sep 2022 16:28:56 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US References: <87bkr2mhj1.fsf@protesilaos.com> From: Dmitry Gutov In-Reply-To: <87bkr2mhj1.fsf@protesilaos.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Hi! On 26.09.2022 15:44, Protesilaos Stavrou wrote: > Dear maintainers, > > The attached patch replaces some hardcoded face properties in log-edit > buffers with a named face. > > The named face allows users/themes to customise how this line is styled. > > What do you think? LGTM, except perhaps call it headers-separator? It's used to separate all the headers, not just summary. From unknown Sun Jun 22 07:38:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 14:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Dmitry Gutov , 58092@debbugs.gnu.org Cc: Lars Ingebrigtsen , Stefan Kangas Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.16642012013159 (code B ref 58092); Mon, 26 Sep 2022 14:07:01 +0000 Received: (at 58092) by debbugs.gnu.org; 26 Sep 2022 14:06:41 +0000 Received: from localhost ([127.0.0.1]:51292 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocoko-0000oq-1A for submit@debbugs.gnu.org; Mon, 26 Sep 2022 10:06:41 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:59183) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocoki-0000oZ-Pf for 58092@debbugs.gnu.org; Mon, 26 Sep 2022 10:06:36 -0400 Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id F2F8B24000C; Mon, 26 Sep 2022 14:06:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1664201186; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=N0/kGbAk5KWNSqPmKI+mGx8QvsGIWPuhj0rkqSUFHmw=; b=GQJH/QmwJy/bhR+JACfMjW7Xd9xzHq0eH7DgGmjCMDBXMowykJ8o4VYqf3E0OAsp7YVlae +f0gA0eHNsIqtwW7TIcjeQNPI1vpKMxdzSBGzRMfGQ/zZ1lOnoxVtYmJYwQw9Sg3RCJFXp 0NVEpZXsD4wfED0vuBtSoW+34CQ/L86Alf5+mQM8lxemgIDQ+AIM5iTl7cCHn5foNvKxC+ WtRtRLrSu+498JcBz8t9zkipTeIAdfnanKVf8ht2YfG7Lh+0duTfkDDECYsKogm/VFvsH/ h5taGBADFvfkX/Yxb6MTMFQM93xpYz13rzOq7BDD19qkMAeErF1xwY2m97+ndA== From: Protesilaos Stavrou In-Reply-To: References: <87bkr2mhj1.fsf@protesilaos.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Mon, 26 Sep 2022 17:06:22 +0300 Message-ID: <87a66mdych.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > From: Dmitry Gutov > Date: Mon, 26 Sep 2022 16:28:56 +0300 > > Hi! > > On 26.09.2022 15:44, Protesilaos Stavrou wrote: >> Dear maintainers, >> >> The attached patch replaces some hardcoded face properties in log-edit >> buffers with a named face. >> >> The named face allows users/themes to customise how this line is styled. >> >> What do you think? > > LGTM, except perhaps call it headers-separator? It's used to separate > all the headers, not just summary. Hello everyone, I made the changes as you suggested and pushed them as commit a386833503. However, I forgot to update the commit message of the patch: it still mentions the old name of the face 'log-edit-summary-separator' instead of 'log-edit-headers-separator'. Sorry for this mistake! Can I revert or amend it? -- Protesilaos Stavrou https://protesilaos.com From unknown Sun Jun 22 07:38:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 14:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Protesilaos Stavrou , 58092@debbugs.gnu.org Cc: Lars Ingebrigtsen , Stefan Kangas Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.16642027645632 (code B ref 58092); Mon, 26 Sep 2022 14:33:01 +0000 Received: (at 58092) by debbugs.gnu.org; 26 Sep 2022 14:32:44 +0000 Received: from localhost ([127.0.0.1]:51317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocpA4-0001Sm-8S for submit@debbugs.gnu.org; Mon, 26 Sep 2022 10:32:44 -0400 Received: from mail-wr1-f49.google.com ([209.85.221.49]:33343) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocpA1-0001SY-6i for 58092@debbugs.gnu.org; Mon, 26 Sep 2022 10:32:42 -0400 Received: by mail-wr1-f49.google.com with SMTP id s14so10618158wro.0 for <58092@debbugs.gnu.org>; Mon, 26 Sep 2022 07:32:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:from:to:cc:subject:date; bh=u6mNiC78HtXir4V4Ey7GHxXevUe6BnaGpb4jFJ/PrIw=; b=nHa5awGOW5umHC+NbpC0xK2g+wdwP9V9iGuprR2NYYxd8NkqpMU+RQTI03HCtphCs5 S/UcITGMQ/0o/mbQDhcwqMbisPyzdOz90sQSiPp/7Jyh1jWycSXplx50w/mj1WGAUvvL T+6FJdupAi8xQX8xR1jvBalOxdZO1+92skXU6gvvl5rPdk6aTAQpYMjLyUC9F1xRN9fG JTteID2csqYkvcmpHX+U56HfQpex4+IG6qS5/xGdvMmhedH65+rjqmZdrcmibLC5F2Ly Q3poEDr475oU/XsV3tVRARnMgigBRJ1+A4NsfN6H/TkN4/Z1srnA4YkNmZo6zC8u4b3C pKCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :sender:x-gm-message-state:from:to:cc:subject:date; bh=u6mNiC78HtXir4V4Ey7GHxXevUe6BnaGpb4jFJ/PrIw=; b=UnVspPhn6gJYciIS5TmnfpJuRQ7YSRZVK0KnZ7uiHpFrUGdkV7fg7QPbeuU9oWyA8a G5nHKaJVhFrJImL8cLeEdsKi0dzRCLtt0OvolTRNlwM5vp/k+Gd/h5kl/vlFptKXDNha 9QFt2qJvsD6IZn4KM2FfHfrqu40XCj5Iq0UOYWxc67kEQ8JZt3GW/aqWXyJtPUevF27q PQOg19cbmR42HeJ2EjNfashEtILF754+VX2ZR+j3gwxCNgymYI7QaE2Jr6SlsSbq7PKs Cu1tVWz0tBYP/Fc7nYZHa1gmXpT215VuReyLzLoWym206vZCd3LnsU7+W/7rHP6YJfr/ J+ww== X-Gm-Message-State: ACrzQf2NZo8l2zp2bnxpj7nu29EFbEWIuQdDvLyPHiu8DMh7UgnnzkXi t7vKxVIQGiqb5lmRotwfL4w= X-Google-Smtp-Source: AMsMyM5GSXhC+IZf1eGdE6ogYJLYRGfFDRHJ4lA6a2sggMi2MFl9pIZYa45gqMOmt1z30OoyydVEQA== X-Received: by 2002:a05:6000:1887:b0:22a:3c3d:75ea with SMTP id a7-20020a056000188700b0022a3c3d75eamr13036726wri.669.1664202755296; Mon, 26 Sep 2022 07:32:35 -0700 (PDT) Received: from [192.168.0.6] ([46.251.119.176]) by smtp.googlemail.com with ESMTPSA id e11-20020adfef0b000000b0022ae0965a8asm14736803wro.24.2022.09.26.07.32.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Sep 2022 07:32:34 -0700 (PDT) Message-ID: <7685a637-aa8f-3746-a0ad-7d07cce003be@yandex.ru> Date: Mon, 26 Sep 2022 17:32:32 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Content-Language: en-US References: <87bkr2mhj1.fsf@protesilaos.com> <87a66mdych.fsf@protesilaos.com> From: Dmitry Gutov In-Reply-To: <87a66mdych.fsf@protesilaos.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) On 26.09.2022 17:06, Protesilaos Stavrou wrote: >> From: Dmitry Gutov >> Date: Mon, 26 Sep 2022 16:28:56 +0300 >> >> Hi! >> >> On 26.09.2022 15:44, Protesilaos Stavrou wrote: >>> Dear maintainers, >>> >>> The attached patch replaces some hardcoded face properties in log-edit >>> buffers with a named face. >>> >>> The named face allows users/themes to customise how this line is styled. >>> >>> What do you think? >> LGTM, except perhaps call it headers-separator? It's used to separate >> all the headers, not just summary. > Hello everyone, > > I made the changes as you suggested and pushed them as commit > a386833503. However, I forgot to update the commit message of the > patch: it still mentions the old name of the face > 'log-edit-summary-separator' instead of 'log-edit-headers-separator'. > > Sorry for this mistake! Can I revert or amend it? If it's just in the commit message, then a revert won't help. And I don't think we have any tools for amending the change log so far. In any case, NEWS is more important than the commit message. So it's probably fine. From unknown Sun Jun 22 07:38:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 14:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Protesilaos Stavrou Cc: Lars Ingebrigtsen , 58092@debbugs.gnu.org, Stefan Kangas , Dmitry Gutov Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.16642032466364 (code B ref 58092); Mon, 26 Sep 2022 14:41:02 +0000 Received: (at 58092) by debbugs.gnu.org; 26 Sep 2022 14:40:46 +0000 Received: from localhost ([127.0.0.1]:51322 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocpHq-0001ea-5e for submit@debbugs.gnu.org; Mon, 26 Sep 2022 10:40:46 -0400 Received: from mail-wm1-f54.google.com ([209.85.128.54]:40454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocpHo-0001eL-7I for 58092@debbugs.gnu.org; Mon, 26 Sep 2022 10:40:45 -0400 Received: by mail-wm1-f54.google.com with SMTP id u16-20020a05600c211000b003b5152ebf09so5080707wml.5 for <58092@debbugs.gnu.org>; Mon, 26 Sep 2022 07:40:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=kX2ay7tVefSjOr2EzzV84TO8DoHkuSYBhmwFP677syI=; b=FFx9zXxccN2QSpapS8thqWHVJ5A7ZlfYwYxaSXVrRTW+hIiHmIoD6tVfZt+rGAi+En LDvnDAyQDkVQ+DyBzZACYUjNVXkop1Cj8NRfraZuhMg401M5ReaJKPeIx77nip8eAHfY XEIyQdp/q7rACYkknkLypdOSgKMa+ZiRIhQGZ6zVFTnVgZZvfSleHkfIe6Rhy1VJfmDb mhA4gjBqXVaEdEUvGXq6CG87ySbNPlxTxe0FLlWaEj0wY5hBDhbKECJDJVwW+BfsKTCX HDDXeT5I5y2x1l2rTSteMNr5ekTt4d4pMM88vnQWRB+u6VMFIuPym1GjzjHTSpWjWXM+ FbEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date; bh=kX2ay7tVefSjOr2EzzV84TO8DoHkuSYBhmwFP677syI=; b=UEd1WH+wkIzYUNmUhFZ+uX5YULB5YqleFl4Mfun6E9+ZX3s818cc8tYIXuOT8Dojno 6D89tsC4H5Kxs92OrYlPFMTp9OJjgg8QAblncmcjDSsSHMvNmcZflUaOyZ72GztXI1QN 3OGzZMF3y6CWRC1xKvU1rs+MDJ+fdK4uamrX6jSR1jdyuzDF1FETur/m1mU4XdSNxx+2 PyvIDBEjrDU/23hc04f8mt+j/5t103bx6TaJTGViG287wrcpaZAz+ywNjpUzfXbFt7LY ew/UF+54WyCg+urarc0uNtVBugYqVvR2V5SeADvdQtDUGdXV98+7O8e9JU8RjOaZhNOt I2fA== X-Gm-Message-State: ACrzQf2e8pe4vBszZTO/MDiC6LMDFmVvmOhIZdgSGXO1RJdpJhet825L 3x6T5zjv06kROLXx/6YeVb4= X-Google-Smtp-Source: AMsMyM5qEq/5D1CYuIpJW/q9EYlMMEnuIeLPO02gQ+Y//DP8NDIKBTLWI5eeK0JInqjhkqG27xOiaQ== X-Received: by 2002:a05:600c:217:b0:3b4:9abc:a5d3 with SMTP id 23-20020a05600c021700b003b49abca5d3mr22301747wmi.17.1664203238005; Mon, 26 Sep 2022 07:40:38 -0700 (PDT) Received: from rltb ([2a01:e0a:3f3:fb50:2e48:1c6b:2114:6f3b]) by smtp.gmail.com with ESMTPSA id w9-20020a5d5449000000b0022ca921dc67sm2072245wrv.88.2022.09.26.07.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Sep 2022 07:40:37 -0700 (PDT) From: Robert Pluim In-Reply-To: <87a66mdych.fsf@protesilaos.com> (Protesilaos Stavrou's message of "Mon, 26 Sep 2022 17:06:22 +0300") References: <87bkr2mhj1.fsf@protesilaos.com> <87a66mdych.fsf@protesilaos.com> Date: Mon, 26 Sep 2022 16:40:36 +0200 Message-ID: <87czbi9p23.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) >>>>> On Mon, 26 Sep 2022 17:06:22 +0300, Protesilaos Stavrou said: Protesilaos> I made the changes as you suggested and pushed them as com= mit Protesilaos> a386833503. However, I forgot to update the commit messag= e of the Protesilaos> patch: it still mentions the old name of the face Protesilaos> 'log-edit-summary-separator' instead of 'log-edit-headers-= separator'. Protesilaos> Sorry for this mistake! Can I revert or amend it? amend no. revert yes, but it=CA=BCs overkill for just a commit message issu= e. You can always run 'make change-history' and fix it in the resulting ChangeLog file (see admin/notes/repo for the details) Robert --=20 From unknown Sun Jun 22 07:38:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 14:50:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Robert Pluim Cc: Protesilaos Stavrou , 58092@debbugs.gnu.org, Lars Ingebrigtsen , Dmitry Gutov Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.16642037997345 (code B ref 58092); Mon, 26 Sep 2022 14:50:02 +0000 Received: (at 58092) by debbugs.gnu.org; 26 Sep 2022 14:49:59 +0000 Received: from localhost ([127.0.0.1]:51326 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocpQl-0001uP-8E for submit@debbugs.gnu.org; Mon, 26 Sep 2022 10:49:59 -0400 Received: from mail-ot1-f49.google.com ([209.85.210.49]:37692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocpQj-0001uB-0g for 58092@debbugs.gnu.org; Mon, 26 Sep 2022 10:49:57 -0400 Received: by mail-ot1-f49.google.com with SMTP id w22-20020a056830061600b006546deda3f9so4591294oti.4 for <58092@debbugs.gnu.org>; Mon, 26 Sep 2022 07:49:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date; bh=Y+Fhu8Ko3/njgeX8JCLiNkBuc9puVgCaiQ/iIangjfI=; b=V6YyuVid6ENulxcZ/aMuLJIo40z3RKTyYsa/jYZXRipoeprPBPmyCxKfHIjecnDYoQ +3HDj1INrYbMkHba5KuzCdsSXoBTSgGFljptah52DveSqw+E4HsoNhCdl3O3I9r89Zt4 ySH3VL7Eh/B9izMre9jKR2MycGxx0B6aTArtKmILEoGTO37pN7pUTvpbv8yvdx6CW/Te K2utv8WK1aiW7W9AKGBaf0TaumHh9VVhMebKKtw4XMbxkyDlsYPhc8JiEMeW/sXJJTdL Q6hz20dYwHDxC2v8WLwgTLbCQS7hgkj706VJs5FjJhG0pfSuPMm1GX39faYcA3G80SfA Ogyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=Y+Fhu8Ko3/njgeX8JCLiNkBuc9puVgCaiQ/iIangjfI=; b=Mmh/obrQG/C9BKLCAkDOq5WmEEnaX5dVL8x/swUIgot1k42JGlnXZsE2lF6hIYSFPE GF0D+ukWq5I7Nrl7d817bW5euMCDgHVwiHrcVHGle7hghRg+aEutrEc8xUTrMQle2Fno Ui9x27Y0iYVcktk2HvM6hK5bP6TFHBz7HCyvhYVEu/XGYCG+pg/KSbXXZROnxJlsQKG9 jduUjE3aoKyAQl87TPCpZTSxKGtqaEK0GgY4y9vLYOjILJHgwxmnN8tDI5QV7Lch9ie9 oh4mELpJKJd5cnQocUfWBeL8ZcJtBLSnNoUkfOxUIjXmIHOTnLBFfAS5PyO6Ebx+D4IN ocxw== X-Gm-Message-State: ACrzQf2IxayFkwLS+hALpiiqVv85Cl0cEQGohUdNNfaIVmtw+yEpVc4M Wnubgaw+8sFpGMoPfkMXFHM3RFqJJzLamkW4LUg= X-Google-Smtp-Source: AMsMyM6ClGsXcYCsgJW/uyesG7RMxymPOHFLsMmSwbDUh3Qh13d+wBXTG/tj2wM0QuOJhpsslOs0+438DohZpvY0a58= X-Received: by 2002:a9d:7c89:0:b0:655:dfb1:331c with SMTP id q9-20020a9d7c89000000b00655dfb1331cmr9829172otn.224.1664203791390; Mon, 26 Sep 2022 07:49:51 -0700 (PDT) MIME-Version: 1.0 References: <87bkr2mhj1.fsf@protesilaos.com> <87a66mdych.fsf@protesilaos.com> <87czbi9p23.fsf@gmail.com> In-Reply-To: <87czbi9p23.fsf@gmail.com> From: Stefan Kangas Date: Mon, 26 Sep 2022 16:49:39 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Robert Pluim writes: > amend no. revert yes, but it=CA=BCs overkill for just a commit message is= sue. You > can always run 'make change-history' and fix it in the resulting > ChangeLog file (see admin/notes/repo for the details) Please don't do that, it will make merging more tricky later. From unknown Sun Jun 22 07:38:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Resent-From: Protesilaos Stavrou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 14:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas , Robert Pluim Cc: Lars Ingebrigtsen , 58092@debbugs.gnu.org, Dmitry Gutov Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.16642041327848 (code B ref 58092); Mon, 26 Sep 2022 14:56:01 +0000 Received: (at 58092) by debbugs.gnu.org; 26 Sep 2022 14:55:32 +0000 Received: from localhost ([127.0.0.1]:51331 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocpW7-00022V-UN for submit@debbugs.gnu.org; Mon, 26 Sep 2022 10:55:32 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:35709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocpW4-00022G-Fp for 58092@debbugs.gnu.org; Mon, 26 Sep 2022 10:55:30 -0400 Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id 7DF416000F; Mon, 26 Sep 2022 14:55:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1664204121; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I5bIHtPjzYg6wabhRMcQ9+IB7SHHEcxf6BXQwVJQ020=; b=FrS3ZY9pNNHZ2+Wr5IvglyntTkWdhZ39ZElsnrqOvLB3zSRof/qr/mfuYuiB74HOd3xDPy hTk7p20K+UiCYt4DoYrVxNjUMrfUlYNzpRASHr1CtSKW9PD8qTrcoIg68moBSqIXH2Wcuc BXTZr8aqHM1r7tHcF9CXoD9CFSpgREb+MsAJLoQoi/CaRdjZBah6s4fFE7WxxWetYtbi8k fdj43ALJ22HrwNBQxMYf2HJXktG/HdKiZA2BLqIUkgQdlZ1y1olhJQER26B0vU6ucA3oxT 8WN8i8EfM6UJB9/LkPCKwdId7m5tkQKwTVfyyfaIkLNC/8xhMnZe8VscNMKnMw== From: Protesilaos Stavrou In-Reply-To: References: <87bkr2mhj1.fsf@protesilaos.com> <87a66mdych.fsf@protesilaos.com> <87czbi9p23.fsf@gmail.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Mon, 26 Sep 2022 17:55:18 +0300 Message-ID: <874jwudw2x.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) PiBGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29tPg0KPiBEYXRlOiBN b24sIDI2IFNlcCAyMDIyIDE2OjQ5OjM5ICswMjAwDQo+DQo+IFJvYmVydCBQbHVpbSA8cnBsdWlt QGdtYWlsLmNvbT4gd3JpdGVzOg0KPg0KPj4gYW1lbmQgbm8uIHJldmVydCB5ZXMsIGJ1dCBpdMq8 cyBvdmVya2lsbCBmb3IganVzdCBhIGNvbW1pdCBtZXNzYWdlIGlzc3VlLiBZb3UNCj4+IGNhbiBh bHdheXMgcnVuICdtYWtlIGNoYW5nZS1oaXN0b3J5JyBhbmQgZml4IGl0IGluIHRoZSByZXN1bHRp bmcNCj4+IENoYW5nZUxvZyBmaWxlIChzZWUgYWRtaW4vbm90ZXMvcmVwbyBmb3IgdGhlIGRldGFp bHMpDQo+DQo+IFBsZWFzZSBkb24ndCBkbyB0aGF0LCBpdCB3aWxsIG1ha2UgbWVyZ2luZyBtb3Jl IHRyaWNreSBsYXRlci4NCg0KT2theSwgSSB3aWxsIGp1c3QgbGVhdmUgaXQgYXMtaXMuICBXaWxs IGJlIG1vcmUgY2FyZWZ1bCBuZXh0IHRpbWUuDQoNCi0tIA0KUHJvdGVzaWxhb3MgU3RhdnJvdQ0K aHR0cHM6Ly9wcm90ZXNpbGFvcy5jb20NCg== From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 27 07:58:22 2022 Received: (at control) by debbugs.gnu.org; 27 Sep 2022 11:58:22 +0000 Received: from localhost ([127.0.0.1]:53212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od9EE-0006Vc-7h for submit@debbugs.gnu.org; Tue, 27 Sep 2022 07:58:22 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51746) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1od9EC-0006VN-UZ for control@debbugs.gnu.org; Tue, 27 Sep 2022 07:58:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=MKVPXYJUWhPU2ClFjCZVmHfRr0p0tWQBd5BFC5Oci3Q=; b=SLLeQd7+dxCaP8qsrYZ3dgIywz nEVpOwvb/hz8Wq4hTRjvRpZ2PC/q7iEDIgkNY5+WLR44ligGrvgifR2c/lBBIWNZQhPAStaukitcu d/Wd8LW8mH2FSFSx3CPkOAXEZ3AdCk09zbvSwMF8s2XgGuEfWKnVZfenNkvyHNOsUXss=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1od9E5-0001X7-8n for control@debbugs.gnu.org; Tue, 27 Sep 2022 13:58:15 +0200 Date: Tue, 27 Sep 2022 13:58:12 +0200 Message-Id: <87czbh3u7f.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #58092 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 58092 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 58092 29.1 quit From unknown Sun Jun 22 07:38:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Sep 2022 15:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: Lars Ingebrigtsen , Robert Pluim , Dmitry Gutov , Protesilaos Stavrou , 58092@debbugs.gnu.org Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.166429384411838 (code B ref 58092); Tue, 27 Sep 2022 15:51:01 +0000 Received: (at 58092) by debbugs.gnu.org; 27 Sep 2022 15:50:44 +0000 Received: from localhost ([127.0.0.1]:56594 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odCr5-00034r-VO for submit@debbugs.gnu.org; Tue, 27 Sep 2022 11:50:44 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:34511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odCqz-00034Z-Li for 58092@debbugs.gnu.org; Tue, 27 Sep 2022 11:50:41 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 67A365C0152; Tue, 27 Sep 2022 11:50:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 27 Sep 2022 11:50:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1664293832; x= 1664380232; bh=tSaZBVrJ6qdw/R9uut56H7D8zHMLGUCEvU19Fp0CFsk=; b=Z 2xQT41EZPVffu4QpFyZQp+uEiSUMtcnQ907vk0vxkSr28nhnwkgZe/VjPxINoVoI MEwUU01LP0xL/hAzPjHyzLTmBe4UkZDbplbQ/+HiWQhvOOC9f+7Ku525au7DHiHD DZjj6rp6c+pQ3CM86GgZK3pxoDB20q0N/K+70v1StwiqBKeC6r65OmAzPa3HKcCA oG69z/d5f5HZLxyl0qr3xM13hxqh8rvRzX0xyfKFBsevJ1tHCGqV99WSrOb4t6Mr W4Uw7+iqkQ7HAx/MU2UlNnPpv+8Hber/EdonaV7XI9+lwlDjhwm/740X9vWmSTb/ o8IFQg4UE11hnNaxA4J+A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664293832; x= 1664380232; bh=tSaZBVrJ6qdw/R9uut56H7D8zHMLGUCEvU19Fp0CFsk=; b=z LoAW+DFx4sI1Eta6GiD0PQilps4RF9rDIpJdhLEy7LfjfljJSlCzsuntrdZkIiog UawuAFLl/1tm/m6UZrbn6fus/CG6q9I6VHhkrDDXH0lk/ao+OkNYxYQORrH97A/u ysVuU6Pr/IT1Ulu62YfhTTSV/hDPcrRczxQhFsQ1JRw8gJ3rfP5jIH5uEVNJdypu vPoZmfreufwi2YW0wHn+wT+uAFT9cbXVX622bujJdLV/OwzFTMQMNnIu7iua6IPq aVW5m31KyKSmgjBkf5T0dpXkEHqeux4MdcdgMU5Xnqt/Zz+tPu09a2562/HkmHVX 0a/hJMU/+JLcmn5Qr/5gw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegiedgieekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgfgsehtqhdttddtreejnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnhepffefhfejudeguddtudekjeekueevvedvieeghfegleet uefhkeegkefhleejvddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Sep 2022 11:50:31 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 500B57E0AC5; Tue, 27 Sep 2022 08:50:31 -0700 (MST) From: Sean Whitton In-Reply-To: (Stefan Kangas's message of "Mon, 26 Sep 2022 16:49:39 +0200") References: <87bkr2mhj1.fsf@protesilaos.com> <87a66mdych.fsf@protesilaos.com> <87czbi9p23.fsf@gmail.com> Date: Tue, 27 Sep 2022 08:50:31 -0700 Message-ID: <87h70szuig.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Mon 26 Sep 2022 at 04:49PM +02, Stefan Kangas wrote: > Robert Pluim writes: > >> amend no. revert yes, but it=CA=BCs overkill for just a commit message i= ssue. You >> can always run 'make change-history' and fix it in the resulting >> ChangeLog file (see admin/notes/repo for the details) > > Please don't do that, it will make merging more tricky later. Hmm, so it's never okay to do that? Or is it to be saved for the more egregrious errors? --=20 Sean Whitton From unknown Sun Jun 22 07:38:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Sep 2022 16:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Sean Whitton Cc: Lars Ingebrigtsen , Robert Pluim , Dmitry Gutov , Protesilaos Stavrou , 58092@debbugs.gnu.org Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.166429534014232 (code B ref 58092); Tue, 27 Sep 2022 16:16:01 +0000 Received: (at 58092) by debbugs.gnu.org; 27 Sep 2022 16:15:40 +0000 Received: from localhost ([127.0.0.1]:56618 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odDFD-0003hU-VW for submit@debbugs.gnu.org; Tue, 27 Sep 2022 12:15:40 -0400 Received: from mail-oa1-f46.google.com ([209.85.160.46]:39697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odDFA-0003hE-7C for 58092@debbugs.gnu.org; Tue, 27 Sep 2022 12:15:38 -0400 Received: by mail-oa1-f46.google.com with SMTP id 586e51a60fabf-11e9a7135easo13904186fac.6 for <58092@debbugs.gnu.org>; Tue, 27 Sep 2022 09:15:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:from:to:cc:subject:date; bh=t26rNQLSUXGq1b9OgMgZcmgwIlBqat7a3BSmmc304Ts=; b=VmwGc7AZeGLvZtHMInj3ucD3mF9MKyI9UZrZOhYYqmYEixC2NaBPfu42EHHAri5gog AUgRi5quiajtGghiraUOVNpRjQaFPof4fgYFj3YMXNal7sB6YZELwbSDvifw8+wEl0Zq Kh74vjQLn7adzt7FvLM6d0Lp7fLIkehELLWOQC9bDZDSOVwv0GrEbzvQDJQ3Qar+w168 H2WdEaBTbYgXGos0E9aGbwPaNUY/STXpx7tgLrpQPaSCpEmPX5Ngd3r0iGZVks5hTaS2 gl2iZpQBiaR+KF9mfVdBDBWtCLvhgDtD0quY8Yv/Fam2E3h8tMGdQDKm33sXzxEMal2b Sriw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date :mime-version:references:in-reply-to:from:x-gm-message-state:from:to :cc:subject:date; bh=t26rNQLSUXGq1b9OgMgZcmgwIlBqat7a3BSmmc304Ts=; b=U747Y0jYgbCudpgN5Oljz3xsL9izdiqh0qQ481jUt7PT373QEJXGLVidB6l8pUKHho 29CENh4TWEk8SkW8aNW5SAqG34C9akIiKo7MFCt3n1cAPE6iZhaW2isc718JB1GgcCNB XDHGFaW7CEhZYfx0DaUsKGFEmPPgKFlDc3qg3PtAzRpdvpQt8EBYVi3iO17+Mqa07+Bn 9gWQcy9yCPCc6U+IlkWk3u5EH7EQ3/0gNuxs4f0klop/laXKzRbBs3df2ptYwzjxbC2c 9lD2/q1noWburvldIJ95PMdhyLXLKFx0TTOVzDyEFPffo+XG4Rbz8u1ZKTKr68LibDoe vxVA== X-Gm-Message-State: ACrzQf2TnKtyXYU+x1O0VLsa1IIlpC32t52dF/4+ackjvEal2eqqMGCT w2Dtue9IpOI/WQyW/Dy7kIu308cacTRPCXEJye0= X-Google-Smtp-Source: AMsMyM7ooJO2pGeqPwwsVtO5rgFl9NieooKg2WWvlcwEqu13Jrxo5JCuTkyvmyrx3loAMFSPAAVldjvNWHj1zP2VCOw= X-Received: by 2002:a05:6870:46a6:b0:12d:130c:2fd5 with SMTP id a38-20020a05687046a600b0012d130c2fd5mr2593346oap.92.1664295330308; Tue, 27 Sep 2022 09:15:30 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 27 Sep 2022 12:15:29 -0400 From: Stefan Kangas In-Reply-To: <87h70szuig.fsf@melete.silentflame.com> References: <87bkr2mhj1.fsf@protesilaos.com> <87a66mdych.fsf@protesilaos.com> <87czbi9p23.fsf@gmail.com> <87h70szuig.fsf@melete.silentflame.com> X-Hashcash: 1:20:220927:info@protesilaos.com::8SCy5IgRzDiHEa/8:6JSg MIME-Version: 1.0 Date: Tue, 27 Sep 2022 12:15:29 -0400 Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Sean Whitton writes: >>> amend no. revert yes, but it=CA=BCs overkill for just a commit message = issue. You >>> can always run 'make change-history' and fix it in the resulting >>> ChangeLog file (see admin/notes/repo for the details) >> >> Please don't do that, it will make merging more tricky later. > > Hmm, so it's never okay to do that? Or is it to be saved for the more > egregrious errors? It's easier for me (or whoever is charge of merging and/or releases) if we don't do that, so I'd prefer it if we could reserve it for particularly nasty mistakes. However, if it has to be done, please do it in two separate commits: one that generates the ChangeLog and one that fixes the mistake. From unknown Sun Jun 22 07:38:59 2025 X-Loop: help-debbugs@gnu.org Subject: bug#58092: 29.0.50; [PATCH] Add log-edit-summary-separator face Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Sep 2022 00:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58092 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: Lars Ingebrigtsen , Robert Pluim , Dmitry Gutov , Protesilaos Stavrou , 58092@debbugs.gnu.org Received: via spool by 58092-submit@debbugs.gnu.org id=B58092.166432619224396 (code B ref 58092); Wed, 28 Sep 2022 00:50:01 +0000 Received: (at 58092) by debbugs.gnu.org; 28 Sep 2022 00:49:52 +0000 Received: from localhost ([127.0.0.1]:57040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odLGq-0006LP-8e for submit@debbugs.gnu.org; Tue, 27 Sep 2022 20:49:52 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:47573) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odLGn-0006LB-MY for 58092@debbugs.gnu.org; Tue, 27 Sep 2022 20:49:51 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 9048B5C0077; Tue, 27 Sep 2022 20:49:44 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Tue, 27 Sep 2022 20:49:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-transfer-encoding:content-type:date:date:from :from:in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; t=1664326184; x= 1664412584; bh=UWzrHZwa5gQMH31UmipDkRIP9N9iRMjjzPrrPSxx6cg=; b=K MCP1ohdpAwoNWki8uLhwFqJYGQuFs6ECX4Fh+gzdngQKCidjzn3qcO1BBcvdDOjw ScTR1ATWNZWFd4PfvYHJO8MpL/RxtZtLTl5AaSU6DLgKkVRS8RnngoEcRGTa2NzT 1Cq9F99Gz9KPdIyUPN+Jzu7+YNpKDagJqtGzF9M0xvAyWGy44ivfEcjpsEHqsd3y 13DSV5clJART3MNlfhtZO1a2Xs/0oaom9qmo4nMEpboiMPmgQmYuQQDjQDx0rgws C/WL7sJ39UBkx+d5zoG2jelRWwx/wqY3TbtEZynNY7mFsRHEHzX8UoEwsPRMDrHU nlkD+RdDN4WcIiRFKEdBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1664326184; x= 1664412584; bh=UWzrHZwa5gQMH31UmipDkRIP9N9iRMjjzPrrPSxx6cg=; b=h p0p8ipCHvu2TrJg0E1g7SbV3J8+4ZDL4BkrgjP4hqJ7vfSgqeGpOxsU7OS8JXu3S vcj1KrBNtBvOs1zCEyUcev8ClwLb0s1yaczF9eRtx4oXpAgARRqWGE0oOSPEj1uh 9GLgRNWimqC7jpbtUzUuMq2rkmU+aXXH5D9tmLyZigd+3ZtqgONHgMZ8RoE493mf Mn4VYWeyzILOPLDNDxiSf4MkdgoO9yKBsCzAh8y8SZ+SHErN31GtT5wutd7rOeoz ErcpwcIQ1fXm85S2uQIUOHhzYMI2QfMYtFVl12y313LtIAyje+NCkRlKHSTGwXHE UI39a9W99bm9p5qLRq12Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegjedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgfgsehtqhdttddtreejnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnhepffefhfejudeguddtudekjeekueevvedvieeghfegleet uefhkeegkefhleejvddunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Sep 2022 20:49:43 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 270487E01ED; Tue, 27 Sep 2022 17:49:42 -0700 (MST) From: Sean Whitton In-Reply-To: (Stefan Kangas's message of "Tue, 27 Sep 2022 12:15:29 -0400") References: <87bkr2mhj1.fsf@protesilaos.com> <87a66mdych.fsf@protesilaos.com> <87czbi9p23.fsf@gmail.com> <87h70szuig.fsf@melete.silentflame.com> Date: Tue, 27 Sep 2022 17:49:42 -0700 Message-ID: <87edvwgw61.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Tue 27 Sep 2022 at 12:15PM -04, Stefan Kangas wrote: > Sean Whitton writes: > >>>> amend no. revert yes, but it=CA=BCs overkill for just a commit message= issue. You >>>> can always run 'make change-history' and fix it in the resulting >>>> ChangeLog file (see admin/notes/repo for the details) >>> >>> Please don't do that, it will make merging more tricky later. >> >> Hmm, so it's never okay to do that? Or is it to be saved for the more >> egregrious errors? > > It's easier for me (or whoever is charge of merging and/or releases) if > we don't do that, so I'd prefer it if we could reserve it for > particularly nasty mistakes. > > However, if it has to be done, please do it in two separate commits: one > that generates the ChangeLog and one that fixes the mistake. Thanks. I've updated admin/notes/repo with this information. --=20 Sean Whitton