GNU bug report logs - #58057
[PATCH] gnu: Add emacs-macrostep-geiser.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#58057: closed ([PATCH] gnu: Add emacs-macrostep-geiser.)
Date: Sun, 25 Sep 2022 13:23:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 25 Sep 2022 15:22:07 +0200
with message-id <87mtantwqo.fsf <at> nicolasgoaziou.fr>
and subject line Re: [bug#58057] [PATCH] gnu: Add emacs-macrostep-geiser.
has caused the debbugs.gnu.org bug report #58057,
regarding [PATCH] gnu: Add emacs-macrostep-geiser.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
58057: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58057
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Hilton Chain <hako <at> ultrarare.space>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add emacs-macrostep-geiser.
Date: Sun, 25 Sep 2022 09:16:47 +0800

* gnu/packages/emacs-xyz.scm (emacs-macrostep-geiser): New variable.
---
 gnu/packages/emacs-xyz.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index d324b39af3..9df7dcd1c6 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -20612,6 +20612,29 @@ (define-public emacs-macrostep
 expansions for debugging with Edebug as normal.")
       (license license:gpl3+))))
 
+(define-public emacs-macrostep-geiser
+  (let ((commit "f6a2d5bb96ade4f23df557649af87ebd0cc45125")
+        (revision "1"))
+    (package
+      (name "emacs-macrostep-geiser")
+      (version (git-version "0.2.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/nbfalcon/macrostep-geiser")
+               (commit commit)))
+         (file-name (git-file-name name version))
+         (sha256
+          (base32 "0dykvwcvg8n24z3fkx6rv3l1mhzmca4cxj0gsvvqsg9wp0az1fc7"))))
+      (build-system emacs-build-system)
+      (propagated-inputs (list emacs-macrostep emacs-geiser))
+      (home-page "https://github.com/nbfalcon/macrostep-geiser")
+      (synopsis "macrostep for geiser and cider")
+      (description
+       "This plug-in implements a macrostep back-end powered by geiser.")
+      (license license:gpl3+))))
+
 (define-public emacs-parent-mode
   (package
     (name "emacs-parent-mode")
-- 
2.37.3

[Message part 3 (message/rfc822, inline)]

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Hilton Chain via Guix-patches via <guix-patches <at> gnu.org>
Cc: Hilton Chain <hako <at> ultrarare.space>, 58057-done <at> debbugs.gnu.org
Subject: Re: [bug#58057] [PATCH] gnu: Add emacs-macrostep-geiser.
Date: Sun, 25 Sep 2022 15:22:07 +0200

Hello,

Hilton Chain via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-macrostep-geiser): New variable.

Thank you. I applied the patch with the following changes:

> +(define-public emacs-macrostep-geiser
> +  (let ((commit "f6a2d5bb96ade4f23df557649af87ebd0cc45125")
> +        (revision "1"))
> +    (package
> +      (name "emacs-macrostep-geiser")
> +      (version (git-version "0.2.0" revision commit))

I downgraded the commit used to the one matching the version bump. As
a consequence, version is exactly "0.2.0", which is always nicer when
subsequent changes do not bring much to the table.

> +      (propagated-inputs (list emacs-macrostep emacs-geiser))

I ordered inputs alphabetically.

> +      (synopsis "macrostep for geiser and cider")
> +      (description
> +       "This plug-in implements a macrostep back-end powered by geiser.")

I used capitalization for Macrostep and Geiser.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.