From unknown Tue Aug 19 09:59:54 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#58028 <58028@debbugs.gnu.org> To: bug#58028 <58028@debbugs.gnu.org> Subject: Status: 29.0.50; Ensures no leakage of glyph_matrix Reply-To: bug#58028 <58028@debbugs.gnu.org> Date: Tue, 19 Aug 2025 16:59:54 +0000 retitle 58028 29.0.50; Ensures no leakage of glyph_matrix reassign 58028 emacs submitter 58028 Manuel Giraud severity 58028 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 11:22:19 2022 Received: (at submit) by debbugs.gnu.org; 23 Sep 2022 15:22:19 +0000 Received: from localhost ([127.0.0.1]:41419 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obkVO-0002ta-TU for submit@debbugs.gnu.org; Fri, 23 Sep 2022 11:22:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:51522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obkVM-0002tS-V7 for submit@debbugs.gnu.org; Fri, 23 Sep 2022 11:22:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obkVM-0003wk-50 for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2022 11:22:16 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:49127) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obkVI-0007nC-Ov for bug-gnu-emacs@gnu.org; Fri, 23 Sep 2022 11:22:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=tTNbTw4clfebMGJm tHxunMDpumAHVEfNHFE/cxTn/ws=; h=date:subject:to:from; d=ledu-giraud.fr; b=t0xWT6T3XaW+OApIzlqZmYVP+5yUC0WGiQhORX3q9bcqsOTz79 BNH+/vHxUYRyu/e/1D+mAza+1C+rdUT8e6OiN5tfP8K2k8DiRpngmaMFz3d5BfcXvhX/h+ DT8XzUuSMrVVXBD0pco5P/CZukH99g1btTeCeLBXz9wIaN3MVv7YELI4sIyT9XBo9/fG/Y qkYLKJQaLt3ptVTZtvsmlc3gXZGoW2Y0W0mti76O4VwdVOvjjKvncNnk8FvmCVSdondX4s 4HTbz+wyicZ2Urj1ESxnYo5MM7hSiCzRhkix2FE4GVuhKnzUX51NEBy9vTdUC5g+KG9Q7k gqiL+/n+0mzQ== Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id c003d4bc (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO) for ; Fri, 23 Sep 2022 17:22:09 +0200 (CEST) From: Manuel Giraud To: bug-gnu-emacs@gnu.org Subject: 29.0.50; Ensures no leakage of glyph_matrix Date: Fri, 23 Sep 2022 17:22:07 +0200 Message-ID: <87illenmjk.fsf@elite.giraud> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=51.159.28.247; envelope-from=manuel@ledu-giraud.fr; helo=ledu-giraud.fr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Maybe this problem never triggers. It is a =C2=AB better be safe =C2=BB ki= nd of patch. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Ensures-no-leakage-of-glyph_matrix.patch >From f539c3b198201f8f33f02b2ff0b595b205e5364c Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Fri, 23 Sep 2022 17:14:44 +0200 Subject: [PATCH] Ensures no leakage of glyph_matrix ; * src/dispnew.c (allocate_matrices_for_window_redisplay): Ensures no leakage of glyph_matrix. --- src/dispnew.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/dispnew.c b/src/dispnew.c index b786f0f1ba..5659b3d4fc 100644 --- a/src/dispnew.c +++ b/src/dispnew.c @@ -1808,10 +1808,10 @@ allocate_matrices_for_window_redisplay (struct window *w) /* If matrices are not yet allocated, allocate them now. */ if (w->desired_matrix == NULL) - { - w->desired_matrix = new_glyph_matrix (NULL); - w->current_matrix = new_glyph_matrix (NULL); - } + w->desired_matrix = new_glyph_matrix (NULL); + + if (w->current_matrix == NULL) + w->current_matrix = new_glyph_matrix (NULL); dim.width = required_matrix_width (w); dim.height = required_matrix_height (w); -- 2.37.3 --=-=-= Content-Type: text/plain In GNU Emacs 29.0.50 (build 2, x86_64-unknown-openbsd7.2, cairo version 1.17.6) of 2022-09-23 built on elite.giraud Repository revision: 94380420e2cba7e2821b22fd8a46cd5b04c985ef Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12101004 System Description: OpenBSD elite.giraud 7.2 GENERIC.MP#739 amd64 Configured using: 'configure --prefix=/home/manuel/emacs --bindir=/home/manuel/bin --with-x-toolkit=no --without-sound --without-compress-install CPPFLAGS=-I/usr/local/include LDFLAGS=-L/usr/local/lib' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBXML2 MODULES NOTIFY KQUEUE OLDXMENU PDUMPER PNG RSVG SQLITE3 THREADS TIFF WEBP X11 XDBE XIM XINPUT2 XPM ZLIB Important settings: value of $LC_ALL: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Dired by name Minor modes in effect: gnus-dired-mode: t global-git-commit-mode: t magit-auto-revert-mode: t icomplete-mode: t display-time-mode: t display-battery-mode: t shell-dirtrack-mode: t global-so-long-mode: t repeat-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t buffer-read-only: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/manuel/.emacs.d/elpa/transient-20220918.2101/transient hides /home/manuel/emacs/share/emacs/29.0.50/lisp/transient Features: (shadow emacsbug whitespace gnus-fun emoji-labels emoji multisession sqlite ibuf-ext ibuffer ibuffer-loaddefs ispell magit-patch magit-subtree magit-gitignore magit-ediff mailalias dabbrev cl-print vc-src vc-sccs vc-cvs vc-rcs log-view vc boxquote-autoloads ediff ediff-merg ediff-mult ediff-wind ediff-diff ediff-help ediff-init ediff-util let-alist rust-utils rust-mode rust-rustfmt rust-playpen rust-compile rust-cargo loaddefs-gen tar-mode finder-inf display-line-numbers mouse-copy mouse-drag vc-hg vc-bzr gnus-dired tramp-sh tramp-cache time-stamp sort gnus-cite mail-extr textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check gnus-async gnus-bcklg qp gnus-ml gnus-topic mm-archive url-http url-gw url-cache url-auth utf-7 imap rfc2104 nndoc nndraft nnmh network-stream nsm nnfolder nnml gnus-agent gnus-srvr gnus-score score-mode nnvirtual nntp gnus-cache nnrss mm-url w3m doc-view jka-compr image-mode wallpaper xdg exif w3m-hist w3m-fb bookmark-w3m w3m-ems w3m-favicon w3m-image tab-line w3m-proc w3m-util shortdoc help-fns radix-tree misearch multi-isearch find-dired ffap magit-extras face-remap magit-bookmark magit-submodule magit-obsolete magit-blame magit-stash magit-reflog magit-bisect magit-push magit-pull magit-fetch magit-clone magit-remote magit-commit magit-sequence magit-notes magit-worktree magit-tag magit-merge magit-branch magit-reset magit-files magit-refs magit-status magit magit-repos magit-apply magit-wip magit-log which-func imenu magit-diff smerge-mode diff git-commit log-edit pcvs-util add-log magit-core magit-autorevert autorevert filenotify magit-margin magit-transient magit-process with-editor magit-mode transient magit-git magit-base magit-section dash compat-27 compat-26 compat compat-macs vc-git diff-mode bug-reference pulse vc-dispatcher vc-svn pcmpl-unix sh-script smie executable paredit edmacro icomplete time battery exwm-randr xcb-randr exwm-config exwm exwm-input xcb-keysyms xcb-xkb exwm-manage exwm-floating xcb-cursor xcb-render exwm-layout exwm-workspace exwm-core xcb-ewmh xcb-icccm xcb xcb-xproto xcb-types xcb-debug kmacro server stimmung-themes modus-operandi-theme modus-themes ytdious osm mingus libmpdee reporter edebug debug backtrace transmission diary-lib diary-loaddefs color calc-bin calc-ext calc calc-loaddefs rect calc-macs w3m-load mu4e mu4e-org mu4e-main mu4e-view mu4e-headers mu4e-compose mu4e-draft mu4e-actions smtpmail mu4e-search mu4e-lists mu4e-bookmarks mu4e-mark mu4e-message flow-fill mule-util hl-line mu4e-contacts mu4e-update mu4e-folders mu4e-server mu4e-context mu4e-vars mu4e-helpers mu4e-config bookmark ido supercite regi ebdb-message ebdb-gnus gnus-msg gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum shr pixel-fill kinsoku url-file svg dom gnus-group gnus-undo gnus-start gnus-dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo gnus-spec gnus-int gnus-range message sendmail yank-media puny rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums gmm-utils mailheader gnus-win gnus nnheader gnus-util mail-utils range mm-util mail-prsvr ebdb-mua ebdb-com crm ebdb-format ebdb mailabbrev eieio-opt speedbar ezimage dframe eieio-base pcase timezone org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic bibtex ol org-keys oc org-compat org-macs org-loaddefs find-func cal-menu calendar cal-loaddefs visual-basic-mode cl web-mode disp-table erlang-start smart-tabs-mode skeleton cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs slime-asdf grep slime-tramp tramp tramp-loaddefs trampver tramp-integration cus-edit cus-load wid-edit files-x tramp-compat rx shell pcomplete parse-time iso8601 time-date ls-lisp format-spec slime-fancy slime-indentation slime-cl-indent cl-indent slime-trace-dialog slime-fontifying-fu slime-package-fu slime-references slime-compiler-notes-tree slime-scratch slime-presentations advice bridge slime-macrostep macrostep slime-mdot-fu slime-enclosing-context slime-fuzzy slime-fancy-trace slime-fancy-inspector slime-c-p-c slime-editing-commands slime-autodoc slime-repl elp slime-parse slime derived cl-extra help-mode lisp-mnt gud apropos compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline icons pp comint osc ansi-color ring hyperspec thingatpt slime-autoloads dired-aux dired-x dired dired-loaddefs so-long notifications dbus xml repeat easy-mmode auctex-autoloads tex-site debbugs-autoloads hyperbole-autoloads magit-autoloads git-commit-autoloads magit-section-autoloads dash-autoloads paredit-autoloads rust-mode-autoloads stimmung-themes-autoloads transient-autoloads with-editor-autoloads info compat-autoloads ytdious-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile cconv url-vars cl-loaddefs cl-lib rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue lcms2 dynamic-setting system-font-setting font-render-setting cairo xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 3026488 254443) (symbols 48 77071 8) (strings 32 521068 23385) (string-bytes 1 16133683) (vectors 16 224942) (vector-slots 8 3660420 266611) (floats 8 765 650) (intervals 56 262421 5119) (buffers 1000 108)) -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 11:49:45 2022 Received: (at 58028) by debbugs.gnu.org; 23 Sep 2022 15:49:45 +0000 Received: from localhost ([127.0.0.1]:41473 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obkvx-0005pe-8k for submit@debbugs.gnu.org; Fri, 23 Sep 2022 11:49:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:52730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obkvv-0005pS-Id for 58028@debbugs.gnu.org; Fri, 23 Sep 2022 11:49:43 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40376) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obkvq-00077v-3y; Fri, 23 Sep 2022 11:49:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=8AqZwbCHKeIU8aRRO3yq+izsu9FvzOPax+1DGZVTmk4=; b=l/EU2Spc/rWuX70qd47B c8AwsheWepG0rocEahwqan9xABTIKZUNACuHWelvPsHAgfnvSdihH1Dbb4itW1fB/XCMY/Rs3IrnF FN3lI5RYQYfhBLpVVw3Y9N/fZSRShXVMHI1I9s3RQZfefk8JqPOusY47TGTe6sdUA2kRn0Myii6cE iX08R+anUuj6xqTXO7lVdRTNVsrEnRDPRBWfHDsLbgV+AeQh7LzVqSRyd+0Ef1eiWloJe0Unz4lO8 ESvqS/GYEgsI3IfMRwbAkoW9g8HP3kp+pt1gfhm8cHKyBJXZHQ9XLgiFTT/kyd4QkJA6rEmMH1OxS 3WdG9O/pHavm6g==; Received: from [87.69.77.57] (port=1382 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obkvo-0007lH-JK; Fri, 23 Sep 2022 11:49:37 -0400 Date: Fri, 23 Sep 2022 18:49:32 +0300 Message-Id: <83sfkiozub.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87illenmjk.fsf@elite.giraud> (message from Manuel Giraud on Fri, 23 Sep 2022 17:22:07 +0200) Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix References: <87illenmjk.fsf@elite.giraud> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58028 Cc: 58028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Date: Fri, 23 Sep 2022 17:22:07 +0200 > > Maybe this problem never triggers. It is a « better be safe » kind of > patch. Please add an assertion there, to catch the case that previously was handled by testing only w->desired_matrix. It might be that what you think is a memory-leak bug is in fact a feature. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 11:59:57 2022 Received: (at 58028) by debbugs.gnu.org; 23 Sep 2022 15:59:57 +0000 Received: from localhost ([127.0.0.1]:41492 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obl5p-00065Q-Bi for submit@debbugs.gnu.org; Fri, 23 Sep 2022 11:59:57 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:47203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obl5j-00065D-TI for 58028@debbugs.gnu.org; Fri, 23 Sep 2022 11:59:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=Dpt7NFZzP4kxT+cZ 3viGyR9IAQEPHcHSNpTpPglb6SI=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=QRAo6IUkZlRUIxdROnruPvGVGL9FmV1MYTt8mG dFKOzc7qBFAMNWeyzzGckd2WVm3pvTTPszsQ11hYO5GZ4OLYO97oaaqAEON/Grs8eMjk3w BNBvpQkUTEoMIYPJ/+z3B2ISCab+zBQXbuiGi739+M7/g7J8BOXUmtsMfgG9VllJ2354+L oi3NC5xUSzCR34M1ns8JB+paxOrgT5gSTi9GdhtKPUAdEBth9E6CEaajO1pUCk24cmVi+6 JNTV9+A6vsE+EPVgo812NtlGaIi88tEww7qo7ojc/KhZH8fLoZTSovddq0ttt8aKuBYHIt yPOcVNVaLFXxz/+XiDCXaK1Q== Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 8bbd19bb (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 23 Sep 2022 17:59:49 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix In-Reply-To: <83sfkiozub.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Sep 2022 18:49:32 +0300") References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> Date: Fri, 23 Sep 2022 17:59:48 +0200 Message-ID: <87czbmnksr.fsf@elite.giraud> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58028 Cc: 58028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Manuel Giraud >> Date: Fri, 23 Sep 2022 17:22:07 +0200 >>=20 >> Maybe this problem never triggers. It is a =C2=AB better be safe =C2=BB= kind of >> patch. > > Please add an assertion there, to catch the case that previously was > handled by testing only w->desired_matrix. I do not understand what you mean here. > It might be that what you think is a memory-leak bug is in fact a > feature. Yes, you're right (but I have a hard time to imagine how). Maybe this patch could just be ignored. Thanks. --=20 Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 13:44:17 2022 Received: (at 58028) by debbugs.gnu.org; 23 Sep 2022 17:44:17 +0000 Received: from localhost ([127.0.0.1]:41676 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obmin-0006z2-J6 for submit@debbugs.gnu.org; Fri, 23 Sep 2022 13:44:17 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obmij-0006yn-QR for 58028@debbugs.gnu.org; Fri, 23 Sep 2022 13:44:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49128) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obmie-00011b-IW; Fri, 23 Sep 2022 13:44:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=vWBAB/ghsZdiOpMJTxgvs6kQ/qtNaUYW4UfY1UsG5iA=; b=jQlHZ8zY2MLueLMz9EFu T8zwS4nW0cVQ+9HhjyxFkBuvpCzVDELX1rvF1lo7yiXffLjKkg6JK1IQELPcVFf7nRnvUyzXFZDFe LSlYYsGNshPPTdVHOs3m424RV/rnz7BOolzhe8rD3cJHN9h+27VxZiEZobDtVihm5OKeYvgCD+OPo AlOVRlmmjMBFPScKsI1NF8i0zKM9IhcK/jZCHG0nPKQMaQzWQ/FkhFRAgDCl7OsVeTZzc4U0U6XOx NE7jjXvoP+7jbrhNkOd96YXetQGmekfook5iTaELmiHVjU0+OeI+lwI8S0zAwQTqqgA6DspTS6ByK e2zW3PP7zkzugw==; Received: from [87.69.77.57] (port=4422 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obmib-0002UG-C6; Fri, 23 Sep 2022 13:44:07 -0400 Date: Fri, 23 Sep 2022 20:43:58 +0300 Message-Id: <83k05uoujl.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87czbmnksr.fsf@elite.giraud> (message from Manuel Giraud on Fri, 23 Sep 2022 17:59:48 +0200) Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58028 Cc: 58028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 58028@debbugs.gnu.org > Date: Fri, 23 Sep 2022 17:59:48 +0200 > > Eli Zaretskii writes: > > >> From: Manuel Giraud > >> Date: Fri, 23 Sep 2022 17:22:07 +0200 > >> > >> Maybe this problem never triggers. It is a « better be safe » kind of > >> patch. > > > > Please add an assertion there, to catch the case that previously was > > handled by testing only w->desired_matrix. > > I do not understand what you mean here. I mean the assertion that triggers when w->desired_matrix is NULL, but w->current_matrix isn't. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 16:43:58 2022 Received: (at 58028) by debbugs.gnu.org; 23 Sep 2022 20:43:58 +0000 Received: from localhost ([127.0.0.1]:41850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obpWg-0007PU-ET for submit@debbugs.gnu.org; Fri, 23 Sep 2022 16:43:58 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:25933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obpWf-0007PM-2h for 58028@debbugs.gnu.org; Fri, 23 Sep 2022 16:43:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=zFDFcoQ9YGS465QO c69hO2+b/am6fBhph37d58dDmy8=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=HQKtl7F8UEoBFRARu7EQCGQ7GZ5s2T4zOsruFE ZQyCZ77hcW+bmGRFhnpGGmpJoWf5mZ0MoVOuP2P+YK1JunjGv9kZWYrwkPoQrcO2zLO19R BNXh29bV6ViEGrxE5dy2pTVj15KjbfDAvQK6UVO7A3qg5YDZEb605NtRMCqJPrHmpnMk7X mgVH4AmhLEeGCQU3+fq4q2Rbph5MWWUzHixs/sIfT8uynsc/voI1z5/Bx1aBbnIYW+/2Tz VKB/8gtKoH5FqwHd4ox398oOe3DvHPfWksJPa8bh07irmP/HRqKaCe14gs77CYpzDOMOBS K8Rkd4/rsBlYmN0r9M/BsvAQ== Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id f0aefae6 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Fri, 23 Sep 2022 22:43:54 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix In-Reply-To: <83k05uoujl.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 23 Sep 2022 20:43:58 +0300") References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> Date: Fri, 23 Sep 2022 22:43:53 +0200 Message-ID: <878rm9om7q.fsf@elite.giraud> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58028 Cc: 58028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> From: Manuel Giraud >> Cc: 58028@debbugs.gnu.org >> Date: Fri, 23 Sep 2022 17:59:48 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> >> From: Manuel Giraud >> >> Date: Fri, 23 Sep 2022 17:22:07 +0200 >> >>=20 >> >> Maybe this problem never triggers. It is a =C2=AB better be safe =C2= =BB kind of >> >> patch. >> > >> > Please add an assertion there, to catch the case that previously was >> > handled by testing only w->desired_matrix. >>=20 >> I do not understand what you mean here. > > I mean the assertion that triggers when w->desired_matrix is NULL, but > w->current_matrix isn't. Oh I see. I add the following: --8<---------------cut here---------------start------------->8--- eassert ((w->desired_matrix =3D=3D NULL) && (w->current_matrix !=3D NULL)); --8<---------------cut here---------------end--------------->8--- and test a little bit with emacs -Q and nothing break. So I think you're right: when w->desired_matrix is NULL, both are. --=20 Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 23 20:26:28 2022 Received: (at 58028) by debbugs.gnu.org; 24 Sep 2022 00:26:28 +0000 Received: from localhost ([127.0.0.1]:41943 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obt00-0004M2-FA for submit@debbugs.gnu.org; Fri, 23 Sep 2022 20:26:28 -0400 Received: from sonic312-25.consmr.mail.ne1.yahoo.com ([66.163.191.206]:39516) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obszy-0004Lq-UX for 58028@debbugs.gnu.org; Fri, 23 Sep 2022 20:26:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663979181; bh=Txf07ab61HsUHxoNDuEPBUhsR3fLR+ajBXdcPpzyZIs=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=XJH7SH09w7cN+D5qy4C3NVGxOWXeiLkyUJbQvRUb4XTC6hGLqfxSkNNp5vCsiBQgbQd96fSAHiIJTyh3jjM9aHmxZBJws5eZUg4CuxcyYn8oUPnlyE9+E1sKJuNHSskRylaXF8v8LBvXAb04FXDHENHFiNe0Fm+/bHg728T6vlvdwqp1nG3LdJZNZLJyCqgCoHVkBNulPKgpLag7kB6921Otae5LfyOZe7Ld9eMa5Y+MYA7joKLFz3Zcrz7j+OTyNvpMzlxBTNLkEuZp7PMOeNyLKnpEk8wlp8VmpitGlOe8BTdCf94Q+NCsygau6Wz1J/C7Z38pqvN/LavzBu1tSg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663979181; bh=l2kzcehiGD4TxmRCAucP2Yfq9A5lPMubyt3cP9OBStK=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=aU6v3zQBLAMQ1JllwtZfeTg/gVClLi+SZ4Y04eVHjBEA76MLtFoJZ00K1fpbBdquFtOqSGj/KrP7agaaOqa5J3Ti/b6noj8eH9pfb+6hzMo9R9ytRtqIrBqBScz7zxWYCqDh8CSTaw+1a3rZaVoC1RYSTD//d/wKCpjastR1hpxOPhh6t8iUvQ5CB4mlsLZuPEwzY9CRQ1SIJk1bb8YQAb4yNd5l0yGfDGYKgZsfzD83L+GTf0Cbhrky3ElV4OzMpPtQsjEemu3NnoczvPjvRasaJ6lvZnSbqH3WKsFXkgNN3QmZa5AvIiE7W4PM2sPkwSKKM+HMSBQ9C2FiPCJQEw== X-YMail-OSG: jfx2mz0VM1kwZ8yoiMnW67MQl431mlPvX_IB6rWYNxa_M4mFvDbIo_V935j4iV. wGJYMlXQSezDZ.HSH_KFiL2s1q5Q8Wg8zFvgF1pVNVZVVRWB8TQcfNrQ03RCrQsrzzxd8RlCevAO cIEoApDwEDEEV9tD9WYdIR1HH8EvAdfBazy.Kc7JfSlkq.aJBc.VfrYgPEW0r80QW2EjwcE1Mg8N gwUiIGkPvzAMcKet3igNsiAfE8clQ_wrubOGzGNbcs3ZDAYGrZ4KGqlmPEn9ZjIrkF3Z5KW89Wox HmiKsCk7NM_1IgVz0yiqNGBJjUuCmHNMYO44XCXm0sBUPHm5vNI4UtoMaAA9TdEY7pi0rlrMPTAC JduByl9sXE5BeqHB_tCASqrCIYwGDLj0eflajd1QINvv.5UFzYh.tKSK4AHgytLoRyOfsZsBFHKD 37AOWO2AwZQ4mj_ZrMVFLmVk8JGE2qC_xgVL9ijEnW6F3VXwTCljUGkr6A7OoQ_B96GOx4x7dt6. 7vlHGKB.nu2VsOZRZUQ5LPyH8HEwqWDR2c5VbaAbeTIM7KPvVuszhXLZVozn6YFU7gzORsqSJCDm xbd87rNHWUmRjN.xbe5RudUMbes4487Z93gbJPSds7YbpipF_pq27VysFK547IuuD4dDH5rk8xKI xS4Fwo33c0kYlU8mCKEYk_IXMEVd9Sf2ezN8Jpr.bZrDRYtdRQ0Dy94YTpgM3df3FdOlT5OgwFd9 7kHukvyqf0FnhafpkqG2lvHhEi3ex5E0hrtnpqgA8g0sOhEVcBlkpaRGllCiuSj_SJbzFsWNFbp4 R91bU8Ri6zTxTAAi1qR9V2OPiirTktixnp2YsIY4mtlDqxQWPjpAaAvJMELYFgLdWaVyv__oUHA8 bJm1jTw_bFlFgxnsqqn.EkAen6IBDJkcIHDr54oJTxbojN_Vp3mr9Za861o3Me3OHyjQSZ9ae.Q4 7m2LbSTeuKyNmGJ7i4KKPJvIk.Qrace89IIeqHstJwF19T6SfKFF3Lfq56CCO7FFMeD5d7OfcMLw FG.QGXFL3eR0U_RJFU4hHRPmqfgESIY0hoFTHRjjz8stqyg.wGo30F6Cxu_M9K97p5P0EOT6idOT OuJuARd4TcDlCjmV3myxAoafCO8RBcUG7wV.e1HYfCVRoyBxtRQu_erSV2AdbqtviyMMw84y7U9i QfhYV8kwSaRlBRT8K2dTxttQ1ib19hal7y9aLneSLiOa6f8u3G1I3dZ3OwcbnNjtF3.dlE2dKKGk nE15BUfgXYDUZnrkT7Merm4wvZJV92SghVsRZWybMmIKB1um29i.8zC5dOeuY2SSwALlyoY1ROC5 Du5bLfTVsQkv7A3a9N.SuCBlnZMcE3WDOAxjs0VIH6E6IS.9TH6j21mSRGUnBs9i54E7Dnb0J5pE aRUs2YBGpOe2_p7tR443bw0KJsn7TFEh8pzUgMfTq6C4FlimudI0xuAOTVLFl2AuKgHp4r433HFW KElzEg0pl1Wyy7EDInwxLgxGb5KHrpkawVgE8_lphKqOlZZ_TzYe58F7G9yYaCftuMrZDMvMBeXi o.38urEadWGd.mdRmOEQaQ2ONgwfp6e7SbupTJrdXPERb2JfmksgJy2ZHQyu8VgV7k.B.hGtuEm5 67BEU98kNWJyvel7QV_pgrKX9OZ56mN2fK5gd0TgAiR5sdgGzIHLfVi0MHcaMVX9OPVzPaT14pRQ 4t1tqqIw7tjTHQmL3RgqPuhGF2r.G8UNqnu6aZLqsnfhSUXGkCqngfl.SiUZSP8gdpjyMxAYTAee _7wHkS.sHtbBI0dmbzRtqW1HGmlm0Z5R_ffvgYEtKr5qRpM5TEPG_MstCx.rgcmlS.krDpt_V7it OuC7XfcEGfxTfiMnvGj91s0hgwJ8coxBluCK00BLW4QDiIJ5bIob5dw4K.tuGFa_PLTlsa5UC.jd QO5Eb7V90lyHdbkqiZWa91BaKmW9WEnxKUAOObgibYNbnsbI7XAQkeiOpUxcY5f_Ii9Sv.N7FUBN HL0vXei9ljUhgJrbf6BqagBOhNJx2lEAmziGly_J1RyfuJO0i4NIbXqjh_MBJBSTpOev7p9gHMQ9 aMjr198py_CNcDhlF.nDGPn8JmAwiXiCbzSbETWTZmEn9ClVPq.PM9fZeZzobll5UC3IW.S03Xnj L9qazDExVvyqtiG521i6jywgx75UvKmQQrjr.uEZVKaK1DDRTbnWpV0w5EJJXiuo4JDsFMpyF.Iv e6EHlrV6T7jl8x.JRlXxxhcwVLfwEW8ToN_wvDoEpkr9lCokb4GK3PCA_NhuiE1x9Un4hCzkY X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic312.consmr.mail.ne1.yahoo.com with HTTP; Sat, 24 Sep 2022 00:26:21 +0000 Received: by hermes--production-sg3-dfffdfbd4-pmzdf (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID a9429de9fd3cb5afdbbdb6883768ff97; Sat, 24 Sep 2022 00:26:19 +0000 (UTC) From: Po Lu To: Manuel Giraud Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> <878rm9om7q.fsf@elite.giraud> Date: Sat, 24 Sep 2022 08:26:13 +0800 In-Reply-To: <878rm9om7q.fsf@elite.giraud> (Manuel Giraud's message of "Fri, 23 Sep 2022 22:43:53 +0200") Message-ID: <874jwxd3dm.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20702 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 422 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58028 Cc: 58028@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Manuel Giraud writes: > eassert ((w->desired_matrix == NULL) && > (w->current_matrix != NULL)); In Emacs, we typically format the code like so: eassert ((w->desired_matrix == NULL) && (w->current_matrix != NULL)); > and test a little bit with emacs -Q and nothing break. So I think > you're right: when w->desired_matrix is NULL, both are. BTW, did you build with checking? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 24 01:46:42 2022 Received: (at 58028) by debbugs.gnu.org; 24 Sep 2022 05:46:42 +0000 Received: from localhost ([127.0.0.1]:42117 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obxzu-0004P9-0U for submit@debbugs.gnu.org; Sat, 24 Sep 2022 01:46:42 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obxzs-0004Ow-BO for 58028@debbugs.gnu.org; Sat, 24 Sep 2022 01:46:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59406) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obxzm-00083I-PR; Sat, 24 Sep 2022 01:46:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=DMD4iukuP/GgcAMJrm7xJhIym9HT3oqT/+il6fXIrTI=; b=lwXkDKW/0UKT8na3EMNs L+gMUrlBge5oBwUmF7TQ4K8rv7djj878ZbyuH8fvCrU9+VsL6wERIJeVajoGoCF9MfXhYK8WKgBEx 3IRbzZ2qlwW0lpoQJSkOyD+7kBWhYi1D7U7tCwyLK0ruaBkwQY9Gr/gwO5i3yqMTmzQwNB3FZHNVw LZUOtQoevqVHmP/77S+MPzoD/rJeKmW4UjNAZNW0U7/q4QwYmYJLwfFeC1NjXI5lL0aG4492s+gJY 8UEV8SJm9uryIlPNFJ08jn+kh06WHRmkARom1PbCyPmWuqMFmg1VE6QtSPvn+LcLfBQZYI2Hq7BId PjKvRtRiGLEZ4Q==; Received: from [87.69.77.57] (port=4829 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obxzl-0001nu-VX; Sat, 24 Sep 2022 01:46:34 -0400 Date: Sat, 24 Sep 2022 08:46:20 +0300 Message-Id: <834jwxpbo3.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <878rm9om7q.fsf@elite.giraud> (message from Manuel Giraud on Fri, 23 Sep 2022 22:43:53 +0200) Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> <878rm9om7q.fsf@elite.giraud> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58028 Cc: 58028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 58028@debbugs.gnu.org > Date: Fri, 23 Sep 2022 22:43:53 +0200 > > Eli Zaretskii writes: > > >> From: Manuel Giraud > >> Cc: 58028@debbugs.gnu.org > >> Date: Fri, 23 Sep 2022 17:59:48 +0200 > >> > >> Eli Zaretskii writes: > >> > >> >> From: Manuel Giraud > >> >> Date: Fri, 23 Sep 2022 17:22:07 +0200 > >> >> > >> >> Maybe this problem never triggers. It is a « better be safe » kind of > >> >> patch. > >> > > >> > Please add an assertion there, to catch the case that previously was > >> > handled by testing only w->desired_matrix. > >> > >> I do not understand what you mean here. > > > > I mean the assertion that triggers when w->desired_matrix is NULL, but > > w->current_matrix isn't. > > Oh I see. I add the following: > --8<---------------cut here---------------start------------->8--- > eassert ((w->desired_matrix == NULL) && > (w->current_matrix != NULL)); > --8<---------------cut here---------------end--------------->8--- > > and test a little bit with emacs -Q and nothing break. So I think > you're right: when w->desired_matrix is NULL, both are. Yes, that's what I meant. So we can install your change with the above assertion added, and then wait for the assertion to trigger and investigate the case(s) where it triggers to see whether we are missing something. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 24 06:29:54 2022 Received: (at 58028) by debbugs.gnu.org; 24 Sep 2022 10:29:54 +0000 Received: from localhost ([127.0.0.1]:42439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc2Px-0005NP-MK for submit@debbugs.gnu.org; Sat, 24 Sep 2022 06:29:53 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:27067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc2Pv-0005NG-GS for 58028@debbugs.gnu.org; Sat, 24 Sep 2022 06:29:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=YYTWjR8DtTfRewRy /v9LOMG4HT/kb+8Mwbx+RiwwD5w=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=aLX4ZUIZKJHZrks3QIMWGK+U5+gOcwyumeP+f4 vDjkpDCBGz9tMJwKy3Y64XAc/wtBRqMWuQybmPNX9O3yYFygHSr0X/yayrjnLfp8gYDLdU oqlkCrpvzc9yLx+aN3sxQO3naeS9feXWFwDnkAeCYIjkBqsJ+rFsKDjuNA7IUPWnEztBPV E+Um1MPk9fWDp/QAFBC3B8cZkdFQkB9E9n3H0NIyvYsKrjQhpxVCP3ID7OBsvYtLJ4E6wz WVqn2Ddui2zx+JYkk3Yl+i7gUI2AS0FnZQi0tQGJHLL8iGXIGX40maMqsq17AB7GmoQGKk OLXwWJJQfj99laCqEZc+0JNA== Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 69e8b6b9 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 24 Sep 2022 12:29:48 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix In-Reply-To: <834jwxpbo3.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Sep 2022 08:46:20 +0300") References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> <878rm9om7q.fsf@elite.giraud> <834jwxpbo3.fsf@gnu.org> Date: Sat, 24 Sep 2022 12:29:17 +0200 Message-ID: <874jwxnk02.fsf@elite.giraud> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58028 Cc: 58028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Eli Zaretskii writes: [...] > Yes, that's what I meant. > > So we can install your change with the above assertion added, and then > wait for the assertion to trigger and investigate the case(s) where it > triggers to see whether we are missing something. Ok. So, as Po suggested, I did a "make check" with and without the new attached patch and get the same following summary result: SUMMARY OF TEST RESULTS ----------------------- Files examined: 450 Ran 6454 tests, 6340 results as expected, 18 unexpected, 96 skipped 1 files did not contain any tests: src/emacs-module-tests.log 10 files contained unexpected results: src/process-tests.log lisp/wdired-tests.log lisp/vc/vc-tests.log lisp/play/fortune-tests.log lisp/net/nsm-tests.log lisp/gnus/gnus-icalendar-tests.log lisp/epg-tests.log lisp/calendar/icalendar-tests.log lisp/bookmark-tests.log lisp/net/tramp-tests.log Thanks. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Ensures-no-leakage-of-glyph_matrix.patch >From ecd618cded21b2ad9d02c991e8f63b5137fe7b41 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Fri, 23 Sep 2022 17:14:44 +0200 Subject: [PATCH] Ensures no leakage of glyph_matrix ; * src/dispnew.c (allocate_matrices_for_window_redisplay): Ensures no leakage of glyph_matrix. --- src/dispnew.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/dispnew.c b/src/dispnew.c index b786f0f1ba..9e4b43087e 100644 --- a/src/dispnew.c +++ b/src/dispnew.c @@ -1807,11 +1807,13 @@ allocate_matrices_for_window_redisplay (struct window *w) struct dim dim; /* If matrices are not yet allocated, allocate them now. */ + eassert ((w->desired_matrix == NULL) + && (w->current_matrix != NULL)); if (w->desired_matrix == NULL) - { - w->desired_matrix = new_glyph_matrix (NULL); - w->current_matrix = new_glyph_matrix (NULL); - } + w->desired_matrix = new_glyph_matrix (NULL); + + if (w->current_matrix == NULL) + w->current_matrix = new_glyph_matrix (NULL); dim.width = required_matrix_width (w); dim.height = required_matrix_height (w); -- 2.37.3 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 24 06:34:41 2022 Received: (at 58028) by debbugs.gnu.org; 24 Sep 2022 10:34:41 +0000 Received: from localhost ([127.0.0.1]:42455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc2Ua-0005Xg-Su for submit@debbugs.gnu.org; Sat, 24 Sep 2022 06:34:41 -0400 Received: from quimby.gnus.org ([95.216.78.240]:46768) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc2UZ-0005XU-EA for 58028@debbugs.gnu.org; Sat, 24 Sep 2022 06:34:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=OEHCpVCtMQHNKe9vy6arHsLf14vVdweFxS7H7x3jd/c=; b=WyL/rpaJ7qopQOKaBi8T8gK10F 0/WCKNBXMyNn0UgjkBipuVBPGmg1GqDLQEjyWKPyqq5sJM6co0Gw3bEBwO+LeHw/ftx2Scg1mollh ARnm5hL0Ao7aLx418xu0P/gxzHW7KuZj/KTCF7lNsBQQtcOhGAxOa35SPKMWnKRLW3qs=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oc2UQ-0002gs-M2; Sat, 24 Sep 2022 12:34:32 +0200 From: Lars Ingebrigtsen To: Manuel Giraud Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix In-Reply-To: <874jwxnk02.fsf@elite.giraud> (Manuel Giraud's message of "Sat, 24 Sep 2022 12:29:17 +0200") References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> <878rm9om7q.fsf@elite.giraud> <834jwxpbo3.fsf@gnu.org> <874jwxnk02.fsf@elite.giraud> X-Now-Playing: Smersh's _Third Noise Principle (Formative North American Electronica 1975-1984) (3)_: "What the Peeper Saw" Date: Sat, 24 Sep 2022 12:34:30 +0200 Message-ID: <87leq9ysax.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Manuel Giraud writes: > Ok. So, as Po suggested, I did a "make check" with and without the new > attached patch and get the same following summary result: I think Po Lu meant building Emacs with checking, otherwise those asserts won't be compiled in. I.e., Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58028 Cc: 58028@debbugs.gnu.org, Eli Zaretskii X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Manuel Giraud writes: > Ok. So, as Po suggested, I did a "make check" with and without the new > attached patch and get the same following summary result: I think Po Lu meant building Emacs with checking, otherwise those asserts won't be compiled in. I.e., ./configure --enable-checking=all; make From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 24 06:37:12 2022 Received: (at 58028) by debbugs.gnu.org; 24 Sep 2022 10:37:12 +0000 Received: from localhost ([127.0.0.1]:42460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc2X2-0005bh-Bd for submit@debbugs.gnu.org; Sat, 24 Sep 2022 06:37:12 -0400 Received: from sonic304-20.consmr.mail.ne1.yahoo.com ([66.163.191.146]:42512) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc2X0-0005bU-GJ for 58028@debbugs.gnu.org; Sat, 24 Sep 2022 06:37:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1664015823; bh=Z//blImr4dx9Wc/8hnhmR8b0Ji+J0+UO/eI4BK+LdT0=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=Z+X6+O+ilhOal/0G/YKAU2BMMau+Rlvfrh+CrmiH9IbZzUKjdCOKMsuVSvzCytq5SApxBp5Ia6tMlpsQrrAh61gzKVfK/uhsgrR6qIw3ItwNAfbnjSkpbGZZAN2kAypyw7yMV3c8o5iHIFzvszb1iBCJhQXzMCk8nQf9tj7IY431YYhdwfHtfzGBQhA7C0TSrVBXwpVnNDOvuDI/GG7Dq20NIN9mtH0To3ULEw/7kAypFFCYYj7ten211+Qra/OChu6LBJkaDMS0JU/1E+yUvpPMjgDVYZ4VXOCihUNUaD2UWrcjvVw/fu1+UIzNRevUZXSkinbPylOlxNB/eK3nnA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1664015823; bh=RD5agLl+ULaAhxnxDG327cu7fHFPFNs5vIHgQZV5krV=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=kOdEffPoejibyxcXuiMcFJVsWp3l3jIoV5Lmz7fJQj9bE4cgHyH/2/hrLrBQJVMjXpCPl1sNgh14Qk3L0qfC7kUaFzckrE5iwy2liZiRqRLWN6RmYkegepWwKkmd6/wkaUc5F/H02UJOOQRAoYLbU7LSXE4W/jGuPzWXzGomz239ULB8nrzyq3X5tmrMyU8CDFAu7FbMSaPYVbS6qnFxjRjJTsjE0gvjcjfrzA9XIxThop8l3zu4+ga1SlpCY6xKTekxUMQwFrl/RImeVDjf1JkFKgYSJE+i+dMKw+QItrIEQzqW8yvncaTqR6MwHrt6kMJa2mwuyeQDkplfu0t4Zw== X-YMail-OSG: NWXiqvkVM1khXTbYuNKr8g.ZwJbN7CreTZ6Ct.66JVhmAYCW4GE08zwA1EKADSY 8jlO2iVCBfDfEj8EcXuSU2vsbbx6x04Dk0Qjm0OJJ.LhDIAu3Gx3eoEiUgx5BH0YyFY201P4Pi7R ZGU9VXeZuNUvC69O3Z7IT4SL_h8ButlUwnsf6EJqw3inHRdcBgzO4xvWrbRbYG4C_3G2v4dECIs2 C9oC21Dh16NtuJvBrlTJBR0XcIeypUk.gp3VChA1b_YiS28Y1Cvtu15uOHNnoma3yA2e41rH7Qp_ z2MJ_0k22d6Eh5FHUAowTYmdozc8Sai5lWy71lgmihzY46bg_lIUpirhTZNLHuojfrV.Dhs.WywJ 2DWgoG070LqsRZsgIu6q5R4INeKWkZjH7_MfLv5qgCR5kypmA_gXkUyyjGVlYLh5LEMYWvtqnaHE SYEX472cczWFwUcQQEubOJYX02H0i7Duq.67WU4p5OLZIT.dMb3D6fiugJxcFb8AqHVBRS0jF4RA e24n7bq3TH5KkKUsG7EMUPZb54RD0ZtwPrItUt30sqtETsRehjHRdJoi7kM1yqks_hLQORnVL1kk OwqavMtsdHwHetANPyOvjXR9W1R4VlM4bqRtMSJXRjTeC_tlwHPcntnxymNBtHHxsgZuzqiOuZir f92trPawdVOYgsiJ8I0U3ppSIOwhpCEpN9FBLoSGm75diN5l.rMbw7D0GtF3KDQVGco8xBuFVV_K MzbB4kjTZgclpm7JypNLwxh7GNX5xfS53MdGI2fDXaJb9bq5wrLiP3RQ5BWnbySOy9wzFTMwpEYw n6yFiDDELVU.OzwwyZvJAo1kTIvE6JgXdWaZN0c4UB2IcPQnCaeW5l5SlqntWP0R0MX6rfzLxEF4 zxmoDNLn5JvwwXRarDKhheSG.HqvzhiD7jj5XaDPy3XhiksSb6kYekwCCHP_YkLBX9H0qDDdc5le Qn6_8gkpq_T1.Ynv2QGnl.gPxyshDddTAd0mgQftqzd9c7DsIQrzKRu9rIsU2axaRoPZJH3bt3A8 BAh5MsBQ.HA4k4WPwZMIzXeOJH.ZF6u37kCC8sGkamFQ1JpkNP608ftUFXEnCTNsh49Q_imF2MfO 0hWZlgMDW9xTCLmPkBJ44aHgjEUIBERHQZTXex.Mqrr7sOU8HCxZvSblzGTgI7FSADHBoQW9tdVw Rs9vtPYwD0HJX7ckw3kGuCpHZ_w8JZr3hr6UPIokZSxigJlvTBX0rvFpdVw0RghoDENcZ9K3CQyy KwnyoGmpZezQ2s2yFbCUK2k_KTn_XwKNuqpO5Rx.0xddmKAre.o8cLvhjfQG3qXHuDJBWCHeiTKv I3ZGqY7IahkKfofptBB7JAmy4Y7Lx290Vsj8Bedhhc_7ZIt7Tsn63pPUpR9QgehEGWH4RpEI1Mjv kqKTkj.HC5lmM_eqF9OT1fzKYQP1S3yLelsvH7aqE2TeP1dByWfBSm7oTSAwSG6eEgEzICNqdCZr 9V.z0qcBAOw0SXR4Dfp3Ey4L42QoZf3LSjdnMtsoh6qBk_qoP.eLxaSj1jHcGD_AnNizi9zkaBsS 3Wnzqd6HJtmexyEKUv58aeRELGM1ei2FA4en3XXZVBoZ2kaEdpFvnFPdvSP71l5Adr_Q1djYUFBd cJnYsMh_CcEfY2eOOWTIUEzWac0ZaGXx3YrnOXwawV_Zaa97wqOjag.bJwHO0W4RQqwjymqsyaXl gCZC6MH_RdT9tR9ml_Li1JJX_3aoOR.O9O1yorOBlBOcpLhb3xxKxwOR.FgInQHhp4t3nTlOl2Au ou1ZUlILq_vrSDWPwU_BSOaT5k3YsvqELIcyFYLLgfB5Tj0tkS8ZMIHu4SUaOtD6kJf9SsKoj43_ gL8e8FvucAGyQ0qUbIm9rf.4BcqV1I8BiN30dEEi2Wjq6s5WpU9VLLDQnvvnwsovSV3V2tsteqsr zM_RMBg88IiaJZJ1NY..WgG0kNSpxXO9PRrF_BJ9Mu5SK6IDLKq9IA3AFDMZFnrOma4Gj4wi2FR2 QKRf24HXIkAGIk5HYEMvUA43B2rVGt1GAeoacF37zN1oh3RNhCv35Ak2yFD2HLjVpChY_F0VP3rW 4H5VccBXsam4CStsORh6DX8.kdcVIioTB9kPxlF0CU3_LPpXRH0W97wphvZYe6z6I2p1Byb84QkV sDx27q7hrSSzeucHKHiY7I45YbAvyfZ66FXbotrEDZrjsxUGmQaAi.j0FPy_5.KA8hbEUAlosniK IW_iNvHByG4VaTNwzPoQDqxwypVBFqadxEVV07W4qb9.WPwP0Ba6O334THnkR7ej_qWSBFjVugA- - X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Sat, 24 Sep 2022 10:37:03 +0000 Received: by hermes--production-sg3-dfffdfbd4-ltdnp (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 114302b6b4a7d6f8d16dd572055c6bf7; Sat, 24 Sep 2022 10:36:59 +0000 (UTC) From: Po Lu To: Lars Ingebrigtsen Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> <878rm9om7q.fsf@elite.giraud> <834jwxpbo3.fsf@gnu.org> <874jwxnk02.fsf@elite.giraud> <87leq9ysax.fsf@gnus.org> Date: Sat, 24 Sep 2022 18:36:53 +0800 In-Reply-To: <87leq9ysax.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sat, 24 Sep 2022 12:34:30 +0200") Message-ID: <87czblawje.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20702 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 226 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 58028 Cc: 58028@debbugs.gnu.org, Eli Zaretskii , Manuel Giraud X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > I think Po Lu meant building Emacs with checking, otherwise those > asserts won't be compiled in. I.e., > > ./configure --enable-checking=all; make Indeed, that's what I meant. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 24 08:31:31 2022 Received: (at 58028) by debbugs.gnu.org; 24 Sep 2022 12:31:31 +0000 Received: from localhost ([127.0.0.1]:42611 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc4Jf-0000WZ-G2 for submit@debbugs.gnu.org; Sat, 24 Sep 2022 08:31:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc4Jd-0000WJ-3x for 58028@debbugs.gnu.org; Sat, 24 Sep 2022 08:31:30 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36102) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc4JX-0001rU-BK; Sat, 24 Sep 2022 08:31:23 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=SvCDGIYVmJTg+DsNwSTLDpPiSxyohBcw7d0ErXd7dGY=; b=XZiUoM+YvjLw O7E5000PLupuFOyUO/NYA8PYKlzUO2TSRgMOyBZBsQDErUT9pP5PZ0KNZgpJCeSzBDSKRoFft7Ghs zfW9M9QLolfcLEemdb70CfHx0XPRHwA5ip9V6AkWAoQS5krvYzFlmrRP7kz1vhdbY+nFkc0X3Cqpd UIuvmB8QHNi53HEPESjMZFqgBbbDbfGR0aiIAxMZXcY/gNarFCyXZt5TqiMJmcUt13ReOBMAiirJU s1xv94lN8kIz/hTgsOQdHMRIaHJp6zT23xS8jlo4wZqJNRdpEYDCWrkpfDBTukx09Es8Ea+os+422 pY6Mqmo05bZ3NiFYZPPwdA==; Received: from [87.69.77.57] (port=2220 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc4JV-0004wO-6O; Sat, 24 Sep 2022 08:31:22 -0400 Date: Sat, 24 Sep 2022 15:31:07 +0300 Message-Id: <83czblned0.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <874jwxnk02.fsf@elite.giraud> (message from Manuel Giraud on Sat, 24 Sep 2022 12:29:17 +0200) Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> <878rm9om7q.fsf@elite.giraud> <834jwxpbo3.fsf@gnu.org> <874jwxnk02.fsf@elite.giraud> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58028 Cc: 58028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 58028@debbugs.gnu.org > Date: Sat, 24 Sep 2022 12:29:17 +0200 > > + eassert ((w->desired_matrix == NULL) > + && (w->current_matrix != NULL)); > if (w->desired_matrix == NULL) > - { > - w->desired_matrix = new_glyph_matrix (NULL); > - w->current_matrix = new_glyph_matrix (NULL); > - } > + w->desired_matrix = new_glyph_matrix (NULL); > + > + if (w->current_matrix == NULL) > + w->current_matrix = new_glyph_matrix (NULL); I think this should be /* If matrices are not yet allocated, allocate them now. */ if (w->desired_matrix == NULL) { w->desired_matrix = new_glyph_matrix (NULL); eassert (w->current_matrix == NULL); } if (w->current_matrix == NULL) w->current_matrix = new_glyph_matrix (NULL); From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 24 11:31:30 2022 Received: (at 58028) by debbugs.gnu.org; 24 Sep 2022 15:31:30 +0000 Received: from localhost ([127.0.0.1]:44995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc77p-0008Cp-PI for submit@debbugs.gnu.org; Sat, 24 Sep 2022 11:31:30 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:2195) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc77n-0008Cg-3t for 58028@debbugs.gnu.org; Sat, 24 Sep 2022 11:31:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=tHcEC4CXAkkSFNSW /5o1cOrXOk1vcaJ5IPGrukmhwWs=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=2VUnmL4OkelVD0p3D1NWmvmhweIVUC55paJHm4 7A6u18tgJJmMESDIpDEb3xU2MlD9qsR+gtLzeQsqKv95pYaGFCrc7ijjqu7JUPlpqOOC8F Xa+OI6Ko89cssKC7KZbe5cUBiXtbuWubIc+jjle/QBoke49IsJmogQ04H9Oz0+0gwray6H 01JnkuGSksT2fLz+Zn527NPf8aBlhBUySzzqBXfJWOnO6uf4GvfgKUiTGSHt0Ku9cVLDaj LhT239j6WsxFrtN5SaPk48a3aqUO4/4mXXSiyRb0554Agxm4RxytQ8zQhKHqL/Up/Wz7pG /8mabzYs/3BZjoV/6h0urUlg== Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 7a43a585 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sat, 24 Sep 2022 17:31:25 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix In-Reply-To: <83czblned0.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Sep 2022 15:31:07 +0300") References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> <878rm9om7q.fsf@elite.giraud> <834jwxpbo3.fsf@gnu.org> <874jwxnk02.fsf@elite.giraud> <83czblned0.fsf@gnu.org> Date: Sat, 24 Sep 2022 17:31:20 +0200 Message-ID: <87zgeon60n.fsf@elite.giraud> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58028 Cc: 58028@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain So I've tested emacs -Q a bit (compiled with --enable-checking=all) with the attached patch. I had no error so far. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Ensures-no-leakage-of-glyph_matrix.patch >From 332ea1a172568a31f8e2ad0dcd921727d30dad68 Mon Sep 17 00:00:00 2001 From: Manuel Giraud Date: Fri, 23 Sep 2022 17:14:44 +0200 Subject: [PATCH] Ensures no leakage of glyph_matrix ; * src/dispnew.c (allocate_matrices_for_window_redisplay): Ensures no leakage of glyph_matrix. --- src/dispnew.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/dispnew.c b/src/dispnew.c index b786f0f1ba..2568ba1086 100644 --- a/src/dispnew.c +++ b/src/dispnew.c @@ -1810,9 +1810,12 @@ allocate_matrices_for_window_redisplay (struct window *w) if (w->desired_matrix == NULL) { w->desired_matrix = new_glyph_matrix (NULL); - w->current_matrix = new_glyph_matrix (NULL); + eassert (w->current_matrix == NULL); } + if (w->current_matrix == NULL) + w->current_matrix = new_glyph_matrix (NULL); + dim.width = required_matrix_width (w); dim.height = required_matrix_height (w); adjust_glyph_matrix (w, w->desired_matrix, 0, 0, dim); -- 2.37.3 --=-=-= Content-Type: text/plain -- Manuel Giraud --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 24 12:09:31 2022 Received: (at 58028-done) by debbugs.gnu.org; 24 Sep 2022 16:09:31 +0000 Received: from localhost ([127.0.0.1]:45050 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc7ic-0002yS-Sn for submit@debbugs.gnu.org; Sat, 24 Sep 2022 12:09:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:54220) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oc7iY-0002y5-0l for 58028-done@debbugs.gnu.org; Sat, 24 Sep 2022 12:09:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41128) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc7iS-0007uy-51; Sat, 24 Sep 2022 12:09:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=P2cVNLmqnXUqAixqaVIZAm/xMgg43fmyu9TG7qt4lOE=; b=dLNzg4uYQoZh RlHMEv+6i5/1kyKjgQi9eTV/qYvdcFRXRejEczy5h7mx2YLvF9ChDOB52xT+TZ8G+UoDXHj7tEvUS tppHsdo6s5sDNumLqcMSg01CnVPdgX9LQh5inp+TX24Gqy4dJmkb17DAixE/uvv8H7zedEzLPInZm mWeguH6Uj5DeBGhWnZFe6vI28Ljuh5IfGrvuY2VCPe6wNAT7n/ZI5ARSk0ZnvJR9/bCJ2O+unCOJG SE6w0xSaV1KmpSZkhCVJjfRCFknMQn1rNrYmP62atoI0w457z6QDmFCzqNkBFQ7MDMe0CD9hgiC/d vQCMTqHamCOV6uDE/qMq1Q==; Received: from [87.69.77.57] (port=3632 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oc7iR-0006qI-GA; Sat, 24 Sep 2022 12:09:19 -0400 Date: Sat, 24 Sep 2022 19:09:06 +0300 Message-Id: <83zgeon49p.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <87zgeon60n.fsf@elite.giraud> (message from Manuel Giraud on Sat, 24 Sep 2022 17:31:20 +0200) Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> <878rm9om7q.fsf@elite.giraud> <834jwxpbo3.fsf@gnu.org> <874jwxnk02.fsf@elite.giraud> <83czblned0.fsf@gnu.org> <87zgeon60n.fsf@elite.giraud> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58028-done Cc: 58028-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 58028@debbugs.gnu.org > Date: Sat, 24 Sep 2022 17:31:20 +0200 > > So I've tested emacs -Q a bit (compiled with --enable-checking=all) with > the attached patch. I had no error so far. Thanks, installed. Please in the future mention the bug number in the commit log message (I added it for you this time). From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 25 12:51:46 2022 Received: (at 58028-done) by debbugs.gnu.org; 25 Sep 2022 16:51:46 +0000 Received: from localhost ([127.0.0.1]:48458 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocUr4-0007Cy-7J for submit@debbugs.gnu.org; Sun, 25 Sep 2022 12:51:46 -0400 Received: from ledu-giraud.fr ([51.159.28.247]:23301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocUr0-0007Cn-W7 for 58028-done@debbugs.gnu.org; Sun, 25 Sep 2022 12:51:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=oPt8h9oYlIbWs4RR z/jvNJhnnW7/SRzgPLL6/+1sEes=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=urZiHBHpR1CkWnpJ/jKwf29JtWsLKp4yI0FBwW lovtf00drzaN2atVLX4e56pg6V7YjiTH2qt+tfrBXmyNckft537nRVpMi9VsxKVHArkDRf R0gBpW9lkyRS116mp/Lx45RlpGlMkUw5oOlJ/XS9teFaGvY4x+qzoabQlfaTxg6h5sbpWI cSGKfHQYbWo9lmo4/PSuOxz2ITykGqSyslHDV8pPbEM3kyUk4DxwZ+0GPedlLxi5ACL61J suT1M0aES5mkij8nVWvhB/3c85ojfQccm511C5hIaLYEiyihT0DgtzDSaJwnAhWuedBg+I vGsmc3Hk8PilESHHuhTPVA4g== Received: from elite.giraud ( [10.1.1.1]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id bff164b3 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Sun, 25 Sep 2022 18:51:40 +0200 (CEST) From: Manuel Giraud To: Eli Zaretskii Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix In-Reply-To: <83zgeon49p.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 24 Sep 2022 19:09:06 +0300") References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> <878rm9om7q.fsf@elite.giraud> <834jwxpbo3.fsf@gnu.org> <874jwxnk02.fsf@elite.giraud> <83czblned0.fsf@gnu.org> <87zgeon60n.fsf@elite.giraud> <83zgeon49p.fsf@gnu.org> Date: Sun, 25 Sep 2022 18:51:38 +0200 Message-ID: <8735cfgzxh.fsf@elite.giraud> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (berkeley-unix) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 58028-done Cc: 58028-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > Thanks, installed. Thanks. But I wonder what is the point of this eassert if it have to be activated at compile time? > Please in the future mention the bug number in the commit log message > (I added it for you this time). Ok, I'll try to remember this next time. BTW, how could you do it *before* submitting a bug report? Best regards, -- Manuel Giraud From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 25 15:15:34 2022 Received: (at 58028-done) by debbugs.gnu.org; 25 Sep 2022 19:15:34 +0000 Received: from localhost ([127.0.0.1]:48562 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocX6E-0002JT-Hj for submit@debbugs.gnu.org; Sun, 25 Sep 2022 15:15:34 -0400 Received: from eggs.gnu.org ([209.51.188.92]:55718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocX69-0002J9-Cs for 58028-done@debbugs.gnu.org; Sun, 25 Sep 2022 15:15:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60102) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocX61-0005lT-Ts; Sun, 25 Sep 2022 15:15:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jB4JvA6DjNQkiwvDU+JkkPcwT+Loqz5FOteZPZ9noNI=; b=BRsOJdi2AaUd w4Jscu/4/wV3+QfwcpJtT7gws2QXx7HVSx3C0QNgP4G+hKUzndePS3MdoP17SICFN43cV53Y2Z5dq o9aBdleMudKD8FJQohgN6N6mEncVZbqqYKiuoqXgvOUToiNh1rqeO0q6Spsf8LYggLj4akUSck2Mf 3vdjDowo7hXMP8F7GlKhAh9zJA09dWwtHBzPyphn+AfZ7k/5Y4ay7oJAljM9FX6qUGnpkfrSjLm/o ZA6ZHJ4d70e+HJzu6sQXuJZ2i2dCfjOQUTevMud2qe1W/H4d/S/2UpCR2G1qocCX6phFlUrENe49O 5BGn+d337JCTpUYVyO4Ilg==; Received: from [87.69.77.57] (port=3913 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocX5q-0005f6-5N; Sun, 25 Sep 2022 15:15:21 -0400 Date: Sun, 25 Sep 2022 22:14:59 +0300 Message-Id: <83r0zzl0zw.fsf@gnu.org> From: Eli Zaretskii To: Manuel Giraud In-Reply-To: <8735cfgzxh.fsf@elite.giraud> (message from Manuel Giraud on Sun, 25 Sep 2022 18:51:38 +0200) Subject: Re: bug#58028: 29.0.50; Ensures no leakage of glyph_matrix References: <87illenmjk.fsf@elite.giraud> <83sfkiozub.fsf@gnu.org> <87czbmnksr.fsf@elite.giraud> <83k05uoujl.fsf@gnu.org> <878rm9om7q.fsf@elite.giraud> <834jwxpbo3.fsf@gnu.org> <874jwxnk02.fsf@elite.giraud> <83czblned0.fsf@gnu.org> <87zgeon60n.fsf@elite.giraud> <83zgeon49p.fsf@gnu.org> <8735cfgzxh.fsf@elite.giraud> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58028-done Cc: 58028-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Manuel Giraud > Cc: 58028-done@debbugs.gnu.org > Date: Sun, 25 Sep 2022 18:51:38 +0200 > > Eli Zaretskii writes: > > > Thanks, installed. > > Thanks. But I wonder what is the point of this eassert if it have to be > activated at compile time? We believe that the assertion will never trigger, so having it in a production build is a net loss: users could lose their edits. OTOH, some of the developers (myself included) routinely compile Emacs with --enable-checking, which activates the assertions. So if this assertion is ever contradicted, chances are that one of the developers will bump into that situation, and will report it (or fix it). > > Please in the future mention the bug number in the commit log message > > (I added it for you this time). > > Ok, I'll try to remember this next time. BTW, how could you do it > *before* submitting a bug report? You don't. But once the bug report has more than a single message, the number is known, so patches submitted after that should mention the bug number. From unknown Tue Aug 19 09:59:54 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 24 Oct 2022 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator