GNU bug report logs - #58024
[PATCH] gnu: services: certbot: Add missing activation directory

Previous Next

Package: guix-patches;

Reported by: Mája Tomášek <maya.tomasek <at> disroot.org>

Date: Fri, 23 Sep 2022 12:59:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mája Tomášek
 <maya.tomasek <at> disroot.org>
Subject: bug#58024: closed (Re: bug#58024: [PATCH] gnu: services: certbot:
 Add missing activation directory)
Date: Thu, 29 Sep 2022 20:57:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#58024: [PATCH] gnu: services: certbot: Add missing activation directory

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 58024 <at> debbugs.gnu.org.

-- 
58024: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58024
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Ludovic Courtès <ludo <at> gnu.org>
To: Mája Tomášek <maya.tomasek <at> disroot.org>
Cc: 58024-done <at> debbugs.gnu.org
Subject: Re: bug#58024: [PATCH] gnu: services: certbot: Add missing
 activation directory
Date: Thu, 29 Sep 2022 22:56:15 +0200
Hi,

Mája Tomášek <maya.tomasek <at> disroot.org> skribis:

> When trying to run certbot, the mcron command fails, as
>  /etc/letsencrypt/live is missing. This patch Adds it into the certbot
>  activation service.

I adjusted the commit log to follow our conventions and applied it.

Thanks!

Ludo’.

[Message part 3 (message/rfc822, inline)]
From: Mája Tomášek <maya.tomasek <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: services: certbot: Add missing activation directory
Date: Fri, 23 Sep 2022 12:27:03 +0200
When trying to run certbot, the mcron command fails, as
 /etc/letsencrypt/live is missing. This patch Adds it into the certbot
 activation service.

 ---
 gnu/services/certbot.scm | 2 ++
 1 file changed, 2 insertions(+)

 diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm
 index 1c819bef48..7dfdad9874 100644
 --- a/gnu/services/certbot.scm
 +++ b/gnu/services/certbot.scm
 @@ -154,6 +154,7 @@ (define (certbot-renewal-jobs config)
 
 (define (certbot-activation config)
   (let* ((certbot-directory "/var/lib/certbot")
 +         (certbot-cert-directory "/etc/letsencrypt/live")
          (script (in-vicinity certbot-directory "renew-certificates"))
          (message (format #f (G_ "~a may need to be run~%") script)))
     (match config
 @@ -164,6 +165,7 @@ (define (certbot-activation config)
              (use-modules (guix build utils))
              (mkdir-p #$webroot)
              (mkdir-p #$certbot-directory)
 +             (mkdir-p #$certbot-cert-directory)
              (copy-file #$(certbot-command config) #$script)
              (display #$message)))))))
 
 -- 
 2.37.3



This bug report was last modified 2 years and 298 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.