Subject: bug#58024: closed (Re: bug#58024: [PATCH] gnu: services: certbot: Add missing activation directory)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 29 Sep 2022 20:57:02 +0000

Your bug report

#58024: [PATCH] gnu: services: certbot: Add missing activation directory

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
58024: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58024
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#58024: [PATCH] gnu: services: certbot: Add missing activation directory
From: Ludovic Courtès <[email-masked]>
To: Mája Tomášek <[email-masked]>
Cc: [email-masked]
Date: Thu, 29 Sep 2022 22:56:15 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi,

Mája Tomášek <[email-masked]> skribis:

> When trying to run certbot, the mcron command fails, as
>  /etc/letsencrypt/live is missing. This patch Adds it into the certbot
>  activation service.

I adjusted the commit log to follow our conventions and applied it.

Thanks!

Ludo’.

Subject: [PATCH] gnu: services: certbot: Add missing activation directory
From: Mája Tomášek <[email-masked]>
To: [email-masked]
Date: Fri, 23 Sep 2022 12:27:03 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

When trying to run certbot, the mcron command fails, as
 /etc/letsencrypt/live is missing. This patch Adds it into the certbot
 activation service.

 ---
 gnu/services/certbot.scm | 2 ++
 1 file changed, 2 insertions(+)

 diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm
 index 1c819bef48..7dfdad9874 100644
 --- a/gnu/services/certbot.scm
 +++ b/gnu/services/certbot.scm
 @@ -154,6 +154,7 @@ (define (certbot-renewal-jobs config)
 
 (define (certbot-activation config)
   (let* ((certbot-directory "/var/lib/certbot")
 +         (certbot-cert-directory "/etc/letsencrypt/live")
          (script (in-vicinity certbot-directory "renew-certificates"))
          (message (format #f (G_ "~a may need to be run~%") script)))
     (match config
 @@ -164,6 +165,7 @@ (define (certbot-activation config)
              (use-modules (guix build utils))
              (mkdir-p #$webroot)
              (mkdir-p #$certbot-directory)
 +             (mkdir-p #$certbot-cert-directory)
              (copy-file #$(certbot-command config) #$script)
              (display #$message)))))))
 
 -- 
 2.37.3