From unknown Thu Aug 21 14:53:25 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#58024] [PATCH] gnu: services: certbot: Add missing activation directory Resent-From: =?UTF-8?Q?M=C3=A1ja_?= =?UTF-8?Q?Tom=C3=A1=C5=A1ek?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Sep 2022 12:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 58024 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 58024@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166393794119526 (code B ref -1); Fri, 23 Sep 2022 12:59:02 +0000 Received: (at submit) by debbugs.gnu.org; 23 Sep 2022 12:59:01 +0000 Received: from localhost ([127.0.0.1]:39656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obiGh-00054q-Nx for submit@debbugs.gnu.org; Fri, 23 Sep 2022 08:59:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:58528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obfts-0007Up-6x for submit@debbugs.gnu.org; Fri, 23 Sep 2022 06:27:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obftq-0005Ra-Ke for guix-patches@gnu.org; Fri, 23 Sep 2022 06:27:14 -0400 Received: from knopi.disroot.org ([178.21.23.139]:56304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obfto-000862-Kl for guix-patches@gnu.org; Fri, 23 Sep 2022 06:27:14 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 41B884A148 for ; Fri, 23 Sep 2022 12:27:08 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4GMzSOnbsPtV for ; Fri, 23 Sep 2022 12:27:07 +0200 (CEST) From: =?UTF-8?Q?M=C3=A1ja_?= =?UTF-8?Q?Tom=C3=A1=C5=A1ek?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1663928827; bh=OA9DrIK+QcvHifr3DA8gVsHXLpurlrnigK6Y/kco2g0=; h=From:To:Subject:Date; b=PWxJ5VP0aEPP6UyMqt7TAHxEA1Ay5J5vQV7OPdchGiv7MBUeVrO6Bw9UVWhYmSNIH 8/1CQ55nI3yT4uWiHfsBMlU9PdzDboYH1NNSjqNxI+0AgDSj3DhAKi3XmY2mcp+x8S 2QPWID6VM52aabuK31BSwYfeK9xHM8RC3YBUspxqPVjZ/ntEjOXUymVBkLZ9W7nIbB IQqBWwU7zL/kiZmOXFr/LNeFADhndjaOLKwssPtGyHaHy6UrJYO8FTHSzJ9KF3fUc5 fh7GhNbb7HBsavUvfoRhzHoWKHjmxjR2Zsv7Xpbf9rFpCUKuxovjQ7n+D5StAFa/q9 AT8sxAmoQgZ9A== Date: Fri, 23 Sep 2022 12:27:03 +0200 Message-ID: <87pmfm2xoo.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=178.21.23.139; envelope-from=maya.tomasek@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Mailman-Approved-At: Fri, 23 Sep 2022 08:58:58 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) When trying to run certbot, the mcron command fails, as /etc/letsencrypt/live is missing. This patch Adds it into the certbot activation service. --- gnu/services/certbot.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm index 1c819bef48..7dfdad9874 100644 --- a/gnu/services/certbot.scm +++ b/gnu/services/certbot.scm @@ -154,6 +154,7 @@ (define (certbot-renewal-jobs config) (define (certbot-activation config) (let* ((certbot-directory "/var/lib/certbot") + (certbot-cert-directory "/etc/letsencrypt/live") (script (in-vicinity certbot-directory "renew-certificates")) (message (format #f (G_ "~a may need to be run~%") script))) (match config @@ -164,6 +165,7 @@ (define (certbot-activation config) (use-modules (guix build utils)) (mkdir-p #$webroot) (mkdir-p #$certbot-directory) + (mkdir-p #$certbot-cert-directory) (copy-file #$(certbot-command config) #$script) (display #$message))))))) -- 2.37.3 From unknown Thu Aug 21 14:53:25 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: =?UTF-8?Q?M=C3=A1ja_?= =?UTF-8?Q?Tom=C3=A1=C5=A1ek?= Subject: bug#58024: closed (Re: bug#58024: [PATCH] gnu: services: certbot: Add missing activation directory) Message-ID: References: <87ill599xs.fsf@gnu.org> <87pmfm2xoo.fsf@disroot.org> X-Gnu-PR-Message: they-closed 58024 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 58024@debbugs.gnu.org Date: Thu, 29 Sep 2022 20:57:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1664485022-1221-1" This is a multi-part message in MIME format... ------------=_1664485022-1221-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #58024: [PATCH] gnu: services: certbot: Add missing activation directory which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 58024@debbugs.gnu.org. --=20 58024: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D58024 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1664485022-1221-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 58024-done) by debbugs.gnu.org; 29 Sep 2022 20:56:24 +0000 Received: from localhost ([127.0.0.1]:39799 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oe0Zz-0000Iq-R2 for submit@debbugs.gnu.org; Thu, 29 Sep 2022 16:56:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40120) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oe0Zy-0000Ic-8c for 58024-done@debbugs.gnu.org; Thu, 29 Sep 2022 16:56:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34736) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oe0Zt-00051w-2i; Thu, 29 Sep 2022 16:56:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=almcsDYWg3+GDkrCA22QxLmwi3mRiMK9dDdYrSXW9F0=; b=jVIjCloWPt2WmciggqJK d3mcOwEGyYSTqMigHovnYXmB4q0dsSvMOUsiSc9KhcD4WfIuNPw+bIxzd8SWMRZ+4m36cjYnkn3HT IKjn/iZe7CZTbNQEalaaZgT1o8RR97ihIwxwqTVGOLjj/RmoU1aPe3EpzcMKrSXbrXr2J7g/twOvQ 3mVWi9UtEpBiVbx4KW86ZeKRwCKCQkCOYNtC+mUrXSG9nFgZC4+/IWe4x+4cWJufQ62zxehfyD1Zu wUL7q2tNvfqYLE8hU5vhE0omWWNe2cChtZY2ugGG66aKRNQmMOzP0aAhdeEWKNlQ+l1P0J/ROH6ms WhOVaz6O4Q9MfA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:50983 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oe0Zs-0000PZ-LW; Thu, 29 Sep 2022 16:56:16 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: =?utf-8?B?TcOhamEgVG9tw6HFoWVr?= Subject: Re: bug#58024: [PATCH] gnu: services: certbot: Add missing activation directory References: <87pmfm2xoo.fsf@disroot.org> Date: Thu, 29 Sep 2022 22:56:15 +0200 In-Reply-To: <87pmfm2xoo.fsf@disroot.org> (=?utf-8?B?Ik3DoWphIFRvbcOhxaFl?= =?utf-8?B?ayIncw==?= message of "Fri, 23 Sep 2022 12:27:03 +0200") Message-ID: <87ill599xs.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 58024-done Cc: 58024-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, M=C3=A1ja Tom=C3=A1=C5=A1ek skribis: > When trying to run certbot, the mcron command fails, as > /etc/letsencrypt/live is missing. This patch Adds it into the certbot > activation service. I adjusted the commit log to follow our conventions and applied it. Thanks! Ludo=E2=80=99. ------------=_1664485022-1221-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Sep 2022 12:59:01 +0000 Received: from localhost ([127.0.0.1]:39656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obiGh-00054q-Nx for submit@debbugs.gnu.org; Fri, 23 Sep 2022 08:59:00 -0400 Received: from lists.gnu.org ([209.51.188.17]:58528) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obfts-0007Up-6x for submit@debbugs.gnu.org; Fri, 23 Sep 2022 06:27:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:57966) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obftq-0005Ra-Ke for guix-patches@gnu.org; Fri, 23 Sep 2022 06:27:14 -0400 Received: from knopi.disroot.org ([178.21.23.139]:56304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1obfto-000862-Kl for guix-patches@gnu.org; Fri, 23 Sep 2022 06:27:14 -0400 Received: from localhost (localhost [127.0.0.1]) by disroot.org (Postfix) with ESMTP id 41B884A148 for ; Fri, 23 Sep 2022 12:27:08 +0200 (CEST) X-Virus-Scanned: SPAM Filter at disroot.org Received: from knopi.disroot.org ([127.0.0.1]) by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4GMzSOnbsPtV for ; Fri, 23 Sep 2022 12:27:07 +0200 (CEST) From: =?utf-8?B?TcOhamEgVG9tw6HFoWVr?= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail; t=1663928827; bh=OA9DrIK+QcvHifr3DA8gVsHXLpurlrnigK6Y/kco2g0=; h=From:To:Subject:Date; b=PWxJ5VP0aEPP6UyMqt7TAHxEA1Ay5J5vQV7OPdchGiv7MBUeVrO6Bw9UVWhYmSNIH 8/1CQ55nI3yT4uWiHfsBMlU9PdzDboYH1NNSjqNxI+0AgDSj3DhAKi3XmY2mcp+x8S 2QPWID6VM52aabuK31BSwYfeK9xHM8RC3YBUspxqPVjZ/ntEjOXUymVBkLZ9W7nIbB IQqBWwU7zL/kiZmOXFr/LNeFADhndjaOLKwssPtGyHaHy6UrJYO8FTHSzJ9KF3fUc5 fh7GhNbb7HBsavUvfoRhzHoWKHjmxjR2Zsv7Xpbf9rFpCUKuxovjQ7n+D5StAFa/q9 AT8sxAmoQgZ9A== To: guix-patches@gnu.org Subject: [PATCH] gnu: services: certbot: Add missing activation directory Date: Fri, 23 Sep 2022 12:27:03 +0200 Message-ID: <87pmfm2xoo.fsf@disroot.org> Mime-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=178.21.23.139; envelope-from=maya.tomasek@disroot.org; helo=knopi.disroot.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 23 Sep 2022 08:58:58 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) When trying to run certbot, the mcron command fails, as /etc/letsencrypt/live is missing. This patch Adds it into the certbot activation service. --- gnu/services/certbot.scm | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gnu/services/certbot.scm b/gnu/services/certbot.scm index 1c819bef48..7dfdad9874 100644 --- a/gnu/services/certbot.scm +++ b/gnu/services/certbot.scm @@ -154,6 +154,7 @@ (define (certbot-renewal-jobs config) (define (certbot-activation config) (let* ((certbot-directory "/var/lib/certbot") + (certbot-cert-directory "/etc/letsencrypt/live") (script (in-vicinity certbot-directory "renew-certificates")) (message (format #f (G_ "~a may need to be run~%") script))) (match config @@ -164,6 +165,7 @@ (define (certbot-activation config) (use-modules (guix build utils)) (mkdir-p #$webroot) (mkdir-p #$certbot-directory) + (mkdir-p #$certbot-cert-directory) (copy-file #$(certbot-command config) #$script) (display #$message))))))) -- 2.37.3 ------------=_1664485022-1221-1--