Subject: bug#58002: closed (Re: bug#58002: 29.1: Sokoban: obsoletion warnings in gamegrid)

From: [email-masked] (GNU bug Tracking System)
Date: Sun, 13 Nov 2022 14:00:03 +0000

Your bug report

#58002: 29.1: Sokoban: obsoletion warnings in gamegrid

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
58002: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=58002
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#58002: 29.1: Sokoban: obsoletion warnings in gamegrid
From: Stefan Kangas <[email-masked]>
To: Dieter Deyke <[email-masked]>
Cc: [email-masked],Mattias Engdegård <[email-masked]>
Date: Sun, 13 Nov 2022 05:59:01 -0800
List-Id: <debbugs-submit.debbugs.gnu.org>

Dieter Deyke <[email-masked]> writes:

> Yes, the patch was installed, the warnings are gone, everything is fine
> now. Please close the bug.

Thanks, done.

Subject: 29.1: Sokoban: obsoletion warnings in gamegrid
From: Mattias Engdegård <[email-masked]>
To: Emacs Bug Report <[email-masked]>
Cc: Dieter Deyke <[email-masked]>, Stefan Kangas <[email-masked]>
Date: Thu, 22 Sep 2022 12:06:27 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

On Emacs master, starting Sokoban (from GNU ELPA) results in several warnings:

> Warning (gamegrid): Using obsolete XEmacs style "glyph"; convert to an Emacs image-spec instead

which apparently is from

> (defvar sokoban-target-options
>   `(((glyph
>       [xpm :data ,sokoban-target-xpm])
[...]

where (after some digging) it seems that the vector needs to be

      ((:type xpm :data ,sokoban-target-xpm :ascent center)))

somewhat non-intuitively, because of the slightly alarming line

> 	   (find-image data)) ;untested!

in gamegrid.el. Suggested patch attached.
Is this all correct and as desired? Does it break anything when using old Emacs versions?