Subject: Re: [bug#57980] [PATCH] gnu: Add emacs-piem.

From: Nicolas Goaziou <[email-masked]>
Date: Sat, 24 Sep 2022 20:57:24 +0200

Hello,

zimoun <[email-masked]> writes:

> * gnu/packages/emacs-xyz.scm (emacs-piem): New variable.

Thank you. Applied with the following changes:

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://git.kyleam.com/piem.git")

I removed ".git" suffix.

> +             (commit (string-append "v" version))))
> +       (file-name (string-append name "-" version "-checkout"))
> +       (sha256
> +        (base32 "0wr6n6wvznngjdp4c0pmdr4xz05dark0kxi5svzhzxsg3rdaql3z"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     (list b4

This need to be moved to inputs, along with an appropriate phase. I'll
do this in a later commit.

> +    (description "This packages provides a collection of Emacs libraries for
> +working with public-inbox archives. As much of the hard work here is already
> +done by other Emacs libraries—things like mail clients, news readers, Git
> +interfaces, and even web browsers—piem is mostly about bridging some of these
> +parts for convenience.")

I added two spaces between sentences.

> +    (license license:gpl3)))

License is actually GPL3+ (I forgot to change it, I'll do this in
a later commit too)

Regards,
-- 
Nicolas Goaziou