Subject: bug#57975: closed (Re: [bug#57975] [PATCH] gnu: rust-libz-sys-1: Do not remove zlib-ng sources.)

From: [email-masked] (GNU bug Tracking System)
Date: Wed, 21 Sep 2022 22:12:02 +0000

Your bug report

#57975: [PATCH] gnu: rust-libz-sys-1: Do not remove zlib-ng sources.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
57975: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57975
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#57975] [PATCH] gnu: rust-libz-sys-1: Do not remove zlib-ng sources.
From: Ricardo Wurmus <[email-masked]>
To: Maxime Devos <[email-masked]>
Cc: [email-masked]
Date: Thu, 22 Sep 2022 00:10:16 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Ricardo Wurmus <[email-masked]> writes:

> Maxime Devos <[email-masked]> writes:
>
>> Proposal: keep removing zlib-ng, and modify the enabled features in
>> whatever crate or Rust application asks for zlib-ng.
>
> Thanks, I’ll give that a try by patching the target application.

Patching the package to not request the zlib-ng feature works, so I
retract this patch.  Thanks again for the hint!

-- 
Ricardo

Subject: [PATCH] gnu: rust-libz-sys-1: Do not remove zlib-ng sources.
From: Ricardo Wurmus <[email-masked]>
To: [email-masked]
Cc: Ricardo Wurmus <[email-masked]>
Date: Wed, 21 Sep 2022 11:35:27 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/packages/crates-io.scm (rust-libz-sys-1)[source]: Only delete bundled
zlib sources.
---
 gnu/packages/crates-io.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/crates-io.scm b/gnu/packages/crates-io.scm
index 42a44a2930..f7703f9295 100644
--- a/gnu/packages/crates-io.scm
+++ b/gnu/packages/crates-io.scm
@@ -32568,9 +32568,9 @@ (define-public rust-libz-sys-1
           "1q25cb8vs113si7q2p0innhi8jk0wpq37hqi2wcc219hcmw43cr3"))
         (modules '((guix build utils)))
         (snippet
-         '(begin (delete-file-recursively "src/zlib")
-                 (delete-file-recursively "src/zlib-ng")
-                 #t))))
+         ;; Do not delete zlib-ng, because we have no native library
+         ;; for it.
+         '(delete-file-recursively "src/zlib"))))
     (build-system cargo-build-system)
     (arguments
      `(#:cargo-inputs
-- 
2.36.1