From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 21 04:17:32 2022 Received: (at submit) by debbugs.gnu.org; 21 Sep 2022 08:17:32 +0000 Received: from localhost ([127.0.0.1]:60548 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oauvB-0004xN-4B for submit@debbugs.gnu.org; Wed, 21 Sep 2022 04:17:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:42792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oauv6-0004xB-B5 for submit@debbugs.gnu.org; Wed, 21 Sep 2022 04:17:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38592) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oauv6-0005nG-4k for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 04:17:24 -0400 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]:34482) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oauv4-0004yd-Kk for bug-gnu-emacs@gnu.org; Wed, 21 Sep 2022 04:17:23 -0400 Received: by mail-ej1-x635.google.com with SMTP id y3so11884072ejc.1 for ; Wed, 21 Sep 2022 01:17:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date; bh=2LFbimHUAsjpsdicqeLh6ttoq5frTpzYkASKScb56lQ=; b=on7wwVXMMlHOP0xlPB20R1LrrMXBLdDK4WAI7+HLPstw8HiFCZb/rY0rXw0ecuLKmt Ry0/vj7sAGl2doatNuJ1Z92K/aCFmWh9r5xSefNy/EIPb3v4YcsX/hk24O62y4JzRO2E l46KWAzjAQncOozuLxb9KFEJ7V8ZV6DfizCWW3b3iTv19KXNlN9gNfx1BRr4T56UXMhm KrbhQVR2MTtiD5ljSkXGmTT6K5N/nBzD/PupBz2f37hg/hgfNtd3NxU4vkOOCW0j7XlE pABbZq20Gko3INFpJyC8gdSufvEyMhJIIsusgpyUVNyqWkIMcr3i7jex0bitIcNKDtQP Gysw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date; bh=2LFbimHUAsjpsdicqeLh6ttoq5frTpzYkASKScb56lQ=; b=S5CqA97zDFasEcuDuR78sGUGNOaLu+CpqK1mLZ4M/DytPB5rW5av2/upQL6V1YdQpe aMpZL+WGND9FbpCOsjDVtgCgV4qyuUHCcnRcFRbtmhWMQ8fnVMw8NC6/h0JYpkozN1zJ 6MkZF0sXox4J30nNjTLRBk53v+d3v8OC4/R4Fp6ufa3/H4XVZGAvsI0uJoEVEow4uIsM AZ/iiu6aDW41xc2/7oB56DN6NbmHkDvDQlWRU6Avf3ilebntMQMkFa2YO151EZVFIEax eBYJUPskx1wfksYBZ5gpUj8dyDcbS6rN6Pu447MWXVY1BOxxxGrWr8XKCRPYP0lIvsPc kl7A== X-Gm-Message-State: ACrzQf0eLGaBx4nCbGqEm8V0p604mus9Zf7JPzwSpEoUsCCILMb2cUG4 TLj5D2faY5RaaUSFZvTTAcmE96V9sx8= X-Google-Smtp-Source: AMsMyM73H6mU8RgF+IYb7KGy3ZcJhXFzgIJM0EWUR5ftYtjwCsAryaAyieKD8KsvRt8cxXc16/z9NA== X-Received: by 2002:a17:907:2c4f:b0:77d:f3eb:f079 with SMTP id hf15-20020a1709072c4f00b0077df3ebf079mr19462378ejc.356.1663748240658; Wed, 21 Sep 2022 01:17:20 -0700 (PDT) Received: from thuna ([193.205.22.58]) by smtp.gmail.com with ESMTPSA id x14-20020a056402414e00b0043bea0a48d0sm1384315eda.22.2022.09.21.01.17.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Sep 2022 01:17:20 -0700 (PDT) From: Thuna To: bug-gnu-emacs@gnu.org Subject: [Patch] Correct the usage of `image-file-name-regexps' Date: Wed, 21 Sep 2022 10:17:16 +0200 Message-ID: <8735clrvjn.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::635; envelope-from=thuna.cing@gmail.com; helo=mail-ej1-x635.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain The variable name, documentation, and the defcustom of `image-file-name-regexps' seems to suggest that it is a list of regexps, however the function `image-file-name-regexp' treats it like a single regexp instead. Copyright-paperwork-exempt: yes --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Correct-the-usage-of-image-file-name-regexps.patch >From 86c4b8e0510ac4ad9d907bed1720b47968450d08 Mon Sep 17 00:00:00 2001 From: Thuna Date: Wed, 21 Sep 2022 09:51:31 +0200 Subject: [PATCH] Correct the usage of `image-file-name-regexps' * lisp/image-file.el (image-file-name-regexp): Treat `image-file-name-regexps' as a list of regexps instead of a regexp. --- lisp/image-file.el | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lisp/image-file.el b/lisp/image-file.el index 0ed88e8e74..e97fb179ee 100644 --- a/lisp/image-file.el +++ b/lisp/image-file.el @@ -91,9 +91,9 @@ image-file-name-regexp "\\'")))) (mapconcat #'identity - (delq nil (list exts-regexp - image-file-name-regexps - (car (rassq 'imagemagick image-type-file-name-regexps)))) + (delq nil (nconc (list exts-regexp + (car (rassq 'imagemagick image-type-file-name-regexps))) + image-file-name-regexps)) "\\|"))) -- 2.35.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 21 07:53:46 2022 Received: (at 57971) by debbugs.gnu.org; 21 Sep 2022 11:53:46 +0000 Received: from localhost ([127.0.0.1]:60977 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oayIT-00030P-U9 for submit@debbugs.gnu.org; Wed, 21 Sep 2022 07:53:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oayIR-000306-La for 57971@debbugs.gnu.org; Wed, 21 Sep 2022 07:53:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=C39mbyn0kAxugPW/y/PipniZGEJFX9OfdUc9SZfK5bs=; b=Xn+kBHLj6btmM6HDdCHXxmzofM 8n5H/wuXlREZ5dLugh7ZlkwMVYGE+an2jtrfk3jGZmsj3FKyRzESClwfClji6rtigd7xV0uHNuSni qEa9f3IJvCw416JsMKppEBk9DVW39TjD5kBmTR/07+JtA0ot6EKG2p0JRP9ymb55znrI=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oayIJ-0004iW-Hw; Wed, 21 Sep 2022 13:53:37 +0200 From: Lars Ingebrigtsen To: Thuna Subject: Re: bug#57971: [Patch] Correct the usage of `image-file-name-regexps' In-Reply-To: <8735clrvjn.fsf@gmail.com> (Thuna's message of "Wed, 21 Sep 2022 10:17:16 +0200") References: <8735clrvjn.fsf@gmail.com> X-Now-Playing: Niki Mono's _Contradictions are a Luxury_: "Contradictions Are A Luxury" Date: Wed, 21 Sep 2022 13:53:35 +0200 Message-ID: <87bkr96j0g.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Thuna writes: > The variable name, documentation, and the defcustom of > `image-file-name-regexps' seems to suggest that it is a list of regexps, > however the function `image-file-name-regexp' treats it like a sin [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57971 Cc: 57971@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Thuna writes: > The variable name, documentation, and the defcustom of > `image-file-name-regexps' seems to suggest that it is a list of regexps, > however the function `image-file-name-regexp' treats it like a single > regexp instead. > > Copyright-paperwork-exempt: yes Thanks; pushed to Emacs 29. If I'm counting correctly, this was the third patch applied, but the number of new lines is still below the limit, so using "Copyright-paperwork-exempt: yes" is still fine, but probably any further patches will require FSF copyright assignment. From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 21 07:53:49 2022 Received: (at control) by debbugs.gnu.org; 21 Sep 2022 11:53:49 +0000 Received: from localhost ([127.0.0.1]:60980 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oayIX-00030j-6f for submit@debbugs.gnu.org; Wed, 21 Sep 2022 07:53:49 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oayIV-00030G-Lt for control@debbugs.gnu.org; Wed, 21 Sep 2022 07:53:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=gP/sCx17nRUZEVMwQ0SBPR1lkxg0wR+CZ9o/E7+e3+U=; b=UbAdi7cd78C6IvDR82onelhwRg 3HXmvVSwgLDRqeY5PQwZFeeOeW4aQ1SW9jHd4loNBhwZs9tPUV60uJQJmra48AedxEUCvhlt1O8jF i+cwmxur6NMDX1s0PzMbUNCVABiO9rMYNHUpbgb/uzy946m3zh8Yi7L67QK9QkFiYwzg=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oayIO-0004if-05 for control@debbugs.gnu.org; Wed, 21 Sep 2022 13:53:42 +0200 Date: Wed, 21 Sep 2022 13:53:39 +0200 Message-Id: <87a66t6j0c.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #57971 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 57971 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 57971 29.1 quit From unknown Mon Aug 18 06:57:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 20 Oct 2022 11:24:09 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator