GNU bug report logs - #57963
[PATCH 0/1] Support user's fontconfig.

Previous Next

Full log

View this message in rfc822 format

From: Taiju HIGASHI <higashi <at> taiju.info>
To: Liliana Marie Prikler <liliana.prikler <at> gmail.com>
Cc: ludo <at> gnu.org, 57963 <at> debbugs.gnu.org, andrew <at> trop.in
Subject: [bug#57963] [PATCH v3] home: fontutils: Support user's fontconfig.
Date: Thu, 29 Sep 2022 23:46:13 +0900

Hi Liliana,

I've sent you the v4 patch.

Taiju HIGASHI <higashi <at> taiju.info> writes:

> Liliana Marie Prikler <liliana.prikler <at> gmail.com> writes:
>
>>> -(define (add-fontconfig-config-file he-symlink-path)
>>> +(define-record-type* <default-font> default-font
>>> +  make-default-font
>>> +  default-font?
>>> +  (serif default-font-serif (default ""))
>>> +  (sans-serif defalut-font-sans-serif (default ""))
>>> +  (monospace default-font-monospace (default "")))
>> Is the empty string a meaningful value in these places?
>
> Sure, It is not meaningful.  I would remove the default value.

I couldn't remove the default value because without a default value, for
example, it can't specify only serifs.
However, I've changed the serialization of the field so that it is now a
comfortable default value.

Cheers,
-- 
Taiju

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.