GNU bug report logs - #57945
[PATCH] gnu: wpa-supplicant: enable OWE support

Previous Next

Full log

Message #8 received at 57945 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Andreas Rammhold <andreas <at> rammhold.de>, 57945 <at> debbugs.gnu.org
Subject: Re: [bug#57945] [PATCH] gnu: wpa-supplicant: enable OWE support
Date: Thu, 22 Sep 2022 21:14:56 +0200

[Message part 1 (text/plain, inline)]

On 20-09-2022 01:59, Andreas Rammhold wrote:
> +           (add-after 'configure 'enable-owe
> +             (lambda _
> +               (let ((port (open-file ".config" "al")))
> +                 (display "CONFIG_OWE=y\n" port)
> +                 (close-port port))
> +               #t))


(1) Why not do this in the 'configure' phase instead?
(2) Trailing #t in phases aren't required anymore since a long time, you 
can remove them.
(3) You are not a committer (and you are the author), so you can't 'push 
the commit on behalf on somebody else'.  From (guix)Commit Access:

   When pushing a commit on behalf of somebody else, please add a
‘Signed-off-by’ line at the end of the commit log message—e.g., with
‘git am --signoff’.  This improves tracking of who did what.

The other meaning of 'Signed-off-by' I'm aware of, is for 'Developer 
Certificate of Origin', but we don't do DCO in Guix (and if we did, it 
would be mentioned in the contributing guidelines somewhere).

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.