GNU bug report logs - #57945
[PATCH] gnu: wpa-supplicant: enable OWE support

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Andreas Rammhold <andreas <at> rammhold.de>
Subject: bug#57945: closed (Re: bug#57945: [PATCH] gnu: wpa-supplicant:
 enable OWE support)
Date: Wed, 28 Sep 2022 20:42:03 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#57945: [PATCH] gnu: wpa-supplicant: enable OWE support

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 57945 <at> debbugs.gnu.org.

-- 
57945: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57945
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: 57945-done <at> debbugs.gnu.org, Andreas Rammhold <andreas <at> rammhold.de>
Subject: Re: bug#57945: [PATCH] gnu: wpa-supplicant: enable OWE support
Date: Wed, 28 Sep 2022 22:41:34 +0200

Hi,

Maxime Devos <maximedevos <at> telenet.be> skribis:

> On 20-09-2022 01:59, Andreas Rammhold wrote:
>> +           (add-after 'configure 'enable-owe
>> +             (lambda _
>> +               (let ((port (open-file ".config" "al")))
>> +                 (display "CONFIG_OWE=y\n" port)
>> +                 (close-port port))
>> +               #t))
>
>
> (1) Why not do this in the 'configure' phase instead?
> (2) Trailing #t in phases aren't required anymore since a long time,
> you can remove them.
> (3) You are not a committer (and you are the author), so you can't
> 'push the commit on behalf on somebody else'.  From (guix)Commit

Good points (perhaps somewhat intimidating for a newcomer).

Andreas, I applied a variant of the patch that accounts for the comments
Maxime made.

Thank you!

Ludo’.

[Message part 3 (message/rfc822, inline)]

From: Andreas Rammhold <andreas <at> rammhold.de>
To: guix-patches <at> gnu.org
Cc: Andreas Rammhold <andreas <at> rammhold.de>
Subject: [PATCH] gnu: wpa-supplicant: enable OWE support
Date: Tue, 20 Sep 2022 01:59:56 +0200

With OWE support users are enable to connect to "Opportunistic Wireless
Encryption" networks. This means users are able to have an encrypted
data channel in an otherwise open wireless network.

* gnu/packages/admin.scm (wpa-supplicant): Enable OWE support.

Signed-off-by: Andreas Rammhold <andreas <at> rammhold.de>
---
 gnu/packages/admin.scm | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/gnu/packages/admin.scm b/gnu/packages/admin.scm
index 5fb621e027..84819992c4 100644
--- a/gnu/packages/admin.scm
+++ b/gnu/packages/admin.scm
@@ -51,6 +51,7 @@
 ;;; Copyright © 2021 Artyom V. Poptsov <poptsov.artyom <at> gmail.com>
 ;;; Copyright © 2022 Wamm K. D. <jaft.r <at> outlook.com>
 ;;; Copyright © 2022 Roman Riabenko <roman <at> riabenko.com>
+;;; Copyright © 2022 Andreas Rammhold <andreas <at> rammhold.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -2133,6 +2134,12 @@ (define-public wpa-supplicant
       CONFIG_CTRL_IFACE_DBUS_INTRO=y\n" port)
                  (close-port port))
                #t))
+           (add-after 'configure 'enable-owe
+             (lambda _
+               (let ((port (open-file ".config" "al")))
+                 (display "CONFIG_OWE=y\n" port)
+                 (close-port port))
+               #t))
           (add-after 'install-documentation 'install-dbus-conf
             (lambda* (#:key outputs #:allow-other-keys)
               (let* ((out (assoc-ref outputs "out"))

base-commit: d845326b5cb33453a50b9c8fd8f21dfd8198a158
prerequisite-patch-id: b830a1b0573b55d8a8378338862dc5bfaac53117
prerequisite-patch-id: 59289da7b58eb3a1ea1f3b531261d0785b58dd36
prerequisite-patch-id: a761f12c1d69204330e6215a26ea110c281ea834
prerequisite-patch-id: fcc87d0b44e2c3597e9270e6d96c8f1e4beddcf6
-- 
2.37.2

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.