Subject: [bug#57944] [PATCH 1/2] gnu: Add gnome-text-editor

From: Liliana Marie Prikler <[email-masked]>
Date: Tue, 20 Sep 2022 07:14:11 +0200

Hi,

Am Dienstag, dem 20.09.2022 um 04:13 +0000 schrieb Sughosha:

> +              (uri (string-append "mirror://gnome/sources/gnome-
> text-editor/"
> +                                  (version-major version)
> +                                  "/"
> +                                  "gnome-text-editor-"
> +                                  version
> +                                  ".tar.xz"))
The format provided by the pretty-printer is, like, a suggestion.

> +    (build-system meson-build-system)
> +    (native-inputs (list pkg-config
You're missing arguments here.  At the very least #:glib-or-gtk? #t

> +     "Text Editor is a simple text editor that focuses on session
> management.
> +It works hard to keep track of changes and state even if you quit
> the
> +application.  You can come back to your work even if you've never
> saved it to a
> +file."
You should probably call it GNOME Text Editor.  The description is
fairly light on advertisments as far as copypasta descriptions go, so I
won't fault you for that here.

> +    (license license:gpl3)))
Should probably be gpl3+.

> +    (synopsis "Simple user-friendly terminal emulator for the GNOME
> desktop")
> +    (description
> +     "Console is supposed to be a simple terminal emulator for the
> average user
> +to carry out simple cli tasks and aims to be a ‘core’ app for
> GNOME/Phosh")
Ehhhhhh... I do want you to cut down on the ads here.

> +    (build-system meson-build-system)
> +    (native-inputs (list desktop-file-utils
Missing arguments.

> +    (home-page "https://gitlab.gnome.org/GNOME/gnome-console")
Dead link is dead.

> +    (license license:gpl3)))
Also probably gpl3+.

Cheers