GNU bug report logs - #57939
29.0.50; Fixing raise-frame on Sway

Previous Next

To reply to this bug, email your comments to 57939 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Fixing raise-frame on Sway
Date: Mon, 19 Sep 2022 09:21:27 -0700

Under Sway, with pgtk, raise-frame doesn't work.  We could make it work
by using Sway's IPC to send a request to "focus" the frame.  This can be
done without invoking any external processes, but here is a hack using
swaymsg(1) just as a demonstration:

    (defun spw/sway-raise-frame (orig-fun &optional frame)
      (unless frame (setq frame (selected-frame)))
      (if (member "XDG_CURRENT_DESKTOP=sway"
                  (frame-parameter frame 'environment))
          (call-process "swaymsg" nil nil nil
    		    (format "[title=\"%s\"]"
                            (frame-parameter frame 'name))
    		    "focus")
        (funcall orig-fun frame)))
    (advice-add 'raise-frame :around #'spw/sway-raise-frame)

On the one hand, Sway is one of the more popular Wayland compositors, so
it would be nice to support this.  On the other hand, this isn't a
generic wlroots mechanism -- it will work only for Sway.  (I suppose
it's possible that some other compositors will adopt Sway's IPC.)

Would this be an appropriate thing to add to raise-frame?  Or is it
better left as a piece of advice?  The IPC protocol is documented here:
<https://manpages.debian.org/sway-ipc>.

-- 
Sean Whitton

Message #8 received at 57939 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: 57939 <at> debbugs.gnu.org
Subject: Re: bug#57939: 29.0.50; Fixing raise-frame on Sway
Date: Tue, 20 Sep 2022 09:30:57 +0800

Sean Whitton <spwhitton <at> spwhitton.name> writes:

> Under Sway, with pgtk, raise-frame doesn't work.  We could make it work
> by using Sway's IPC to send a request to "focus" the frame.  This can be
> done without invoking any external processes, but here is a hack using
> swaymsg(1) just as a demonstration:
>
>     (defun spw/sway-raise-frame (orig-fun &optional frame)
>       (unless frame (setq frame (selected-frame)))
>       (if (member "XDG_CURRENT_DESKTOP=sway"
>                   (frame-parameter frame 'environment))
>           (call-process "swaymsg" nil nil nil
>     		    (format "[title=\"%s\"]"
>                             (frame-parameter frame 'name))
>     		    "focus")
>         (funcall orig-fun frame)))
>     (advice-add 'raise-frame :around #'spw/sway-raise-frame)

> On the one hand, Sway is one of the more popular Wayland compositors, so
> it would be nice to support this.  On the other hand, this isn't a
> generic wlroots mechanism -- it will work only for Sway.  (I suppose
> it's possible that some other compositors will adopt Sway's IPC.)

If there's anything I've learned in over 2 decades of dealing with
windowing on GNU/Linux, it's that these mechanisms tend to be yanked
from underneath our feet.  It sounds very risky to add support for that
to such a basic function in Emacs.

In addition, raise-frame is not really supposed to focus the frame.  But
I guess that's unavoidable here.

And what if there are multiple frames with the same name? What frame is
raised in that case?

So thanks, but this is not really the right thing for Emacs.

Message #11 received at 57939 <at> debbugs.gnu.org (full text, mbox):

From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Po Lu <luangruo <at> yahoo.com>, 57939 <at> debbugs.gnu.org
Subject: Re: bug#57939: 29.0.50; Fixing raise-frame on Sway
Date: Mon, 19 Sep 2022 22:32:36 -0700

Hello,

On Tue 20 Sep 2022 at 09:30AM +08, Po Lu wrote:

> If there's anything I've learned in over 2 decades of dealing with
> windowing on GNU/Linux, it's that these mechanisms tend to be yanked
> from underneath our feet.  It sounds very risky to add support for that
> to such a basic function in Emacs.

Sway is pretty committed to interface stability, but it's a valid concern.

> And what if there are multiple frames with the same name? What frame is
> raised in that case?

Yeah, we'd need to make a more precise IPC query to get some sort of
unique handle.

-- 
Sean Whitton

Message #14 received at 57939 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: 57939 <at> debbugs.gnu.org
Subject: Re: bug#57939: 29.0.50; Fixing raise-frame on Sway
Date: Tue, 20 Sep 2022 14:12:00 +0800

Sean Whitton <spwhitton <at> spwhitton.name> writes:

> Sway is pretty committed to interface stability, but it's a valid concern.

I'm not worried about whether or not Sway keeps the interface stable,
the problem is whether or not Sway will still be a thing in 2, 5, 10, or
20 years.

Not to mention that Sway is still a niche compositor, compared to the
likes of GNOME Shell or Kwin.

If we take the route of supporting non-standard interfaces provided by
all "popular" Wayland compositors at any given time, then we will
quickly fall into the rabbit hole of constantly keeping up with changes
to that status quo.

Message #17 received at 57939 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Sean Whitton <spwhitton <at> spwhitton.name>
Cc: Po Lu <luangruo <at> yahoo.com>, 57939 <at> debbugs.gnu.org
Subject: Re: bug#57939: 29.0.50; Fixing raise-frame on Sway
Date: Tue, 20 Sep 2022 12:12:44 +0200

Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text
editors" <bug-gnu-emacs <at> gnu.org> writes:

> I'm not worried about whether or not Sway keeps the interface stable,
> the problem is whether or not Sway will still be a thing in 2, 5, 10, or
> 20 years.

That is indeed a worry.

> Not to mention that Sway is still a niche compositor, compared to the
> likes of GNOME Shell or Kwin.
>
> If we take the route of supporting non-standard interfaces provided by
> all "popular" Wayland compositors at any given time, then we will
> quickly fall into the rabbit hole of constantly keeping up with changes
> to that status quo.

There's no set rules for any of this -- but we want Emacs to be as
usable as possible across as large a number of systems as possible.
This means that we have a lot of special purpose code in Emacs to work
around oddities in systems, and to interact with specific systems and
libraries.

Sway seems to be one of the major players in the Wayland world, so I'd
welcome code to make Emacs work better under Sway.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.