GNU bug report logs - #57927
[PATCH] gnu: source-highlight: Fix lesspipe file name and use gexps.

Previous Next

Full log

Message #19 received at 57927 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: kiasoc5 <kiasoc5 <at> disroot.org>, Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 57927 <at> debbugs.gnu.org
Subject: Re: [bug#57927] [PATCH] gnu: source-highlight: Fix lesspipe file name
 and use gexps.
Date: Wed, 28 Sep 2022 23:14:03 +0200

[Message part 1 (text/plain, inline)]

On 28-09-2022 06:34, kiasoc5 via Guix-patches via wrote:
>>> * gnu/packages/pretty-print.scm (source-highlight):
>>> [arguments]: Use gexps, remove trailing #ts.
>>> [phases]: Add phase to make src-highlight-lesspipe.sh work.
>> These unrelated changes should be separated into at least two
>> patches next time: one to gexp and remove the #ts, the other to
>> make the functional change.
>> < to go
>> straight to master.
> 1. Does trailing #t change the hash?

Yes.

> 2. Why might Gexpification change the hash?

When the resulting staged code changes.  This could happen if you were 
to do, say, #$(this-package-input "boost") instead of (assoc-ref 
%build-inputs "boost") for example, though AFAICT you didn't make any 
G-exp-related changes that would change the hash.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.