GNU bug report logs - #57908
[PATCH] gnu: quodlibet: Fix build.

Previous Next

Package: guix-patches;

Reported by: Remco van 't Veer <remco <at> remworks.net>

Date: Sun, 18 Sep 2022 14:22:02 UTC

Severity: normal

Tags: patch

Done: Mathieu Othacehe <othacehe <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#57908: closed ([PATCH] gnu: quodlibet: Fix build.)
Date: Fri, 30 Sep 2022 13:52:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 30 Sep 2022 15:50:51 +0200
with message-id <87bkqx6kec.fsf <at> gnu.org>
and subject line Re: bug#57908: [PATCH] gnu: quodlibet: Fix build.
has caused the debbugs.gnu.org bug report #57908,
regarding [PATCH] gnu: quodlibet: Fix build.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
57908: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57908
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Remco van 't Veer <remco <at> remworks.net>
To: guix-patches <at> gnu.org
Cc: Remco van 't Veer <remco <at> remworks.net>
Subject: [PATCH] gnu: quodlibet: Fix build.
Date: Sun, 18 Sep 2022 16:21:07 +0200
Some tests fail because adwaita-icon-theme doesn't ship legacy icons
anymore since version 42.  Application runs fine without visual defects.

* gnu/packages/music.scm (quodlibet): Skip trayicon tests.
---
 gnu/packages/music.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index 66b4beae0c..bb6ff3efbd 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -6784,7 +6784,9 @@ (define-public quodlibet
                           "--ignore=tests/test_browsers_iradio.py"
                           ;; broken upstream
                           "--disable-warnings"
-                          "--ignore=tests/quality")
+                          "--ignore=tests/quality"
+                          ;; missing legacy icons in adwaita-icon-theme
+                          "--ignore=tests/plugin/test_trayicon.py")
                   (format #t "test suite not run~%"))))
           (add-after 'install 'glib-or-gtk-wrap ; ensure icons loaded
             (assoc-ref glib-or-gtk:%standard-phases 'glib-or-gtk-wrap))

base-commit: d7e56aebec4535f3567c362b6084818873e54b0d
-- 
2.37.3



[Message part 3 (message/rfc822, inline)]
From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Remco van 't Veer <remco <at> remworks.net>
Cc: 57908-done <at> debbugs.gnu.org
Subject: Re: bug#57908: [PATCH] gnu: quodlibet: Fix build.
Date: Fri, 30 Sep 2022 15:50:51 +0200
> * gnu/packages/music.scm (quodlibet): Skip trayicon tests.

Applied, thanks!

Mathieu


This bug report was last modified 2 years and 233 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.