GNU bug report logs - #57905
[PATCH] Fix eshell directory and executable completion on action t

Previous Next

Full log

Message #22 received at 57905 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Pettersson <daniel <at> dpettersson.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Jim Porter <jporterbugs <at> gmail.com>, 57905 <at> debbugs.gnu.org
Subject: Re: bug#57905: [PATCH] Fix eshell directory and executable completion
 on action t
Date: Mon, 19 Sep 2022 22:27:39 +0200

> Please don't use 'concat' to create a file name with leading
> directories; instead, please use file-name-concat.

Ah I had know idea of the existence of that function, that definitely
seams like the better option. Thanks for spreading the word.

> Some regression tests would be nice though. I've been trying to add
> tests as I go through various parts of Eshell, but I haven't looked much
> at the "interactive" bits like em-cmpl.el yet. 'eshell-test/forward-arg'
> in test/lisp/eshell/eshell-tests.el might make for an ok basis to adapt
> into some completion tests (which could probably then go into
> .../em-cmpl-tests.el).

I will take a look :)

> Daniel, I've now pushed your patch to Emacs 29.
>
> This change was just small enough to apply without assigning copyright
> to the FSF, but for future patches you want to submit, it might make
> sense to get the paperwork started now, so that subsequent patches can
> be applied speedily. Would you be willing to sign such paperwork?

Great and sure.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.