From unknown Mon Aug 18 14:24:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57905: [PATCH] Fix eshell directory and executable completion on action t Resent-From: Daniel Pettersson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2022 07:08:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 57905@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166348485227355 (code B ref -1); Sun, 18 Sep 2022 07:08:03 +0000 Received: (at submit) by debbugs.gnu.org; 18 Sep 2022 07:07:32 +0000 Received: from localhost ([127.0.0.1]:47653 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZoOp-000772-4Q for submit@debbugs.gnu.org; Sun, 18 Sep 2022 03:07:32 -0400 Received: from lists.gnu.org ([209.51.188.17]:54136) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZgjD-0000pJ-Gk for submit@debbugs.gnu.org; Sat, 17 Sep 2022 18:56:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34764) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZgjD-0005HF-BO for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 18:56:03 -0400 Received: from mail-qt1-f175.google.com ([209.85.160.175]:40798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZgjB-0001X5-DR for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 18:56:03 -0400 Received: by mail-qt1-f175.google.com with SMTP id cj27so6255390qtb.7 for ; Sat, 17 Sep 2022 15:56:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=G3CCUqwlXtuA8qd5oJvg7sy/8/jbLGcSdqkFDXIX0cE=; b=RGagsxerzbJ7i9f7/THpkDcF4ZxwbTnTosQE8WtptKQ7NHlnu/iKspBHZfJ0klyB1I VmK+/bdLGuu9jOnVR9Ldo/eCV123Y7ioOPO+oo9k5lqeTGxXVFJ+FUWQ/JgRcHKVeUQD UaxYO3V0yqWE3BXuO3npSlJTBlRjk6XOeR9LekP5IxgAHWdecebLYIIHg9hfbKDa7knw fWuhStdXtY1DJyKL2pI/3b5Nt4s5bGlpxSulhZQm3LarLdGEpsRKaKT6bcm7Ejs4uFkL aOnwqI4N+XHrAsD9R6RnE9CCteXoDhDNVAFhoYqcPC1s5kpzm5pjI64OpiSbqye0GyDu KxBg== X-Gm-Message-State: ACrzQf25Ef0muQeqh/7K2mhLFME9euQtXl4iit5+NwNWBo1qsLQk2vLn Da7NVNNUvq1fn6eQDFAdZXtfc6R25BEYKA== X-Google-Smtp-Source: AMsMyM5CQ/Abm8nZ5dnxuGrbteeo4/TOEmJjQT+X2TI7fjEGpNXhOjLiVsoCLGgrzN0zPXQBxIHG8A== X-Received: by 2002:a05:622a:4cb:b0:35c:be68:784e with SMTP id q11-20020a05622a04cb00b0035cbe68784emr9914173qtx.331.1663455359995; Sat, 17 Sep 2022 15:55:59 -0700 (PDT) Received: from mail-yb1-f179.google.com (mail-yb1-f179.google.com. [209.85.219.179]) by smtp.gmail.com with ESMTPSA id de20-20020a05620a371400b006bb49cfe147sm8956513qkb.84.2022.09.17.15.55.59 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Sep 2022 15:55:59 -0700 (PDT) Received: by mail-yb1-f179.google.com with SMTP id g5so37578733ybg.11 for ; Sat, 17 Sep 2022 15:55:59 -0700 (PDT) X-Received: by 2002:a5b:38f:0:b0:66e:c99f:ec49 with SMTP id k15-20020a5b038f000000b0066ec99fec49mr9797015ybp.33.1663455359462; Sat, 17 Sep 2022 15:55:59 -0700 (PDT) MIME-Version: 1.0 From: Daniel Pettersson Date: Sun, 18 Sep 2022 00:55:48 +0200 X-Gmail-Original-Message-ID: Message-ID: Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=209.85.160.175; envelope-from=daniel.dpettersson.net@gmail.com; helo=mail-qt1-f175.google.com X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -0.8 (/) X-Mailman-Approved-At: Sun, 18 Sep 2022 03:07:26 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) When eshell directory/executable completion results in multiple candidates the candidates are striped of their file path. emacs -Q M-x eshell RET touch test1 test2 chmod +x test1 test2 ./test In *Completions* buffer: 2 possible completions: test1 test2 Expected: ./test1 ./test2 Same issue for directories: mkdir test_dir1 test_dir2 ./test_dir In *Completions* buffer: 2 possible completions: test1_dir1 test2_dir2 This also the case when the candidates are not in the working directory: mkdir -p 1/2/3/4 touch 1/2/3/4/test1 1/2/3/4/test2 chmod +x 1/2/3/4/test1 1/2/3/4/test2 ./1/2/3/4/test In *Completions* buffer: 2 possible completions: test1 test2 This issue is not present with one completion as further down the call stack `completion-file-name-table' is called with action t, which concates completion string directory with completion candidate. Possible solution: --- lisp/eshell/em-cmpl.el | 29 ++++++++++++++++++++++++++--- 1 file changed, 26 insertions(+), 3 deletions(-) diff --git a/lisp/eshell/em-cmpl.el b/lisp/eshell/em-cmpl.el index 822cc94149..d9261fae27 100644 --- a/lisp/eshell/em-cmpl.el +++ b/lisp/eshell/em-cmpl.el @@ -378,6 +378,31 @@ eshell-complete-parse-arguments args) posns))) +(defun eshell--pcomplete-executables () + "Complete amongs a list of directories and executables. + +Wrapper for `pcomplete-executables' or `pcomplete-dirs-or-entries', +depending on the value of `eshell-force-execution'. + +Adds path prefix to candidates independent of `action' value." + ;; `pcomplete-entries' returns filenames without path on `action' t + ;; use current string directory as done in `completion-file-name-table' + ;; when `action' is nil to construct executable candidates. + (let* ((table (if eshell-force-execution + (pcomplete-dirs-or-entries nil #'file-readable-p) + (pcomplete-executables)))) + (lambda (string pred action) + (let ((cands (funcall table string pred action))) + (if (eq action t) + (let ((specdir (file-name-directory string))) + (mapcar + (lambda (cand) + (if (stringp cand) + (concat specdir cand) + cand)) + cands)) + cands))))) + (defun eshell--complete-commands-list () "Generate list of applicable, visible commands." ;; Building the commands list can take quite a while, especially over Tramp @@ -392,9 +417,7 @@ eshell--complete-commands-list (completion-table-dynamic (lambda (filename) (if (file-name-directory filename) - (if eshell-force-execution - (pcomplete-dirs-or-entries nil #'file-readable-p) - (pcomplete-executables)) + (eshell--pcomplete-executables) (let* ((paths (eshell-get-path)) (cwd (file-name-as-directory (expand-file-name default-directory))) -- 2.30.1 (Apple Git-130) Issue on 28.2.0 as well. In GNU Emacs 29.0.50 (build 1, aarch64-apple-darwin20.6.0, NS appkit-2022.60 Version 11.5.2 (Build 20G95)) of 2022-09-16 built on Daniels-Air Repository revision: fe7c015b20b5bca07aa178d28b9fd5cc66ad16f9 Repository branch: master Windowing system distributor 'Apple', version 10.3.2022 System Description: macOS 11.5.2 Configured features: ACL DBUS GLIB GNUTLS JSON LCMS2 LIBXML2 MODULES NOTIFY KQUEUE NS PDUMPER PNG RSVG SQLITE3 THREADS TOOLKIT_SCROLL_BARS WEBP XIM ZLIB Important settings: value of $LC_CTYPE: UTF-8 locale-coding-system: utf-8-unix Major mode: Eshell Minor modes in effect: shell-dirtrack-mode: t eshell-prompt-mode: t eshell-hist-mode: t eshell-pred-mode: t eshell-cmpl-mode: t eshell-proc-mode: t eshell-arg-mode: t tooltip-mode: t global-eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message mailcap yank-media puny dired dired-loaddefs rfc822 mml mml-sec password-cache epa derived epg rfc6068 epg-config gnus-util text-property-search mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils pcmpl-unix cl-seq cl-macs vc-git diff-mode easy-mmode vc-dispatcher bug-reference byte-opt gv bytecomp byte-compile cconv time-date em-unix em-term term disp-table shell subr-x ehelp em-script em-prompt em-ls em-hist em-pred em-glob em-extpipe em-cmpl em-dirs esh-var pcomplete comint ansi-color ring em-basic em-banner em-alias esh-mode eshell esh-cmd generator cl-loaddefs cl-lib esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/ns-win ns-win ucs-normalize mule-util term/common-win tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind kqueue cocoa ns lcms2 multi-tty make-network-process emacs) Memory information: ((conses 16 71482 9836) (symbols 48 8490 0) (strings 32 24424 2081) (string-bytes 1 760661) (vectors 16 16661) (vector-slots 8 215237 12871) (floats 8 32 63) (intervals 56 573 57) (buffers 1000 13)) From unknown Mon Aug 18 14:24:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57905: [PATCH] Fix eshell directory and executable completion on action t Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2022 07:41:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Pettersson Cc: 57905@debbugs.gnu.org Received: via spool by 57905-submit@debbugs.gnu.org id=B57905.166348684730571 (code B ref 57905); Sun, 18 Sep 2022 07:41:01 +0000 Received: (at 57905) by debbugs.gnu.org; 18 Sep 2022 07:40:47 +0000 Received: from localhost ([127.0.0.1]:47704 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZov0-0007x1-Nh for submit@debbugs.gnu.org; Sun, 18 Sep 2022 03:40:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZouy-0007wo-RA for 57905@debbugs.gnu.org; Sun, 18 Sep 2022 03:40:45 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57034) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZout-0005Pq-Gd; Sun, 18 Sep 2022 03:40:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=UY/JQxWi9bcuMINaXZIsJdynfTGKvjT2YtdOShjlJMU=; b=Zjy0DijnWVfG COl7R+WhhuR1W+OgV3dzeRTmWmdRscMcVn52O01C9lPrkFZIo0CC8zynjkXqZtVp3j/YzMTWPEPAS nVyJvDoKTaoppHHD921gbG22ON86GffEq7aiK37gBNPT7zixK/BP2pNv3nXvwM8RY1J2ZnDffgxMP eLJUXQXVGjE0xDbMNYJjSK+77l1btB1jy6xOq8DJpJAg3C1BJYnBty0CaTwqTq21oD5UXmUE9FcWi +jguzeixsVzSxfvjhAEsop1LqQ0j1N8+4RORZK4Zd5MgS6qMhXtzy6PlgB3cJBD6vuonjOd/vrhNd qoS8o9U00c3zOAvDfRICWQ==; Received: from [87.69.77.57] (port=2741 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZoup-000231-8p; Sun, 18 Sep 2022 03:40:39 -0400 Date: Sun, 18 Sep 2022 10:40:36 +0300 Message-Id: <83fsgpyvt7.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Daniel Pettersson on Sun, 18 Sep 2022 00:55:48 +0200) References: X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Daniel Pettersson > Date: Sun, 18 Sep 2022 00:55:48 +0200 > > +(defun eshell--pcomplete-executables () > + "Complete amongs a list of directories and executables. > + > +Wrapper for `pcomplete-executables' or `pcomplete-dirs-or-entries', > +depending on the value of `eshell-force-execution'. > + > +Adds path prefix to candidates independent of `action' value." > + ;; `pcomplete-entries' returns filenames without path on `action' t > + ;; use current string directory as done in `completion-file-name-table' > + ;; when `action' is nil to construct executable candidates. > + (let* ((table (if eshell-force-execution > + (pcomplete-dirs-or-entries nil #'file-readable-p) > + (pcomplete-executables)))) > + (lambda (string pred action) > + (let ((cands (funcall table string pred action))) > + (if (eq action t) > + (let ((specdir (file-name-directory string))) > + (mapcar > + (lambda (cand) > + (if (stringp cand) > + (concat specdir cand) > + cand)) > + cands)) > + cands))))) Please don't use 'concat' to create a file name with leading directories; instead, please use file-name-concat. From unknown Mon Aug 18 14:24:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57905: [PATCH] Fix eshell directory and executable completion on action t Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2022 10:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Pettersson Cc: Jim Porter , 57905@debbugs.gnu.org Received: via spool by 57905-submit@debbugs.gnu.org id=B57905.166349771717890 (code B ref 57905); Sun, 18 Sep 2022 10:42:02 +0000 Received: (at 57905) by debbugs.gnu.org; 18 Sep 2022 10:41:57 +0000 Received: from localhost ([127.0.0.1]:47900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZrkK-0004eT-W3 for submit@debbugs.gnu.org; Sun, 18 Sep 2022 06:41:57 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZrkJ-0004eD-2p for 57905@debbugs.gnu.org; Sun, 18 Sep 2022 06:41:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ouoXsIzKvV+2r2YbepDkBq0/246uZuv0rmIysVdYMlY=; b=brX1rXEZnzGr7bUM6q1ZUj/3JJ m2G6en29mPLhMCDpdXdC/ca5PKP4W6KuDqeQdDp5IhTgif8XlIPLjbPMhqvwHyHnLJSEUFf4wTdqM 34fIdBft5O6TTPxJOCkcwdmlRxuZmfaRfz4uRI+jPCi5Gii4mYOnHn2VuFARyJiHnNxo=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZrkA-0006pg-D3; Sun, 18 Sep 2022 12:41:48 +0200 From: Lars Ingebrigtsen In-Reply-To: (Daniel Pettersson's message of "Sun, 18 Sep 2022 00:55:48 +0200") References: X-Now-Playing: Stephan Mathieu's _Radiance (12): Pacific_: "Pacific" Date: Sun, 18 Sep 2022 12:41:45 +0200 Message-ID: <87a66x55hy.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Daniel Pettersson writes: > This issue is not present with one completion as further down the call > stack `completion-file-name-table' is called with action t, which concates > completion string directory with completion cand [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Daniel Pettersson writes: > This issue is not present with one completion as further down the call > stack `completion-file-name-table' is called with action t, which concates > completion string directory with completion candidate. > > Possible solution: Hm... I'm not that familiar with how this works in eshell myself; perhaps Jim has some comments -- added to the CCs. From unknown Mon Aug 18 14:24:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57905: [PATCH] Fix eshell directory and executable completion on action t Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 00:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen , Daniel Pettersson Cc: 57905@debbugs.gnu.org Received: via spool by 57905-submit@debbugs.gnu.org id=B57905.16635474747333 (code B ref 57905); Mon, 19 Sep 2022 00:32:02 +0000 Received: (at 57905) by debbugs.gnu.org; 19 Sep 2022 00:31:14 +0000 Received: from localhost ([127.0.0.1]:51535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oa4gs-0001uD-7T for submit@debbugs.gnu.org; Sun, 18 Sep 2022 20:31:14 -0400 Received: from mail-pl1-f182.google.com ([209.85.214.182]:42850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oa4gn-0001tx-WD for 57905@debbugs.gnu.org; Sun, 18 Sep 2022 20:31:12 -0400 Received: by mail-pl1-f182.google.com with SMTP id v1so26466733plo.9 for <57905@debbugs.gnu.org>; Sun, 18 Sep 2022 17:31:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:from:to:cc:subject :date; bh=oV0R6WSFFHJeITFX536/LTCxFW+VG4eMpCgdfZaHQhg=; b=HswhrXIIImSxRM1jvLv5bdHGP2zzIhK4tZOZgo/1eyTSJQufspb9bfwuIyY+MmZOV0 IIyUPNX5oGPPgFTSjADqtHf/5xPOxU35s8w2DgaafXemZqh9dtI/4Ryl+bEtJ2RfkGYA AUlYFSbJo5nb/PTscoNH3Hs2b6ELFgEpoFnR2K6BgCbWxn5NOf7LwnMTRd11h7S1wYqn q9n02ZRBJikajK27DSuBi4Nx0TNjUwkbQ4nBL+Hg5O9z/wQhMmnHG0883KRYLVvaZmuM VxQztwrDBWLPfKZ/3OZxBvdedNHK7/HD4PyJRoI3ZDLZ+XzhT5cA+ZsaL5iCuAmqmfzw eOcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:content-language:in-reply-to:mime-version :date:message-id:from:references:cc:to:subject:x-gm-message-state :from:to:cc:subject:date; bh=oV0R6WSFFHJeITFX536/LTCxFW+VG4eMpCgdfZaHQhg=; b=nKkF7qtpDLo83CpkOcSS425VimO6bYpQE/8eV81j26w9vPSglhMfXfc9vMTKooonuG V36m0/eYQ2j3wudrPgDMstvzIo+VKlPjiRt7biLElb2AF5eDeybpa+eHu++ldDoYXqt0 WhoJM0SfSxZ1FDVHuzDf6tsE+g57Ns/RRlyxLG/C1G3zLl7lhrN17FLGViVUHFYCB9De uQh32Hwzj6KDZ4mlORrAw+mxTKoQnfDAvPsxwIY7x4z4w/QORBIy2Dyw3pdoszIZaCxf Hz1KnvQULBZTkfBsLWSM3cNrUkj8EgvgQyMC4waewBtypixm44g5Ac1bT8mdCLgKbor6 NoOA== X-Gm-Message-State: ACrzQf22/fmeMy9T5lbxvY5FeoNI2QXUUm8K6SoILB8iE+rTDA54Ebnj 6wh4Is/W+y7B8syarQifGTSkvEgVGIA= X-Google-Smtp-Source: AMsMyM78l4MRLKYqjnSC32WMcgvbqDowx5CjqtveJPVl5hfnlx9DNzGaHbMMQ30xqjMf77Tk6FL5vA== X-Received: by 2002:a17:903:41c9:b0:176:b9df:c743 with SMTP id u9-20020a17090341c900b00176b9dfc743mr10643289ple.162.1663547462909; Sun, 18 Sep 2022 17:31:02 -0700 (PDT) Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id u21-20020a632355000000b0041c30def5e8sm12583396pgm.33.2022.09.18.17.31.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 18 Sep 2022 17:31:02 -0700 (PDT) References: <87a66x55hy.fsf@gnus.org> From: Jim Porter Message-ID: Date: Sun, 18 Sep 2022 17:31:01 -0700 MIME-Version: 1.0 In-Reply-To: <87a66x55hy.fsf@gnus.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On 9/18/2022 3:41 AM, Lars Ingebrigtsen wrote: > Daniel Pettersson writes: > >> This issue is not present with one completion as further down the call >> stack `completion-file-name-table' is called with action t, which concates >> completion string directory with completion candidate. >> >> Possible solution: > > Hm... I'm not that familiar with how this works in eshell myself; > perhaps Jim has some comments -- added to the CCs. With the caveats that I don't know much about pcomplete (maybe someone who does would have something interesting to say about this patch?) and that I haven't built Emacs with the patch, I think the logic here makes sense. Some regression tests would be nice though. I've been trying to add tests as I go through various parts of Eshell, but I haven't looked much at the "interactive" bits like em-cmpl.el yet. 'eshell-test/forward-arg' in test/lisp/eshell/eshell-tests.el might make for an ok basis to adapt into some completion tests (which could probably then go into .../em-cmpl-tests.el). That said, I wouldn't object to merging this without regression tests; it doesn't seem fair to me to expect patch authors to write tests when the component they're patching doesn't have tests in the first place. :) From unknown Mon Aug 18 14:24:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57905: [PATCH] Fix eshell directory and executable completion on action t Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 08:23:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Jim Porter Cc: 57905@debbugs.gnu.org, Daniel Pettersson Received: via spool by 57905-submit@debbugs.gnu.org id=B57905.166357576531951 (code B ref 57905); Mon, 19 Sep 2022 08:23:02 +0000 Received: (at 57905) by debbugs.gnu.org; 19 Sep 2022 08:22:45 +0000 Received: from localhost ([127.0.0.1]:52282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaC3B-0008JG-BV for submit@debbugs.gnu.org; Mon, 19 Sep 2022 04:22:45 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaC39-0008J1-Gl for 57905@debbugs.gnu.org; Mon, 19 Sep 2022 04:22:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=8o6ptAm39kRwAf8vtT5CKKoC7nnNXuUf2hzppR/anHA=; b=aQ3vlbGjXcmFGgTwaJp1HDVh3p 4z0oleI5JdoQtGKGGEZucOIu6r0DZU7Gsk/mrjOI4IL7WittuTZu5GAN0WXsypfc69Fyp2hH75Am/ RhQ0kKTyHoQRtgvyyA+BMiX2iJmmsklIlJIKaBWGxKZ3Cajyp6aJ8xaq6/uMe//S/1g4=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaC31-0007Ap-3z; Mon, 19 Sep 2022 10:22:37 +0200 From: Lars Ingebrigtsen In-Reply-To: (Jim Porter's message of "Sun, 18 Sep 2022 17:31:01 -0700") References: <87a66x55hy.fsf@gnus.org> X-Now-Playing: 13 & God's _Own Your Ghost_: "Death Major" Date: Mon, 19 Sep 2022 10:22:34 +0200 Message-ID: <87v8pjwz79.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Jim Porter writes: > That said, I wouldn't object to merging this without regression tests; > it doesn't seem fair to me to expect patch authors to write tests when > the component they're patching doesn't have tests in [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Jim Porter writes: > That said, I wouldn't object to merging this without regression tests; > it doesn't seem fair to me to expect patch authors to write tests when > the component they're patching doesn't have tests in the first > place. :) Thanks. Daniel, I've now pushed your patch to Emacs 29. This change was just small enough to apply without assigning copyright to the FSF, but for future patches you want to submit, it might make sense to get the paperwork started now, so that subsequent patches can be applied speedily. Would you be willing to sign such paperwork? From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 19 04:22:51 2022 Received: (at control) by debbugs.gnu.org; 19 Sep 2022 08:22:51 +0000 Received: from localhost ([127.0.0.1]:52285 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaC3G-0008JZ-Mu for submit@debbugs.gnu.org; Mon, 19 Sep 2022 04:22:50 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaC3E-0008J9-JQ for control@debbugs.gnu.org; Mon, 19 Sep 2022 04:22:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GFGdrLZqXonfD8s8ARhuZh4eR1WmyIUcGub3EV+hgUE=; b=TOgcT0dM6BlamlhYVhUKanFQKX 2AcJg4wjMaDasEIydj6qTN3bEnBnqFAZ49OZ/+HdQcmZE/GbugP8COZF09+niSLgLb2CPhZ8sTkSa wVusj2maY1RraiiihCo1NGogSpEwS3FfZ8lk/DgeqzBqxCAsjPg0mVnoD2fZlNUebFdc=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaC36-0007Aw-Ms for control@debbugs.gnu.org; Mon, 19 Sep 2022 10:22:42 +0200 Date: Mon, 19 Sep 2022 10:22:40 +0200 Message-Id: <87tu53wz73.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #57905 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 57905 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 57905 29.1 quit From unknown Mon Aug 18 14:24:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57905: [PATCH] Fix eshell directory and executable completion on action t Resent-From: Daniel Pettersson Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 20:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: Jim Porter , 57905@debbugs.gnu.org Received: via spool by 57905-submit@debbugs.gnu.org id=B57905.166361927815670 (code B ref 57905); Mon, 19 Sep 2022 20:28:01 +0000 Received: (at 57905) by debbugs.gnu.org; 19 Sep 2022 20:27:58 +0000 Received: from localhost ([127.0.0.1]:55389 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaNMz-00044g-PH for submit@debbugs.gnu.org; Mon, 19 Sep 2022 16:27:58 -0400 Received: from mail-qt1-f170.google.com ([209.85.160.170]:41893) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaNMy-00044U-2x for 57905@debbugs.gnu.org; Mon, 19 Sep 2022 16:27:56 -0400 Received: by mail-qt1-f170.google.com with SMTP id c11so375000qtw.8 for <57905@debbugs.gnu.org>; Mon, 19 Sep 2022 13:27:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=FvJloCXMOjVc9ZmFeVDgwrFBw3wDvd9/mN8asoeKHis=; b=AQDe5PVDzTO+ylPVAqlKqj4QbjkgYEhBe8Z1UzHk06xQ/UW5Chp+8ke8FEmLLjlHN8 UPoPspMMhd4rzNvX14aG1rYYUpTqYVwxkNHOYHIt9NwJqIGoQ1RD12L60/kaLwCba/Sz GT62JMg0xmEAF762XwjNDZ5sSLq452GHYZFvy/pTviULdHJWbW26HLjgGrYyeB9kp3Ze Ffk9/nBr2yjbJRGDHPv91wZUZ3EGBkzpl0DRhmLpUxSIcXXOB5vQsk6t8jYX15EpyICn zpl5PedLQUL0D3REsxk/L1JbhUW73mwilw4AFLbBVUKTrrKjh0k2cKocpBC4Ul4Fd5Qn 7Ubg== X-Gm-Message-State: ACrzQf12ZFJ2a+VIg0keoGallQeV/IOO1xR7uXgIill16vuKwmuD4aWX eI61Q5LH1C6L8/kRijC3CzV6y6K/+xz5Nw== X-Google-Smtp-Source: AMsMyM7gSyR9HgzSML65uaJY9X9/wQ8nksrLuWVgR+yenZfDJ1YQfjQzlD3Mqv1fTtrqLbBfNA0EzQ== X-Received: by 2002:a05:622a:3cd:b0:344:9749:8228 with SMTP id k13-20020a05622a03cd00b0034497498228mr16713615qtx.512.1663619270564; Mon, 19 Sep 2022 13:27:50 -0700 (PDT) Received: from mail-yb1-f174.google.com (mail-yb1-f174.google.com. [209.85.219.174]) by smtp.gmail.com with ESMTPSA id d1-20020a05620a240100b006cf14cc6740sm2872737qkn.70.2022.09.19.13.27.50 for <57905@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Sep 2022 13:27:50 -0700 (PDT) Received: by mail-yb1-f174.google.com with SMTP id c9so471725ybf.5 for <57905@debbugs.gnu.org>; Mon, 19 Sep 2022 13:27:50 -0700 (PDT) X-Received: by 2002:a25:4985:0:b0:6b3:b7ca:6764 with SMTP id w127-20020a254985000000b006b3b7ca6764mr9190194yba.174.1663619270029; Mon, 19 Sep 2022 13:27:50 -0700 (PDT) MIME-Version: 1.0 References: <87a66x55hy.fsf@gnus.org> <87v8pjwz79.fsf@gnus.org> In-Reply-To: <87v8pjwz79.fsf@gnus.org> From: Daniel Pettersson Date: Mon, 19 Sep 2022 22:27:39 +0200 X-Gmail-Original-Message-ID: Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) > Please don't use 'concat' to create a file name with leading > directories; instead, please use file-name-concat. Ah I had know idea of the existence of that function, that definitely seams like the better option. Thanks for spreading the word. > Some regression tests would be nice though. I've been trying to add > tests as I go through various parts of Eshell, but I haven't looked much > at the "interactive" bits like em-cmpl.el yet. 'eshell-test/forward-arg' > in test/lisp/eshell/eshell-tests.el might make for an ok basis to adapt > into some completion tests (which could probably then go into > .../em-cmpl-tests.el). I will take a look :) > Daniel, I've now pushed your patch to Emacs 29. > > This change was just small enough to apply without assigning copyright > to the FSF, but for future patches you want to submit, it might make > sense to get the paperwork started now, so that subsequent patches can > be applied speedily. Would you be willing to sign such paperwork? Great and sure. From unknown Mon Aug 18 14:24:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57905: [PATCH] Fix eshell directory and executable completion on action t Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 20:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57905 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Daniel Pettersson Cc: Jim Porter , 57905@debbugs.gnu.org Received: via spool by 57905-submit@debbugs.gnu.org id=B57905.166361972725063 (code B ref 57905); Mon, 19 Sep 2022 20:36:02 +0000 Received: (at 57905) by debbugs.gnu.org; 19 Sep 2022 20:35:27 +0000 Received: from localhost ([127.0.0.1]:55420 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaNUF-0006WB-CC for submit@debbugs.gnu.org; Mon, 19 Sep 2022 16:35:27 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38066) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaNUD-0006Vw-Dm for 57905@debbugs.gnu.org; Mon, 19 Sep 2022 16:35:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=o4NWiEazXs2WqEqOmZS30ysfO2UUPwvqU/AN3SXHAQw=; b=m5GgswWB6uSPynH+WF8TMMHdFd MLWoIenlQEDcZIoS5W+P9xhxU134Ih0FTwcnCGrDHCF6zKpIGwBT9OAOXpFams8BmAR9rvxyK8Cv5 Rp5jjW3pRiBKGxfL3gDYBWpIVP/jry0RaL30vGcmLMO1dMtmT1Q04MoG9rgm2VGlXpMs=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaNU5-0003pO-1c; Mon, 19 Sep 2022 22:35:19 +0200 From: Lars Ingebrigtsen In-Reply-To: (Daniel Pettersson's message of "Mon, 19 Sep 2022 22:27:39 +0200") References: <87a66x55hy.fsf@gnus.org> <87v8pjwz79.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJFBMVEUgHRwsKypra2te X18MDAxTVFSbm5vT09P5+flBPz9/f3////8dA4mvAAAAAWJLR0QLH9fEwAAAAAd0SU1FB+YJExMt Iqhfzh0AAAGmSURBVDjLrdPNTsJAEADgGop6RETlaAhqjyT+hGOL03JVg8IRCZZeNQh7FNF23sAX 8EGd2Z92Eb0xIWF3P6azO10cx46tivqunrcc3/kjquc3DshwHLBh34BrWIWbA9xN5vPRDegH5xBM EDP6POpUA36Co4rr7Cc49NUDNPSzYzn1z7KeDR0cqimlvqtBSYL3CSZCHBdwjbUc4EillC4J6oti HQLs5SAuLIDB1EAnpUGsVr/GEKWmxu4bDdCVDWmPwZcVOcPjfQiCCJH35H1rEDUDQkJ9qiEDDdCV EPEmywSpDS816PBJQoJPGyglTDUsCkjjRg+CbAV4B90P2cgVaHBG2FoHK/6FwBRf/oJ8V6m9WqED LjXQI6OpgbkL3YUG0dOtpogy3SsGbrVoKvDo10lTA6fWVUqEfHBXQ0jpgXihaUm80vHlLhkgoV5v YxZPMCX1pjnscJ8P6S3NqGH6LkkIkMsFB7e80laXTwIMijNG6lppCMSz6ROXL4BKP6lpwuUtgD7O LvcOroT5F+QAD8iRmvUCoHwaxycurMPvl7JBuN8k/AAQOjHslB0+sgAAACV0RVh0ZGF0ZTpjcmVh dGUAMjAyMi0wOS0xOVQxOTo0NTozNCswMDowMJD4h5oAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjIt MDktMTlUMTk6NDU6MzQrMDA6MDDhpT8mAAAAAElFTkSuQmCC X-Now-Playing: Vex'd's _#savefabric (11) (Mixed by Second Storey)_: "Gravity (2004)" Date: Mon, 19 Sep 2022 22:35:16 +0200 Message-ID: <8735cnnlvf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Daniel Pettersson writes: >> Daniel, I've now pushed your patch to Emacs 29. >> >> This change was just small enough to apply without assigning copyright >> to the FSF, but for future patches you want to submit, it might make [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Daniel Pettersson writes: >> Daniel, I've now pushed your patch to Emacs 29. >> >> This change was just small enough to apply without assigning copyright >> to the FSF, but for future patches you want to submit, it might make >> sense to get the paperwork started now, so that subsequent patches can >> be applied speedily. Would you be willing to sign such paperwork? > > Great and sure. Great; here's the form to get started: Please email the following information to assign@gnu.org, and we will send you the assignment form for your past and future changes. Please use your full legal name (in ASCII characters) as the subject line of the message. ---------------------------------------------------------------------- REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES [What is the name of the program or package you're contributing to?] Emacs [Did you copy any files or text written by someone else in these changes? Even if that material is free software, we need to know about it.] [Do you have an employer who might have a basis to claim to own your changes? Do you attend a school which might make such a claim?] [For the copyright registration, what country are you a citizen of?] [What year were you born?] [Please write your email address here.] [Please write your postal address here.] [Which files have you changed so far, and which new files have you written so far?]