From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 17 04:23:09 2022 Received: (at submit) by debbugs.gnu.org; 17 Sep 2022 08:23:09 +0000 Received: from localhost ([127.0.0.1]:45151 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZT6T-0000zf-8I for submit@debbugs.gnu.org; Sat, 17 Sep 2022 04:23:09 -0400 Received: from lists.gnu.org ([209.51.188.17]:56038) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZT6Q-0000zW-Tn for submit@debbugs.gnu.org; Sat, 17 Sep 2022 04:23:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38050) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZT6Q-0005XR-PP for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 04:23:06 -0400 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:42538) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZT6P-0004Am-7p for bug-gnu-emacs@gnu.org; Sat, 17 Sep 2022 04:23:06 -0400 Received: by mail-ej1-x62e.google.com with SMTP id sb3so24487911ejb.9 for ; Sat, 17 Sep 2022 01:23:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date; bh=MmV477K8YceYzex9482ao9p8KW/qXxWwuUTAkoaS3ZM=; b=qNh2IZuoRcVHSyeCr+I17pUXYj7wtOaJ866F+2h1wHMwSK0e7AYuZSM6Y+Kwn6ZfwJ NG81u2nQhGo8uJKzQ9eIPPW1OY4VPUMONMpMn3iw2CPPhpScF6gNuGdeAnw6Y8fGR66C LVqw8es5v9mto5KhAVYjtngGpkwCOH4TOUwd1aiY98mxSzZD/O2bihBtWs++RN8jL8TS eK5MlGuSIA8fXW0r/K0W0K44g8dNc+dR/hQrOmbYc0Z/FgIAC+vThZWEoIjDa3LskOtg 6emfi9R+JoQkjxAtAPCsPxLi8W0wERBXSo+lYFN8T/Guh8k9n271wVMfEP0uDc1v8NAp dlfA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=MmV477K8YceYzex9482ao9p8KW/qXxWwuUTAkoaS3ZM=; b=d8ZO0yVRh69umKIqFd5klScmGtSXk4Mwahiprf9NAuRksDN8sUO4Q76hdnIrRNKtHY 927owMA1oaEYE1d1Tm2VyPlTWdvHts1H4lRTLX8CbQ00HT7ikUWRMS6Db/vkAVKvfzZp d6Uizb7RMaywc3e0z4R6pUObiyLDatIqMSlVlgTjFNWuKYAU7Ga/+TMMg7OocvdYw/pz kEC1i79sqn+RERSWX7GggDTUJsQDHq7NQlHx/Q5KjB9I2bRz8QvMIDwxLL35mOeeO9eu HnOz74Ow50aA7AaPlDJKWv5qt7MliYg6ZxVx1V6BjnJ7moyOfI1HKrD8w1gPEcBiH3d5 3vIA== X-Gm-Message-State: ACrzQf1M/y1HT2AtzGbeqXuLkDW5WnAwJ9+QkpETLMm69pDzxh1mK+Mw t9HRk7gnvCkDCkTGcNaRzNbEHNSMTA0= X-Google-Smtp-Source: AMsMyM6K+oNmPRZLADGxJgy3yFXpnDLvo5DBvwMzlcG9ECrEEtGH/x6PNJQe9sKgGhuTvNcyrvOmqA== X-Received: by 2002:a17:907:7d9e:b0:771:db66:7b7c with SMTP id oz30-20020a1709077d9e00b00771db667b7cmr6005108ejc.393.1663402983271; Sat, 17 Sep 2022 01:23:03 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::8510]) by smtp.gmail.com with ESMTPSA id t11-20020a056402020b00b00452e7ae2214sm5871519edv.42.2022.09.17.01.23.01 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Sep 2022 01:23:02 -0700 (PDT) From: Augusto Stoffel To: bug-gnu-emacs@gnu.org Subject: [PATCH] pulse-momentary-highlight-one-line: Act on visual line X-Debbugs-CC: Protesilaos Stavrou Date: Sat, 17 Sep 2022 10:23:01 +0200 Message-ID: <87illme7fe.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Tags: patch Currently, if point is say at the prompt of a comint buffer, pulse-momentary-highlight-one-line doesn't show do anything =E2=80=93 or, m= ore precisely, it pulses the zero-length region from prompt end to EOB. Prot: I think you want to apply a similar change in pulsar.el. --=-=-= Content-Type: text/patch Content-Disposition: attachment; filename=0001-pulse-momentary-highlight-one-line-Act-on-visual-lin.patch >From e1241510fc9e0deddc5adb416aec5de4ca0300c8 Mon Sep 17 00:00:00 2001 From: Augusto Stoffel Date: Sat, 17 Sep 2022 10:17:34 +0200 Subject: [PATCH] pulse-momentary-highlight-one-line: Act on visual line * lisp/cedet/pulse.el (pulse-momentary-highlight-one-line): Act on entire visual line, ignoring fields etc. --- lisp/cedet/pulse.el | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el index 9941f2a0cb..0564cf6d04 100644 --- a/lisp/cedet/pulse.el +++ b/lisp/cedet/pulse.el @@ -202,12 +202,8 @@ pulse-momentary-highlight-one-line Optional argument FACE specifies the face to do the highlighting." (save-excursion (goto-char (or point (point))) - (let ((start (line-beginning-position)) - (end (save-excursion - (end-of-line) - (when (not (eobp)) - (forward-char 1)) - (point)))) + (let ((start (progn (vertical-motion 0) (point))) + (end (progn (vertical-motion 1) (point)))) (pulse-momentary-highlight-region start end face)))) ;;;###autoload -- 2.37.3 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 17 05:38:26 2022 Received: (at 57876) by debbugs.gnu.org; 17 Sep 2022 09:38:26 +0000 Received: from localhost ([127.0.0.1]:45195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZUHK-0002sO-Fb for submit@debbugs.gnu.org; Sat, 17 Sep 2022 05:38:26 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZUHH-0002sB-TG for 57876@debbugs.gnu.org; Sat, 17 Sep 2022 05:38:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51444) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZUHC-00072Y-7m; Sat, 17 Sep 2022 05:38:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=L7RLB5uQ7fUxdN8IMxGiIhRglSc0ijpWLo4o7lbSIKQ=; b=pTr94EFKEsTQ1FjeyVch 8jLfLeLSCE+yD1aoVN4JACBQ6dxt5UWW6hY50krRLaHaNdf0bB+vnlUipDhxGUfQQFt8PKwA33qZH jjGp1gpQMHBWkJjG+O+2+Dr586OwDD8GpgiIjOFeh1XdSrDsHlOU/E0R7aGTg4kq42o4pWHDCClnz ys1UjtMUQQVOIKvpWSwvbg/B9UwOXqanJu+/Wtz8e1qvNAGjXFcl3xJxhsuMYUIWeaaBaHLMLBUpj +ZhvYCbB/7QuOz3z4wyJ+fwGAosOJMfF9eDDhSRoxgBlXcNWM7GdDXdxLL1NRDvxePhAtOJxzsxU+ jioYpvGsAPU9RQ==; Received: from [87.69.77.57] (port=4830 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZUHA-0003Xl-Be; Sat, 17 Sep 2022 05:38:17 -0400 Date: Sat, 17 Sep 2022 12:38:15 +0300 Message-Id: <83sfkq1gu0.fsf@gnu.org> From: Eli Zaretskii To: Augusto Stoffel In-Reply-To: <87illme7fe.fsf@gmail.com> (message from Augusto Stoffel on Sat, 17 Sep 2022 10:23:01 +0200) Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line References: <87illme7fe.fsf@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57876 Cc: public@protesilaos.com, 57876@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Protesilaos Stavrou > From: Augusto Stoffel > Date: Sat, 17 Sep 2022 10:23:01 +0200 > > Tags: patch > > Currently, if point is say at the prompt of a comint buffer, > pulse-momentary-highlight-one-line doesn't show do anything – or, more > precisely, it pulses the zero-length region from prompt end to EOB. > > Prot: I think you want to apply a similar change in pulsar.el. > > > >From e1241510fc9e0deddc5adb416aec5de4ca0300c8 Mon Sep 17 00:00:00 2001 > From: Augusto Stoffel > Date: Sat, 17 Sep 2022 10:17:34 +0200 > Subject: [PATCH] pulse-momentary-highlight-one-line: Act on visual line > > * lisp/cedet/pulse.el (pulse-momentary-highlight-one-line): Act on > entire visual line, ignoring fields etc. Why don't you use beginning/end-of-visual-line? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 17 06:56:56 2022 Received: (at 57876) by debbugs.gnu.org; 17 Sep 2022 10:56:56 +0000 Received: from localhost ([127.0.0.1]:45239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZVVI-00056B-6p for submit@debbugs.gnu.org; Sat, 17 Sep 2022 06:56:56 -0400 Received: from mail-ej1-f45.google.com ([209.85.218.45]:34340) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZVVE-00055u-1H for 57876@debbugs.gnu.org; Sat, 17 Sep 2022 06:56:55 -0400 Received: by mail-ej1-f45.google.com with SMTP id y3so54678950ejc.1 for <57876@debbugs.gnu.org>; Sat, 17 Sep 2022 03:56:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=YL47q2py8LXttNH32VvK6w1tAvGPVceRM0FVDOAHGvs=; b=V9IsxTzrSb0CcUQ4YpEDDYVb6w9jfPG6ZueyUu/u3OBE4kvfPtQhhaaGm+M1FSaECH pYZJtQhgJIBggJQNNfg7kD9YrFTkbb89YIOTpXZBVOyZtoJ5U/UX6gHYl6wY7FnnvkrR DarDzTZE4ADA9HZm3YfuBJe63kc1wVWlqtVk0Cl3lA7sY/+PDiRO4LpPDsSdp3GLCyvJ NYl6wmhkQw6avecroyolhwVehnqO3rpRm61iq/dzJXqm65Qawd/ARHXPKqW02X3KWO+G NDLCFP2N1od6ab+nyHPCclD4Dd3ynUKeEQ5W5uLButL7Db+LWQ26X+k6tufws/NgQQLp td9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=YL47q2py8LXttNH32VvK6w1tAvGPVceRM0FVDOAHGvs=; b=LS4cF4b2bLOMNhbylgtzxzICLWls2wTeQi89ylRYIMrpPEzI0lEnO0Aw+mOrg0QZ6I nvbNJAHe80SKTxc/xpGmXhVhisWcm0i5v7uadNZpRw6qkU3m4TkSOX+05opqZL4uHa3q iiVl+rFhU22wn4swmLm2Zjw0ph5jehljBOGRB/Tlku43zFTWOO8bI/na0XhIovSOt3yY y5PWxUV7xPJh1bwaCIeJnUwtk02pfL713+9J2wDewx9mcWymkBt302pBYDo6gZQKCWtb oWUVvY22WBJmjJvHgWlQhUOJtJZ5B1Td73AkoAP1kNtGUuKiltUy4fPL9DbQD2jzEsDI 0jsQ== X-Gm-Message-State: ACrzQf0XV+prvGUql8MU0yN3wYRMm4gDNb+A0GHwiqUVcvKXjX1PrVql wE38QmYn8ZhPXPyEuA0xMtAPbdMsG/0= X-Google-Smtp-Source: AMsMyM4UtvBa7qOrqOTPm/sRX3WPQjkfD7o7Mc8uNThcTmZuQbBqB6nshUzx9F+9ISgyDiaFVQr6xg== X-Received: by 2002:a17:907:7241:b0:780:1475:63ef with SMTP id ds1-20020a170907724100b00780147563efmr6213278ejc.391.1663412205992; Sat, 17 Sep 2022 03:56:45 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::8510]) by smtp.gmail.com with ESMTPSA id c26-20020a056402101a00b0044792480994sm15432131edu.68.2022.09.17.03.56.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Sep 2022 03:56:45 -0700 (PDT) From: Augusto Stoffel To: Eli Zaretskii Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line In-Reply-To: <83sfkq1gu0.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Sep 2022 12:38:15 +0300") References: <87illme7fe.fsf@gmail.com> <83sfkq1gu0.fsf@gnu.org> Date: Sat, 17 Sep 2022 12:56:44 +0200 Message-ID: <87a66yclqr.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57876 Cc: public@protesilaos.com, 57876@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, 17 Sep 2022 at 12:38, Eli Zaretskii wrote: >> Cc: Protesilaos Stavrou >> From: Augusto Stoffel >> Date: Sat, 17 Sep 2022 10:23:01 +0200 >>=20 >> Tags: patch >>=20 >> Currently, if point is say at the prompt of a comint buffer, >> pulse-momentary-highlight-one-line doesn't show do anything =E2=80=93 or= , more >> precisely, it pulses the zero-length region from prompt end to EOB. >>=20 >> Prot: I think you want to apply a similar change in pulsar.el. >>=20 >>=20 >> >From e1241510fc9e0deddc5adb416aec5de4ca0300c8 Mon Sep 17 00:00:00 2001 >> From: Augusto Stoffel >> Date: Sat, 17 Sep 2022 10:17:34 +0200 >> Subject: [PATCH] pulse-momentary-highlight-one-line: Act on visual line >>=20 >> * lisp/cedet/pulse.el (pulse-momentary-highlight-one-line): Act on >> entire visual line, ignoring fields etc. > > Why don't you use beginning/end-of-visual-line? Because it obeys fields, so if you try to highlight a prompt line in a comint buffer, only part of the line would be highlighted. The (only, AFAICT) purpose of pulse-momentary-highlight-one-line is to locate the cursor, so you want to pulse a little rectangle spanning the entire width of the window. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 17 07:20:52 2022 Received: (at 57876) by debbugs.gnu.org; 17 Sep 2022 11:20:52 +0000 Received: from localhost ([127.0.0.1]:45266 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZVsR-0005r9-Sp for submit@debbugs.gnu.org; Sat, 17 Sep 2022 07:20:52 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40358) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZVsP-0005qt-Tm for 57876@debbugs.gnu.org; Sat, 17 Sep 2022 07:20:50 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35118) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZVsK-00060g-5j; Sat, 17 Sep 2022 07:20:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=TMixKe4Ots5EQeFPgL5tQIvy6cF2mY05rS0Jdo3BHTQ=; b=MHzMRJDUGxFk Ay/rlBfacUeqetfuCWkocOkP6zJmneI0+YmL22KSJIfTSs21hfaclgEi7HPs36nYf8TjFtjrkcr9+ CTQdqlzaYAHbpRJldo74Bxvfp96+IK7ayRmYEx60Fkqwp2fa0LfUgsmB+SeU8yX/aWYS1dmWNoG5Q akYDxsXpcLvwOftMzMUneNcH+dRuXVQ08V71/hYQdErpQm1qJgkeHS1tHJkjf0tzbmnqL9Nfy7ehi BLImtr9PGVVU1jB9h9HTKIkeImMNH378qzHaa03qbbNZTQXegW34RPhK9LatVkBonzB6ea/IUXxPx eirkyD1Utfq5bxcz07JyiA==; Received: from [87.69.77.57] (port=3288 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZVsJ-0005OV-Iy; Sat, 17 Sep 2022 07:20:43 -0400 Date: Sat, 17 Sep 2022 14:20:43 +0300 Message-Id: <83mtay1c38.fsf@gnu.org> From: Eli Zaretskii To: Augusto Stoffel In-Reply-To: <87a66yclqr.fsf@gmail.com> (message from Augusto Stoffel on Sat, 17 Sep 2022 12:56:44 +0200) Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line References: <87illme7fe.fsf@gmail.com> <83sfkq1gu0.fsf@gnu.org> <87a66yclqr.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57876 Cc: public@protesilaos.com, 57876@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Augusto Stoffel > Cc: 57876@debbugs.gnu.org, public@protesilaos.com > Date: Sat, 17 Sep 2022 12:56:44 +0200 > > > Why don't you use beginning/end-of-visual-line? > > Because it obeys fields, so if you try to highlight a prompt line in a > comint buffer, only part of the line would be highlighted. It should be possible to disable fields temporarily by binding inhibit-point-motion-hooks, right? I prefer doing that to reinventing the wheel of moving to the edges of the visible line. From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 17 07:32:06 2022 Received: (at 57876) by debbugs.gnu.org; 17 Sep 2022 11:32:06 +0000 Received: from localhost ([127.0.0.1]:45272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZW3K-0008Oq-2O for submit@debbugs.gnu.org; Sat, 17 Sep 2022 07:32:06 -0400 Received: from mail-ed1-f53.google.com ([209.85.208.53]:34407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZW3G-0008OH-Qn for 57876@debbugs.gnu.org; Sat, 17 Sep 2022 07:32:04 -0400 Received: by mail-ed1-f53.google.com with SMTP id z21so34964826edi.1 for <57876@debbugs.gnu.org>; Sat, 17 Sep 2022 04:32:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=1XNOaQc9lYfCL8xy4ui++nme2V9rKyrTquJXxsn8bMM=; b=dy/93yqo4Hv4Ts9WZaGxljdJ/BFoS+9aT8xtXt5ayELpnKDN7kTqoC+djjDHVWM96G Mqr6nMP3AFGRnCA9nugNkYnuVLkLmb7FDIGTqRvQsdHPxaNJ9uFNkQQ0AeYVuoU4o/40 +3Gtw+1u1ZziYBzmR1yKFIHUfH4H92/wgBN7jq4TOWzmmbHeF4FmAc8u9p9Gq9OjEBcj q8OfqOxv4Z7+Hhmftsl5x7zk7qW27DvEf7yEuB6JtjgD5LhG4CZV0F7JDJ3aAxErwzWu 7hWstxmAR/TROg3fz+fARIpBzIVaO2h1swElQ0a1J3m3YrxM5EESDgZ8+lfsfjwGfskC n8KQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=1XNOaQc9lYfCL8xy4ui++nme2V9rKyrTquJXxsn8bMM=; b=QOXipsZbRcJlIumX+20m73ZSgavJuN2njWzey73Vn0n0eKvsXTkdtGvJJ6RqiCtV5L sS0yOVaUX+EwbAntx6kcrDpsrJK75JGE7BC8emND8jmx93DVFO4jBTjJek+CHbiAbNRh bAOUCa9kEOb1BS8ZHSG1WEkZX9x4NJUlE7vltHP4BzwScEI5COO6rP5XSH6RxQZIg8Qm vp72pkW0sG0ReDq0OJ4VZfRNlL/PqfvWHcEni/KTwKEBP6dDGFzna9Mqb4ld9zoJPa4n mHu5TNowJQjag8/UcGX1e0vlpDDmZGmOQTH20kIa+x2uEbRLm6U4eXqKrucvmWYfddyr oCpw== X-Gm-Message-State: ACrzQf0m9+0vgZgtgykjLzuBzQZQrjxqpwMTGEVHDFFI7YOik/5fIyMd 2OkG+kd+dwQ1WvRZDi3nE8E= X-Google-Smtp-Source: AMsMyM6KPSISFUtLg13vQZ8mZgGD2KMv/ZSyulrc4g7U71Hd9PivsfSXXGmDE3prVssMsPZaFmvp5A== X-Received: by 2002:a05:6402:410:b0:451:ea13:4ed7 with SMTP id q16-20020a056402041000b00451ea134ed7mr7950576edv.262.1663414316998; Sat, 17 Sep 2022 04:31:56 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::8510]) by smtp.gmail.com with ESMTPSA id u3-20020a05640207c300b00451e3160451sm11533644edy.89.2022.09.17.04.31.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Sep 2022 04:31:56 -0700 (PDT) From: Augusto Stoffel To: Eli Zaretskii Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line In-Reply-To: <83mtay1c38.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 17 Sep 2022 14:20:43 +0300") References: <87illme7fe.fsf@gmail.com> <83sfkq1gu0.fsf@gnu.org> <87a66yclqr.fsf@gmail.com> <83mtay1c38.fsf@gnu.org> Date: Sat, 17 Sep 2022 13:31:55 +0200 Message-ID: <871qsack44.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57876 Cc: public@protesilaos.com, 57876@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, 17 Sep 2022 at 14:20, Eli Zaretskii wrote: >> From: Augusto Stoffel >> Cc: 57876@debbugs.gnu.org, public@protesilaos.com >> Date: Sat, 17 Sep 2022 12:56:44 +0200 >> >> > Why don't you use beginning/end-of-visual-line? >> >> Because it obeys fields, so if you try to highlight a prompt line in a >> comint buffer, only part of the line would be highlighted. > > It should be possible to disable fields temporarily by binding > inhibit-point-motion-hooks, right? I prefer doing that to reinventing > the wheel of moving to the edges of the visible line. This variable is allegedly obsolete since Emacs 25. In any case, the patch is really trivial, so how would this be making the code simpler or more robust? From debbugs-submit-bounces@debbugs.gnu.org Sat Sep 17 07:49:56 2022 Received: (at 57876) by debbugs.gnu.org; 17 Sep 2022 11:49:56 +0000 Received: from localhost ([127.0.0.1]:45294 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZWKZ-0000Ws-S6 for submit@debbugs.gnu.org; Sat, 17 Sep 2022 07:49:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60794) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZWKX-0000Wc-09 for 57876@debbugs.gnu.org; Sat, 17 Sep 2022 07:49:53 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33076) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZWKQ-0001ZC-IL; Sat, 17 Sep 2022 07:49:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jx4wCwMFl8+pnrXHW9tk60YNR8L1G0mVNNfrlM/IBF8=; b=BK+KXwkpKG7T YtjIad66xaBP6v8kZI9qiJEI/JCRg0cwKjCgDCRF8VvMwPhf47bhMwDBU/uHqemZ4ei+cnAyLyxCT V78Di4m/+48DoX8HfMXFzqK3ms2o74NiIuzNcfkWFfUZ8ycbsABBDTKmQ6y6dOyRu5Ty0yxIz0vry ZGj/IFhKI5U7wK4YWMXO1p5HBRBNjDtz1dgA/HOjdrP8SeWWEvZSvn/tarnja/5r5XMcRXbQihb+G Fjcm+snU/ub+7Tz9m2gqTOt5D0bDCbM7TzaIoCRhU0+rCLR51IOnGt+mDtwYitMoz8dYVY/8Vs7a2 erUJSgZ4G9kReRD612tijw==; Received: from [87.69.77.57] (port=1083 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZWKP-0003TQ-1C; Sat, 17 Sep 2022 07:49:46 -0400 Date: Sat, 17 Sep 2022 14:49:44 +0300 Message-Id: <83leqi1aqv.fsf@gnu.org> From: Eli Zaretskii To: Augusto Stoffel In-Reply-To: <871qsack44.fsf@gmail.com> (message from Augusto Stoffel on Sat, 17 Sep 2022 13:31:55 +0200) Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line References: <87illme7fe.fsf@gmail.com> <83sfkq1gu0.fsf@gnu.org> <87a66yclqr.fsf@gmail.com> <83mtay1c38.fsf@gnu.org> <871qsack44.fsf@gmail.com> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57876 Cc: public@protesilaos.com, 57876@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Augusto Stoffel > Cc: 57876@debbugs.gnu.org, public@protesilaos.com > Date: Sat, 17 Sep 2022 13:31:55 +0200 > > > It should be possible to disable fields temporarily by binding > > inhibit-point-motion-hooks, right? I prefer doing that to reinventing > > the wheel of moving to the edges of the visible line. > > This variable is allegedly obsolete since Emacs 25. Sorry, I meant inhibit-field-text-motion. > In any case, the patch is really trivial, so how would this be > making the code simpler or more robust? I just explained the reasons above: we have these utility functions for a reason: so that Lisp programs won't need to reinvent how to do what these utilities do every time. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 18 03:24:08 2022 Received: (at 57876) by debbugs.gnu.org; 18 Sep 2022 07:24:08 +0000 Received: from localhost ([127.0.0.1]:47691 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZoet-0007Xr-Th for submit@debbugs.gnu.org; Sun, 18 Sep 2022 03:24:08 -0400 Received: from relay10.mail.gandi.net ([217.70.178.230]:39115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZoer-0007XL-PV for 57876@debbugs.gnu.org; Sun, 18 Sep 2022 03:24:06 -0400 Received: (Authenticated sender: public@protesilaos.com) by mail.gandi.net (Postfix) with ESMTPSA id A8103240003; Sun, 18 Sep 2022 07:23:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protesilaos.com; s=gm1; t=1663485839; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ns1bY0pCzIWRwdQuDOxWtv8F92XDHmsCCW2/QSwFI2w=; b=GYAOWiBYSYbiDoXVVVxWCBMQEzVC8UjSEay7WoYpr+fLl1CEBMkwNL99FELZ285YFfygfo tGLJvpAiHjN4tDNbBOjGOk0skvLmawCKdiF53bcoPVJJ9ZOt7p89gbAgktPgGaAS9Ff6Mm B/1c2XEUZhnmGqABcg2adl0Byw+mo3sXK6S1qcZ3Y31afLcYQAAAUK9S1Br9NX3dSPO0LZ Yru376fJeo60XwtOMEm1ujLV2W0Pr/e/rdTuM4K9KEk0h5bkGPRkwRIhBpID717WyzWgi2 oliUTwftxnMJkgkNTQgS0BhDbSQn9i01mUBVErq3syAVsZDNsHXK66QU4ERxaA== From: Protesilaos Stavrou To: Augusto Stoffel , 57876@debbugs.gnu.org Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line In-Reply-To: <87illme7fe.fsf@gmail.com> References: <87illme7fe.fsf@gmail.com> User-Agent: Notmuch/0.37 (https://notmuchmail.org) Emacs/29.0.50 (x86_64-pc-linux-gnu) Date: Sun, 18 Sep 2022 10:23:53 +0300 Message-ID: <87mtaxqh6e.fsf@protesilaos.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57876 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) PiBGcm9tOiBBdWd1c3RvIFN0b2ZmZWwgPGFyc3RvZmZlbEBnbWFpbC5jb20+DQo+IERhdGU6IFNh dCwgMTcgU2VwIDIwMjIgMTA6MjM6MDEgKzAyMDANCj4NCj4gVGFnczogcGF0Y2gNCj4NCj4gQ3Vy cmVudGx5LCBpZiBwb2ludCBpcyBzYXkgYXQgdGhlIHByb21wdCBvZiBhIGNvbWludCBidWZmZXIs DQo+IHB1bHNlLW1vbWVudGFyeS1oaWdobGlnaHQtb25lLWxpbmUgZG9lc24ndCBzaG93IGRvIGFu eXRoaW5nIOKAkyBvciwgbW9yZQ0KPiBwcmVjaXNlbHksIGl0IHB1bHNlcyB0aGUgemVyby1sZW5n dGggcmVnaW9uIGZyb20gcHJvbXB0IGVuZCB0byBFT0IuDQo+DQo+IFByb3Q6IEkgdGhpbmsgeW91 IHdhbnQgdG8gYXBwbHkgYSBzaW1pbGFyIGNoYW5nZSBpbiBwdWxzYXIuZWwuDQoNCkhlbGxvIEF1 Z3VzdG8sDQoNCkp1c3QgdG8gbm90ZSB0aGF0IEkgYW0gbW9uaXRvcmluZyB0aGlzIHRocmVhZCBh bmQgd2lsbCBhY3QgYWNjb3JkaW5nbHkuDQoNClRoYW5rIHlvdSENCg0KUHJvdA0KDQotLSANClBy b3Rlc2lsYW9zIFN0YXZyb3UNCmh0dHBzOi8vcHJvdGVzaWxhb3MuY29tDQo= From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 18 07:02:23 2022 Received: (at 57876) by debbugs.gnu.org; 18 Sep 2022 11:02:23 +0000 Received: from localhost ([127.0.0.1]:47971 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZs46-0001D1-TX for submit@debbugs.gnu.org; Sun, 18 Sep 2022 07:02:23 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZs45-0001Cn-10 for 57876@debbugs.gnu.org; Sun, 18 Sep 2022 07:02:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=1eLo9bPkagsjCcl8KPIG3GcNW46J8St+36TQTVK4hF0=; b=Ef9yz/6PgzXldE+2U9LLR8kid7 XJhWV6jeHwRti95mE36+X0lZA03kKbr2Ey+Sdkp7VChNicnaLXJka0ewOmjh/lg/adseNSZlQJlT2 taCdrxxUCpvEcKGcpxqvLV0oTxGzMFXURABj5hjxTNzy9oGaemnZf0n5SbA7oE01IaAI=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZs3w-00070a-Eg; Sun, 18 Sep 2022 13:02:14 +0200 From: Lars Ingebrigtsen To: Augusto Stoffel Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line In-Reply-To: <87illme7fe.fsf@gmail.com> (Augusto Stoffel's message of "Sat, 17 Sep 2022 10:23:01 +0200") References: <87illme7fe.fsf@gmail.com> X-Now-Playing: The Vaselines's _Make More Noise (4)_: "Son Of A Gun" Date: Sun, 18 Sep 2022 13:02:11 +0200 Message-ID: <8735cp3pzg.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Augusto Stoffel writes: > Currently, if point is say at the prompt of a comint buffer, > pulse-momentary-highlight-one-line doesn't show do anything – or, more > precisely, it pulses the zero-length region from prompt end [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57876 Cc: Protesilaos Stavrou , 57876@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Augusto Stoffel writes: > Currently, if point is say at the prompt of a comint buffer, > pulse-momentary-highlight-one-line doesn't show do anything =E2=80=93 or,= more > precisely, it pulses the zero-length region from prompt end to EOB. Thanks; pushed to Emacs 29. Eli Zaretskii writes: >> This variable is allegedly obsolete since Emacs 25. > > Sorry, I meant inhibit-field-text-motion. That variable does not affect what beginning-of-visual-line does w.r.t. fields, only invisible text. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 18 07:02:27 2022 Received: (at control) by debbugs.gnu.org; 18 Sep 2022 11:02:27 +0000 Received: from localhost ([127.0.0.1]:47974 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZs4B-0001DJ-7W for submit@debbugs.gnu.org; Sun, 18 Sep 2022 07:02:27 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37958) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZs49-0001Cs-5e for control@debbugs.gnu.org; Sun, 18 Sep 2022 07:02:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+6jQseh0pVFtc6ypGuBjy40apQQ8Z0DLxF76AzakZyc=; b=V0IiWJxZUqnZFEvgz/oB2gmw34 pOYr+do9J1hIxRq5q1PNWK0n1/+ZS2L6t1fJtOszWYo0xWNgjpE6MDmnbDeVGvHIRR9MmvIfM+8wi /MANvs/qqd33m3S9xkSPU0kyetP/7YUDL+CCtFWfVf8Uhl3rhdjaAAQae9ZJyrLpqDXI=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZs41-00070k-LV for control@debbugs.gnu.org; Sun, 18 Sep 2022 13:02:19 +0200 Date: Sun, 18 Sep 2022 13:02:17 +0200 Message-Id: <871qs93pza.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #57876 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 57876 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 57876 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 18 08:40:41 2022 Received: (at 57876) by debbugs.gnu.org; 18 Sep 2022 12:40:41 +0000 Received: from localhost ([127.0.0.1]:48252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZtbF-00009V-9n for submit@debbugs.gnu.org; Sun, 18 Sep 2022 08:40:41 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41448) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZtbD-00009G-OA for 57876@debbugs.gnu.org; Sun, 18 Sep 2022 08:40:40 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60774) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZtb8-0001rS-IV; Sun, 18 Sep 2022 08:40:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=33MMnfURN6W/eVQCpQU8iac9ihOBQUj5+GZXjLQSaIQ=; b=ZPyjc2yFI9hR Z29I7+2+enl91oWzvKimnIm3dAhtZ0zE6JHmXok+4xua1yqC3EMmyz2ZPN7RB1yvgUce75veRqNL3 T8jdRkwre52GE0FMOVsyamfNKzU+FMDlyyM6wUSMpWLgMGATwUmwarA9LOx3PvQdYQ3V8ULC8rEEo HDk8CCiTwwSvNY/JZLtpbpsyy00eVeTrjqCWgidkmuzPkP4ZksB6oy+GvxLNCkBnwalb/CQthyGvx Z6wvzzRLovHmerAoDSAnYJxyEtQ7UupkLbEGGYMaMlV7y266+Ce96IWRc8IubkEmD2QOVoQZv4GkX Ok+87vswGuG3bsz0voR+pw==; Received: from [87.69.77.57] (port=1266 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZtb8-0000Yh-17; Sun, 18 Sep 2022 08:40:34 -0400 Date: Sun, 18 Sep 2022 15:40:36 +0300 Message-Id: <83bkrczwhn.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <8735cp3pzg.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 18 Sep 2022 13:02:11 +0200) Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line References: <87illme7fe.fsf@gmail.com> <8735cp3pzg.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57876 Cc: 57876@debbugs.gnu.org, public@protesilaos.com, arstoffel@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Protesilaos Stavrou , 57876@debbugs.gnu.org > From: Lars Ingebrigtsen > Date: Sun, 18 Sep 2022 13:02:11 +0200 > > Eli Zaretskii writes: > > >> This variable is allegedly obsolete since Emacs 25. > > > > Sorry, I meant inhibit-field-text-motion. > > That variable does not affect what beginning-of-visual-line does > w.r.t. fields, only invisible text. That's not what the doc string of inhibit-field-text-motion does, so it might be a bug in itself. line-beginning-position, for example, does ignore fields when that variable is non-nil. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 18 08:45:44 2022 Received: (at 57876) by debbugs.gnu.org; 18 Sep 2022 12:45:44 +0000 Received: from localhost ([127.0.0.1]:48282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZtg8-0000KU-G8 for submit@debbugs.gnu.org; Sun, 18 Sep 2022 08:45:44 -0400 Received: from quimby.gnus.org ([95.216.78.240]:38964) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZtg7-0000KF-9q for 57876@debbugs.gnu.org; Sun, 18 Sep 2022 08:45:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=wOzYmwahoAn5PXc6Zh60kgg/AjKD0nSFEiXrU4u7+BM=; b=WILo5quQL9BETY9mZNPam1yiTB Y6koHslmyOb7ycblM7Rm9DyRXex6GzZeeIJsmaoO8qUyzayNhYlHRAposPpBRCs0JzbEcaPEVBBTu DKPKj5uaAGVaAwKAHzGpZQ2oaYt2YDVm6EWs5AmAc0Hy8vZ6YpeD73N9yJEbF6kNBjeg=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZtfy-0007h1-54; Sun, 18 Sep 2022 14:45:36 +0200 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line In-Reply-To: <83bkrczwhn.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 18 Sep 2022 15:40:36 +0300") References: <87illme7fe.fsf@gmail.com> <8735cp3pzg.fsf@gnus.org> <83bkrczwhn.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEWsmGTGsXW7r5n5 +fnT0c6FdHA6MkL///+d0C9kAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+YJEgwTBeNW4yMAAAGUSURB VDjLnZRLcsIwDIYdZtjHPQGYOutME/YZAqw7LvIBGKz7H6GS/MgD6KJaOBp//h3rtxJV6RQl0bXi 0PrQnUuMMgy1gLEDcAAW6HEDMNYNLBJgjLGWBuMkHbTOCgprLRjnSBzBBwME+LY+0D6SRsV+7Dyi R4sEHGLwULbyNOctj3fkNTNAQYrACoqBa9EmgQsP9wzo5fQOfAXKVtcFqAVw9F90JvN5Yk/arFhH O1f8A/TR9gL2YqKx0LBTVCBAiIr9wnY2DKKCgOPF1tPUhjxEKMclr5t7dhcQj1WynXIfmqnyNgPk dQRCSCBvxQDmCj0pFia20iUvwVxx4QpunIWi6LgXF14VsDZRvbuPd6D+Gxw69tXIfZy55V2bvo+e +xKv3NncomR7UvRcgb+C3Aei24miYsANe6H7UAyClVMpPfbZkkAXxYa28SOcvAp4m0CVQbMCegYw gnB8Bg9J34GkIHel8hMX8yOWRGB2ypiNUevQRmv1HKDiD4bMEX9mgKKuK1VJkmdhC1Ji+hFVOhO1 hV/qhvd9Tl5wdwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0xOFQxMjoxOTowNSswMDowMJrK 6TMAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDktMThUMTI6MTk6MDUrMDA6MDDrl1GPAAAAAElF TkSuQmCC X-Now-Playing: The Meters's _Gettin' Funkier All The Time (5): Mister Moon_: "Chug Chug Chug-A-Lug (Push And Shove)" Date: Sun, 18 Sep 2022 14:45:33 +0200 Message-ID: <87o7vc26mq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> >> This variable is allegedly obsolete since Emacs 25. >> > >> > Sorry, I meant inhibit-field-text-motion. >> >> That variable does not affect what beginning-of-visual-line does >> w.r.t. fields, o [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57876 Cc: 57876@debbugs.gnu.org, public@protesilaos.com, arstoffel@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: >> >> This variable is allegedly obsolete since Emacs 25. >> > >> > Sorry, I meant inhibit-field-text-motion. >> >> That variable does not affect what beginning-of-visual-line does >> w.r.t. fields, only invisible text. > > That's not what the doc string of inhibit-field-text-motion does, so > it might be a bug in itself. line-beginning-position, for example, > does ignore fields when that variable is non-nil. Oh, sorry! I was confusing myself by testing with (let ((inhibit-point-motion-hooks t)) (beginning-of-visual-line)) which is the wrong thing, of course -- with inhibit-field-text-motion it works fine. So adjusting the patch to use that instead might be appropriate (but doesn't make much difference). From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 18 08:55:53 2022 Received: (at 57876) by debbugs.gnu.org; 18 Sep 2022 12:55:53 +0000 Received: from localhost ([127.0.0.1]:48325 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZtpw-0000fp-UZ for submit@debbugs.gnu.org; Sun, 18 Sep 2022 08:55:53 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZtpv-0000fb-T4 for 57876@debbugs.gnu.org; Sun, 18 Sep 2022 08:55:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42814) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZtpq-00043q-Di; Sun, 18 Sep 2022 08:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9pN1BUEr3qZds/CwSOaz0wW49DOtIep/0tUMCSOIDjM=; b=XviHPdHNgGdm Da9wwJlUpng2eRjp0DRITUBTNeBHvX5jSJey5Tr79iRBfg0z3+a2NgS4h7MV/KMYb1+Z1qjwe8uVH MHh/Q1BONB03jytqsnI+aqxHKBdW3KZ41tQAml9tyPf80LXK/S8nqMuWOhd3sdiXCf9DPlo/KtMBu rtBk1TtzG6tCRCVfyVeghcFLzVuqYU/iIZMqcRPR0wNy7OkvrAbmpScOoMe14nQoX9r23ic8spb17 wlHtUF0UQRVdyP/xBcywIjsHR+8ycu7h0nmHcZjgVGVgnBPgvvCUF8DfatEUFwIsyvCJUjmXyIQ9D 6ZvdSCbxP6SByqBFQLFLQA==; Received: from [87.69.77.57] (port=2193 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZtpp-0002Mj-Sg; Sun, 18 Sep 2022 08:55:46 -0400 Date: Sun, 18 Sep 2022 15:55:48 +0300 Message-Id: <838rmgzvsb.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87o7vc26mq.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 18 Sep 2022 14:45:33 +0200) Subject: Re: bug#57876: [PATCH] pulse-momentary-highlight-one-line: Act on visual line References: <87illme7fe.fsf@gmail.com> <8735cp3pzg.fsf@gnus.org> <83bkrczwhn.fsf@gnu.org> <87o7vc26mq.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57876 Cc: 57876@debbugs.gnu.org, public@protesilaos.com, arstoffel@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: arstoffel@gmail.com, public@protesilaos.com, 57876@debbugs.gnu.org > Date: Sun, 18 Sep 2022 14:45:33 +0200 > > Oh, sorry! I was confusing myself by testing with > > (let ((inhibit-point-motion-hooks t)) (beginning-of-visual-line)) > > which is the wrong thing, of course -- with inhibit-field-text-motion it > works fine. > > So adjusting the patch to use that instead might be appropriate (but > doesn't make much difference). My point in suggesting that was that it is better to use utility functions we have rather than the equivalent code, because the utility functions presumably serve as a locus of all our wisdom related to what they do. For example, what does "beginning of visual line" mean with bidirectional text? Instead of having to decide this in each case, we have a function that already does TRT. From unknown Tue Jun 17 20:39:37 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Mon, 17 Oct 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator