Subject: bug#57871: closed (Re: [bug#57871] [PATCH] ideviceinstaller: new package)

From: [email-masked] (GNU bug Tracking System)
Date: Thu, 22 Sep 2022 05:46:02 +0000

Your bug report

#57871: [PATCH] ideviceinstaller: new package

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
57871: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57871
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#57871] [PATCH] ideviceinstaller: new package
From: Julien Lepiller <[email-masked]>
To: Jacob Hrbek <[email-masked]>
Cc: [email-masked]
Date: Thu, 22 Sep 2022 07:44:54 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Pushed to master as 04cad8e29ed85be838921c7fa05f7c5bce94b6d1.

I had to change a few things in the final patch:

First of all, please run "guix lint" on your future submissions, so you
can fix some of these issues beforehand.

I changed the source to look directly for the git repository: the
tarballs at github are not always stable, which might break the
package, and a git source is easier to archive in Software Heritage.

I also wrapped a long line in the description, and removed your
comments about versions, since they are not relevant in Guix. This also
fixes an issue about lonely parenthesis. Note that version constraints
like >= 1.2.3 are not relevant in Guix, since packages are not expected
to ever downgrade.

Then, I added the autotools packages (autoconf, automake and libtool)
for the bootstrap phase to run and generate the configure script.

I moved the runtime dependencies (libimobiledevice and other libraries)
to the inputs instead of the native-inputs. There is no difference
between the two for normal compilation, but when cross-compiling, a
software can only link to inputs and propagated-inputs since they are
for the target platform, whereas native-inputs are for the native
platform (the computer performing the build).

Thanks for the patch!

Subject: [PATCH] ideviceinstaller: new package
From: Jacob Hrbek <[email-masked]>
To: [email-masked]
Cc: Jacob Hrbek <[email-masked]>
Date: Fri, 16 Sep 2022 23:41:07 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

---
 gnu/packages/libusb.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/libusb.scm b/gnu/packages/libusb.scm
index 8a5967f7b4..08206fd87c 100644
--- a/gnu/packages/libusb.scm
+++ b/gnu/packages/libusb.scm
@@ -41,6 +41,7 @@ (define-module (gnu packages libusb)
   #:use-module (guix build-system glib-or-gtk)
   #:use-module (guix build-system python)
   #:use-module (gnu packages autotools)
+  #:use-module (gnu packages compression)
   #:use-module (gnu packages gnupg)
   #:use-module (gnu packages gtk)
   #:use-module (gnu packages java)
@@ -339,6 +340,28 @@ (define-public python-capablerobot-usbhub
 I2C and SPI devices attached to the USB Hub.")
     (license license:expat)))

+(define-public ideviceinstaller
+  (package
+    (name "ideviceinstaller")
+    (version "1.1.1")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "https://github.com/libimobiledevice/ideviceinstaller/rele
ases/download/" version
+                           "/ideviceinstaller-" version ".tar.bz2"))
+       (sha256
+        (base32 "0qrhdhcxd9x901g2zq3znvrfjhy8hcdp17xkm8aq3y7jjzn87f6y"))))
+    (build-system gnu-build-system)
+    (native-inputs
+     (list pkg-config ; >=0.9.0
+           libimobiledevice ; >=1.3.0
+           libzip ; >=0.10
+           ))
+    (home-page "https://libimobiledevice.org/")
+    (synopsis "CLI Tool to manage apps and app archives on iOS devices")
+    (description "This package provides an interface to manage IPA format files and applications for iOS devices, it's written in C")
+    (license license:gpl2)))
+
 (define-public libplist
   (package
     (name "libplist")
--
2.37.1