GNU bug report logs - #57870
27.1; vc-tor has no effect

Previous Next

Package: emacs;

Reported by: Sean Whitton <spwhitton <at> spwhitton.name>

Date: Fri, 16 Sep 2022 23:23:01 UTC

Severity: normal

Tags: patch

Found in version 27.1

Done: Sean Whitton <spwhitton <at> spwhitton.name>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sean Whitton <spwhitton <at> spwhitton.name>
Subject: bug#57870: closed (Re: bug#57870: 27.1; vc-tor has no effect)
Date: Sun, 18 Sep 2022 01:02:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#57870: 27.1; vc-tor has no effect

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 57870 <at> debbugs.gnu.org.

-- 
57870: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57870
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Sean Whitton <spwhitton <at> spwhitton.name>
To: Philip Kaludercic <philipk <at> posteo.net>, 57870-done <at> debbugs.gnu.org
Subject: Re: bug#57870: 27.1; vc-tor has no effect
Date: Sat, 17 Sep 2022 18:01:46 -0700
Hello,

On Sat 17 Sep 2022 at 02:28PM GMT, Philip Kaludercic wrote:

> Sean Whitton <spwhitton <at> spwhitton.name> writes:
>
>> Hello,
>>
>>>From reading vc-do-command, it looks to me that the vc-tor defcustom has
>> never actually had any effect on the commands that are run.  The
>> full-command variable is used only in messages displayed to the user.
>>
>> If someone else could verify this, I'll push the attached.  This is
>> blocking my work on #57807.  Thanks.
>
> I've just tried it out and it seems to do the right thing.

Thanks for reviewing!

-- 
Sean Whitton

[Message part 3 (message/rfc822, inline)]
From: Sean Whitton <spwhitton <at> spwhitton.name>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.1; vc-tor has no effect
Date: Fri, 16 Sep 2022 16:22:04 -0700
[Message part 4 (text/plain, inline)]
Hello,

From reading vc-do-command, it looks to me that the vc-tor defcustom has
never actually had any effect on the commands that are run.  The
full-command variable is used only in messages displayed to the user.

If someone else could verify this, I'll push the attached.  This is
blocking my work on #57807.  Thanks.

-- 
Sean Whitton
[0001-vc-do-command-Actually-include-torsocks-in-the-comma.patch (text/x-patch, attachment)]

This bug report was last modified 2 years and 246 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.