GNU bug report logs - #57857
[PATCH] gnu: busybox: fix the cross build.

Previous Next

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: 路辉 <luhux76 <at> gmail.com>, 57857 <at> debbugs.gnu.org
Subject: [bug#57857] [PATCH] gnu: busybox: fix the cross build.
Date: Fri, 16 Sep 2022 17:08:33 +0200

[Message part 1 (text/plain, inline)]

On 16-09-2022 14:35, 路辉 wrote:
> 


+             (if tests?
+                 (apply invoke "make"
+                        ;; "V=1"
+                        "SKIP_KNOWN_BUGS=1"
+                        "SKIP_INTERNET_TESTS=1"
+                        "check" make-flags)
+                 #t)))

Can be simplified to

(when tests?
  (apply invoke "make"
          ;; "V=1"
          "SKIP_KNOWN_BUGS=1"
          "SKIP_INTERNET_TESTS=1"
          "check" make-flags))


+     `(#:tests? (if ,(%current-target-system) #f #t)

That's the default, no need to mention it again here.

+       #:make-flags
+       (let ((target ,(%current-target-system)))
+         (if target
+             (list (string-append "CROSS_COMPILE=" target "-"))
+             (list)))

Can be simplified:

#:make-flags
,(let ((target ,(%current-target-system)))
   (if target
       #~(list (string-append "CROSS_COMPILE=" ,target))
       #~'()))

(the #~ makes the phasing more explicit, if you go for that, I recommend 
turning the arguments into (arguments (list #:phases #~(modify-phases 
...) #:make-flags ...)), instead of using ` / , , to remain consistent.)

Greetings,
Maxime

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.