GNU bug report logs - #57857
[PATCH] gnu: busybox: fix the cross build.

Previous Next

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: 路辉 <luhux76 <at> gmail.com>
Cc: 57857 <at> debbugs.gnu.org
Subject: [bug#57857] [PATCH] gnu: busybox: fix the cross build.
Date: Sun, 25 Sep 2022 19:55:35 +0200

[Message part 1 (text/plain, inline)]

On 16-09-2022 17:53, 路辉 wrote:
>> Can be simplified:
>>
>> #:make-flags
>> ,(let ((target ,(%current-target-system)))

Oops the , before (%current-target-system) shouldn't be there

>>      (if target
>>          #~(list (string-append "CROSS_COMPILE=" ,target))

OOps, ,target -> #$target

>>          #~'()))
>>
>> (the #~ makes the phasing more explicit, if you go for that, I recommend
>> turning the arguments into (arguments (list #:phases #~(modify-phases
>> ...) #:make-flags ...)), instead of using ` / , , to remain consistent.)
>>
>> Greetings,
>> Maxime
>>
> 
> new patch vvvv

The #:make-flags simplification is missing (it can help with avoiding 
rebuilds (e.g. if a particular architecture needs some different 
#:make-flags than usual), but otherwise looks good.

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.