GNU bug report logs - #57856
28.2; bookmark context strings in encrypted files

Previous Next

Full log

Message #33 received at 57856 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Gustavo Barros <gusbrs.2016 <at> gmail.com>, 57856 <at> debbugs.gnu.org
Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files
Date: Mon, 19 Sep 2022 11:00:07 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

Hi Lars,

> Looking at how to integrate this (which is always iffy when we're
> dealing with several packages), I think this has to be done the other
> way.  That is, `bookmark-make-record' has to check whether the file is
> encrypted or not, becaues `*insert-file-contents' might not have been
> run at all (if this is a new encrypted file, for instance).
>
> So `tramp-crypt-file-name-p' is perfect for that, but there doesn't seem
> to be any `epa-file-name-p' (or something equivalent)?  Hm...  OK, that
> was trivial to add, so I've now done it this way in Emacs 29.

Thanks.

Thinking further about, there are also other files which shouldn't
expose snippets to bookmarks. Think about .authinfo / .netrc (more
general, all files used as auth-sources backend). And perhaps other
files.

Wouldn't it be better, if packages like Tramp, epa, auth-sources, you
name it, could mark files to be excluded from bookmark-make-record? For
example, a hook a package could contribute to. In Tramp, we would run

(add-hook 'bookmark-inhibit-bookmark-hook #'tramp-crypt-file-name-p)

Similar for other packages.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.