From unknown Sun Jun 22 11:46:49 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#57856 <57856@debbugs.gnu.org> To: bug#57856 <57856@debbugs.gnu.org> Subject: Status: 28.2; bookmark context strings in encrypted files Reply-To: bug#57856 <57856@debbugs.gnu.org> Date: Sun, 22 Jun 2025 18:46:49 +0000 retitle 57856 28.2; bookmark context strings in encrypted files reassign 57856 emacs submitter 57856 Gustavo Barros severity 57856 normal tag 57856 moreinfo thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 07:47:29 2022 Received: (at submit) by debbugs.gnu.org; 16 Sep 2022 11:47:29 +0000 Received: from localhost ([127.0.0.1]:41967 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ9of-0000Ku-5c for submit@debbugs.gnu.org; Fri, 16 Sep 2022 07:47:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:38858) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ9od-0000Km-Nd for submit@debbugs.gnu.org; Fri, 16 Sep 2022 07:47:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ9od-0003Hl-H7 for bug-gnu-emacs@gnu.org; Fri, 16 Sep 2022 07:47:27 -0400 Received: from mail-qv1-xf30.google.com ([2607:f8b0:4864:20::f30]:38661) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZ9ob-0005IP-M5 for bug-gnu-emacs@gnu.org; Fri, 16 Sep 2022 07:47:27 -0400 Received: by mail-qv1-xf30.google.com with SMTP id i15so16419729qvp.5 for ; Fri, 16 Sep 2022 04:47:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:user-agent:sender:from :to:cc:subject:date; bh=zCIWa2ZeT7WgNTBVLVPXP8lEy6IkRg18iYmDdtYwIWY=; b=elwu6p65+AH4iRnybbzLTqMpmEmj3nycbq8EoUwXk4/cY4BODg11Cs5jyA965gXAlQ Rv1GAy5hzaj486rTJw/3oZf7xIHudX4No5IgwFz3/7DQlfimv1ODog8gU817cIDslqfH dJzZsGKApqqnJDIN5TocxH907gjH2wtoAKkoAHw1vphy1QBnkdIvJi6HqHob4lQ5Ljb5 D8TGW/G//sKUD2LpxbNJ8Vw74p0hqn3SK3N+1SoVfG9xYtOvkU2Lzr8IFDQCnMzFN4dx CqsKLZ45FNl96nL8lLqDWg8EWle4xoQAzI7Iiuk0lK6yJFi4Mc/TsP4REMZDHUrisstJ tKgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:user-agent:sender :x-gm-message-state:from:to:cc:subject:date; bh=zCIWa2ZeT7WgNTBVLVPXP8lEy6IkRg18iYmDdtYwIWY=; b=14+lrdV/C3fhWAqlQhPoDfil8Zs9FdHEeamEaeSyOSY0dkueVHQPBNkdQhkhnVDZyB pv9nEP9VbdDjuXGJU4SD1b+x/Wcv6viijSV71jOeCKyqrDT9VvGjw1CdCHPKrbOMRW8A PvjirLGUc71WmclCd6RkVcjgb3lOdXd4UfPr1kJcnSJl5gPV+QMNssR8HPYvljJUooTZ 8TYowxoaJE58JT0mM8KVlxTyPBaei9SJRVoWK0FK5U2TSThgSJ3YO8BDkQBp8aYXoP23 rrH3NxevweOlKQZmOXEBaDpzLFQihiTNwed6Jo3XPwJz8GyplbjPEyexsyVSD3Kf2Bi8 2cDg== X-Gm-Message-State: ACrzQf31ShDAjwoHqalyMrrwbNWZzHA6ixjZghIyxf4s9X4DTGtdufAJ uzqJ0WduuXTxdWmO1xyb0KvTTF8hqH8= X-Google-Smtp-Source: AMsMyM6cCnYQyhlzHAlCIW30DDYlwYeenhqf+tEg8iesSHLHKH2h6gXJcwJMyyfdWsVcow37iaN+2g== X-Received: by 2002:ad4:5282:0:b0:4a9:b75a:e33a with SMTP id v2-20020ad45282000000b004a9b75ae33amr3808652qvr.67.1663328839625; Fri, 16 Sep 2022 04:47:19 -0700 (PDT) Received: from gusbrs-laptop ([102.129.152.129]) by smtp.gmail.com with ESMTPSA id z185-20020a37b0c2000000b006bb9e4b96e6sm5820238qke.24.2022.09.16.04.47.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 04:47:18 -0700 (PDT) User-agent: mu4e 1.8.10; emacs 28.2 From: Gustavo Barros To: bug-gnu-emacs@gnu.org Subject: 28.2; bookmark context strings in encrypted files Date: Fri, 16 Sep 2022 08:08:25 -0300 Message-ID: <87bkrfh77i.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed Received-SPF: pass client-ip=2607:f8b0:4864:20::f30; envelope-from=gusbrs.2016@gmail.com; helo=mail-qv1-xf30.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) Hi All, I guess this one is midway between a bug report and a feature request. I don't see that this is anyway against expected/documented behavior of involved libraries (bookmark.el, epg.el), but it is arguably a bad corner case of interaction between the two, which represents a (small) potential security issue. Currently (Emacs 28.2), when setting a bookmark in a gpg encrypted file, part of the buffer is stored unencrypted as `front-context-string' and `rear-context-string' in the `bookmark-default-file' whenever `bookmark-search-size' is larger than 0, which by default is 16. It could be argued that it is unwise to set a bookmark in this context. But, well, users do all kind of stuff. Besides, Emacs provides no hint that this may be risky (as far as I can tell). So it would be nice if Emacs would be a little more conservative here, and locally set `bookmark-search-size' to 0 in buffers visiting encrypted files. I think it'd be overkill to provide a full reproduction recipe, since most of it would just be to set up environment (key etc.) for GPG. But anyone who already has a setup and an encrypted file can reproduce the following simple steps (which I have tested in an .org.gpg file with `emacs -Q'): Visit the encrypted file. Set a bookmark with `bookmark-set' ("C-x r m") somewhere near a non-empty part of the buffer. Save bookmarks with `bookmark-save'. Inspect `bookmark-default-file' (by default "~/.emacs.d/bookmarks"), particularly `front-context-string' and `rear-context-string' of the pertinent bookmark, to find part of the original encrypted file stored there unencrypted. Best regards, Gustavo. In GNU Emacs 28.2 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2022-09-12 built on gusbrs-laptop Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Linux Mint 20.3 Configured using: 'configure --with-mailutils --with-xwidgets --with-native-compilation --without-compress-install' Configured features: ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM GSETTINGS HARFBUZZ JPEG JSON LCMS2 LIBOTF LIBSELINUX LIBSYSTEMD LIBXML2 M17N_FLT MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM XWIDGETS GTK3 ZLIB Important settings: value of $LC_MONETARY: pt_BR.UTF-8 value of $LC_NUMERIC: pt_BR.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t indent-tabs-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug sendmail bookmark pp vc-git diff-mode vc-dispatcher org-element avl-tree generator ol-eww eww xdg url-queue thingatpt mm-url ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-search eieio-opt cl-extra help-mode speedbar ezimage dframe gnus-art mm-uu mml2015 mm-view mml-smime smime dig gnus-sum shr kinsoku svg dom browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util url-parse url-vars mailcap gnus-group gnus-undo gnus-start gnus-dbus dbus xml gnus-cloud nnimap nnmail mail-source utf7 netrc nnoo parse-time gnus-spec gnus-int gnus-range message rmc puny rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader gnus-win gnus nnheader gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache rfc2047 rfc2045 ietf-drums text-property-search mail-utils mm-util mail-prsvr wid-edit ol-docview doc-view jka-compr image-mode exif dired dired-loaddefs ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete comint ansi-color ring org-list org-faces org-entities noutline outline easy-mmode org-version ob-emacs-lisp ob-core ob-eval org-table oc-basic json map bibtex iso8601 time-date subr-x ol rx org-keys oc org-compat advice org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs cl-loaddefs cl-lib seq byte-opt gv bytecomp byte-compile cconv epa-file epa derived epg rfc6068 epg-config iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads xwidget-internal dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit x multi-tty make-network-process native-compile emacs) Memory information: ((conses 16 238516 14883) (symbols 48 20306 0) (strings 32 72413 2731) (string-bytes 1 2383288) (vectors 16 36730) (vector-slots 8 659339 39456) (floats 8 313 89) (intervals 56 312 0) (buffers 992 11)) From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 08:08:03 2022 Received: (at 57856) by debbugs.gnu.org; 16 Sep 2022 12:08:03 +0000 Received: from localhost ([127.0.0.1]:42000 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZA8Z-00033d-7y for submit@debbugs.gnu.org; Fri, 16 Sep 2022 08:08:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45380) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZA8X-000331-HQ for 57856@debbugs.gnu.org; Fri, 16 Sep 2022 08:08:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=nHeA9XlWdZW+s051srng8qkqT+HAS7MH/oQbc7S0ZNo=; b=kj2AfhW/cDaMLx8SbVICdmYgjo 7AmvRgAgtrJx7XvzoFjq8nJf3sE24iNhsgupIPzs0aNy4oilmK8jwHytNnI3Aox6NKdSM0SJJQAnD HktxgxkhDDkFGlNaXngrbuYWnCR6VYZR3giAYHkN8nvWXhfWkDrY5HMHbg44fJJAMlzI=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZA8P-0003mq-EO; Fri, 16 Sep 2022 14:07:55 +0200 From: Lars Ingebrigtsen To: Gustavo Barros Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <87bkrfh77i.fsf@gmail.com> (Gustavo Barros's message of "Fri, 16 Sep 2022 08:08:25 -0300") References: <87bkrfh77i.fsf@gmail.com> X-Now-Playing: Billie Eilish's _When we all fall asleep where do we go?_: "When The Party's Over" Date: Fri, 16 Sep 2022 14:07:52 +0200 Message-ID: <87mtaz8quf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Gustavo Barros writes: > It could be argued that it is unwise to set a bookmark in this > context. But, well, users do all kind of stuff. Besides, Emacs > provides no hint that this may be risky (as far as I can tell). So i [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57856 Cc: 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Gustavo Barros writes: > It could be argued that it is unwise to set a bookmark in this > context. But, well, users do all kind of stuff. Besides, Emacs > provides no hint that this may be risky (as far as I can tell). So it > would be nice if Emacs would be a little more conservative here, and > locally set `bookmark-search-size' to 0 in buffers visiting encrypted > files. I think that makes sense. Alternatively, we could prompt the user for what to do in these files? Anybody have any opinions? From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 08:08:07 2022 Received: (at control) by debbugs.gnu.org; 16 Sep 2022 12:08:07 +0000 Received: from localhost ([127.0.0.1]:42003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZA8d-00033t-Gn for submit@debbugs.gnu.org; Fri, 16 Sep 2022 08:08:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45394) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZA8b-000336-HE for control@debbugs.gnu.org; Fri, 16 Sep 2022 08:08:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=buzw/TZ/V8pxou2a9l10U+Ci5j1BtBGhZaAqaYWuAeo=; b=KEo3+m6ApoQPHASdVvVK0zm4RS u6rcB/LLLea0NYQqq2aP1dND2aTlk0FXSXtEBE5MLDUAHRGSpPMfBEQHnW24xUsnYjpV0rn/u3c/q XGg1dFaSz/DEkJrkWyzORvExYnj3porlCfdRw6plzS3zvbaMy+v51wrQXYeUYwpRdlKI=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZA8T-0003pA-To for control@debbugs.gnu.org; Fri, 16 Sep 2022 14:07:59 +0200 Date: Fri, 16 Sep 2022 14:07:57 +0200 Message-Id: <87leqj8qua.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #57856 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 57856 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) tags 57856 + moreinfo quit From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 08:48:42 2022 Received: (at 57856) by debbugs.gnu.org; 16 Sep 2022 12:48:42 +0000 Received: from localhost ([127.0.0.1]:42092 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZAlu-0006M5-Gl for submit@debbugs.gnu.org; Fri, 16 Sep 2022 08:48:42 -0400 Received: from mail-qt1-f173.google.com ([209.85.160.173]:41537) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZAlr-0006Lp-Fz for 57856@debbugs.gnu.org; Fri, 16 Sep 2022 08:48:40 -0400 Received: by mail-qt1-f173.google.com with SMTP id c11so15789826qtw.8 for <57856@debbugs.gnu.org>; Fri, 16 Sep 2022 05:48:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:sender:from:to:cc:subject:date; bh=dQ1M84Qq3xSCos7+U+UK6kw3XL3SJHuazWe7HWJ2nD4=; b=QP7XclwxiSEXlI5G4bA+q3N0KSSKlQm1Mf+0R1b7zMQxcCgN3wn86rAyz7OkgysDrg sVXgWc+wpTDUh8tKkTP5xPQnQx/T9onkPfTD4jWMaEXAG5kFt4rlM92dkZlWz6NisQez kgzSUjelyVw6VstiYwoVOXRSEdWCNp0Z3Vw5pVRaIh7Q6VItbuhQ5ntrjJGwQ30FbnYg jI+p0dQUimjgqagFr84yeJIGSdcAUiITKPwJS1/+jSzLNKvcPJD2IvGXkpDsq2PzDl6u DzxVEe+AAfPNAQPFeRGCWUnom2eqLDaB25APjCCCvGKKM5mDMc94nqxHuxLAPPt0xRHv W12Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:sender:x-gm-message-state:from:to:cc:subject :date; bh=dQ1M84Qq3xSCos7+U+UK6kw3XL3SJHuazWe7HWJ2nD4=; b=0x0FxqA6a69rdUVTmfyNtrOqotfUlkOKKMK+ZbHtiScgtQcUuC7p7UwVO2K6ULAh7D 5dkuLzSCC3HOmdiCjn3Sp3NNODQdiX0anWHtxm90XEyNZa4xt1USJ5fFK14kxGuki6Zv zpukFKXxHVJIzjz5NIxqltV4BjHdsz7pBcMeSS0xQcdbAvE1C1Rr5Gswc8QFhBCbSsgc K78dS/ESNN0I/wsSw9UKE3AYA+4OFb09egDKSX6cCmACLKXvvqCI9UGAHBmYvjNVOlrG M3dzV8fW3WgxG4269duASRuNMGi9Jogueq0IVQFU6gOcQ/ggw+3i3MTeXOpvhdmV2hwI Uh6A== X-Gm-Message-State: ACrzQf2Ow5t/HiJUNk2/TinsAewohZzyIcunkt7gLn5y1KQU026qtK9k Ip9UDGRd1I37/nZOFWlcFyuhQh/l+Hs= X-Google-Smtp-Source: AMsMyM40DQeiOYy2XDBl30jvLecLayReBu+YUKpUd9zFJeSjRi0pL8JLsvrA/YJ8lR8v0mJZShDpZg== X-Received: by 2002:a05:622a:c4:b0:35c:cc56:6444 with SMTP id p4-20020a05622a00c400b0035ccc566444mr3792433qtw.289.1663332513630; Fri, 16 Sep 2022 05:48:33 -0700 (PDT) Received: from gusbrs-laptop ([102.129.152.129]) by smtp.gmail.com with ESMTPSA id 62-20020a370741000000b006b9ab3364ffsm5793109qkh.11.2022.09.16.05.48.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 05:48:32 -0700 (PDT) References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> User-agent: mu4e 1.8.10; emacs 28.2 From: Gustavo Barros To: Lars Ingebrigtsen Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files Date: Fri, 16 Sep 2022 09:30:19 -0300 In-reply-to: <87mtaz8quf.fsf@gnus.org> Message-ID: <877d23h4df.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 57856 Cc: 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Hi Lars, Thanks again for the very prompt response. On Fri, 16 Sep 2022 at 14:07, Lars Ingebrigtsen wrote: > Gustavo Barros writes: > >> It could be argued that it is unwise to set a bookmark in this >> context. But, well, users do all kind of stuff. Besides, Emacs >> provides no hint that this may be risky (as far as I can tell). So >> it >> would be nice if Emacs would be a little more conservative here, and >> locally set `bookmark-search-size' to 0 in buffers visiting encrypted >> files. > > I think that makes sense. Alternatively, we could prompt the user for > what to do in these files? > > Anybody have any opinions? If this were to be left to user discretion, I'd suggest a variable rather than a prompt. What would we ask? "This file is encrypted. Set bookmark, yes or no?" "Why wouldn't I? Yes." For the value of `bookmark-search-size'? "What's that? Default. RET" The general point is, how many users should we expect to know "at prompt time" that `bookmark.el' stores part of the buffer in the bookmark file and what it represents for an encrypted file? But, to be honest, I'm not even sure if this being optional is particularly meaningful. Do you see any use case where one would actually want to store unencrypted context of an encrypted file? Best regards, Gustavo. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 09:01:39 2022 Received: (at 57856) by debbugs.gnu.org; 16 Sep 2022 13:01:39 +0000 Received: from localhost ([127.0.0.1]:42104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZAyR-0006ii-JF for submit@debbugs.gnu.org; Fri, 16 Sep 2022 09:01:39 -0400 Received: from quimby.gnus.org ([95.216.78.240]:45814) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZAyP-0006iU-H4 for 57856@debbugs.gnu.org; Fri, 16 Sep 2022 09:01:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lCny8tHIGwbZeA7IpOxTKQb97dpWtNvhTwt5h8ahaQo=; b=MBPOeKGH26R4lYIfX0YuKT0kHl RR1n9fCJ/1vriI6wdkfD/PoTUCHPQG9LwwtW7o/mZyb1uO2Ad65V0kuBRZZkeLzqF8jLCqOjweHNN DcMaimlseFA0MJXWCYHkdeBQEfqeivlvRBEeHyNsZyjuzO0tgDG+jw/4IGIOGyvjaLK4=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZAyG-0004Bj-R8; Fri, 16 Sep 2022 15:01:30 +0200 From: Lars Ingebrigtsen To: Gustavo Barros Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <877d23h4df.fsf@gmail.com> (Gustavo Barros's message of "Fri, 16 Sep 2022 09:30:19 -0300") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEV9coBFLl4VFRWx raft7Ob////o4EvwAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YJEAw6MSytQPYAAAGKSURBVDjLlZRb doQgDIZFXIDGWYBkugA1WYA27H9NDQG8TOtDMwcO5uNPwm0aN/xtzSfI343+7tabo3dFoR0igo4C DgDaJYUnonnFmwUDnjy1d4AGGj/DMdFdgC8fofENlTkJNEv2T0S+7wcHhyLHn2ZnpeHwAd7wK3ku 1XrAcf8A7zVld9rOHHOqKKwYOG5u6fYDkM4JOpZoJidYrdhYrQLdKpW8D/9FQbrE6QCXHKR7GA6Q AvsSKpEDaNxRqoJm7DS6vCzFSCcg0OzSviwFZ2B+3e5UkLYWUKeeCoIupxggaKh0KbxkSRc5igaB cFcQK8jL8yWHRHWrzCJtyZ8VxDafZi7L66hWFZkTtewtgqdogFmiWA4zlo4kA/VHEpa6J50UkCQc z/MYVWUgljXr4mysZZ7A0JZPRbVXYEdkpzKzVJCYtm90VX5RAMe127/kCmYIem8DY9zr0ed11As7 icOs3wyUZxYw9Bu+UqDFbgmfz2yC9ByGcn0Y/7AElicATwCfwMOfzL/BD8VDqPeEMP8PAAAAJXRF WHRkYXRlOmNyZWF0ZQAyMDIyLTA5LTE2VDEyOjU4OjQ5KzAwOjAwprljqgAAACV0RVh0ZGF0ZTpt b2RpZnkAMjAyMi0wOS0xNlQxMjo1ODo0OSswMDowMNfk2xYAAAAASUVORK5CYII= X-Now-Playing: Brigitte Fontaine's _Comme =?utf-8?Q?=C3=A0?= la radio_: "J'ai vingt six ans" Date: Fri, 16 Sep 2022 15:01:28 +0200 Message-ID: <87czbv8od3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Gustavo Barros writes: > But, to be honest, I'm not even sure if this being optional is > particularly meaningful. Do you see any use case where one would > actually want to store unencrypted context of an encrypted file? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57856 Cc: 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Gustavo Barros writes: > But, to be honest, I'm not even sure if this being optional is > particularly meaningful. Do you see any use case where one would > actually want to store unencrypted context of an encrypted file? I could imagine somebody just .gpg-ing most of their files on principle without them really being "secret", and wanting the bookmark feature to work properly (and for that you have to have the context). But that's probably a very unusual setup, so perhaps just setting bookmark-search-size to 0 in these buffers is the best (and least annoying) way to go. And if somebody wants to override this, they can do it from some hook... From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 09:18:11 2022 Received: (at 57856) by debbugs.gnu.org; 16 Sep 2022 13:18:11 +0000 Received: from localhost ([127.0.0.1]:42124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZBER-0007AP-2q for submit@debbugs.gnu.org; Fri, 16 Sep 2022 09:18:11 -0400 Received: from mout.gmx.net ([212.227.15.19]:45609) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZBEP-0007AC-Ot for 57856@debbugs.gnu.org; Fri, 16 Sep 2022 09:18:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663334283; bh=gYfBRzPhhA8ErzGLfytt0EbM55zF6kvmK9V0bUfgiVY=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=MqcDaAUdwOcZ95KwAG1j41o1RaeCO/3ai0FSRDGmE7NR7ILuVNMzvSfRAmg3b2Zi+ +e4Hue/YLoJXJ8gtofwiyvrtPSsTlYyDz3VTfCWq0Ch/l20C5kBz7EbmNXr+6kG/r5 RdQmuPRYLh18to47zPn88VHOV9ZhSU6KOwifz1RQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.151.147]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MEm6L-1oXl8C1RO7-00GEHV; Fri, 16 Sep 2022 15:18:03 +0200 From: Michael Albinus To: Lars Ingebrigtsen Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <87czbv8od3.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 16 Sep 2022 15:01:28 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> Date: Fri, 16 Sep 2022 15:18:02 +0200 Message-ID: <87y1ujsbjp.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:AU/oCEmr1X4PHcf3CB8jfJZzCmLWcfS+Om5I5/e1m5uUH/Ocr7X sBQ1sKdy7CIHnyEeXUFY5vXuG9jFkYeOydZi1ZI8jVPnk1gtmIeZKJEizKZ06TjzW4k7G7z zebQUPlgp93H+Kfsk9AwCok4tb2PsULmTJSvizSCo5b6FgmSRXdE8XhlrEJpAwFJ1fCitn8 pZzpevOpESpj08kUgKXXQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:A5yNrPUlhM8=:I2lplHtBowH+AZjNajZBpQ /FJGOT1DJ4xLVHsL9babsk5MrnFakHyesaGs3IQFWu7pWSv4klJ/9wSjFBKbG6yDn6gvcz27Q D0YzRMnKXKLFmSGpINLBZNPSJuIoXJtoio5TG4+a0hO0DqzkssslJLGDuOAsY/vP0zXsQiPej FeIdN28yLhUUCUY2csaO4nLB1pbyJtUxNGnfTUCC2h11j+N1Nnur0Ja6VIEFBuQtxDj/LUHTq S+v/3rER2K0FhfSsybWuer9mi/aAd3BOYL6/hSGsvOLrO58rPvI/vva6knijHoDhHC3h8xoOG Tbxc2DBqauwgjtyL1roI2a6xApaWzWFXstI5KdkRrkzOAEruGcV4lIjpPMvQuMTC2BFKOxpv8 3zLZnVGqvIdArfgaVb+yHjbvOOyi6b1pPo8NdZIPGGTaR0dUbF+ppvzRkGItNor03q4qpXmlP EtdrvyXjbjcIxZfn2SysWu+fE/Ol/vSY0Za05CNMi7sHgy5B0j/FSeWD71cNZWVkptDQnth2e sccgu+JAgJ+x+BWFcY36rv2t9pgS6bvc/ozNDx0ZiU/esfMSuXq4zbNxgcunt5mscFB6uLCBn KefgOH3KbGcKz65wWheUtRDPu+rlpIWtsCsyc1VsWMt3v9evvfea+xhQpoDhQQJcUgtqsVlVj WY2E+x31AppwvE4BVU66duu3R7BXdX02iEtEm1QzLsspgeN/eBKu1JN8c0nqo29zsZ0m+Wcre Izm3xCRqjApCD3sM91V2tmQBaxFmLJokgTho7DlW3n9jQjW11E2E3mIseYDjU8C8SUG3PDHmn 2OAIg+paCgWBXQOj10VcEvn3zaVBoRf1KpGU+RrHKZT7ck1G1lIsKxWxhx+Cl/cFpZB4ddMQ2 hgyQ3gkLE+RdknWyJGAz5CEKzcZ9Q0jC9sGnZceJpI+HYEHtAiR9FTFylq/dmRXb5mXr5qXIk zU2v5kfTB1Hw8MvYcWfJd9+g3K6ZVnsBtB86ApzDe7VpKWAv+7EZgd4/73naawPUeMo22iEbJ hy74s20ji0g5rI23q7egqgIrypiXD+5WKmsPfEGtPkRqbwdgwyc6ySkSF7quj3k8UAfOwJWNu 09ZRQU/XVvrqqCmQmUYiA4XlvSWS8anLQ9s7T1F0zIGLy8Ubo+Om/QFg4Ve4ALyxPkPoStUef BixTJsDse8bzH5Mt05eKaz7eBy X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: >> But, to be honest, I'm not even sure if this being optional is >> particularly meaningful. Do you see any use case where one would >> actually want to store unencrypted context of an encrypted file? > > I could imagine somebody just .gpg-ing most of their files on principle > without them really being "secret", and wanting the bookmark feature to > work properly (and for that you have to have the context). > > But that's probably a very unusual setup, so perhaps just setting > bookmark-search-size to 0 in these buffers is the best (and least > annoying) way to go. And if somebody wants to override this, they can > do it from some hook... JFTR, there's not only gpg encryption. We have also tramp-crypt.el, which let users encrypt all their files on a remote host. Those files shall be handled similar, when it comes to implementation. See (info "(tramp) Keeping files encrypted") Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 18 06:20:06 2022 Received: (at 57856) by debbugs.gnu.org; 18 Sep 2022 10:20:06 +0000 Received: from localhost ([127.0.0.1]:47848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZrPB-0003uS-PT for submit@debbugs.gnu.org; Sun, 18 Sep 2022 06:20:06 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZrP9-0003tq-4W for 57856@debbugs.gnu.org; Sun, 18 Sep 2022 06:20:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Sq1VQDIfHrcGo0yzfL0IJyH7wgHLMPVitv8EdKMnEpo=; b=HybwAoFMzWbA1KxFOI+BKNVp02 7fOKfjRlepWQedQuP0esbpeiQk6UNLvlI878nz7xNGONmIlm0cUkqU6jpJAIFfdTRTc6NvNtsTE6N vEeoRkNLRUJsOjmP6O/veQ3YwNAvO6RL+mEKVXKYvaqe/RwbUKArseadpu+RK1pYnkDo=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oZrOz-0006eI-45; Sun, 18 Sep 2022 12:19:55 +0200 From: Lars Ingebrigtsen To: Michael Albinus Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <87y1ujsbjp.fsf@gmx.de> (Michael Albinus's message of "Fri, 16 Sep 2022 15:18:02 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAFVBMVEUpJykfHB1+gIG0 ydGuubtOTVL///+yPxuZAAAAAWJLR0QGYWa4fQAAAAd0SU1FB+YJEgoJFD1GRbgAAAGpSURBVDjL bZNhkoMgDIVJd/kPzngBZC8gnAA4AGvN/a+yIQTFzjotVr6+9wJEpf67YIvK8q/6nL/Bh8C+ozJP AiwAAtbM84ZdLVvZKcIqbKMAq4YIdOV5C5mBHTEaVX9eQwemW8HBd3peBgAzAZiAWCGK9Cvs3ZNC KWfFUd0mCtJoZeAgBcVDvQF5aTA/BEiL7gYcUJXmm3M1xwm0RXAByWMIfUvMtPX6VZLPYdpELd+z 7KUBGKD2YXU+MaATgOalRaaTc11hJyu6XgRymIFcL+dcaIBLMmPbK5zkxOASYK0EFIGNwVVt21oa HGc3q94ZCmlS6Z/DcXa3MsD2DR8NSEY7QF4aCRQ+gORgO44jXVZXk+BBmjM5H2n+AZBBaU6lZ1xr qXg6zxGiGCuvuDkfwhU+Wp5A8SXnu1y4GotOr82H1K2gH5fG185ORcAoTNeDQMxU2N273FuoYzPi E+T/g7FiJiDuo0WlWZYOSpQMIwf8+9651lsxXoWcAlc7XrUB1uyoVPrkW2Fbf63ZM7iqsrJjS/Qc 8QSEFlpfblYfAL5T39tPYLcb/AENp3EfHoqI2QAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0x OFQxMDowOToyMCswMDowMCsFq2IAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDktMThUMTA6MDk6 MjArMDA6MDBaWBPeAAAAAElFTkSuQmCC X-Now-Playing: Stephan Mathieu's _Radiance (12): Pacific_: "Pacific" Date: Sun, 18 Sep 2022 12:19:52 +0200 Message-ID: <874jx56l2v.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: > JFTR, there's not only gpg encryption. We have also tramp-crypt.el, > which let users encrypt all their files on a remote host. Those files > shall be handled similar, when it comes to implementatio [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Albinus writes: > JFTR, there's not only gpg encryption. We have also tramp-crypt.el, > which let users encrypt all their files on a remote host. Those files > shall be handled similar, when it comes to implementation. > > See (info "(tramp) Keeping files encrypted") Right... switching off bookmark context lines would go into `epa-file-insert-file-contents' in the gpg case, I think -- where would we do that in the Tramp case? From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 18 06:43:32 2022 Received: (at 57856) by debbugs.gnu.org; 18 Sep 2022 10:43:32 +0000 Received: from localhost ([127.0.0.1]:47911 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZrlr-0004hV-Sz for submit@debbugs.gnu.org; Sun, 18 Sep 2022 06:43:32 -0400 Received: from mout.gmx.net ([212.227.17.20]:51449) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZrlp-0004h9-2D for 57856@debbugs.gnu.org; Sun, 18 Sep 2022 06:43:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663497802; bh=kACv38Sn/LPa2c6JjAchirhwRzcWYkb/5uIX6OErAvo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=T9l2d2jD3/3To6qq5JRyvS5dD9BeYIprH6anj5FgIGKNFtOG++ZaBB6sGO/9sJBt5 qV37Cxi6S7kEU8hXqmoRWKO5u4mUaM2KkBcggD1V1KuGF1sqRYQDn+y81UGjOjPFRT nSEJ5qbh8IO5jsUIFxKOyrKi9XxUcRNJEcWbmrDM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.159.44]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MfpOT-1pFnIO48Iz-00gGdJ; Sun, 18 Sep 2022 12:43:22 +0200 From: Michael Albinus To: Lars Ingebrigtsen Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <874jx56l2v.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 18 Sep 2022 12:19:52 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> Date: Sun, 18 Sep 2022 12:43:20 +0200 Message-ID: <87mtaxx8s7.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:dJiFqfZbjmm2M4srHqDseVEehjsNiREwgtqkzoNBOdrC7OuxDjS 1Gli3PQ6jc9OcTCsxcLATdpFGLg3F478hS0qWW6hxBPinbzEMKB1+KeHM03o1yJd+paAy/D DO8YsXAdZSkVJB7JE89b53hZlhY60kLArB1PJrJalOc0Yjl7ET5hU3MU0DBqCpE6gtkV4/a gDLrtlzKvtXHXqotqAHew== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:UdXvifVcPWM=:MT8Q4nGkZEyu1hpL9PRemd HNPhTYSgT87fvJoeHoBfAv8iFj/h/UeJeoj64cvnYKIgoZwb+u3mfI6wxb4382dIM/qL9QwUp efzob5TGboVipNIYmKWqZ53YaQ89HVRq2rZk0UQj+mpqYv2WLtXR9+tyB38Ftd8Kk2efDWeUO fVFgrqPKfehkJqSOer9HDLGCex6WdDybJVnHBRSjQVPXFXXTLLE5bop95eGeRe7jdN+ZcT3Lo mJhhhD6rsms4pKE8BzXBrdxlNBIWOrYQw5P1kJ1Q7lExjXsu+gtqYlurNkDhgwoz62CO9/4XS CTEaHUDp/q22Xh6UeinmRGMn4ZC4Dh4YCZHiSvKGn7xrDYkv38a55VplkpE6ZBp9r3WrIAbfe zRtfckrT0B54ufiwIpX8r7+yCKYjujABCmRHuQwxwPdZLmR4Gk5hvib5GXU9rFQJnHlAmxhut TPn8lqRXngfmN9NHFeQrUlzaWX3twhFn5Y3v+XlbjC53xG5Ocpb+lCyQhsQ9wcv0Bo659Zhh7 CKDkmpEFsVEaIqg9akvG76Q+Bsb7HEQKz4ClRpThhxFtWDwXPaTC/0klMgc9a4+d53Wk2MKbI oGqg4JsUzL2eS7b0ha2iQJ10jTciTqQ7ZSQ6iViIWV3//cgAGpJ2rdhsh+yCGK3IpQQvB/5zo 5PCF/57fIcgH2n/pOfVv9oPDObJnoeJCqywO2Jhuh/Vy3gdkIYrq29q2h9GFqZ1scgifSdz1o 2yL8UE4/XrXtln4cA3SCydHDUTwbEaxEAnw8yNoWK98/NWaFPV3ZJMGG6Kn9li9GCkhiMV3tP E/1k8+b6m5f0eEfa2KIDdI9zMz3drUPW47xFR8sCkenQN8g2sHOdU/nYD9PnAaINC5rwePzS+ ddB5XhQMiIwVayoWpusMz2fyFvk3TYoFXjwaKP3o+PFiErhQ/VRgZk+agOHpqTUMfjIMB26aZ plf6/7ARj7/kI8Xm0a+OotdSAxXMWH8fjrYKVDzqlWvT46shzFKvCJ6waaxQuq9EXlp6VeEYm IWrc+QL5y9K7KnSBkybPvlRn9RpUpQxr3wEbp114N8PC5P/3MPJlzBuaBHarScx7k5JyIvIHz E9FoYVvq3BkjRsNDGn5DK6zv/9DHqQ5zs6N+LRR7dr80BV5CVVs63AfhvAB3M0Lmx3AOEyJEE 8juC9uqGjxMoIEEAc63fRDmQrh X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: Hi Lars, >> JFTR, there's not only gpg encryption. We have also tramp-crypt.el, >> which let users encrypt all their files on a remote host. Those files >> shall be handled similar, when it comes to implementation. >> >> See (info "(tramp) Keeping files encrypted") > > Right... switching off bookmark context lines would go into > `epa-file-insert-file-contents' in the gpg case, I think -- where would > we do that in the Tramp case? There is `tramp-handle-insert-file-contents'. Since this is used for several Tramp backends, we need a check, whether Tramp encryption is active. Something like --8<---------------cut here---------------start------------->8--- (when (tramp-crypt-file-name-p filename) ...) --8<---------------cut here---------------end--------------->8--- OTOH, this would expose the "tramp-crypt-" namespace to tramp.el. Hmm, maybe I will adapt the solution, but you could start with this. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 19 03:42:58 2022 Received: (at 57856) by debbugs.gnu.org; 19 Sep 2022 07:42:58 +0000 Received: from localhost ([127.0.0.1]:52154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaBQf-00051C-VV for submit@debbugs.gnu.org; Mon, 19 Sep 2022 03:42:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47196) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaBQb-00050s-Hy for 57856@debbugs.gnu.org; Mon, 19 Sep 2022 03:42:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QT8mLIaeDzhA13yinqgfLudelNtaggTGBZdr+9lfSVI=; b=Uliq+syKUgvApE2Omwhe7nCgZ3 LP0LLk9foiKYjsi4zmDR5unOU/CUWTCo5NA+X3X/67W+o0LqObh7yIAhkUgGsATp68H0wGkaEJr3S MWR5vIUXwMyFzvMgWdS7Uakl7XltzDyCoSpOCFFjx6t51JO0sorvPM4U57kD6F7DAaIU=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaBQS-0006pZ-Tb; Mon, 19 Sep 2022 09:42:46 +0200 From: Lars Ingebrigtsen To: Michael Albinus Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <87mtaxx8s7.fsf@gmx.de> (Michael Albinus's message of "Sun, 18 Sep 2022 12:43:20 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEX83Lr94cKsqadv QmL///9urP2wAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YJEwcJFfolgRgAAAGBSURBVDjLdZSNlYQw CISDNgCxAQMNeKT/3m7Ij/HcPd7qc+eTZEKIKX0P+lD4PzBC3iMIL8AzvQn8PQOAFpDxSIkoMfGt UbuUJQkxRY6I3M6yUtNZSKSDHsePIvaiXZe5JD7cVLOplRuEQ6LdzVxN68pow3FRAH8BTrRBQgZC JmhVoN2KqSPgema0ZeyqVr1atTVUENorwuNWnnYpHXXGI6O5wvuRcPwFmigMmRb2k9MNckUNMa+i XvlUXwBvV9eqXnTD4wIeXq0C6Wm2wFYsEvCrmOcJrvBkbUCU5p6DMZJDgoY1ut92uXq2tnKN+7Xs 1hp6Y0gpiRaY4ftVC62Vj5etlly2ZzPki+HzzGdsBi6a+0GjZ6TrA7R2xY3ogRoIcfxdMZohvUHb b8ZBWBLz3QxoY/mIBehzjgAphn3yfohEsA3oN/XZ0z0DK8Dubmc0xCOD4ih9nbz561VZvttB/OJ2 zNErFK6iNiny0l2NKCVczC/EOPZzZ+j9ZRAaAk/wC8i0SPbmcZflAAAAJXRFWHRkYXRlOmNyZWF0 ZQAyMDIyLTA5LTE5VDA3OjA5OjIwKzAwOjAwZRHd3QAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0w OS0xOVQwNzowOToyMCswMDowMBRMZWEAAAAASUVORK5CYII= X-Now-Playing: DMX Krew's _Sound of the Street_: "Emerging Technology" Date: Mon, 19 Sep 2022 09:42:44 +0200 Message-ID: <87leqfzu6j.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: >> Right... switching off bookmark context lines would go into >> `epa-file-insert-file-contents' in the gpg case, I think -- where would >> we do that in the Tramp case? > > There is `tramp-handle-in [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Albinus writes: >> Right... switching off bookmark context lines would go into >> `epa-file-insert-file-contents' in the gpg case, I think -- where would >> we do that in the Tramp case? > > There is `tramp-handle-insert-file-contents'. Since this is used for > several Tramp backends, we need a check, whether Tramp encryption is > active. Something like > > (when (tramp-crypt-file-name-p filename) > ...) > > OTOH, this would expose the "tramp-crypt-" namespace to tramp.el. Hmm, > maybe I will adapt the solution, but you could start with this. Looking at how to integrate this (which is always iffy when we're dealing with several packages), I think this has to be done the other way. That is, `bookmark-make-record' has to check whether the file is encrypted or not, becaues `*insert-file-contents' might not have been run at all (if this is a new encrypted file, for instance). So `tramp-crypt-file-name-p' is perfect for that, but there doesn't seem to be any `epa-file-name-p' (or something equivalent)? Hm... OK, that was trivial to add, so I've now done it this way in Emacs 29. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 19 03:43:03 2022 Received: (at control) by debbugs.gnu.org; 19 Sep 2022 07:43:03 +0000 Received: from localhost ([127.0.0.1]:52158 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaBQl-00051t-A3 for submit@debbugs.gnu.org; Mon, 19 Sep 2022 03:43:03 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47212) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaBQk-00051A-DF for control@debbugs.gnu.org; Mon, 19 Sep 2022 03:43:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uhkWRcTJbdB+bMdPKayPxKYS2ZFpyCp0rACQcwQOTVE=; b=qJ93FZP2dmZJgsxBBDsoCt/KEE PHSS/jIfibczZ12FBfTTtWndWRofk9GcpFe92kbWGbvx1A74qRXUERJ4gj1QCDRmfwwQXmxAdfqTI sSnfljFqpVk1Fj2ADPZpIu1cRvCbzPyJ7ktdxuxXWt+kqxctogvRtUb51Fi0MW1OJpsw=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaBQc-0006pl-Et for control@debbugs.gnu.org; Mon, 19 Sep 2022 09:42:56 +0200 Date: Mon, 19 Sep 2022 09:42:54 +0200 Message-Id: <87k05zzu69.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #57856 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 57856 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 57856 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 19 05:00:17 2022 Received: (at 57856) by debbugs.gnu.org; 19 Sep 2022 09:00:17 +0000 Received: from localhost ([127.0.0.1]:52387 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaCdV-0005Jn-3X for submit@debbugs.gnu.org; Mon, 19 Sep 2022 05:00:17 -0400 Received: from mout.gmx.net ([212.227.15.19]:38067) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaCdS-0005JV-S1 for 57856@debbugs.gnu.org; Mon, 19 Sep 2022 05:00:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663578008; bh=bKUqlbnBTdB64paCXfdEagx+pS96szsKc6yTY/moRHk=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=hw+8JazLpf/ixueHk7vp/hCBYpsaBG3y4bkusKqhecN9cEFMsqkVqKjcNXuYOAivB LinYv4FLzRqQ4g9M0fIUqyogIcpxzHOQ/XScFTtJS/FEmRR5k1gTsOtdwlHfTjEfQt 9oaI2ixSBD/O+y7RFb4o9JbVaMDjRb4LpiBAKiaI= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.159.44]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N1Obh-1pGz7z0M6V-012qRR; Mon, 19 Sep 2022 11:00:08 +0200 From: Michael Albinus To: Lars Ingebrigtsen Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <87leqfzu6j.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 19 Sep 2022 09:42:44 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> <87leqfzu6j.fsf@gnus.org> Date: Mon, 19 Sep 2022 11:00:07 +0200 Message-ID: <878rmfkaco.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:0A3lV4TULm7n98YnB30ZlDbhh1V3pzuArmmrxUcfaER8KgfGrIC YdYRht+ujKeI6dEiOcdtcnU2ed8wT4Slc+zrIXkp0S14SNo5yvZJhU30AaFo2vjpnuiiqsV uwrCvbMj94I6lvIs/d/JfosGod8mqOsAsjBJ6JvEvQxQPcA/daI22+YXv0ptqxKtbeO3/pH 0MpFkI5NFuxC/26int73g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:yiLzfo9N/+4=:y1ZpKuAUuip2rrI27Qb5UA x/7fYzEt6VLus7MiNpwMWI8QHU5rFauhWmQllcffsh/lmGzhmvPkY/aijGRx78NZmUXZCMzr/ 0xoSDuQrEn+hyGZAY/VqM9haXTdXIGsqLNqEsJyFa6VgQAexB6gSWF6mFvRVGkinL7/294eZE 3icAbdFoVr5pQWctf8mAi+kFoiEuJQ1M7pBb/DuXnNXB4yAhO1EmF0hTdOQbLIQOaPv52VFu7 bztkQi5uED+Iwb/KpnCtFgUCFstf1MccVIg9x9iz2PTx53ZeCLV2a5t0wd0O3+X3PUPdM07q5 FjMv5fc0Voam/u+pUVCXWP8Tz26kOhvgk5kcItPSIOA3YD+oZ+TxHdVygcKaCrCV6E6ObnIdQ K6uiAU3VZR761spu4xoDRQNEoSDNLFkFUs/imAs5NfvDsHPTKmwZ/fm8WatWn1QpbUxM0DcMH 2GTEv26G8r7aAubX5WeRFf4Lwnr5F2+c5bBXweb9OQ9mhrK4yozZV8xiMFRtlFL0xLNiZ8fjl uHab0uywSety+Jmy1EbGweKpDQy3EpYOpnVqlrp4TxUdnqUPQRhrOpDgU6fU9aFmfwjPKCJH9 6oCnKYVhN3fgOlBcW4S0GMgX1ApzhXaVOh9uRpQtlfjQwRexoKPauFMqEseZuDF/Y/vUqPnd1 XNw77e0UapkX34Q9UlMsvvH6939Xh8k9e7EGaLnA769N6UtVqi+6AAVd7KeQUgGg2xOmYP3Hj TbBGQ1V0UI0DvZ7Vetn5gDpMkE07xSMScrBfOOZnu3fvLCuHhHROi5RRwlVaKxj3j629wiDKy dTEED/P7njHmtGr+ha9Y5H0Vg2SFO8l3DU4lhzL+RXEllm7+LDWf/Y2QZxO0LT4xxwhJYNCan v18RNcCq2DU5L/euzVRfd6cSfmq4K/3pjqcNbjDI6kXVJ0bKsaxSh32qeHXISanehJZbDWMcC dVTHyGD5mVJE/gJ6j0v+8UCkTLtzo1VPeWB0q3zCOwq1gAL+vR/dkBPUOywXm8yvg9lqVfCDs gbmYZT1TM4tauHH0bbN2xS96U81uyKqhkKy/KbHIbpfL1GOWcMvmtsk3LIf3KS6d/ZeCWzL1S StHFsiPErvTRQguUwmLrz6fuQKFHF2wYx/m4xde5WYA+ELjiSPjtRKO8Io+6qLXfg/AIgeI6n IBUe5S4lVEbBvhOReJpaS5RRyd X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: Hi Lars, > Looking at how to integrate this (which is always iffy when we're > dealing with several packages), I think this has to be done the other > way. That is, `bookmark-make-record' has to check whether the file is > encrypted or not, becaues `*insert-file-contents' might not have been > run at all (if this is a new encrypted file, for instance). > > So `tramp-crypt-file-name-p' is perfect for that, but there doesn't seem > to be any `epa-file-name-p' (or something equivalent)? Hm... OK, that > was trivial to add, so I've now done it this way in Emacs 29. Thanks. Thinking further about, there are also other files which shouldn't expose snippets to bookmarks. Think about .authinfo / .netrc (more general, all files used as auth-sources backend). And perhaps other files. Wouldn't it be better, if packages like Tramp, epa, auth-sources, you name it, could mark files to be excluded from bookmark-make-record? For example, a hook a package could contribute to. In Tramp, we would run (add-hook 'bookmark-inhibit-bookmark-hook #'tramp-crypt-file-name-p) Similar for other packages. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 19 07:15:56 2022 Received: (at 57856) by debbugs.gnu.org; 19 Sep 2022 11:15:56 +0000 Received: from localhost ([127.0.0.1]:52563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaEkl-0000px-Vx for submit@debbugs.gnu.org; Mon, 19 Sep 2022 07:15:56 -0400 Received: from mail-qk1-f180.google.com ([209.85.222.180]:46817) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaEkk-0000pj-Lv for 57856@debbugs.gnu.org; Mon, 19 Sep 2022 07:15:54 -0400 Received: by mail-qk1-f180.google.com with SMTP id d17so19415803qko.13 for <57856@debbugs.gnu.org>; Mon, 19 Sep 2022 04:15:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:sender:from:to:cc:subject:date; bh=rG0GTktLBFM0tbmUUbNa+CwTKG8fYokQQa161INojYk=; b=mKyMkRu8akseUvR/o3m+k2rYcJzeu9yWi3aKzga6mEv9B+ihTNjGRulzMMdcMrZOkL w7L9jm4sJHMWd70zPbjPYCCIkfjMzLnwLMg1l/c3qaAFqCS9AeaFCLL5NIO3VoMKukUy khL7x4nILFtOdJcy3zcJH04h2pzcoGihN2WHiwJIMERgYpcTztkSfDbBa+lOBPip5SID Vyj+YLt+VkcozBm3QH0P6uHPy+eWT2+kb3JiL7c2Y7FCYu5hJRHN/lSJUGY2oALS1qG9 zms6fb88zdT8P+mmsy7YrkyHhTXysJV3QAwhXZrP/AZhZVcpyv6bw1I+I5iXUHqF9waI TO5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:sender:x-gm-message-state:from:to:cc:subject :date; bh=rG0GTktLBFM0tbmUUbNa+CwTKG8fYokQQa161INojYk=; b=y17Fozl+uKYK+MG4XHtyGVVSU9nyBDlkkL9T8Ac/v+Myhu2cTtdTJF5Z9CH0sGPBrf snUkLONyrpESPHfLV10DasKlCLYqLzBPcMXhAr+adpYB1mFb016NLxQqfF+uyzG1PtEF zgPQpzPB6bj3acaMgG0hHoYF9n/Jf4CXO5bryC+Owukv2TvURbSK+xBGebu201FRtPL+ q1MbrSjEgFCFjLEAxQmfs7duKo7TpA+/aiuAbPLlR7HP/XgEcjlKOeqtkc9kZ04N7MWA SnhIr5WaO2zJh3nhQJto3YrNA0mJD50JESrOuxEIdF+nnvjlCQ3mdu9tQykSbvY0gDZG WnsQ== X-Gm-Message-State: ACrzQf3kve2gxoFRI/OWL7rn3Fen/ns5b0LggE0TpFDAx1REVuoKMw1z 0eQTJboEQgOrvJouWfeDdmzH1c6nLucqXQ== X-Google-Smtp-Source: AMsMyM5g41FEG4jSkMfbfaEsjWyPUZzwfajmtQo8AnxQ7jGG9HQCGBbLvPU7U93vJuy/fuBRsZCETw== X-Received: by 2002:a37:6456:0:b0:6cf:135a:87f6 with SMTP id y83-20020a376456000000b006cf135a87f6mr2440159qkb.227.1663586148834; Mon, 19 Sep 2022 04:15:48 -0700 (PDT) Received: from gusbrs-laptop ([102.129.153.23]) by smtp.gmail.com with ESMTPSA id c3-20020ac87d83000000b0035a7070e909sm10972065qtd.38.2022.09.19.04.15.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 19 Sep 2022 04:15:48 -0700 (PDT) References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> <87leqfzu6j.fsf@gnus.org> User-agent: mu4e 1.8.10; emacs 28.2 From: Gustavo Barros To: Lars Ingebrigtsen Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files Date: Mon, 19 Sep 2022 08:13:51 -0300 In-reply-to: <87leqfzu6j.fsf@gnus.org> Message-ID: <87a66v399b.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 57856 Cc: Michael Albinus , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) On Mon, 19 Sep 2022 at 09:42, Lars Ingebrigtsen wrote: > Looking at how to integrate this (which is always iffy when we're > dealing with several packages), I think this has to be done the other > way. That is, `bookmark-make-record' has to check whether the file is > encrypted or not, becaues `*insert-file-contents' might not have been > run at all (if this is a new encrypted file, for instance). > > So `tramp-crypt-file-name-p' is perfect for that, but there doesn't > seem > to be any `epa-file-name-p' (or something equivalent)? Hm... OK, > that > was trivial to add, so I've now done it this way in Emacs 29. Thank you very much. Best regards, Gustavo. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 19 08:03:13 2022 Received: (at 57856) by debbugs.gnu.org; 19 Sep 2022 12:03:13 +0000 Received: from localhost ([127.0.0.1]:52605 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaFUX-0004Fl-8i for submit@debbugs.gnu.org; Mon, 19 Sep 2022 08:03:13 -0400 Received: from quimby.gnus.org ([95.216.78.240]:49866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaFUV-0004FY-Bc for 57856@debbugs.gnu.org; Mon, 19 Sep 2022 08:03:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=QY0XhuthmFME/0TnPRQ2eCpih1lDlPHMYD0w6maAfc0=; b=uyT1D7zAvrWIz+0QmbWhLCHqid BbDl3ALnLzmpob26NBx43dvVWWskW60yovmb2fV0K9Xr2wJaaSfn0++NafmdGGim3YdSKPThVEGFW a5Cvzpc1wxoZVltrQZzTfLYN2uhn848qdjjtqLZlHeb4XLTIriAw+3NaLdltT0OD7KdY=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaFUM-0000Dp-SZ; Mon, 19 Sep 2022 14:03:05 +0200 From: Lars Ingebrigtsen To: Michael Albinus Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <878rmfkaco.fsf@gmx.de> (Michael Albinus's message of "Mon, 19 Sep 2022 11:00:07 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> <87leqfzu6j.fsf@gnus.org> <878rmfkaco.fsf@gmx.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEUXExBSPiumc7Wa XlH///+spZNTAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+YJEws5BEbJbn0AAAFkSURBVDjLrZNRooQg CEUhNwC6gSdtIHP/e3sgatZMf+NHJkcRLgjwk8Gvi3VEegHooBZfoE0FgloN4CmSfZ+7t+12SRQd NEG/nZDNLvsDAPLZgBweJNpsH45ub7cYKA4Yu735WtIajtQVrSDIMVxZEjzD3QRkAallC+HQFA43 e+5putokm6u9S5bWy2MPFXABzATfgP2yqmJZswl6gSB7ITg94Qu4n712NXi5XEFJkrFnxtNVbBIR tkougILIjAPx0opVw7HQkl0AmUvKY0W0ys7s5W5lXduMOebZfLf+w9TK3c7cGxPP/TtQXah35bOV Yx2pPADu3rsdLOdy1cKoph8nBIttZ3zahewE5LsrObPJoY46sLdh6mgahDeQKtdaSauKxdxPgLUm 1k7b/lQxWIDJ3p7fkORwE9lr4qAkdGlmYdtUq2be/o5ZMd+nQsU8w1cnGqO1KKTSCskfimisY8Dr +AelXyYxJcVJ2wAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0xOVQxMTo1NzowNCswMDowMIEP XOkAAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDktMTlUMTE6NTc6MDQrMDA6MDDwUuRVAAAAAElF TkSuQmCC X-Now-Playing: Jay Glass Dubs vs Guerilla Toss's _Vs_: "String Dub" Date: Mon, 19 Sep 2022 14:03:02 +0200 Message-ID: <87mtavvafd.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: > Thinking further about, there are also other files which shouldn't > expose snippets to bookmarks. Think about .authinfo / .netrc (more > general, all files used as auth-sources backend). And perhap [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Albinus writes: > Thinking further about, there are also other files which shouldn't > expose snippets to bookmarks. Think about .authinfo / .netrc (more > general, all files used as auth-sources backend). And perhaps other > files. > > Wouldn't it be better, if packages like Tramp, epa, auth-sources, you > name it, could mark files to be excluded from bookmark-make-record? For > example, a hook a package could contribute to. In Tramp, we would run > > (add-hook 'bookmark-inhibit-bookmark-hook #'tramp-crypt-file-name-p) Yes, that's true, but we don't really have a way to define auth-source-file-p except by heuristics -- a netrc file may be called anything. So I'm not sure how that'd look... From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 19 08:16:58 2022 Received: (at 57856) by debbugs.gnu.org; 19 Sep 2022 12:16:58 +0000 Received: from localhost ([127.0.0.1]:52621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaFhq-0004aG-Bt for submit@debbugs.gnu.org; Mon, 19 Sep 2022 08:16:58 -0400 Received: from mout.gmx.net ([212.227.15.18]:36145) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaFhn-0004a2-CM for 57856@debbugs.gnu.org; Mon, 19 Sep 2022 08:16:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663589808; bh=AgqtXCh7a91hrAaUrr8SvDQjLD8eemJXdpne/zYb98M=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=MVFAKHQQ+UCBw9ZC2znPWOHm5eIlYU5qdoQvU0peb26O5hwcOvY5wfxCqVaaWipDf sYWUfINxUTCDSe/JN8cd2oZNgp1uqavvJF7ce/YO5rhJfhpHYPqJ3CsIvfueXha2nK 38I65r+ci3svVdt+VOEeTfd+0CvBLaM0MqGZC3rE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.159.44]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MfpOd-1pC2ED2Q9J-00gFLd; Mon, 19 Sep 2022 14:16:48 +0200 From: Michael Albinus To: Lars Ingebrigtsen Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <87mtavvafd.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 19 Sep 2022 14:03:02 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> <87leqfzu6j.fsf@gnus.org> <878rmfkaco.fsf@gmx.de> <87mtavvafd.fsf@gnus.org> Date: Mon, 19 Sep 2022 14:16:47 +0200 Message-ID: <87zgevimog.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Tkm9icbU+qzGUvO1s1sit3KRlpPCb32wwML7OevHWgWU8OOFwPv +mrhVLP19XB+v/PCZtHz3NH5DuCK6poiLsWWnoByHI4weh/iOVOG7hIIlnzC5irD3RDBUNX zjUSqaczejbQ6GZl/0I81Ql3zv8IVjG9Ea9AeBz+NAREfH+4zv39qvSzq/fW9S4YEn7ZJGm h8S05Flls5MELKrrICCtQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:js65KjivFYU=:4ZXTrNR+fF3xdfj5O82bNK cbT6FxTBG2LURxgm8iaBpOsSvZe/uT3ZrJWafPzdAiCey3qhU/2gp1GIoszj0u4pC/Ysi42o2 ilTHZ7SOLwoaOsXuyzeaSfOkHKFO6wEeEr2WNsRPCqmZk3YqA00tLUlLlJ4ktWZBueyknrHYL g0luS4XhLVpldt60SgLuCReOLA07+6wL9xg281jOZy2gEYGSPN3bqkDu8aSQ81jvyE7uiVXux rZ5pLw81CRfYpiM2tRFbj9ladvrOwMl0kR1b1OJlf3MiUnjvjFpN19UPe84A+ecsr2TmTx7Km LXTs1cSXnc9TV1RK6UajeWg8A7wN/26lGbcrOQLidI4d1aG7nq1Hyjo+RQ671YagIYDQ3dAU/ sC/5/X74Pd6bb17KP+tSAfwFlxVw8ajSxQ3+qO5OQAS9CxOWSk2e3jaBG2Sz/OfTzfYsxhTt/ Z6/x8FlB14lBc+zSyCVYNms1ra+zSfxxUNq1Vj/skSl5O8lqMB25XwzKwryFgZGbS0DcnbylO an7zaQgF3NEEX5RlxUdjlvxwhJ75kUEgntHBM2qwVM8iclGOON50frfsMDpLBdDGd1vMxwK6p Yqb29GZAo18BEjbkfhVrUYkP3d04QYZFV1f6imLh/WT5kB7ajGD72AcS4vuvgLq/MqCRoI1ad owxEehCrRSVhzrdau2Fhq6s2UG8ZLSWbHJJ2y9pdmEytqmTd5wjEcPRBYZaCdKsbHNqaeWFhY T88fnG2KVP6EpI0gjzZhCgCENhwdiop2YJBzukNtscdlNzS0UO57GJ/zzB5eIROd5FOsJ1W4C rML/gqj7loBr9X87j+lUWE7ukXco3qMWM88JOhdDWXwfFyFdj8Iuhw7Op0gCQeBr+kj+tpwcC k1MfYbhZGxLRsNWM0ZqPfFfwdjc0RK/QbcFw48GlTIwF5g/OTLVcer3Xu6hR/DxrxFNTyww0s 1PSi5sVSKLqF2Pu9Gj3L70h+ekRcPorlNQDC3yr3hcFlu5BbUoBGhjc+cTYEv7OqwPomjNSgX y1bqm4IqFu8YV9193NpmN2IFM16ndgi2G3zM1O5qVmvorhHczlCOcILmshPlRsVTCTgZxVrsP 84dkKTGC5A+EBhOyyyuEITzbE/rjdUb2SeIw877Df94zUphW0Enusg1MOclDS/9MBdj/MBhVY dKsOLihoLi1s5fSuWG+fkNZLC3 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: Hi Lars, > Michael Albinus writes: > >> Thinking further about, there are also other files which shouldn't >> expose snippets to bookmarks. Think about .authinfo / .netrc (more >> general, all files used as auth-sources backend). And perhaps other >> files. >> >> Wouldn't it be better, if packages like Tramp, epa, auth-sources, you >> name it, could mark files to be excluded from bookmark-make-record? For >> example, a hook a package could contribute to. In Tramp, we would run >> >> (add-hook 'bookmark-inhibit-bookmark-hook #'tramp-crypt-file-name-p) > > Yes, that's true, but we don't really have a way to define > auth-source-file-p except by heuristics -- a netrc file may be called > anything. > > So I'm not sure how that'd look... auth-source-file-name-p could scan the auth-sources declarations for a file based backend, and return t for such files. Shouldn't be too hard to implement (oops, do I offer to volunteer?) Let's start with bookmark-inhibit-bookmark-hook, adding tramp-crypt-file-name-p and epa-file-name-p, and see, who else wants to be added. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 19 08:35:09 2022 Received: (at 57856) by debbugs.gnu.org; 19 Sep 2022 12:35:09 +0000 Received: from localhost ([127.0.0.1]:52637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaFzQ-000531-UP for submit@debbugs.gnu.org; Mon, 19 Sep 2022 08:35:09 -0400 Received: from quimby.gnus.org ([95.216.78.240]:50242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaFzO-00052R-7g for 57856@debbugs.gnu.org; Mon, 19 Sep 2022 08:35:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :Date:References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=CZUf/XBQ1d+r8dlRn6xac2H9ywKH0voZmx24z1Tvq48=; b=HTohYy3Yidz3StJVkQ09SlVXjc vjoBTKx7QhmKCmTm9H5g3IEL558zNfA9hEdmBDWBBzlkX+yn+V1q/X10LHQMPs0JDp8jWgXFMqi+2 Ntb+RFX/spBvY81dS2UxiDEgyav9oxKKde2x+gVcOkDzg6IoIvRsWnlDtk8EILOtIsDg=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaFzF-0000UU-E8; Mon, 19 Sep 2022 14:34:59 +0200 From: Lars Ingebrigtsen To: Michael Albinus Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <87zgevimog.fsf@gmx.de> (Michael Albinus's message of "Mon, 19 Sep 2022 14:16:47 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> <87leqfzu6j.fsf@gnus.org> <878rmfkaco.fsf@gmx.de> <87mtavvafd.fsf@gnus.org> <87zgevimog.fsf@gmx.de> X-Now-Playing: Jesca Hoop's _Memories Are Now_: "Simon Says" Date: Mon, 19 Sep 2022 14:34:56 +0200 Message-ID: <874jx3v8y7.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: > auth-source-file-name-p could scan the auth-sources declarations for a > file based backend, and return t for such files. Shouldn't be too hard > to implement (oops, do I offer to volunteer?) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Albinus writes: > auth-source-file-name-p could scan the auth-sources declarations for a > file based backend, and return t for such files. Shouldn't be too hard > to implement (oops, do I offer to volunteer?) Yes, those were the heuristics I were alluding to. =F0=9F=98=80 But I was thinking about packages that say (let ((auth-sources ...)) (auth-source-search ...)) and we'd have no idea how to identify those files. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 19 09:03:43 2022 Received: (at 57856) by debbugs.gnu.org; 19 Sep 2022 13:03:43 +0000 Received: from localhost ([127.0.0.1]:52698 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaGR4-0005nx-T5 for submit@debbugs.gnu.org; Mon, 19 Sep 2022 09:03:43 -0400 Received: from mout.gmx.net ([212.227.17.20]:55153) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaGR2-0005ni-Hp for 57856@debbugs.gnu.org; Mon, 19 Sep 2022 09:03:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663592611; bh=9kTOMm31Y2G2Mu0lZY4RgX/8OvcU6k9+VseewotIcOs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=FK8PxxBxAHAgUhPnWY9zme2+5VFXeDcadkdbGne2taLucFQoPasAbgu7nwEQoXLb9 sGBwKiUttgpVNGiRaSGqndOyqIT3oy2THhLijui+4QAnlYw+XePL2TU3MGBeIflgFf CN3P6UckgJSOsA7+IEc5U4KeS6L8C4iRAor6fbf8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.159.44]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MbAgq-1p7OGJ2Q92-00bZos; Mon, 19 Sep 2022 15:03:31 +0200 From: Michael Albinus To: Lars Ingebrigtsen Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <874jx3v8y7.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 19 Sep 2022 14:34:56 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> <87leqfzu6j.fsf@gnus.org> <878rmfkaco.fsf@gmx.de> <87mtavvafd.fsf@gnus.org> <87zgevimog.fsf@gmx.de> <874jx3v8y7.fsf@gnus.org> Date: Mon, 19 Sep 2022 15:03:30 +0200 Message-ID: <87v8pjikil.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:DjSpEq7MSz60FxZ+0+Ei6A5C5aJPuIdGJS3dwu0rm6yQk4pqyW/ hDyaZ4exRC2OGiH0Q2PAEud1g0FAbhlWduG+v8gkkSp4FK+ak8dOiiboLPqbba2prkkUBuH w4bGsRXWQZb55qsspJpNZo4pcbqP8MbhmvpoQLnetZuxaZ1RRDQ35cUqnKyhlmJufChiHo1 ftmQhmB2Pk0deeRJML2iA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:St1ZyZLIRa4=:qqT7yij8xWI+ROcBh8Xnq2 fq75zkx+lX8f5FJ7x+AhYHRso3XhPdHdxfJKVitQ+JO9pXZT2KRFckPkCRf9wBNO8vapI0/Qr qmmBqj+9gqnMxNJIJ5q58RNnGecACIZ2SLFsoJnRDaIRKk/jl4HgpnmR1hqP/42clunxt9RQw C8kB1nfb105RX27gAb1++HlK43QWr5VF6nVbf18gN5CXx6n42s1POHHkvnudaC0EoA4m7/XLM k2vnuhyWYgvEX71OyV4/QWngRrBZRSPUqCis14rrKXHkWTSO/EN4Ah1o4aw3+L54CYD4aBySY kCRRvd8xnk9++KPA4FJSSuKBq9R8JZY2dWUxzmC1lYONs3KMGl9PUGEFbBjeOl9mthl7kHcIh WmwdX2lpq+mELD5fJshZ8n53pB8ewAZG6YMjx5tLcbjd5apSRUj0hIhhyYTx2cQ1E/sk95akz wKXW8rpOL+QJonCjqhFNbf61uvasjs1D5zCv+mJRDtvmwuPtYPcJt0+MolQBJJEbXT4buhmBL Uk1UH4uW3P19S+GYSHk6MVENIa+pSlU0ykgOtwP9dhkEqHqSRCb6iO0CGrnZX63C6R7WWx8Ot VAshmPOOqiacoIz/1zcmeqKuXKxzJfr4+EW9O2+g51TngaeYMRbdb/Ql9Ah0xrBbluuy56EYN 6hXLWEMyX3lqqkYJMLiJhJCJuPD09qQYKfN/VqiF0XAnn//BdN8+u5sCUsbzemcDKfExc+4Wx HyLAxSa0jBOw/qH510cSOQalnSkm87+fD8mhPCvRjGymt/fUDwdjJORLnPVd/LY5OCTHugNsL fdrqawBksc8uG4yBHT1wIrO4RhW/zOEnhl3lJpcuvp9iU3hdy2gPOWQegp1uQdxG/o/Ea3kzG U61s/bv46nLrWgFZLTnBpOehbCTdmcpeKyQg36Nj5WrN9egbl7deFPQtfemkK1nFw0UKKFlaq 7X/KsTbrdtTBmtzbEjzMtLLeCLbS7Vwc0P81i2fQ5aUEuoimQiqv2vhX0FYBPaTOeWcXKhQre bw08ZWKAOdNAKaVqy6udNAtAPYFK6GImR6/C9yfhW050585LgZ0raDO9TW9xx6E0HH8Va7gr4 hIBJ51E9UMw6cKXEyYO4QtdNKcxFfxZr6GnEF3Uw6mlDrcXXy5VNX28mWCbf2irb+oK7oytaA 0vSsNUsWw5IV1MdSmd4exK9m+V X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: Hi Lars, > (let ((auth-sources ...)) > (auth-source-search ...)) > > and we'd have no idea how to identify those files. Yes. Packages which hide to-be-protected files in a let-form cannot expect that we identify such files, except inside that let-form. This isn't worse than today. But we will protect users who do in their init file (setq auth-sources '("~/.authinfo" "~/my-own-netrc-file-name")) Maybe, additionally or instead of, all files with enabled reveal-mode in the visiting buffer shall be protected as well. Another check function. (defun reveal-mode-p (filename) (when-let ((buffer (get-file-buffer filename))) (buffer-local-value reveal-mode buffer))) Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 19 14:44:48 2022 Received: (at 57856) by debbugs.gnu.org; 19 Sep 2022 18:44:48 +0000 Received: from localhost ([127.0.0.1]:55220 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaLlA-0005NF-Hl for submit@debbugs.gnu.org; Mon, 19 Sep 2022 14:44:48 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36826) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaLl8-0005N3-Fn for 57856@debbugs.gnu.org; Mon, 19 Sep 2022 14:44:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uA23UMOjZMnkuZQf6h63cWHAWABLZwV23r+rPBYXqeU=; b=uJFb4g63JkLQf6avqkOtZV1PWk 5TWu2mH5lbfDVtxOMi1MnLvp2grwhyYUXncNDzQgHIIjXsVB6sQ3uUmQng072nq0zrxGgwq74jzfH b3aGn/sjnd/vUbt9TQ4m8vNpZt6gZZA2osSz8Kf5itvsTqjwKrnPVArH8EbRP/qz6cWM=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaLl0-00035s-8y; Mon, 19 Sep 2022 20:44:40 +0200 From: Lars Ingebrigtsen To: Michael Albinus Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <87v8pjikil.fsf@gmx.de> (Michael Albinus's message of "Mon, 19 Sep 2022 15:03:30 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> <87leqfzu6j.fsf@gnus.org> <878rmfkaco.fsf@gmx.de> <87mtavvafd.fsf@gnus.org> <87zgevimog.fsf@gmx.de> <874jx3v8y7.fsf@gnus.org> <87v8pjikil.fsf@gmx.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEX39fS7oaDCNDYa FxRfXVr///+Dd8mqAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YJExIiI1kCiHMAAAGoSURBVDjLrZTb jcQgDEVNJgXYhAKACjbCBQRB/zXtNXlMsrPS/qw1IoQD1w/iIfrLHE858+d6nqLLRn4wl32iKWXQ 6OITZAbIlNN0B9DPyWOIU/4AO8LvDvwA8Xg81hOGAdINmEJEAIwRXuLNw4g+k2fyj2D3rMTAmIsI lcNaedoNaIe1O9ASioawDVW8Nj2BBi017P5wcqmnlMKZOHLShW06n2AdIvCA+TZOHVLrLjIcKzXq B1jrOHEExI24DVADfDCdgSLqKq3g2GZ7VWyxH4yXQtI2Csfmlebx3AhgbqtlNQy+miIRiws+lU59 Fl50KWMnuQCt1+m4vnBivI8aH9IWwqsMJQVgmi/AtKhJBztRyW1HclgqXwDOnNPM1BHeHu5SNisp G4BWkPf9zWVFfU2Phdr74rYFNWEHVdcLUrnCQgZVcSHN1KW38GUT7XapFWXtDdVtK5T07UZL19Cv r+Rh2PY7uH9X/wD6p1WkPj4/Z5VHZVyKz26eWJJn8YyeTuL8BSey/rIW9D5LTukCKRkQAFC07tlU Tpjhh9g5ZokY/vzn+c2+AZZnhojJQEPSAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIyLTA5LTE5VDE4 OjM0OjM1KzAwOjAwLeArFgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMi0wOS0xOVQxODozNDozNSsw MDowMFy9k6oAAAAASUVORK5CYII= X-Now-Playing: Japan's _Quiet Life (4): Life In Tokyo_: "Life In Tokyo [Original 12" Version]" Date: Mon, 19 Sep 2022 20:44:37 +0200 Message-ID: <8735cnryp6.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: > But we will protect users who do in their init file > > (setq auth-sources '("~/.authinfo" "~/my-own-netrc-file-name")) Yes, that's a good point. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Albinus writes: > But we will protect users who do in their init file > > (setq auth-sources '("~/.authinfo" "~/my-own-netrc-file-name")) Yes, that's a good point. > Maybe, additionally or instead of, all files with enabled reveal-mode in > the visiting buffer shall be protected as well. Another check function. > > (defun reveal-mode-p (filename) > (when-let ((buffer (get-file-buffer filename))) > (buffer-local-value reveal-mode buffer))) Hm... I'm not sure about that. I can see people wanting to use that mode in buffers that have no secrets -- just because they don't want to display that stuff. And the context strings do add real value in bookmarks when finding the correct location. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 10:50:12 2022 Received: (at 57856) by debbugs.gnu.org; 20 Sep 2022 14:50:12 +0000 Received: from localhost ([127.0.0.1]:59185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaeZf-0004kG-WC for submit@debbugs.gnu.org; Tue, 20 Sep 2022 10:50:12 -0400 Received: from mout.gmx.net ([212.227.17.22]:40155) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaeZd-0004k3-3s for 57856@debbugs.gnu.org; Tue, 20 Sep 2022 10:50:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663685400; bh=A2biTIEAE9U6e4Gt3e2SL6c3h471nLIrsmNWmbD+9HM=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=AC6TbYgbjP0U/P+sX833looF+KdSmRW8qUyXGvniDJH1SZQcioLCPZHP0AOs9jf/7 Ga6OxI60kGLN89CBMipikYweB30LebyfKTa2d33SmMDlNyb1kZQs1JWV8nd+k0pSY5 o50RT1i4OJth2JcgTLwsUYZqmrxNDKqvrpBF9j0A= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.125.182]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MbzyJ-1p8tnD0Sfn-00dUs3; Tue, 20 Sep 2022 16:50:00 +0200 From: Michael Albinus To: Lars Ingebrigtsen Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <8735cnryp6.fsf@gnus.org> (Lars Ingebrigtsen's message of "Mon, 19 Sep 2022 20:44:37 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> <87leqfzu6j.fsf@gnus.org> <878rmfkaco.fsf@gmx.de> <87mtavvafd.fsf@gnus.org> <87zgevimog.fsf@gmx.de> <874jx3v8y7.fsf@gnus.org> <87v8pjikil.fsf@gmx.de> <8735cnryp6.fsf@gnus.org> Date: Tue, 20 Sep 2022 16:49:58 +0200 Message-ID: <878rmegkx5.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:oOalENEzOeXH0UyNWlKttllo+gm1QgeyuC4UZhC83NYbGKd3dAF utE58Ij9ui0oRq2F3TbEDXj/Basmj1t0eV4/HfdmemtciKEjht4ip79yz62JNLJlAVmMv0R WVMImdJ2L7RxAmWr/jCDTt4PNXNOhADZzKNa8aWZpMZitiwubW4CQz81aUeUFEXmF3TJS0D lKj8VQzNQCZ0bRP+o3h7g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:44SZEKMz6uE=:tV2RvjDV7Ds+jYOu0nwPDf 6xOpZZD7XSc8K13j8UU+B96I+ClK4x162ek098hHMS1Qg3F9bf05CwrWbyaAOMAvUQQIy3IP4 t7VIHl0kTGiLxjrkGB1V7zTV3bZKNbk+4JHZ94KpKZwL78RTeh80fUq1OpZQ3BmrFRwzywbH3 PUs6zpUXHwBRfcW6jSabOLzC409KJjfMknwo1oUe6WEKIRfWVcxZz0e5emDzqmqSMQS7IW+BS x0tvHbmvqK3OamyaakKZmQuZ/YPBoN0h12K61sWVYMnS7Ch8FBzOwU1pHzzI7ob+5H7GJ/9Cd WxdDStOsZcvfmMn6z+QO7a4RjtDPpbtMDmM4IWwujJV7xHKmqqnEXnJZ/1NTns+iHoj5eZmam 208kW/Ky1gr28otTcmrhN1laCSM+2NUIyvaSaxMRR6N6B+q3wMmUyTjnTzHfVbGlqEdHKSzer BlTPx4NG3fR2IDYQFMN8z98aRo/+FxZBTx9xQ3Glcvd1V5YU983IPat3j0xOpr6wmBGoMkzZj /cjzVCKlk9RmXkIRGTYfxvx/S4Es+BFtu6Gy+ra/6+7iafiPFstRFB45PaPFBqSrGNyjWtTlF Ph0AUh32d9b+wByJA2uG3pflN09Vo3CIVgOcu9znKpKnG8xDq3C9Xptosq6WQ7yWoCDab9R3v KPwXML70C58tJQx4IFY7W9NUv9PpxW59wvs8LTR21FZz5O1gqseRWFlAXK+Nys/zLiaDiDEgr kxAfHv/izTdhksnMAzLJMN0nXWmIAo7dKYanvBGqVbLDEQAXRvXvnWOWled9mT4lyViy9qrJm 4BiEGHY7ugPDw2KjKSVeG19eRPtDHGnG04/BF3l+Y4Qux2bBmOJNB51yseWmMHTS0fVyAUHtD reMI3QSYJq7nIy4/o4cAVB8N9PfsudSlepwhBMjIKI19QQBpug1F3Fc3/3vUC6Y8UpoKVO9pG PeBWB3OquBm6iUXaujepSwhPDeUhrXmOwGUEtT08eSBgcQpnm7iSvEQEayqfYvgyYVHjCCduc HJ5OLa8J5VHIqQOlfDwia/RiI/QmIGYRG1pkKnHBITmtpOjVhiNYTFDGFNetdk6VXoD7VXDt/ 82UletptmyJV2hPlItVqFJN/nBXRbXZFwlYnFJsbUXMCHTwRJM2BLSGi27rpUoHz9cmK9Djtn qabQfmPrsePQXMrEtQaRkPrNEg X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: Hi Lars, > Michael Albinus writes: > >> But we will protect users who do in their init file >> >> (setq auth-sources '("~/.authinfo" "~/my-own-netrc-file-name")) > > Yes, that's a good point. I gave it a try. WDYT? (Documentation must be added, of course) Best regards, Michael. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment Content-Transfer-Encoding: quoted-printable diff --git a/lisp/auth-source-pass.el b/lisp/auth-source-pass.el index 86e0b48a79..4519705e14 100644 =2D-- a/lisp/auth-source-pass.el +++ b/lisp/auth-source-pass.el @@ -319,6 +319,16 @@ auth-source-pass--name-port-user-suffixes (list (format "%s" name))))) +(defun auth-source-pass-file-name-p (file) + "Say whether FILE is used by `auth-source-pass'." + (and (stringp file) (stringp auth-source-pass-filename) + (string-equal + (expand-file-name file) (expand-file-name auth-source-pass-filena= me)))) + +(with-eval-after-load 'bookmark + (add-hook 'bookmark-inhibit-bookmark-functions + #'auth-source-pass-file-name-p)) + (provide 'auth-source-pass) ;;; auth-source-pass.el ends here diff --git a/lisp/auth-source.el b/lisp/auth-source.el index c79e5b81f7..13ebd80106 100644 =2D-- a/lisp/auth-source.el +++ b/lisp/auth-source.el @@ -522,6 +522,21 @@ auth-source-backend-parse-parameters ;; (mapcar #'auth-source-backend-parse auth-sources) +(defun auth-source-file-name-p (file) + "Say whether FILE is used by `auth-sources'." + (let* ((backends (mapcar #'auth-source-backend-parse auth-sources)) + (files + (mapcar (lambda (x) + (when (member (slot-value x 'type) '(json netrc plsto= re)) + (slot-value x 'source))) + backends))) + (member (expand-file-name file) + (mapcar #'expand-file-name (remq nil files))))) + +(with-eval-after-load 'bookmark + (add-hook 'bookmark-inhibit-bookmark-functions + #'auth-source-file-name-p)) + (cl-defun auth-source-search (&rest spec &key max require create delete &allow-other-keys) diff --git a/lisp/bookmark.el b/lisp/bookmark.el index f150a24bbf..941cf7932c 100644 =2D-- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -592,6 +592,14 @@ bookmark-make-record-function in which case a default heuristic will be used. The function can also equivalently just return ALIST without NAME.") +(defcustom bookmark-inhibit-bookmark-functions nil + "List of functions to call before make a bookmark record. +The functions take `buffer-file-name' as argument. If any of +these functions returns non-nil, the current buffer is not used +for a bookmark." + :type 'hook + :version "29.1") + (defun bookmark-make-record () "Return a new bookmark record (NAME . ALIST) for the current location." (let* ((bookmark-search-size @@ -599,10 +607,8 @@ bookmark-make-record ;; don't include any context in the bookmark file, because ;; that would leak (possibly secret) data. (if (and buffer-file-name - (or (and (fboundp 'epa-file-name-p) - (epa-file-name-p buffer-file-name)) - (and (fboundp 'tramp-crypt-file-name-p) - (tramp-crypt-file-name-p buffer-file-name)))) + (not (run-hook-with-args-until-success + 'bookmark-inhibit-bookmark-functions buffer-file= -name))) 0 bookmark-search-size)) (record (funcall bookmark-make-record-function))) diff --git a/lisp/epa-hook.el b/lisp/epa-hook.el index 70c3030881..f4616b3b91 100644 =2D-- a/lisp/epa-hook.el +++ b/lisp/epa-hook.el @@ -92,6 +92,10 @@ epa-file-name-p "Say whether FILE is handled by `epa-file'." (and auto-encryption-mode (string-match-p epa-file-name-regexp file))) +(with-eval-after-load 'bookmark + (add-hook 'bookmark-inhibit-bookmark-functions + #'epa-file-name-p)) + (define-minor-mode auto-encryption-mode "Toggle automatic file encryption/decryption (Auto Encryption mode)." :global t :init-value t :group 'epa-file :version "23.1" diff --git a/lisp/net/tramp-crypt.el b/lisp/net/tramp-crypt.el index d556c87606..60a1c37c9c 100644 =2D-- a/lisp/net/tramp-crypt.el +++ b/lisp/net/tramp-crypt.el @@ -852,6 +852,14 @@ tramp-crypt-handle-unlock-file (tramp-compat-funcall 'unlock-file (tramp-crypt-encrypt-file-name filename)))) +(with-eval-after-load 'bookmark + (add-hook 'bookmark-inhibit-bookmark-functions + #'tramp-crypt-file-name-p) + (add-hook 'tramp-crypt-unload-hook + (lambda () + (remove-hook 'bookmark-inhibit-bookmark-functions + #'tramp-crypt-file-name-p)))) + (add-hook 'tramp-unload-hook (lambda () (unload-feature 'tramp-crypt 'force))) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 10:53:39 2022 Received: (at 57856) by debbugs.gnu.org; 20 Sep 2022 14:53:39 +0000 Received: from localhost ([127.0.0.1]:59197 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaed1-0004q4-5a for submit@debbugs.gnu.org; Tue, 20 Sep 2022 10:53:39 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47690) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaed0-0004pp-1B for 57856@debbugs.gnu.org; Tue, 20 Sep 2022 10:53:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=yFGt5lWiGNQ/sXFJhe5TuzajbuqxIL15ssO5dd9dFk8=; b=OvfHLuoKguTVYiVFnUeysnTUvg U0/QCaKr0bZWadjSXsbQVqs6c+6WnOWmtDDqImCDUZu/Cdb+QmcrXNwzmDTP5hU7DcmyG3yySr911 dchMf6xM3sd9LsbSOYQmeNb/A3r71ie4+N0Nw9OoO+kxHAyMWWpSCtjigZSkmDB+ZrrU=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oaecq-00033Z-Ot; Tue, 20 Sep 2022 16:53:30 +0200 From: Lars Ingebrigtsen To: Michael Albinus Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <878rmegkx5.fsf@gmx.de> (Michael Albinus's message of "Tue, 20 Sep 2022 16:49:58 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> <87leqfzu6j.fsf@gnus.org> <878rmfkaco.fsf@gmx.de> <87mtavvafd.fsf@gnus.org> <87zgevimog.fsf@gmx.de> <874jx3v8y7.fsf@gnus.org> <87v8pjikil.fsf@gmx.de> <8735cnryp6.fsf@gnus.org> <878rmegkx5.fsf@gmx.de> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEVmtfJ/f423y8+b X1lLLzj///8Z8KpJAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+YJFA4MBpHqN7UAAAFtSURBVDjLrdNR koMgDAZg0B6AQA6g0AMI4QBlyf3PtIFWq6u7MzvT/6Ez8DUkjKrUB6ONVtYPRgNYDQPADBasQC7B xjgso+OCGbgiW+ZJ6RTmuICKY3NtgnFzSsEoHUFlExXAHWwBM6rs5oICnA2qOLiI1WT6CvITapHe kxTLQfAYp+j9MspRkKJAwckpQFhGKOQE0NkH9qmUU5mtCTWOVUkF2WWc1tsM5/vBFjP4wb8iEKiF mWjx78gF5/ZnJK5gnnvzD+DSwa4VQwPnmLkuPgD0g2kFcDk3kLSWmd9AvAPeVVSB3uN4lOO8VvSC vE6FlV49glxIBmnQTsp91eBek897kAWXBpYS7oE7gA+eEj17NOAXtFnbxCe4V6JAvo97AEcyXkwb uDdIEm2AB6ALuGfZrCsQbbA9pwa8pRwe7e0vKHiC9fU5vlKyNp/8BH//Nk+t18iYl/s3Bj7NphuU hI/rCj5X9CBe9/h3vgHNwHGMbot6eAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0yMFQxNDox MjowNiswMDowMNOuE08AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjItMDktMjBUMTQ6MTI6MDYrMDA6 MDCi86vzAAAAAElFTkSuQmCC X-Now-Playing: Sylvester's _Sylvester-Step II_: "I Took My Strength From You" Date: Tue, 20 Sep 2022 16:53:26 +0200 Message-ID: <8735cmdrmh.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Michael Albinus writes: > I gave it a try. WDYT? > (Documentation must be added, of course) Looks good to me. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Michael Albinus writes: > I gave it a try. WDYT? > (Documentation must be added, of course) Looks good to me. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 11:00:46 2022 Received: (at 57856) by debbugs.gnu.org; 20 Sep 2022 15:00:46 +0000 Received: from localhost ([127.0.0.1]:59201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaeju-00076C-0b for submit@debbugs.gnu.org; Tue, 20 Sep 2022 11:00:46 -0400 Received: from mout.gmx.net ([212.227.17.22]:36077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaejn-0006dI-TL for 57856@debbugs.gnu.org; Tue, 20 Sep 2022 11:00:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663686033; bh=JJvIIO3gqWoqZw+7xGD6Z+JkaVsKedjmAXtF03OvFGQ=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=lVCWbhl9UrIcw41Tkxrtm1ZRYqBFKKoXFnFuz2LASxxPFWJ/6cfXoRx/jWQ5z4bU/ rZ3tnDWJ9ORia1REDrprSuREq359PSiZjwbpjkvIrINsS1Yy2CdNlQOPlwPc2Q8HvY zfHDUFpuzz4tYKW3gNJZph4kkg+KogBlOsLeTYtM= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.125.182]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MWRVb-1oltAQ21xz-00Xu2E; Tue, 20 Sep 2022 17:00:33 +0200 From: Michael Albinus To: Lars Ingebrigtsen Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <8735cmdrmh.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 20 Sep 2022 16:53:26 +0200") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> <87leqfzu6j.fsf@gnus.org> <878rmfkaco.fsf@gmx.de> <87mtavvafd.fsf@gnus.org> <87zgevimog.fsf@gmx.de> <874jx3v8y7.fsf@gnus.org> <87v8pjikil.fsf@gmx.de> <8735cnryp6.fsf@gnus.org> <878rmegkx5.fsf@gmx.de> <8735cmdrmh.fsf@gnus.org> Date: Tue, 20 Sep 2022 17:00:32 +0200 Message-ID: <874jx2gkfj.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:oAihSDLnqw69J+OpJrFaezv8BMyZVQM32sVJbpkUa2GfLPlMjIT k3MuVMn+QJNym/OOG8nTHZ+Zf1uAqimqy0qyAnSWF8KJ4VlZi7uKMgqr40iGdKTrLWs8e5f Qed5x4NV6EE0zkkX3UZBiTReKi1JG+u4qCI1eKp0eASxhQCkGp+ZjBi07rhnAEA/PwFbtrh kxVRTA64s6r4odDjqHCHw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:HATyK51fMRQ=:JfVukZVjKUhfX6mlc3v+Q5 k2nKWxFY3mripcfRIz7ljU1mqj5/gJlB9qpe2FEWpX5OLN/+IAi6wztE2tvy+5G1Rl+oStqr7 TKyVSkeEdzLdd44iatwAooUqoY3j74qvO1nkX1NF+C9mcI4mPhp1u8ZFw2V0syIVLuhNM5vFv nyhlb6OJxaYK35YKyEZoHuqRnVl0oT4kvayEAA3OCInJc1T04PMhIAiJH/0sxYoYDiPmfaRnA HxwNepYucBFeabEqhe6/z+MsULGeFMH/ct0gnirTOs2RxzFHowrImlcqmfu7HRXpi4Eurehx1 kNLIRduK9vIGCy4/OXNbjLmNfAxaOsh2npfINWsIKKnSHLbm+IkJKkVIDRLspZ/CzSP3CasVb 97M4GMp1OmvnAUhMNpYg/JE2NWZ09XSUreDbJLFN9N4Be/iyj+ZkK087MfTSPJVXZ7OjG89eC mZ6YDjDbfqKpH95k6XyppZoXhWKERK0lm6edOaKV4rAJmg2riXHmsaJK8gq4en3/xniHNhaCr xCcHazdAqk+nebBzkKvGeWQmmT07MKMBeq+M+DY3rcty81wn7vwPeJo6munc/Xg3VZZNb+XvK gsWs0wgGf6UlILV4lzjsaB7bLUnjxS0Gjl9WHKKvAuHyQ70rwrfyV7bdDIIXM4Tjr8Pf9jdHW ECO81HAnQQmJDQyDcCbvK5uQoyV8XUFVdrMH1TXPRKgwIyGBsoafC1NOws39gBPmipXPes6x/ rRLiUPJoyCavHDwwViVIGPJIpJahqFv1iuPhY1YAhZwlblPSesjaeUnjoK88w0gzKYHztVMaa duTGgw/swN3U7xA4+5cPDKX8VP+2lxLOko+pPqsIQAWrf/YPbu4zh1IV1YqS6snEc56846ZAn QdfVsNd4FEnQH9E7G4jUm0iEZzgTgtvm4x9wsvHxdSJZhFQJogDvTzNoX9fpA9yfjm8RjnlSA 1ytVsGmF7hFXx64768YCxILns79/mg10tJ29SZxlL9gpTCjFlKdQ2t+oXiQ9qIPmuZCJNlTor ahHFRFA4g+DGMP/xUj/8huIC/p4TmzStowXf9e9J/+fGP1qjBAGLxxjz2vKYHz7Ih7HfEF0Aa 4OaBwAHA+gvcQi7KgNkXEtuxbVO0TDPQYBVjDxsenSiceFsMHiXLex9X8Auj2vov59hB9xq8f a3aVNYlakymrxk77Pq8BUGMzMj X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57856 Cc: Gustavo Barros , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: Hi Lars, >> I gave it a try. WDYT? >> (Documentation must be added, of course) > > Looks good to me. Thanks. I'll wait a day or two, whether somebody hollers. If not, I'll push. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 11:12:07 2022 Received: (at 57856) by debbugs.gnu.org; 20 Sep 2022 15:12:07 +0000 Received: from localhost ([127.0.0.1]:59218 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaeut-0007Th-9m for submit@debbugs.gnu.org; Tue, 20 Sep 2022 11:12:07 -0400 Received: from mail-qt1-f176.google.com ([209.85.160.176]:41758) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaeur-0007T9-8Q for 57856@debbugs.gnu.org; Tue, 20 Sep 2022 11:12:06 -0400 Received: by mail-qt1-f176.google.com with SMTP id c11so1896936qtw.8 for <57856@debbugs.gnu.org>; Tue, 20 Sep 2022 08:12:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:sender:from:to:cc:subject:date; bh=z9NGEQ0GMvE2wtFbZDR+iMMdwt4YjH4PpyOmerVc4o8=; b=IcIT+ROwXx2U7yiT105nDNB0Lgfho6T3YpfOTMyNCaf23QR2HaBMJaTakdwP+DAAdH rDAjs/FS1OwN4RiVcukIJoY6AXItEP5dKNpbRDf8cc8UgEe++6BWFdq/e5hj3qhGTV9h T7ICsKe+oH5lOntFvP5vhPPAy1jyqECj5T9SIoWiATo7RJKPSed9hyNoG/q8TuPZMPPW xpXHNnCKod+ix/SUXHwpuZlxBU4VHuW1OMa1LfT+NCHHATLVTh4h3IE3Ogrf6EPUNuwh zghIpitO/ADf4tCkkU5p+W2hm06cDL8yp9uoKgGO2mItGEe2uHb+CasQ+frBGZcj9Tif fOsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:in-reply-to:date:subject:cc:to:from :user-agent:references:sender:x-gm-message-state:from:to:cc:subject :date; bh=z9NGEQ0GMvE2wtFbZDR+iMMdwt4YjH4PpyOmerVc4o8=; b=LS7FH0HUpQu+6XUuLM79xqF6bnbIDPKOmuVJw6geZk+wfPGS9BoaJ/yQkf4arWkrzq Lrao0SDm+Cnj6A9dP3+OoiwfGzSchddyxm/BUepzoFWUBllMtw18HfOMwIHFWF47N3zt kfYi5l4QwqXlorvH4+Sm0u6lsM9zzJjd5cA+l1S5RMLtQp6TucAFyAvO3wChR1kfwM1J i9H0v4oF4q4kTfnxXHdbaFGGNVXzA0kaXn4+qW70lEDOsmwrhqzvsPDNgKM9TgIE66jc aJCCcej4OY3HBS/HXKLXuDFb/s5GxnMWyL5gH92jpA88DFpiz8+ie7GtkjU11Kb13L61 E5sw== X-Gm-Message-State: ACrzQf2K/+lQbJHGFXFsaD9m/CX8JDdmBcFJ8atqwpgLwsOc5wanbFOH Cb2Mah0D4zShpMsBaJpji4wjZKKwMzsZ5w== X-Google-Smtp-Source: AMsMyM4bYyh0cc+aeMik9St9b0Tq4yDf2GJuhZysgR6XNMN1EjmQe5efHBvgFe0vcg2X5lEA+c6Z6A== X-Received: by 2002:ac8:7f46:0:b0:35c:da6b:cfbc with SMTP id g6-20020ac87f46000000b0035cda6bcfbcmr14931007qtk.553.1663686718978; Tue, 20 Sep 2022 08:11:58 -0700 (PDT) Received: from gusbrs-laptop ([154.21.21.201]) by smtp.gmail.com with ESMTPSA id w11-20020a05620a424b00b006cbbc3daaacsm314905qko.113.2022.09.20.08.11.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 20 Sep 2022 08:11:58 -0700 (PDT) References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> <87leqfzu6j.fsf@gnus.org> <878rmfkaco.fsf@gmx.de> <87mtavvafd.fsf@gnus.org> <87zgevimog.fsf@gmx.de> <874jx3v8y7.fsf@gnus.org> <87v8pjikil.fsf@gmx.de> <8735cnryp6.fsf@gnus.org> <878rmegkx5.fsf@gmx.de> User-agent: mu4e 1.8.10; emacs 28.2 From: Gustavo Barros To: Michael Albinus Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files Date: Tue, 20 Sep 2022 12:03:45 -0300 In-reply-to: <878rmegkx5.fsf@gmx.de> Message-ID: <87a66ucc7a.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 57856 Cc: Lars Ingebrigtsen , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi Michael, On Tue, 20 Sep 2022 at 16:49, Michael Albinus wrote: > I gave it a try. WDYT? > (Documentation must be added, of course) If I may, I do have a comment about the defcustom. I think `bookmark-inhibit-bookmark-functions` is not really a precise name, since it is not about inhibiting the bookmark itself, but only the context strings. How about `bookmark-inhibit-context-functions`? On the same vein, the docstring could be clearer about it. Say: "List of functions to call before making a bookmark record. The functions take `buffer-file-name' as argument. If any of these functions returns non-nil, the bookmark does not record context strings from the current buffer." WDYT? (Either way, thank you!) Best regards, Gustavo. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 20 12:19:27 2022 Received: (at 57856) by debbugs.gnu.org; 20 Sep 2022 16:19:27 +0000 Received: from localhost ([127.0.0.1]:59445 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oafy3-0001EV-3q for submit@debbugs.gnu.org; Tue, 20 Sep 2022 12:19:27 -0400 Received: from mout.gmx.net ([212.227.17.22]:39485) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oafy1-0001EJ-SB for 57856@debbugs.gnu.org; Tue, 20 Sep 2022 12:19:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1663690757; bh=AEWmyWD1sBbqK5yKtxmKpfevW1hwNUhFPOF8SiRsG80=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=aejFB4gpmeSu79AbM2D6Vc7W3cuwK59GdH0mOIZ2T/OhG7uW27jKlphFmy8yskoGE A0Rck6c7bQTD2yIzLwTQYdCRKPtJ+jy0fkYbnBpYNRXwUrVdvVB0JdhhiBiD0HwYCT qIg+Rz6SwyzSicktq9ozwMIz6P79VgpJdRMV8zJE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.125.182]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MlNtF-1ozWbR3PDx-00ljsj; Tue, 20 Sep 2022 18:19:16 +0200 From: Michael Albinus To: Gustavo Barros Subject: Re: bug#57856: 28.2; bookmark context strings in encrypted files In-Reply-To: <87a66ucc7a.fsf@gmail.com> (Gustavo Barros's message of "Tue, 20 Sep 2022 12:03:45 -0300") References: <87bkrfh77i.fsf@gmail.com> <87mtaz8quf.fsf@gnus.org> <877d23h4df.fsf@gmail.com> <87czbv8od3.fsf@gnus.org> <87y1ujsbjp.fsf@gmx.de> <874jx56l2v.fsf@gnus.org> <87mtaxx8s7.fsf@gmx.de> <87leqfzu6j.fsf@gnus.org> <878rmfkaco.fsf@gmx.de> <87mtavvafd.fsf@gnus.org> <87zgevimog.fsf@gmx.de> <874jx3v8y7.fsf@gnus.org> <87v8pjikil.fsf@gmx.de> <8735cnryp6.fsf@gnus.org> <878rmegkx5.fsf@gmx.de> <87a66ucc7a.fsf@gmail.com> Date: Tue, 20 Sep 2022 18:19:15 +0200 Message-ID: <87zgeuf27w.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:46HVLqfFigDnRNamlbBpZi1wLuCYOss3zTUN/YUkkJfjSPyfZrU ckrWbrbDS8LA+9ziH0IML53xurzu0uajgFZHHhxGO2Usk6vPC1yLcSaztESLacykNg2bqHg 9fgbIRX1BhTlUuQLqAj+fYqBzUZpdMRZ3mJ2afHlk1lhoNqCDXQKMxp9Ru+svY9QipNPIQA eV+jYiY4EVHshmc0/YeBQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:WsLf1alJ5/Y=:Pkz5W+jlaZaLyZkWw/iosU hIuKi5ZlhIMvX/U9DeqMh2kED+PkY6V1Y+KQKDzB3IwgU+PyRogkTw/w/rgCV1Pdc3AyrrOMp bGtM/3QMuSmNizNZlGfKePsFdsFMczwCjCUHeV49J/2/6q5HQC8dXOUQIPqp7Su00nvAlQh64 jzBLteWVd93lzdX4zLmL7rNeATVV2/QqhFMdrCJnEcxPXIDSuRhbZ7JUxUBCzOfHbnMOzBRrH uYhA9/ZoJCY1qua4Aw5B4KLOkXBxt5dIPNC3evS/gb5xLtBG4AGlE2Odk0kfGTPAOtKYuF4T+ suBCaaRH7vWWYRMHagL0unYXdbKHd48mtauLwpNbpj4mWwvE5NYFTUbZOqclmfEyJu46C4C+t dRvbpf+6lG2fATxePXdnDzIJrR1RzKuUWfhE6cMZRhAh0eOdhGtWKY9BiDHR/iZjBQnwbvevG qxSETGVuWkrn5el9ewK8sQGsbt9b3Mb4DjBV9Lc3MqXRYYSAWORVyW0IMjsNYkc+IJXYCVjW7 icFm4ORlIeSI6/dM5o+qe8/hGvsCzIKUC/nERm7GXoGq48IET3R8FnKzlfoIN9MMRKXL+Il10 EXYTQ5vlicPphcqkAO0Sc1d/K9kWITpdNbgBF3OqkYFLOm1wmA066stYt5rnqr7EH3SDWAkxz GrDJK/ZhIwlKwPBrdPKr6jnCLRZVzYQspSE5WktZr8iRnVBNL+gD468CK0GmaurE0wxLAFV7d j58wxccqZayt7xbQ601wNgPA8TUyMjkQJK+GVYsxfn4eDrJVkxgh84yBJmUmCLqHQoI/oLOoW gnKsLrp2AQp90PUHM+XFjm6YJSOB8bodqVnjS+O4RjbsIZVBsburiTx8530dJbAaOoS76fKXl YYWOKoYgIu8IhEwSSDqpcw+ODNo06SypXJMtSkUAyehtrkVfPUJ9dQXgABiaCkH+dAx298wcv hbXs/9/Ldb61n1gvc+6fCLksKRwj0eNJbqYk1RC7iqA3zs70HHQhPjmRTygvOTEtA4nlR2SO9 zeqNsiqKk4Vct84cKRYw3f9mxo3/qN9Vrwhm9QQALaV4mjDAVViECsQsH5RtGqbvTp0gLkauf QybLI0W5JXmxRbo5HKQ3xKRcP6YWGG4yfPJqVmli8A7e3sLEzEm3Mk4GtcgbhyGM4UZI+kdh6 32rUlw6VbCcDb9+F8PL2+pWmtf X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57856 Cc: Lars Ingebrigtsen , 57856@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Gustavo Barros writes: > Hi Michael, Hi Gustavo, > If I may, I do have a comment about the defcustom. I think > `bookmark-inhibit-bookmark-functions` is not really a precise name, > since it is not about inhibiting the bookmark itself, but only the > context strings. How about `bookmark-inhibit-context-functions`? On > the same vein, the docstring could be clearer about it. Say: > > "List of functions to call before making a bookmark record. > The functions take `buffer-file-name' as argument. If any of > these functions returns non-nil, the bookmark does not record > context strings from the current buffer." > > WDYT? Thanks, will apply both. I'm notoriously bad in giving names and writing documentation, so everything will help me! > Best regards, > Gustavo. Best regards, Michael. From unknown Sun Jun 22 11:46:49 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 19 Oct 2022 11:24:08 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator