From unknown Fri Jun 20 07:28:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#57852 <57852@debbugs.gnu.org> To: bug#57852 <57852@debbugs.gnu.org> Subject: Status: [PATCH] services: nginx: Don't emit empty fields Reply-To: bug#57852 <57852@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:28:35 +0000 retitle 57852 [PATCH] services: nginx: Don't emit empty fields reassign 57852 guix-patches submitter 57852 Simen Endsj=C3=B8 severity 57852 normal tag 57852 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 16 03:52:31 2022 Received: (at submit) by debbugs.gnu.org; 16 Sep 2022 07:52:31 +0000 Received: from localhost ([127.0.0.1]:41535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ69G-00044J-PH for submit@debbugs.gnu.org; Fri, 16 Sep 2022 03:52:31 -0400 Received: from lists.gnu.org ([209.51.188.17]:49634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ695-000441-4s for submit@debbugs.gnu.org; Fri, 16 Sep 2022 03:52:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46310) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ694-00070W-Q6 for guix-patches@gnu.org; Fri, 16 Sep 2022 03:52:18 -0400 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]:46075) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oZ693-0004eu-4O for guix-patches@gnu.org; Fri, 16 Sep 2022 03:52:18 -0400 Received: by mail-lf1-x134.google.com with SMTP id w8so34242265lft.12 for ; Fri, 16 Sep 2022 00:52:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:subject:to:date:from :message-id:from:to:cc:subject:date; bh=g00RbRwUYWg4KYR4cn9UWOFxjcUmayJoSTsC/wkzPm8=; b=O2gIYsqITljFLkUzd8Ng6F2F2dR/Zzu4++O4pLNDgXEs+LN+mSVcinKssCFpICIwuR yet0HB1NTmgC01rWTZAIUljnrACSR93SmPCIS0gjEteHPTO8XBje2Q8diGkc55Dh6GI2 N7epPumiyO17eiJwLwFa+q5DkT3z+OlxE6N5r89FYIq8lUFi8EdTJ58vGMhE/Td+3RjG DfVbwnSnDDLGnfSwT88tIXWaVJqkFROAE0vlbAN3yZU5y9USC2FgY45rfRupmsPajQ5o gT1izP9CL3c76pUf26sRNW04YYZV0S3xIY5ZZ/i0SAWBeO7/GJW2JdzWtLFFAfzBNEt4 KT5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:subject:to:date:from :message-id:x-gm-message-state:from:to:cc:subject:date; bh=g00RbRwUYWg4KYR4cn9UWOFxjcUmayJoSTsC/wkzPm8=; b=W0visSgxpSSeMwjNrE7WxzdSp6ktXUPHm9tCZuWn0Nplo1GMCm5VlyYidC38KSG10V r9jZrdGoMcfQ1A6VqSYzZayNO3Vj90uq0uE9NYK3r90R2pECj//tScUjcEj2PpsfvrsO vRfDdNszTpTIyr8eV+880WV3PwVbsiS8rTH/limwR58T6F5TKeR+2vagLendHHPVeEqS 9LlGvOpDfbGaDTQjK9FSKadJ8QXp4v5kythNblDji4opqcE6/ItHUW3X56GMo6e57zpI Xkk4dnPsNc+zmWNdfEaTTi1hs+UuUSVk5/E0lfAdOLMwih7sJ7YhcNUxYasoE0Z/xQDk RZVw== X-Gm-Message-State: ACrzQf2s/2yKhMfvG26FzgJhmX27mOiu/ZeOPoE/fkPqXLOwdtUL4iV0 yzJ31ihf7nR4q9mUA1aqAEToSag5rd9UYA== X-Google-Smtp-Source: AMsMyM4mXBVlVIbzKUjcEFtcr1FqXraY2LZah6z9qBwHrRYO1gzjrWITHR+wi+/0CRNq80FSrW+5Jw== X-Received: by 2002:a05:6512:3b06:b0:498:fa72:c24d with SMTP id f6-20020a0565123b0600b00498fa72c24dmr1281179lfv.538.1663314734334; Fri, 16 Sep 2022 00:52:14 -0700 (PDT) Received: from simendsjo-laptop (78-72-230-58-no2730.tbcn.telia.com. [78.72.230.58]) by smtp.gmail.com with ESMTPSA id z9-20020a056512370900b00494a27500c1sm3351699lfr.163.2022.09.16.00.52.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Sep 2022 00:52:13 -0700 (PDT) Message-Id: <874jx73gfk.fsf@gmail.com> From: Simen =?utf-8?Q?Endsj=C3=B8?= Date: Fri, 16 Sep 2022 09:50:37 +0200 To: guix-patches@gnu.org Subject: [PATCH] services: nginx: Don't emit empty fields MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2a00:1450:4864:20::134; envelope-from=simendsjo@gmail.com; helo=mail-lf1-x134.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) An empty root or index field is an error in nginx. * gnu/services/web.scm (emit-nginx-server-config): Don't emit root or index fields when they are empty --- gnu/services/web.scm | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/gnu/services/web.scm b/gnu/services/web.scm index 5bac496f01..e347f5dbcc 100644 --- a/gnu/services/web.scm +++ b/gnu/services/web.scm @@ -14,6 +14,7 @@ ;;; Copyright =C2=A9 2020 Arun Isaac ;;; Copyright =C2=A9 2020 Oleg Pykhalov ;;; Copyright =C2=A9 2020, 2021 Alexandru-Sergiu Marton +;;; Copyright =C2=A9 2022 Simen Endsj=C3=B8 ;;; ;;; This file is part of GNU Guix. ;;; @@ -646,8 +647,12 @@ (define-syntax-rule (and/l x tail ...) " server_name " (config-domain-strings server-name) ";\n" (and/l ssl-certificate " ssl_certificate " <> ";\n") (and/l ssl-certificate-key " ssl_certificate_key " <> ";\n") - " root " root ";\n" - " index " (config-index-strings index) ";\n" + (if (not (equal? "" root)) + (list " root " root ";\n") + "") + (if (not (null? index)) + (list " index " (config-index-strings index) ";\n") + "") (if (not (nil? try-files)) (and/l (config-index-strings try-files) " try_files " <> ";\= n") "") base-commit: 02c5ed4f1bbd83bddd81902604af6f8add41ac54 --=20 2.37.3 From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 26 17:21:21 2022 Received: (at 57852-done) by debbugs.gnu.org; 26 Sep 2022 21:21:21 +0000 Received: from localhost ([127.0.0.1]:51936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocvXV-0001x5-Gr for submit@debbugs.gnu.org; Mon, 26 Sep 2022 17:21:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:36322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocvXQ-0001wn-W8 for 57852-done@debbugs.gnu.org; Mon, 26 Sep 2022 17:21:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44524) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocvXK-0002s0-92; Mon, 26 Sep 2022 17:21:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=6o50KYZndH9pc8xJN/TErFiSEkoJ1GFWnt0zAvkY87Q=; b=HY/0tmyTHxWVJAgjPEj0 7rsKuwtKKxFg9bY2eY/Mo/1iLyP8/SBgr2ihDICmbbi5FreUkM1L3+qy5c+qfN/mG5hb/BTyV1hPB OEVqOKXtaiB8i+/y1ha81ZE5JnGQnop/B8KIj5Grnph7zpT1OMSgg1lJNvphW5y+5KlO32ijNeQ8a lOtS3m9csyCEfLMdRG1jgLGaS/OR6T/R4Q3RU/4s8fVqEVDAkOdgoWIC5DM5smR0OwTuvgTYRgf0a x8a15maYl8l/5WWEvVRWUqxTK67Z4S1y4D1kb8ocDAvZgGk7bB3gKDSOJmHLdS45LPhUVNe8CfEkj CNtCQX8xYqfgvg==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:59220 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ocvXJ-00015I-S0; Mon, 26 Sep 2022 17:21:10 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Simen =?utf-8?Q?Endsj=C3=B8?= Subject: Re: bug#57852: [PATCH] services: nginx: Don't emit empty fields References: <874jx73gfk.fsf@gmail.com> Date: Mon, 26 Sep 2022 23:21:07 +0200 In-Reply-To: <874jx73gfk.fsf@gmail.com> ("Simen =?utf-8?Q?Endsj=C3=B8=22's?= message of "Fri, 16 Sep 2022 09:50:37 +0200") Message-ID: <87fsgdj0ho.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57852-done Cc: 57852-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Simen Endsj=C3=B8 skribis: > An empty root or index field is an error in nginx. > > * gnu/services/web.scm (emit-nginx-server-config): Don't emit root or > index fields when they are empty Good catch. Applied, thanks! Ludo=E2=80=99. From unknown Fri Jun 20 07:28:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 25 Oct 2022 11:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator