Subject: Re: bug#57835: (featurep 'haiku) vs (eq system-type 'haiku)

From: Po Lu <[email-masked]>
Date: Fri, 16 Sep 2022 09:28:18 +0800

Stefan Kangas <[email-masked]> writes:

> Severity: wishlist
>
> Should the below be changed to use (eq system-type 'haiku) instead?
> It seems like that's the pattern we use for the other systems we
> support.
>
> ./term/haiku-win.el:28:(unless (featurep 'haiku)
> ./loadup.el:306:(if (featurep 'haiku)
> ./cus-start.el:866:                       (featurep 'haiku))
> ./version.el:81:                       ((featurep 'haiku)
> ./select.el:527:              ((featurep 'haiku) (add-hook
> 'haiku-lost-selection-functions
> ./select.el:535:          ((featurep 'haiku) (remove-hook
> 'haiku-lost-selection-functions
> ./net/browse-url.el:1044:    ((featurep 'haiku)
> ./image/wallpaper.el:246:        ((featurep 'haiku)

The `haiku' named feature checks for Haiku window system support, while
`system-type' only checks if Emacs (which could be built without window
system support) is running on Haiku.  So this isn't a bug.