From unknown Sat Jun 14 18:45:04 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#57831 <57831@debbugs.gnu.org> To: bug#57831 <57831@debbugs.gnu.org> Subject: Status: [PATCH] testsuite: Remove stray semicolon Reply-To: bug#57831 <57831@debbugs.gnu.org> Date: Sun, 15 Jun 2025 01:45:04 +0000 retitle 57831 [PATCH] testsuite: Remove stray semicolon reassign 57831 sed submitter 57831 Marvin Schmidt severity 57831 normal tag 57831 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 10:36:45 2022 Received: (at submit) by debbugs.gnu.org; 15 Sep 2022 14:36:45 +0000 Received: from localhost ([127.0.0.1]:58825 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYpyu-000134-TM for submit@debbugs.gnu.org; Thu, 15 Sep 2022 10:36:45 -0400 Received: from lists.gnu.org ([209.51.188.17]:44176) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYoB1-0006De-0l for submit@debbugs.gnu.org; Thu, 15 Sep 2022 08:41:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50252) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYoB0-0005W4-SQ for bug-sed@gnu.org; Thu, 15 Sep 2022 08:41:06 -0400 Received: from mail-ej1-x62e.google.com ([2a00:1450:4864:20::62e]:33485) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oYoAz-0003gt-2E for bug-sed@gnu.org; Thu, 15 Sep 2022 08:41:06 -0400 Received: by mail-ej1-x62e.google.com with SMTP id lc7so41929677ejb.0 for ; Thu, 15 Sep 2022 05:41:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date; bh=XYrKqBuc6u7C8kTpLpOzL+vfaPjpO0/j4goxNBMlBK4=; b=Mzg2M7gC7E+5V8HXhfQpi/uWe46xIQIG/KGuJfAlCj55T0IqkQSVODBvAwzZ8rbGN8 kABboa21R6qKvrPz82/q42VN2pPSOyWnYBEFCj+tvJZ51cm3Qvy208wiGaXGbMenKh95 VARVEQMpIhBJBs9xG9je0gvxUSSMvWQaycy0jiRFMfjvTqhT5uIcH5HU5CWTTV/3TuJq 59oIsYjwxaX9T461hnM0MDXcAl+FFW80dhxwGti7pUKUDAFVn9xguxaXp9o9MaN1tEHf uhUzvI8Hp5F/j1QijYVFgZ43woWKb5aiAbnPergX6087N8md3VLDzgizlFPGi8eXFs5+ Lqeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date; bh=XYrKqBuc6u7C8kTpLpOzL+vfaPjpO0/j4goxNBMlBK4=; b=RzskLBADQx3X4K2jWLLsQfDySsunMRQEje7/6dDuBzDf7U6MxIgEgdSdCIFEZ0xLAb n4NpWJnQptMDIO7m9XXMIEcwOVgynYVnHONgR7EPhwiOP3Pbz8xRfJH2wV04ISAMd4fZ Jg0zQOrcx5UymeP0iEiy0XhRvCVhxCty1uC57D0he1j1ANNhGRU1ynsAwknjQlMLYIor Y08IvwLDJ2gmBaBcpfnhRls+3E3Fd50x1wq4iU6emTB4pXZeQsMcWdtle3iUwd/WHYQ/ cxlyLCD830Q+NI2431qKsL7vK298V6pyA8ZoMGPd3hZK+l8M0Vsw9cZ49xzw3Ln9cNI9 q+NA== X-Gm-Message-State: ACgBeo2zke1pIgw9RXOP9wYNT18N6Wer/hht4tjVusGxq0RT0ZA2pe1L 5WuHWvKIeFwNCSLKl3ZjJHakyatKjoo= X-Google-Smtp-Source: AA6agR68ct2VxIg5d3VJnd38jGyljhVKmZWLkeX6L+hE7l090KNBCbutOHBJQc0nbWpAdETPfpGSmg== X-Received: by 2002:a17:907:318b:b0:740:33f2:9e8 with SMTP id xe11-20020a170907318b00b0074033f209e8mr28970689ejb.138.1663245663188; Thu, 15 Sep 2022 05:41:03 -0700 (PDT) Received: from pythagoras.local (dynamic-077-006-157-206.77.6.pool.telefonica.de. [77.6.157.206]) by smtp.gmail.com with ESMTPSA id og12-20020a1709071dcc00b0073a644ef803sm9044058ejc.101.2022.09.15.05.41.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Sep 2022 05:41:02 -0700 (PDT) From: Marvin Schmidt To: bug-sed@gnu.org Subject: [PATCH] testsuite: Remove stray semicolon Date: Thu, 15 Sep 2022 14:41:00 +0200 Message-Id: <20220915124100.2911375-1-marvin.schmidt1987@gmail.com> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::62e; envelope-from=marvin.schmidt1987@gmail.com; helo=mail-ej1-x62e.google.com X-Spam_score_int: -17 X-Spam_score: -1.8 X-Spam_bar: - X-Spam_report: (-1.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Thu, 15 Sep 2022 10:36:40 -0400 Cc: Marvin Schmidt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.1 (--) It unintentionally ends the `export` command causing all the following variables not being exported to the test environment I was backporting the alleged fix[1] for the problem that leads to the following failure of the inplace-selinux.sh ``` inplace-selinux.sh: set-up failure: CONFIG_HEADER not defined ``` but the test still failed for me in the same way. Investigating the problem I noticed that some variables from the `TESTS_ENVIRONMENT` weren't present in the test. I then noticed the semicolon in the `built_program=sed;` line and figured that it probably ends the `export` command unintentionally. Looking at the original patch[1] showed that Chris Marusich inserted the ``` CONFIG_HEADER='$(CONFIG_HEADER)' ``` line just above `built_programs=sed;` which explains why it worked for him originally [1] b8f98f7dc363 ("tests: export CONFIG_HEADER to test scripts") [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36150#16 --- testsuite/local.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/testsuite/local.mk b/testsuite/local.mk index 13e6d004717e..2455af691b86 100644 --- a/testsuite/local.mk +++ b/testsuite/local.mk @@ -160,7 +160,7 @@ TESTS_ENVIRONMENT = \ abs_top_builddir='$(abs_top_builddir)' \ abs_top_srcdir='$(abs_top_srcdir)' \ abs_srcdir='$(abs_srcdir)' \ - built_programs=sed; \ + built_programs=sed \ srcdir='$(srcdir)' \ top_srcdir='$(top_srcdir)' \ CC='$(CC)' \ -- 2.37.3 From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 15:55:30 2022 Received: (at 57831) by debbugs.gnu.org; 15 Sep 2022 19:55:30 +0000 Received: from localhost ([127.0.0.1]:59227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYuxN-0003lP-S0 for submit@debbugs.gnu.org; Thu, 15 Sep 2022 15:55:30 -0400 Received: from mail-lf1-f42.google.com ([209.85.167.42]:46696) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYuxL-0003lB-IX for 57831@debbugs.gnu.org; Thu, 15 Sep 2022 15:55:28 -0400 Received: by mail-lf1-f42.google.com with SMTP id a8so31998214lff.13 for <57831@debbugs.gnu.org>; Thu, 15 Sep 2022 12:55:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=AV4vhhl1B3m9rTwaefmyLXbqqDkuVfdCaw1t6V9WPLI=; b=j2+yol9lMPaXeDylsWUXSxsQJTlFDCFwsafuyDFzKtGsanqGhDQdX5i8w4MStcXE0q /xiCaHIzbAWYrk3AQLjSQIf9ToCqRxMGiOyEnmMHx2L/eA6UuqTflmeAnTCrNXrTOM+A BgYFG0d+9w7ZrWl8sPx6/uLM/thKhqggzxUIlMOobPMyJDwExhjF4fTnEa20dSEULshX 4xpFmozVCS4QW2ExP2MbPRvZ8F+J9LDO1q+qscsymGq6GR6+TB0v2YibC584MR39PNS7 rJloeUlXiSMSgRxrldLFb+UcOtHL91CDS5kpmUe7rwfq/otJfczmm0xOne7v55q3dJOZ 2+tQ== X-Gm-Message-State: ACrzQf0hW7zlRNZfHHHraCIKdGkPS+K+l9RFN3QAaISuG/NJmiab/y5/ F8ka4rNr8Kr9xWQfOFFgumRXNAo2vHL6iKh6gj8= X-Google-Smtp-Source: AMsMyM4ddSwtzK5YhdlUzPNgsUPSdNA7hq/zXt84wBrc6k2YIxpbtxFxw2Ww88aRDlbkjAvqkq9IvXxbd83KcoBk0V4= X-Received: by 2002:a19:4918:0:b0:48c:e6a0:c8d8 with SMTP id w24-20020a194918000000b0048ce6a0c8d8mr491226lfa.679.1663271721513; Thu, 15 Sep 2022 12:55:21 -0700 (PDT) MIME-Version: 1.0 References: <20220915124100.2911375-1-marvin.schmidt1987@gmail.com> In-Reply-To: <20220915124100.2911375-1-marvin.schmidt1987@gmail.com> From: Jim Meyering Date: Thu, 15 Sep 2022 12:55:09 -0700 Message-ID: Subject: Re: bug#57831: [PATCH] testsuite: Remove stray semicolon To: Marvin Schmidt Content-Type: multipart/mixed; boundary="00000000000020a50905e8bca041" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 57831 Cc: 57831@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) --00000000000020a50905e8bca041 Content-Type: text/plain; charset="UTF-8" On Thu, Sep 15, 2022 at 10:32 AM Marvin Schmidt wrote: > It unintentionally ends the `export` command causing all the following > variables not being exported to the test environment > > I was backporting the alleged fix[1] for the problem that leads to the > following failure of the inplace-selinux.sh > ``` > inplace-selinux.sh: set-up failure: CONFIG_HEADER not defined > ``` > but the test still failed for me in the same way. Investigating the > problem I noticed that some variables from the `TESTS_ENVIRONMENT` > weren't present in the test. I then noticed the semicolon in the > `built_program=sed;` line and figured that it probably ends the `export` > command unintentionally. > > Looking at the original patch[1] showed that Chris Marusich inserted the > ``` > CONFIG_HEADER='$(CONFIG_HEADER)' > ``` > line just above `built_programs=sed;` which explains why it worked for > him originally > > [1] b8f98f7dc363 ("tests: export CONFIG_HEADER to test scripts") > [2] https://debbugs.gnu.org/cgi/bugreport.cgi?bug=36150#16 > --- > testsuite/local.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/testsuite/local.mk b/testsuite/local.mk > index 13e6d004717e..2455af691b86 100644 > --- a/testsuite/local.mk > +++ b/testsuite/local.mk > @@ -160,7 +160,7 @@ TESTS_ENVIRONMENT = \ > abs_top_builddir='$(abs_top_builddir)' \ > abs_top_srcdir='$(abs_top_srcdir)' \ > abs_srcdir='$(abs_srcdir)' \ > - built_programs=sed; \ > + built_programs=sed \ > srcdir='$(srcdir)' \ > top_srcdir='$(top_srcdir)' \ > CC='$(CC)' \ Good catch. Thank you for that fix. I introduced the bug with this commit: v4.2.2-100-gb250bd4 I'll push the attached soon: --00000000000020a50905e8bca041 Content-Type: application/octet-stream; name="sed-test-env.diff" Content-Disposition: attachment; filename="sed-test-env.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_l83h0paj0 RnJvbSA5MDQwNDNjY2U3ZDdiM2Q5NGNiNGJhYmI3ZWViZTExMWEwOGE3ZjVhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXJ2aW4gU2NobWlkdCA8bWFydmluLnNjaG1pZHQxOTg3QGdt YWlsLmNvbT4KRGF0ZTogVGh1LCAxNSBTZXAgMjAyMiAxMjo1MToxNCAtMDcwMApTdWJqZWN0OiBb UEFUQ0hdIHRlc3RzOiByZW1vdmUgc3RyYXkgZXhwb3J0LWVuZGluZyBzZW1pY29sb24gaW4gdGVz dCBzZXR1cAoKKiB0ZXN0c3VpdGUvbG9jYWwubWsgKFRFU1RTX0VOVklST05NRU5UKTogUmVtb3Zl IHRoZSBlcnJvbmVvdXMgIjsiCnRoYXQgZWZmZWN0aXZlbHkgZWxpZGVkIGFsbCBmb2xsb3dpbmcg dmFyPXZhbCBwYWlycyBmcm9tIHRoZSB0ZXN0CmVudmlyb25tZW50LiBSZXBvcnQgYW5kIHBhdGNo IGZyb20gaHR0cDovL2J1Z3MuZ251Lm9yZy81NzgzMQpCdWcgaW50cm9kdWNlZCB2aWEgdjQuMi4y LTEwMC1nYjI1MGJkNC4KLS0tCiB0ZXN0c3VpdGUvbG9jYWwubWsgfCAyICstCiAxIGZpbGUgY2hh bmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS90ZXN0c3Vp dGUvbG9jYWwubWsgYi90ZXN0c3VpdGUvbG9jYWwubWsKaW5kZXggMTNlNmQwMC4uMjQ1NWFmNiAx MDA2NDQKLS0tIGEvdGVzdHN1aXRlL2xvY2FsLm1rCisrKyBiL3Rlc3RzdWl0ZS9sb2NhbC5tawpA QCAtMTYwLDcgKzE2MCw3IEBAIFRFU1RTX0VOVklST05NRU5UID0JCQkJXAogICBhYnNfdG9wX2J1 aWxkZGlyPSckKGFic190b3BfYnVpbGRkaXIpJwlcCiAgIGFic190b3Bfc3JjZGlyPSckKGFic190 b3Bfc3JjZGlyKScJCVwKICAgYWJzX3NyY2Rpcj0nJChhYnNfc3JjZGlyKScJCQlcCi0gIGJ1aWx0 X3Byb2dyYW1zPXNlZDsJCQkJXAorICBidWlsdF9wcm9ncmFtcz1zZWQJCQkJXAogICBzcmNkaXI9 JyQoc3JjZGlyKScJCQkJXAogICB0b3Bfc3JjZGlyPSckKHRvcF9zcmNkaXIpJwkJCVwKICAgQ0M9 JyQoQ0MpJwkJCQkJXAotLSAKMi4zNy4zLjY2Mi5nMzZmOGU3ZWQ3ZAoK --00000000000020a50905e8bca041--