From unknown Sun Jun 22 20:56:10 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#5783 <5783@debbugs.gnu.org> To: bug#5783 <5783@debbugs.gnu.org> Subject: Status: [bug #29349] ls.c missing HAVE_NL_LANGINFO check Reply-To: bug#5783 <5783@debbugs.gnu.org> Date: Mon, 23 Jun 2025 03:56:10 +0000 retitle 5783 [bug #29349] ls.c missing HAVE_NL_LANGINFO check reassign 5783 coreutils submitter 5783 Alan Hourihane severity 5783 normal tag 5783 fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 12:11:34 2010 Received: (at submit) by debbugs.gnu.org; 26 Mar 2010 16:11:34 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvC8D-0005bj-Rs for submit@debbugs.gnu.org; Fri, 26 Mar 2010 12:11:34 -0400 Received: from mx10.gnu.org ([199.232.76.166]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvBro-0005Ug-C6 for submit@debbugs.gnu.org; Fri, 26 Mar 2010 11:54:37 -0400 Received: from lists.gnu.org ([199.232.76.165]:49928) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1NvBrj-0001qd-A9 for submit@debbugs.gnu.org; Fri, 26 Mar 2010 11:54:31 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1NvBri-0006qN-Hf for bug-coreutils@gnu.org; Fri, 26 Mar 2010 11:54:30 -0400 Received: from [140.186.70.92] (port=37905 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1NvBrh-0006p6-2g for bug-coreutils@gnu.org; Fri, 26 Mar 2010 11:54:29 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.0 (2010-01-18) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_00,HS_INDEX_PARAM, RDNS_NONE autolearn=no version=3.3.0 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1NvBrf-0005Gx-Cg for bug-coreutils@gnu.org; Fri, 26 Mar 2010 11:54:28 -0400 Received: from colonialone.fsf.org ([140.186.70.51]:37787 helo=internal.in.savannah.gnu.org) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvBrf-0005Gn-BG for bug-coreutils@gnu.org; Fri, 26 Mar 2010 11:54:27 -0400 Received: from [10.1.0.103] (helo=frontend.in.savannah.gnu.org) by internal.in.savannah.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvBrd-0005IZ-5j; Fri, 26 Mar 2010 15:54:25 +0000 Received: from www-data by frontend.in.savannah.gnu.org with local (Exim 4.69) (envelope-from ) id 1NvBrd-0004SD-4A; Fri, 26 Mar 2010 15:54:25 +0000 To: Eric Blake , Alan Hourihane , jim@meyering.net, bug-coreutils@gnu.org Subject: [bug #29349] ls.c missing HAVE_NL_LANGINFO check From: Alan Hourihane X-Savane-Server: savannah.gnu.org:443 [10.1.0.103] MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 X-Savane-Project: coreutils X-Savane-Tracker: bugs X-Savane-Item-ID: 29349 User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.8) Gecko/20100303 Gentoo Firefox/3.5.8 X-Apparently-From: 80.176.228.186 (Savane authenticated user alanh) Message-Id: <20100326-155424.sv52095.73505@savannah.gnu.org> References: <20100326-140452.sv52095.37134@savannah.gnu.org> <20100326-091259.sv1389.99813@savannah.gnu.org> <20100326-152438.sv52095.28975@savannah.gnu.org> <20100326-152746.sv52095.57078@savannah.gnu.org> <20100326-094813.sv1389.34901@savannah.gnu.org> In-Reply-To: <20100326-094813.sv1389.34901@savannah.gnu.org> Date: Fri, 26 Mar 2010 15:54:25 +0000 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-Spam-Score: -6.4 (------) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Fri, 26 Mar 2010 12:11:31 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.4 (------) Follow-up Comment #5, bug #29349 (project coreutils): O.k. But the problem is that when abmon_init returns 0 we get the horrible error message for the case that we don't have HAVE_NL_LANGINFO. And given that abmon_init() already contains this check, we should probably just move the check to around the abmon_init() call as in the attached patch and remove the if/endif in abmon_init() itself. _______________________________________________________ Reply to this item at: _______________________________________________ Message sent via/by Savannah http://savannah.gnu.org/ From debbugs-submit-bounces@debbugs.gnu.org Fri Mar 26 14:22:36 2010 Received: (at control) by debbugs.gnu.org; 26 Mar 2010 18:22:36 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvEB2-0006UH-CH for submit@debbugs.gnu.org; Fri, 26 Mar 2010 14:22:36 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NvEB0-0006U9-ER for control@debbugs.gnu.org; Fri, 26 Mar 2010 14:22:34 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.69) (envelope-from ) id 1NvEAv-0001kU-CG; Fri, 26 Mar 2010 14:22:29 -0400 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Message-ID: <19372.64357.289117.642050@fencepost.gnu.org> Date: Fri, 26 Mar 2010 14:22:29 -0400 From: Glenn Morris To: control Subject: control X-Attribution: GM X-Mailer: VM (www.wonderworks.com/vm), GNU Emacs (www.gnu.org/software/emacs) X-Hue: white X-Ran: wAru+q8flFd2j@Oe&cz+WUw^bP%Sm<'e*%%+,K{g/&{$L)A_8Osw:$Ms&nSl2Sc|w9'lTV X-Debbugs-No-Ack: yes X-Spam-Score: -5.1 (-----) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -5.1 (-----) merge 5776 5778 5779 5780 5781 5783 severity 5762 wishlist tags 5762 patch close 5755 close 5749 retitle 5749 append-to-buffer and point reassign 5767 emacs,gnus user emacs23.3 usertags 5755 port-from-trunk From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 30 00:47:09 2018 Received: (at 5783) by debbugs.gnu.org; 30 Oct 2018 04:47:09 +0000 Received: from localhost ([127.0.0.1]:53024 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHLvo-0002OW-P2 for submit@debbugs.gnu.org; Tue, 30 Oct 2018 00:47:08 -0400 Received: from mail-it1-f172.google.com ([209.85.166.172]:50389) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gHLvm-0002Iq-Ri; Tue, 30 Oct 2018 00:47:07 -0400 Received: by mail-it1-f172.google.com with SMTP id k206-v6so12317079ite.0; Mon, 29 Oct 2018 21:47:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=5lRKLHq0SHUBWEZAhNvhqZqT5pH8DcDF37x/9HvML/g=; b=LRtI4K8JlRF2uihherwna705f7NGLatIhv7qhVxUv+w17aHU4WGhYdm9a+nSoSGI9Q D3aVUig4QsuLtf287KsZfDuiX630vOTbAezKqenX+Lxk2fPjAqHsK0AYW4FP58ZmDs+0 OWECaxr0IgyV4fqOuMlDlAwvHWFKEgy/0fhwKXltls25uADQuahT3gzZwaErWdXe/oCx b7YZoJkAD4WkaEp40xFoh3kT2FcwNnoEWRlX9W1cK2g/RynBNIMieVnlOZcHqNTQxbxh vZZISW1PdCxWzwLRPBtGR6MmCJTH20IU2KtlJ3kON2J6UKvUFdsSGzMZ9zx3YSqSkYx3 wDSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=5lRKLHq0SHUBWEZAhNvhqZqT5pH8DcDF37x/9HvML/g=; b=lsoIhCAfRFbeEYH1u0kiYWxhv/LI7i/0lf+Hb9AzIjI1DaBoTl2ynJ7NVRN2cOvPbD TYVKDy3J/3UMvVIvx75g7Cq0xaM8l1TP7xfAOF2sg+plAjpSKuF7wU4MS5gmhKriiBeo gI1vpgpcC7vjUisSb8yoTKo7Ij65WHeO48fUwvVqbHzTPoF9Si5m/ySqMQk7umVbWMSL oMlvzMeIQOMfFK2BAE/BfMJZXHukF425DdUc7tXOh9B3lAAlmqH6A0t+N8PNrIy+CGbw W81Dv9QFnuO4O3jlz1GT+1TfC6omjql9b/Bryw5PscuoyJSaiKeolAPFUIOrey5WkjE6 QxGQ== X-Gm-Message-State: AGRZ1gJBLA7OaDaNCr1Um3hL24JaDpV4gnICoJbQcnic4fEToznyksHE v0n++I87Dx24A3QRcP7UG5u5FXKxaZ8= X-Google-Smtp-Source: AJdET5elMrBD7RLn5LVDsmEv1kNKVFqL4/2YgEeDzHw2w2visq5eemA5pn0s+5TbRJzDDYr1BV2Ncg== X-Received: by 2002:a24:21d5:: with SMTP id e204-v6mr331687ita.127.1540874820612; Mon, 29 Oct 2018 21:47:00 -0700 (PDT) Received: from tomato.housegordon.com (moose.housegordon.com. [184.68.105.38]) by smtp.googlemail.com with ESMTPSA id v21-v6sm7535877iob.7.2018.10.29.21.46.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 29 Oct 2018 21:46:59 -0700 (PDT) To: 5783@debbugs.gnu.org From: Assaf Gordon Subject: bug5783: ls.c missing HAVE_NL_LANGINFO check Message-ID: <729e1e2c-f5bc-cf11-3b04-16784bf6dd26@gmail.com> Date: Mon, 29 Oct 2018 22:46:51 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 5783 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 5783 fixed close 5783 stop triaging very old bug: https://debbugs.gnu.org/5783 and https://savannah.gnu.org/bugs/?29349 . In 2016, Paul committed the following: ls: fix %%b format and precompute more https://git.savannah.gnu.org/cgit/coreutils.git/commit/?id=1db94ee969b984bbd00b97c6abbe2f69db8e0000 Which I believe fixes the ls/month issue (compare the commit with the suggested patch from 2010: https://savannah.gnu.org/bugs/download.php?file_id=20037 ). As such, I'm closing this bug (if that's wrong, re-open it). Discussion can continue by replying to this thread. -assaf From unknown Sun Jun 22 20:56:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 27 Nov 2018 12:24:12 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator