GNU bug report logs - #5782
[PATCH] tests: fix typos in envvar-check script

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5782 in the body.
You can then email your comments to 5782 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: bug-coreutils <at> gnu.org
Subject: [PATCH] tests: fix typos in envvar-check script
Date: Fri, 26 Mar 2010 16:50:59 +0100

When reusing code like this for grep,
I stumbled across the variable name mismatch:

From 8915368ee3f9580155a8a3119a27e9615368a846 Mon Sep 17 00:00:00 2001
From: Jim Meyering <meyering <at> redhat.com>
Date: Fri, 26 Mar 2010 16:46:23 +0100
Subject: [PATCH] tests: fix typos in envvar-check script

* tests/envvar-check: Fix variable name typos.
Probably harmless, since no selected shell would fail to unset.
---
 tests/envvar-check |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/envvar-check b/tests/envvar-check
index e31b941..1dee9af 100644
--- a/tests/envvar-check
+++ b/tests/envvar-check
@@ -21,9 +21,9 @@ if (FOO=FOO; unset FOO) >/dev/null 2>&1; then
 else
   as_unset=false
 fi

-envvar_check_failed=0
+envvar_check_fail=0
 vars='
   _POSIX2_VERSION
   BLOCKSIZE
   BLOCK_SIZE
@@ -48,9 +48,9 @@ do
   $as_unset $var
   if eval test \"\${$var+set}\" = set; then
     echo "$0: the $var environment variable is set --" \
       ' unset it and rerun this test' >&2
-    envvar_check_failed=1
+    envvar_check_fail=1
   fi
 done

 test "$envvar_check_fail" = 1 && exit 1
--
1.7.0.3.448.g82eeb

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.