GNU bug report logs - #57813
Icon images are non-functional

Previous Next

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Juri Linkov <juri <at> linkov.net>
Cc: 57813 <at> debbugs.gnu.org
Subject: bug#57813: Icon images are non-functional
Date: Mon, 19 Sep 2022 15:12:25 +0300

> From: Juri Linkov <juri <at> linkov.net>
> Cc: 57813 <at> debbugs.gnu.org
> Date: Sun, 18 Sep 2022 22:06:56 +0300
> 
> > Thanks.  I only quickly read the patch, and have one comment: the
> > hard-coded left-margin should depend on the value returned by
> > current-bidi-paragraph-direction, because text that is displayed
> > right-to-left should have the icons on the right margin, not left
> > margin.
> 
> To not create a new mirrored image file for RTL arrow required a change in
> icons--create to support ':rotation 180' for the existing image file:
> 
>   (define-icon outline-close-rtl-in-margins outline-close
>     '((image "outline-close.svg" "outline-close.pbm"
>              :height 10 :ascent center :rotation 180))
>     "Icon used for buttons for closing a section in outline buffers."
>     :version "29.1"
>     :help-echo "Close this section")
> 
> Then the right margin could be used with:

Thanks, the code LGTM.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.