GNU bug report logs - #57809
[PATCH] gnome-boxes: Add 'qemu' as propagated-input

Previous Next

Full log

View this message in rfc822 format

From: Maxime Devos <maximedevos <at> telenet.be>
To: Jacob Hrbek <kreyren <at> rixotstudio.cz>, 57809 <at> debbugs.gnu.org
Subject: [bug#57809] [PATCH] gnome-boxes: Patch 'qemu-img' path
Date: Mon, 19 Sep 2022 15:41:24 +0200

[Message part 1 (text/plain, inline)]

On 19-09-2022 06:09, Jacob Hrbek wrote:
> +                          (setenv "DESTDIR" "/")))
> +                      (add-before 'configure 'substitute-qemu-dependencies
> +                        (lambda* (#:key inputs #:allow-other-keys)
> +
>                  (substitute* "src/installed-media.vala"
> +                              (("qemu-img")
> +                               (search-input-file inputs "/bin/qemu-img"))))))))

Aside from the indentation (which would IIUC be corrected by "guix 
style", see point (5) of the checklist in "(guix)Submitting Patches")) ...

>       (native-inputs
>        (list desktop-file-utils           ;for update-desktop-database
>              gettext-minimal
> @@ -12162,6 +12167,7 @@ (define-public gnome-boxes
>              sparql-query
>              spice-gtk
>              tracker


> +           qemu-minimal                 ;for qemu-img

... and the non-alphabetical sorting, ...

>              vte
>              webkitgtk-with-libsoup2))    ;for webkit2gtk-4.0

... looks good to me (though to be clear, I did not test the changes), 
though those problems can be addressed by the committer (just a note for 
future submissions).

Greetings,
Maxime.

[OpenPGP_0x49E3EE22191725EE.asc (application/pgp-keys, attachment)]

[OpenPGP_signature (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.