Subject: Re: [bug#57809] [PATCH] gnome-boxes: Add 'qemu' as propagated-input

From: Maxime Devos <[email-masked]>
Date: Thu, 15 Sep 2022 15:03:21 +0200

On 14-09-2022 20:17, Jacob Hrbek wrote:
> Fixes:
> 
> (gnome-boxes:9304): Boxes-WARNING **: 19:54:29.345: review-page.vala:32: Box setup failed: Failed to create volume: internal error: creation of non-raw file images is not supported without qemu-img.
> 
> (gnome-boxes:9304): Boxes-CRITICAL **: 19:54:29.345: boxes_assistant_review_page_populate: assertion 'machine != NULL' failed
> 
> Steps to reproduce:
> 1. Open gnome-boxes on GNU Guix
> 2. Try to create a box with GNU Guix ISO and expect failure above
> 
> 

Instead of propagation, I recommend doing a substitute* instead, to 
avoid the usual downsides of propagation.  Searching for 'qemu-img' in 
the source code of gnome-boxes (with tar, grep -rF and guix build 
--source), I found:

src/installed-media.vala:        string[] argv = { "qemu-img", 
"convert", "-O", "qcow2", device_file, destination_path };

Could you substitute* "qemu-img" -> (search-input-file inputs 
"bin/qemu-img") and move QEMU from 'propagated-inputs' to 'inputs'.

Greetings,
Maxime.