From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Sep 2022 17:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 57807@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.1663176001958 (code B ref -1); Wed, 14 Sep 2022 17:20:02 +0000 Received: (at submit) by debbugs.gnu.org; 14 Sep 2022 17:20:01 +0000 Received: from localhost ([127.0.0.1]:55972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYW3N-0000FG-84 for submit@debbugs.gnu.org; Wed, 14 Sep 2022 13:20:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:33242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYW3J-0000F5-Pn for submit@debbugs.gnu.org; Wed, 14 Sep 2022 13:19:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYW3F-0007CK-Tv for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 13:19:55 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYW3D-0007CD-E4 for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 13:19:53 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B00E75C00F0 for ; Wed, 14 Sep 2022 13:19:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Sep 2022 13:19:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1663175989; x=1663262389; bh=UnqKUoO930WCqRlYsPk7Ql4dq7u+dWw5WMK T/ZTUrBY=; b=e4j9/qMDfF45Wt5dGUC74+Gv4ugZxvDfyqvAKz2a9cPMG9eBt6l CrTuQJ/enfIKoPT9TGyVPkkqfUkngtjRmu/6k0R3tkkFpIMO4xFFSaZt+uTOVsnx 9D0o+IRwXBC01OIqJ7x6kHqiBovTV+rYT0i2xMNS+CPm6b8umgROQyVIeeHKCvz+ NpsfwJf7WM0WT4RBOeuNi2REDuWXgUGdgAP/wLXHvCkuIAs1CVroiwm3bEbWIUBc peu+XTSTS2Z621ZVLsmzKO36VXA87zAwk/qpP0lRlzwAk2oFqTK7pEF27A0wY0Er Ekduq/+/P7urYhX7kTpjf94j6xZn7Q0pNhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663175989; x= 1663262389; bh=UnqKUoO930WCqRlYsPk7Ql4dq7u+dWw5WMKT/ZTUrBY=; b=b q/jHc9rlt4IDnmeiKLQZeuaxDjodl9xEcl9/S0qqlGwgKvf14repdmydXaBdN6qa tmYqF1p3D9IBBA+bL03kg+mu1wwEppDCE0977XS3uyXP5wkAqG0W3gWCoUTol9uF sZfB7Hnl3qn8ifKarr6tv93nHhwuOWxpV9c3BJhSIqKuLxsuaESJNPf8b3Y85Fk1 qAVHRgh99pLhPg3b6OWuDFeF4LhARjCrdX7LkZ5MgEHVWf1WXPTAdIOrAYXb5QVt oUD9eHwJgIbi0YSqMfvvJlnM7NgTGWFYMq13AItCBzbukZSu2fBUfyBuf5Bbuf+L mY3hnhQZDu7ZiOahD3/wg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduiedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgfgggtsehttddttd dtredtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehs phifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepfffgheeggffgheeuvd ethfekuddtgffgtdeukeegkedttefftdeghfdvgfdtjeelnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhih htthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 14 Sep 2022 13:19:49 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id BF8BF7F1678; Wed, 14 Sep 2022 10:19:48 -0700 (MST) From: Sean Whitton Date: Wed, 14 Sep 2022 10:19:48 -0700 Message-ID: <87czbxub4b.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.27; envelope-from=spwhitton@spwhitton.name; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Hello, vc-git-log-edit-mode is already able to properly understand git-log(1) output which logs multiple branches. Here's a hack to demonstrate that: (let ((default-directory "~/src/emacs/") (vc-git-log-switches (cons "origin/scratch/posix-spawn" vc-git-log-switches))) (call-process-shell-command "git branch -f tmp 4b2ca6bfc0") (vc-print-branch-log "tmp")) (4b2ca6bfc0 is an old tip of master close to scratch/posix-spawn.) An example of a case in which it is useful to produce logs like this is when you're trying to figure out how several feature branches relate to each other and to the trunk. I don't think the idea of producing a log showing more than one branch at once is fundamentally git-specific. So I would like to extend vc-print-branch-log to allow logging more than one branch, or alternatively, add a vc-print-branch-logs command. I believe that there are two design issues, on which I'm requesting review/input: (1) Extending the VC history functions API to permit expressing a request for the backend to print a log of multiple branches. We could allow the START-REVISION argument to `print-log' to take a list of branches, or add an additional optional argument ADDITIONAL-START-REVISIONS. The latter seems more robust to me. (2) How could vc-print-branch-log prompt the user for multiple branch names? Magit has the user separate branch names with commas, offering completion for each branch name. But I suppose commas never appearing in branch names is git-specific. So the command could prompt the user repeatedly for branch names, until the user hits RET to input a zero-length branch name, indicating they've input them all. -- Sean Whitton From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Sep 2022 17:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.16631773273229 (code B ref 57807); Wed, 14 Sep 2022 17:43:02 +0000 Received: (at 57807) by debbugs.gnu.org; 14 Sep 2022 17:42:07 +0000 Received: from localhost ([127.0.0.1]:56010 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYWOj-0000pz-8G for submit@debbugs.gnu.org; Wed, 14 Sep 2022 13:42:07 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40558) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYWOe-0000pS-FV for 57807@debbugs.gnu.org; Wed, 14 Sep 2022 13:42:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36076) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYWOZ-0003Bj-8Y; Wed, 14 Sep 2022 13:41:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=jaLtRXBCL95jdodm0uxFJpNzaBMy9+axO41p13PFQSw=; b=bVQRaVRr2e5t ON2HOQCV1au89KQWC3LlHkpdUlioonAK+qxFTuhDHLGA1T5E9+xcwLWFmOV9G6XjbuSk58GiIuQbg x0xdtZ4ArigevPo6+xKbjaU219PS2VPfJi3h3CbYNwynGSRPtyk59rYSNq9Jh0LMkFJ69ZD4Oj4GQ B3EqtngEryTsaqrCDfzfJ8MxKxUOXYZgyIOiZFFphiGDkdqCo9GamHnmdFb4pIV5Vm6KTYNvwFOtv ThnaWxZPa9uH3LtdVQ7hzfTGdQZaYnRCkNNVili8boG6d1FFiFQ+gb+f5gd4kxJ4B61tMlncoEJky XIdg0dryu9T3yt/9WZORKQ==; Received: from [87.69.77.57] (port=4977 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYWOO-0007Bu-Md; Wed, 14 Sep 2022 13:41:54 -0400 Date: Wed, 14 Sep 2022 20:41:35 +0300 Message-Id: <83sfkt26r4.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87czbxub4b.fsf@melete.silentflame.com> (message from Sean Whitton on Wed, 14 Sep 2022 10:19:48 -0700) References: <87czbxub4b.fsf@melete.silentflame.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Whitton > Date: Wed, 14 Sep 2022 10:19:48 -0700 > > vc-git-log-edit-mode is already able to properly understand git-log(1) > output which logs multiple branches. Here's a hack to demonstrate that: > > (let ((default-directory "~/src/emacs/") > (vc-git-log-switches > (cons "origin/scratch/posix-spawn" vc-git-log-switches))) > (call-process-shell-command "git branch -f tmp 4b2ca6bfc0") > (vc-print-branch-log "tmp")) > > (4b2ca6bfc0 is an old tip of master close to scratch/posix-spawn.) > > An example of a case in which it is useful to produce logs like this is > when you're trying to figure out how several feature branches relate to > each other and to the trunk. > > I don't think the idea of producing a log showing more than one branch > at once is fundamentally git-specific. So I would like to extend > vc-print-branch-log to allow logging more than one branch, or > alternatively, add a vc-print-branch-logs command. I believe that there > are two design issues, on which I'm requesting review/input: > > (1) Extending the VC history functions API to permit expressing a > request for the backend to print a log of multiple branches. We could > allow the START-REVISION argument to `print-log' to take a list of > branches, or add an additional optional argument > ADDITIONAL-START-REVISIONS. The latter seems more robust to me. > > (2) How could vc-print-branch-log prompt the user for multiple branch > names? Magit has the user separate branch names with commas, offering > completion for each branch name. But I suppose commas never appearing > in branch names is git-specific. So the command could prompt the user > repeatedly for branch names, until the user hits RET to input a > zero-length branch name, indicating they've input them all. I'm not sure I understand: how is this different from what "C-x v L" already produces? From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Sep 2022 19:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166318384315606 (code B ref 57807); Wed, 14 Sep 2022 19:31:02 +0000 Received: (at 57807) by debbugs.gnu.org; 14 Sep 2022 19:30:43 +0000 Received: from localhost ([127.0.0.1]:56296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYY5r-00043e-G5 for submit@debbugs.gnu.org; Wed, 14 Sep 2022 15:30:43 -0400 Received: from relay12.mail.gandi.net ([217.70.178.232]:43223) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYY5p-00043D-5v for 57807@debbugs.gnu.org; Wed, 14 Sep 2022 15:30:41 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id B5D4A200003; Wed, 14 Sep 2022 19:30:31 +0000 (UTC) From: Juri Linkov In-Reply-To: <87czbxub4b.fsf@melete.silentflame.com> (Sean Whitton's message of "Wed, 14 Sep 2022 10:19:48 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> Date: Wed, 14 Sep 2022 22:17:13 +0300 Message-ID: <86v8ppn5b2.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > vc-git-log-edit-mode is already able to properly understand git-log(1) I suppose vc-git-log-view-mode, not vc-git-log-edit-mode? > output which logs multiple branches. Here's a hack to demonstrate that: > > (let ((default-directory "~/src/emacs/") > (vc-git-log-switches > (cons "origin/scratch/posix-spawn" vc-git-log-switches))) > (call-process-shell-command "git branch -f tmp 4b2ca6bfc0") > (vc-print-branch-log "tmp")) > > (4b2ca6bfc0 is an old tip of master close to scratch/posix-spawn.) Is this equivalent to `M-& git log origin/scratch/posix-spawn 4b2ca6bfc0`, then enabling vc-git-log-view-mode in the output buffer? > An example of a case in which it is useful to produce logs like this is > when you're trying to figure out how several feature branches relate to > each other and to the trunk. I never encountered anything like this. I wonder if this is a common need? > I don't think the idea of producing a log showing more than one branch > at once is fundamentally git-specific. So I would like to extend > vc-print-branch-log to allow logging more than one branch, or > alternatively, add a vc-print-branch-logs command. Maybe vc-print-branch-logs, to keep the original vc-print-branch-log uncomplicated. > I believe that there are two design issues, on which I'm requesting > review/input: > > (1) Extending the VC history functions API to permit expressing a > request for the backend to print a log of multiple branches. We could > allow the START-REVISION argument to `print-log' to take a list of > branches, or add an additional optional argument > ADDITIONAL-START-REVISIONS. The latter seems more robust to me. > > (2) How could vc-print-branch-log prompt the user for multiple branch > names? Magit has the user separate branch names with commas, offering > completion for each branch name. But I suppose commas never appearing > in branch names is git-specific. So the command could prompt the user > repeatedly for branch names, until the user hits RET to input a > zero-length branch name, indicating they've input them all. Maybe by using completing-read-multiple with branch names separated by crm-separator, not necessarily comma? From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Sep 2022 22:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166319538410646 (code B ref 57807); Wed, 14 Sep 2022 22:44:02 +0000 Received: (at 57807) by debbugs.gnu.org; 14 Sep 2022 22:43:04 +0000 Received: from localhost ([127.0.0.1]:56483 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYb60-0002lc-AC for submit@debbugs.gnu.org; Wed, 14 Sep 2022 18:43:04 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47883) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYb5x-0002l7-Q9 for 57807@debbugs.gnu.org; Wed, 14 Sep 2022 18:43:03 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id AEF965C00D4; Wed, 14 Sep 2022 18:42:55 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Wed, 14 Sep 2022 18:42:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663195375; x=1663281775; bh=l6KX7S3I0C DEV2CJ4wftOvyO0Ei7zeZ+5KBfl7IR1Og=; b=m2cFg2XGcovurpewdeRswAemSQ KAomqb1ARrPlmEPYNQ3PM5XGYohKolS0/aecRUcGvSE5gXqNG+9RAWDeEsKC9kKr rC6U1JZHqyEG3VSQdqW6GGS3yZulNu04pGHh/vv2rqnks9Dlb4uQ/9kd6ev9uU+4 dSwjEsMjYzBVAt9dA9n0oaLGj+Sd8Q9XpqVoi6x2UxS1PjsAdGE8Sw+ag3wQ5hPL gi/m0Q3nGQyC8WYQjj01cemEe0hiHs/J4K0064j4xc2CNxctG1nLOdfp2bYHkRGT mufRwp7H3+uIl6N7mZSB3KZKbfvZ3vlroL8ZZUVjHwhvyVJw8GaJx0+VZViA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663195375; x=1663281775; bh=l6KX7S3I0CDEV2CJ4wftOvyO0Ei7 zeZ+5KBfl7IR1Og=; b=MW53yRely87FQBzCUpZbB+qXVhn1KcQRr/W+FI1QXsDV aAIlVne08kTxAMGIi5YIti4kH2Tkh6d44Tx5CJIBWTcE5H+O8TQ6zClLFJ6HDJpo p8HAmAY6T7Ea5PlF8eZnSjXCG5ugN/6eUDiy8UBVQsa6vo8rTNl/5iKCkQ/Nf2es 0HHRW2e/jsPuowZhcJxIvrKZNc8u+wv4KBxqNetzIDp/lo5x4YQbOy1Xot/s6fBP rfYv6bCnytURA1RXUcV1LgjeFf3JELzADEmzHaKRsxNlPx+KNGB0O6zlzApkjWWl HVzSb/y+28uUkvgEEPQnc51gxtmO09KeAGpThBRh5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedujedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepffeutedtfedvtdetvefgueefjefggedugfefuddtgeefteek heduvdefjeejieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 18:42:55 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 1C6C67F18D3; Wed, 14 Sep 2022 15:42:54 -0700 (MST) From: Sean Whitton In-Reply-To: <83sfkt26r4.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 14 Sep 2022 20:41:35 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <83sfkt26r4.fsf@gnu.org> Date: Wed, 14 Sep 2022 15:42:54 -0700 Message-ID: <87leqlshld.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 14 Sep 2022 at 08:41PM +03, Eli Zaretskii wrote: > I'm not sure I understand: how is this different from what "C-x v L" > already produces? Here's an example showing logging two branches "melete" and "erebus" in a repo of mine: * 8d679018 (origin/erebus) sync from melete ~/doc on erebus * 44398919 use light-on-dark on erebus * 272fc7a6 manual DPMS on erebus since it means no sound * 22fc8f11 erebus wallpaper * 512eb187 erebus terminal font size | * 038c0a31 (HEAD -> melete, origin/melete) sync from erebus ~/doc on melete | * 8197e31e modus-vivendi on melete for erebus |/ * c3f9d152 (origin/master, origin/HEAD, master) attempt to ensure [...] * 643b20f6 spw/maybe-scale-basic-faces: simplify checking fonts were found >From this view one is able to see how erebus is 5 commits ahead of master and melete is two (different) commits ahead of master. -- Sean Whitton From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 14 Sep 2022 22:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov , 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166319549810863 (code B ref 57807); Wed, 14 Sep 2022 22:45:02 +0000 Received: (at 57807) by debbugs.gnu.org; 14 Sep 2022 22:44:58 +0000 Received: from localhost ([127.0.0.1]:56489 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYb7p-0002p8-Oa for submit@debbugs.gnu.org; Wed, 14 Sep 2022 18:44:58 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47931) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYb7o-0002ov-1v for 57807@debbugs.gnu.org; Wed, 14 Sep 2022 18:44:56 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 007135C00E6; Wed, 14 Sep 2022 18:44:51 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 14 Sep 2022 18:44:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663195490; x=1663281890; bh=qJm1dsHgGG yWE92LYtk0uZVEj2MuIMu3W2Hg0nfBjJ0=; b=m7gPZqWOqCZjTVUAjZWbqcGcrK IXfwN2l3iGcUPSTRIqyBbXQTYU4PF4dhp7mGvhudhVV+5uEAKZa3BRs81x11batd 2M09SgRppZdmBOyUM8dP7Scn6Ep+Wx+8rMY6lH6Q8w2NFoM10S+79OUmjOrtJnjX CRfO1LztGGbHbL/3GOHnzjTMz1YB57rFILy1TIInVHLubFXV5uNFiTFqGmvEhSTH 0/pZF65JSmhy2Lry32pEMwgXBVm4559z3sBn3aG3QJ1Jpj7ktW63cchlFsO5a0hQ n54GpSJQbNjjrl8Jz3UQzdUa/6x24OgcrC2xTekJB+97f5s+547ZhB0XQBEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663195490; x=1663281890; bh=qJm1dsHgGGyWE92LYtk0uZVEj2Mu IMu3W2Hg0nfBjJ0=; b=S85yVotcu4s/5NA/lJj5iVDdFs3d12GY+x2kbipRYWmc RmhkbUNoGtCaCZpED+rpmG4oJe5hetJGd3HeXHMDAtFEhlxzYBGMdldqQztI7wfo qgJDHlJngrBdoxj17CDzyybXqNYVn7mi6u+o6z+4WJcEqLiPQ4jLSp7cMpIX/Tmm MkKdiW3SNqqIcqG3D98fPKTqM9esHDliZP/bDToegwM1Roc5ZI2XXlWhQSEf5Je7 ilsaI9YJIZ7iZWxcgOx1Yz0JxGYpzpqLbA07+lNt3YF+ohbFl+QKDauJ2mhiamFD /zpVnE0kPXVLiHPDwlsvDxy2oenShf9CoAfDW4/a5A== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedujedgudehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepffeutedtfedvtdetvefgueefjefggedugfefuddtgeefteek heduvdefjeejieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 14 Sep 2022 18:44:50 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 0E27F7F18D3; Wed, 14 Sep 2022 15:44:50 -0700 (MST) From: Sean Whitton In-Reply-To: <86v8ppn5b2.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 14 Sep 2022 22:17:13 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> Date: Wed, 14 Sep 2022 15:44:49 -0700 Message-ID: <87h719shi6.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 14 Sep 2022 at 10:17PM +03, Juri Linkov wrote: >> vc-git-log-edit-mode is already able to properly understand git-log(1) > > I suppose vc-git-log-view-mode, not vc-git-log-edit-mode? Yes, sorry. >> output which logs multiple branches. Here's a hack to demonstrate that: >> >> (let ((default-directory "~/src/emacs/") >> (vc-git-log-switches >> (cons "origin/scratch/posix-spawn" vc-git-log-switches))) >> (call-process-shell-command "git branch -f tmp 4b2ca6bfc0") >> (vc-print-branch-log "tmp")) >> >> (4b2ca6bfc0 is an old tip of master close to scratch/posix-spawn.) > > Is this equivalent to `M-& git log origin/scratch/posix-spawn 4b2ca6bfc0`, > then enabling vc-git-log-view-mode in the output buffer? It's not, because vc-git-log-view-mode requires you pass four or five options to git-log to get output it can properly display. That knowledge is locked up in vc-git.el right now. > Maybe vc-print-branch-logs, to keep the original vc-print-branch-log > uncomplicated. Perhaps a prefix argument? >> (2) How could vc-print-branch-log prompt the user for multiple branch >> names? Magit has the user separate branch names with commas, offering >> completion for each branch name. But I suppose commas never appearing >> in branch names is git-specific. So the command could prompt the user >> repeatedly for branch names, until the user hits RET to input a >> zero-length branch name, indicating they've input them all. > > Maybe by using completing-read-multiple with branch names separated > by crm-separator, not necessarily comma? I guess it would be a strange VC system that allows spaces in branch names, huh? -- Sean Whitton From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2022 05:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166322000128130 (code B ref 57807); Thu, 15 Sep 2022 05:34:01 +0000 Received: (at 57807) by debbugs.gnu.org; 15 Sep 2022 05:33:21 +0000 Received: from localhost ([127.0.0.1]:56742 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYhV2-0007Je-Un for submit@debbugs.gnu.org; Thu, 15 Sep 2022 01:33:21 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYhUy-0007JN-2B for 57807@debbugs.gnu.org; Thu, 15 Sep 2022 01:33:19 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:40814) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYhUs-0008RC-Qz; Thu, 15 Sep 2022 01:33:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=ZioPfNN7b1A8bw8p95qFbOrqoYzOqJD4EHV0eq58kcM=; b=S7KSCLIKuV7d Qx4MRSzcUlSulcx1iHSr00veHmHWQVtdO7oFl902+sAM87aaAdcEzzkKPDS4Br2gaykyS0TDdviI7 6pwwc/8Pb2oWK8dS/2wOzoeqGi+XfDAVJp4uNxrzy6nWuxvtHMwSeTKD7Lya1D9xaqjy8x1v7aBLM m5PN7JrYPaOrOl53b83vWt2LI1fCWm2S5h9Qjh/L1gApWlLnEa+D2tWkOx+0G1iG88FBt9CX2Fwdw 9dlc9iZloRZjYr0rjR2wUgBcwjq2izUvUWUT1OLpv3HOUw/OLR3p5x7g+V5gPbzBDNTkvqbuDPoPl v891u5yzQwJ5a4YsIt+xsg==; Received: from [87.69.77.57] (port=4632 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYhUr-0000sE-Mp; Thu, 15 Sep 2022 01:33:10 -0400 Date: Thu, 15 Sep 2022 08:33:00 +0300 Message-Id: <83fsgt19tf.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87leqlshld.fsf@melete.silentflame.com> (message from Sean Whitton on Wed, 14 Sep 2022 15:42:54 -0700) References: <87czbxub4b.fsf@melete.silentflame.com> <83sfkt26r4.fsf@gnu.org> <87leqlshld.fsf@melete.silentflame.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Whitton > Date: Wed, 14 Sep 2022 15:42:54 -0700 > > On Wed 14 Sep 2022 at 08:41PM +03, Eli Zaretskii wrote: > > > I'm not sure I understand: how is this different from what "C-x v L" > > already produces? > > Here's an example showing logging two branches "melete" and "erebus" in > a repo of mine: > > * 8d679018 (origin/erebus) sync from melete ~/doc on erebus > * 44398919 use light-on-dark on erebus > * 272fc7a6 manual DPMS on erebus since it means no sound > * 22fc8f11 erebus wallpaper > * 512eb187 erebus terminal font size > | * 038c0a31 (HEAD -> melete, origin/melete) sync from erebus ~/doc on melete > | * 8197e31e modus-vivendi on melete for erebus > |/ > * c3f9d152 (origin/master, origin/HEAD, master) attempt to ensure [...] > * 643b20f6 spw/maybe-scale-basic-faces: simplify checking fonts were found > > >From this view one is able to see how erebus is 5 commits ahead of > master and melete is two (different) commits ahead of master. So the difference is that what you want to see is all the branches up to their HEAD, and not just branches merged into the current branch, is that right? If so, I guess some optional feature of "C-x v L" could do that. However, if the repository has many branches (and ours, for example, does), wouldn't that make for a crowded and hard-t-read log buffer? Perhaps asking the user for a name of one branch will be enough? More than one branch could be problematic on display, I think. From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2022 07:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.16632252404567 (code B ref 57807); Thu, 15 Sep 2022 07:01:02 +0000 Received: (at 57807) by debbugs.gnu.org; 15 Sep 2022 07:00:40 +0000 Received: from localhost ([127.0.0.1]:56840 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYirY-0001Bb-Gn for submit@debbugs.gnu.org; Thu, 15 Sep 2022 03:00:40 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:33365) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYirW-0001BL-IL for 57807@debbugs.gnu.org; Thu, 15 Sep 2022 03:00:39 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 8FECD1C0002; Thu, 15 Sep 2022 07:00:29 +0000 (UTC) From: Juri Linkov In-Reply-To: <87h719shi6.fsf@melete.silentflame.com> (Sean Whitton's message of "Wed, 14 Sep 2022 15:44:49 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> Date: Thu, 15 Sep 2022 09:59:59 +0300 Message-ID: <861qsdktqo.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Is this equivalent to `M-& git log origin/scratch/posix-spawn 4b2ca6bfc0`, >> then enabling vc-git-log-view-mode in the output buffer? > > It's not, because vc-git-log-view-mode requires you pass four or five > options to git-log to get output it can properly display. That > knowledge is locked up in vc-git.el right now. This part is clear, but I also wanted to know what git command corresponds to this feature. Is it just `git log` with two branch names on the command line? What additional options are required? Maybe `--graph --oneline`? Also I see that git documentation mentions `--branches[=]`. From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2022 16:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov , 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166325856725198 (code B ref 57807); Thu, 15 Sep 2022 16:17:02 +0000 Received: (at 57807) by debbugs.gnu.org; 15 Sep 2022 16:16:07 +0000 Received: from localhost ([127.0.0.1]:58992 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYrX5-0006YM-ID for submit@debbugs.gnu.org; Thu, 15 Sep 2022 12:16:07 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:48341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYrX0-0006Xh-Pp for 57807@debbugs.gnu.org; Thu, 15 Sep 2022 12:16:06 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 80B005C00BB; Thu, 15 Sep 2022 12:15:57 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 15 Sep 2022 12:15:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663258557; x=1663344957; bh=3wXVq+5KG6 Qer+CKgOccb5PTF22XnW4o5OeLGfCzXPo=; b=ocKbS+9D6qPpq7UGLPN8HUn98F kFstWyxfWECZXHCpZbtnaZ+EpTXhKLRR+S+eNzwnk5uBw2r6uApKhEUAe5kUK69f xH5R1hLVdcJ0GYIk46lSXrehHP+vrx0fVPsirywkdCHkq5ZE/g+xN+Bg+BslUCzX CL4x4j5ub4TyiYMGZyeHlwZgUFhrhf+YFEqTh5ia24DSLAgKdHzqWaGx3fy5qXvq kY7QLEEdnylnGu7Yy7SYMuX8rmAQLafrNRigMMsjIR7lRjh6CPqJBDY07K09P5gB 6tlBMomCDwmThEdShoUVyty1ZoyF1hmEwrlQAdGgITrv2MOtbYG7qeSN2ilw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663258557; x=1663344957; bh=3wXVq+5KG6Qer+CKgOccb5PTF22X nW4o5OeLGfCzXPo=; b=JFgnK7pId8erMtFoh2ZIDQX9oWcpTZTrXQaJ6zNAvfKf 9jhpX1FKcg23XsRKpbvZs2wFtWWwSN9qpb6nZaWGjeXAaeelhbDpHvDBq+wn7BVB +6wWlRc4MOAePds/OSkip3GtoWpDNABvVW81HwpffrR8Ge1WmiwNlNTBKC8+SU8A oZasvf8RhTcuu4U9WpGM6CqTJsBY8BIKW7fNhQVfjmmTeBS/EBy0FiwSNedH53YZ Xf0m0ApDRF6B/38sZ0tHPI3OvCEabRugQ+sRLrTso3HR7t1jhHbxLcrrard3DPU6 IpfbHN5ZhgcWfC3uL5tcxIeTjlTBzzvFActXLUbjqA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedukedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeffueettdefvddtteevgfeufeejgfegudfgfedutdegfeet keehuddvfeejjeeifeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Sep 2022 12:15:57 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 8A0C87F18EA; Thu, 15 Sep 2022 09:15:56 -0700 (MST) From: Sean Whitton In-Reply-To: <861qsdktqo.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 15 Sep 2022 09:59:59 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> Date: Thu, 15 Sep 2022 09:15:56 -0700 Message-ID: <87fsgs396r.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Thu 15 Sep 2022 at 09:59AM +03, Juri Linkov wrote: >>> Is this equivalent to `M-& git log origin/scratch/posix-spawn 4b2ca6bfc0`, >>> then enabling vc-git-log-view-mode in the output buffer? >> >> It's not, because vc-git-log-view-mode requires you pass four or five >> options to git-log to get output it can properly display. That >> knowledge is locked up in vc-git.el right now. > > This part is clear, but I also wanted to know what git command > corresponds to this feature. Is it just `git log` with two > branch names on the command line? What additional options > are required? Maybe `--graph --oneline`? Also I see that > git documentation mentions `--branches[=]`. It's something along these lines: git log -100 --graph --decorate --date=short \ --pretty="tformat:%d%h..: %an %ad %s" --abbrev-commit \ BRANCH1 BRANCH2 -- Sean Whitton From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2022 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166325870225409 (code B ref 57807); Thu, 15 Sep 2022 16:19:02 +0000 Received: (at 57807) by debbugs.gnu.org; 15 Sep 2022 16:18:22 +0000 Received: from localhost ([127.0.0.1]:58998 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYrZG-0006bk-2K for submit@debbugs.gnu.org; Thu, 15 Sep 2022 12:18:22 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:34703) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYrZE-0006bU-41 for 57807@debbugs.gnu.org; Thu, 15 Sep 2022 12:18:20 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 151D45C00EE; Thu, 15 Sep 2022 12:18:15 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 15 Sep 2022 12:18:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663258695; x=1663345095; bh=GTJsTtJjeO EuERU2o2mQvRSf/JsZTutY6kMYWYc3lHA=; b=vOqtVaJppNfhNb0tXyTO97Y/Oy 21UauLLxASYrw8cPSXqt1zdRExyZKLPJo2BXrNGSUfyaPdp96QOtOUcA2R8RN8rN iMETv5npAXie1KxwxUW/sTU9RVuu1zlHZGX2Ee5Nv2T7n/qamTBsddIUEQHtdfve MHWherxoV+FlZMCWncI0D376by1QJLkJOvrVcYfjVCriJQ7j17xpw1L1RPJU22Za UhD9EgEzBIVOkUGDtDZ9hEUyl2tnBKumfA0bZ1EABqWyEqmYG58Nhe4nEOcNTaRc B6Gq4cYm69n4PA7OQq0fkMOm8i1PgPT63f/pFokiCiXcwDMKhxiP3lVtzHvg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663258695; x=1663345095; bh=GTJsTtJjeOEuERU2o2mQvRSf/JsZ TutY6kMYWYc3lHA=; b=HF/e5o7EEpNiUbUfQQi+2vBMMGHBbd1wUxKDl2NiRXef NEJnbs5VD4Pd7CXBEJ2Qerv888L5H3h5otXTHYneUQaJFYQZsdcoxgerXiOER2k+ CoO1HxLXqWibBeLcZzrt+lMgi4Pf3iIUNecMVdmT0yl4UEkQr1wdA/eTiXmb/YEB emzSr4/dkK6joA+B5RKzWH5dNJnlr9tC4aqF27j2vwESTY1L6SrMMGetMwsGDd8Y sUwKGMzKtO6kAfZOoOr9kRs1HbOWJqnTOKvprv3OZGKFrYwJQ6HeRo5qLxJkmJ2u IFlWexB/oOK2+tBXB1OWOwJKfmW2oR/nqgm4NT8jfw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedukedguddtudcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeffueettdefvddtteevgfeufeejgfegudfgfedutdegfeet keehuddvfeejjeeifeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Sep 2022 12:18:14 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 2C7AD7F18EA; Thu, 15 Sep 2022 09:18:13 -0700 (MST) From: Sean Whitton In-Reply-To: <83fsgt19tf.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 15 Sep 2022 08:33:00 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <83sfkt26r4.fsf@gnu.org> <87leqlshld.fsf@melete.silentflame.com> <83fsgt19tf.fsf@gnu.org> Date: Thu, 15 Sep 2022 09:18:13 -0700 Message-ID: <87bkrg392y.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Thu 15 Sep 2022 at 08:33AM +03, Eli Zaretskii wrote: > So the difference is that what you want to see is all the branches up > to their HEAD, and not just branches merged into the current branch, > is that right? > > If so, I guess some optional feature of "C-x v L" could do that. > However, if the repository has many branches (and ours, for example, > does), wouldn't that make for a crowded and hard-t-read log buffer? > Perhaps asking the user for a name of one branch will be enough? More > than one branch could be problematic on display, I think. Not all branches, as indeed that would quickly become unreadable. The user has to say exactly which branches they would like to be included. And usually you wouldn't type more than two or three. -- Sean Whitton From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2022 16:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166326052928580 (code B ref 57807); Thu, 15 Sep 2022 16:49:02 +0000 Received: (at 57807) by debbugs.gnu.org; 15 Sep 2022 16:48:49 +0000 Received: from localhost ([127.0.0.1]:59072 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYs2i-0007Qr-Uv for submit@debbugs.gnu.org; Thu, 15 Sep 2022 12:48:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYs2f-0007Qc-9a for 57807@debbugs.gnu.org; Thu, 15 Sep 2022 12:48:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60760) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYs2Z-00060v-Lv; Thu, 15 Sep 2022 12:48:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=OCZQ/IHL6PnowsOLIbpHuDDxIiyWCOYKvsCfRJFuVIs=; b=rDaE+piZpxZL WQD/A2Z9m2Z5c+G0amALQ2w/fJq4CHfDVocqpewAP2r/ctKBqBoxLBN9HDJzNZouZPkVu3YHQCGW2 FaWJxgs+fdhJrJjTO/ir8ZMi6QSuxJDhPOoM6h1qPvkF0s0ZmO8rSFVDn9sRBkT7pZZQ+xwcXfAca ipT348S88JfqaKlvTriWBNq9cCV6RGTCtaG78r6OBNaVeuMDV7ZdpB7w4JCIEIXGkgU++m6VFfCnA UMGeDhbsT+IuJekVA/U69kNGkpjPqyswk5ERw2VkfZW8rwEjz+E4L8h4cjDqnCO2U8bPMkKeeLeF+ Q4tqJmM/jI+y1iTdqI2Y3g==; Received: from [87.69.77.57] (port=3527 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYs2Y-0004Fc-Vo; Thu, 15 Sep 2022 12:48:39 -0400 Date: Thu, 15 Sep 2022 19:48:30 +0300 Message-Id: <83czbwziqp.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87bkrg392y.fsf@melete.silentflame.com> (message from Sean Whitton on Thu, 15 Sep 2022 09:18:13 -0700) References: <87czbxub4b.fsf@melete.silentflame.com> <83sfkt26r4.fsf@gnu.org> <87leqlshld.fsf@melete.silentflame.com> <83fsgt19tf.fsf@gnu.org> <87bkrg392y.fsf@melete.silentflame.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Sean Whitton > Date: Thu, 15 Sep 2022 09:18:13 -0700 > > Hello, > > On Thu 15 Sep 2022 at 08:33AM +03, Eli Zaretskii wrote: > > > So the difference is that what you want to see is all the branches up > > to their HEAD, and not just branches merged into the current branch, > > is that right? > > > > If so, I guess some optional feature of "C-x v L" could do that. > > However, if the repository has many branches (and ours, for example, > > does), wouldn't that make for a crowded and hard-t-read log buffer? > > Perhaps asking the user for a name of one branch will be enough? More > > than one branch could be problematic on display, I think. > > Not all branches, as indeed that would quickly become unreadable. The > user has to say exactly which branches they would like to be included. > And usually you wouldn't type more than two or three. I think 3 is already too much for the largely unidimensional display we (and Git) provide. From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2022 17:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.1663263480855 (code B ref 57807); Thu, 15 Sep 2022 17:38:01 +0000 Received: (at 57807) by debbugs.gnu.org; 15 Sep 2022 17:38:00 +0000 Received: from localhost ([127.0.0.1]:59122 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYsoK-0000Di-11 for submit@debbugs.gnu.org; Thu, 15 Sep 2022 13:38:00 -0400 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:61275) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYsoH-0000DT-P4 for 57807@debbugs.gnu.org; Thu, 15 Sep 2022 13:37:59 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id CC14240006; Thu, 15 Sep 2022 17:37:49 +0000 (UTC) From: Juri Linkov In-Reply-To: <87fsgs396r.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 15 Sep 2022 09:15:56 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> Date: Thu, 15 Sep 2022 20:27:30 +0300 Message-ID: <8635cs8s59.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>>> Is this equivalent to `M-& git log origin/scratch/posix-spawn 4b2ca6bfc0`, >>>> then enabling vc-git-log-view-mode in the output buffer? >>> >>> It's not, because vc-git-log-view-mode requires you pass four or five >>> options to git-log to get output it can properly display. That >>> knowledge is locked up in vc-git.el right now. >> >> This part is clear, but I also wanted to know what git command >> corresponds to this feature. Is it just `git log` with two >> branch names on the command line? What additional options >> are required? Maybe `--graph --oneline`? Also I see that >> git documentation mentions `--branches[=]`. > > It's something along these lines: > > git log -100 --graph --decorate --date=short \ > --pretty="tformat:%d%h..: %an %ad %s" --abbrev-commit \ > BRANCH1 BRANCH2 This is what I proposed a long ago, maybe it makes sense here. After invoking a vc command with a prefix argument it could pop up the minibuffer with the command line that you can edit to add or delete more arguments for the git command. So e.g. after 'C-u C-x v b l BRANCH1 RET' it will insert in the minibuffer the default command `git log ... BRANCH1`, where you can add BRANCH2 and modify any other option. Then it runs this command and displays the output in the vc-git-log-view-mode buffer. From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2022 22:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Eli Zaretskii , 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.16632809715172 (code B ref 57807); Thu, 15 Sep 2022 22:30:03 +0000 Received: (at 57807) by debbugs.gnu.org; 15 Sep 2022 22:29:31 +0000 Received: from localhost ([127.0.0.1]:59455 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYxMQ-0001LL-Mu for submit@debbugs.gnu.org; Thu, 15 Sep 2022 18:29:31 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:58701) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYxMO-0001L8-RT for 57807@debbugs.gnu.org; Thu, 15 Sep 2022 18:29:29 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id BDDFF3200A96; Thu, 15 Sep 2022 18:29:22 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Thu, 15 Sep 2022 18:29:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663280962; x=1663367362; bh=9QTCDXrg5u 80Bz1wxGeCf9CRh+U88kViUiqAWTMBckQ=; b=uI8tEDz1LTKEzv8Z+etOJS96bU WanRnyFJ8xxlt0LwKT3aGLOii3ecem1AlqtW6BnVH7aLxH/ZtOROGAcLKtESTddX 8NRg7m1l1UWitwNBJqXKWiSBDvZFI6zDwx2w/pH/FKXNvWx3K3XodnV5/6gyqB8W G7whRT7+DH7ULd29J2bhHBTmnSSgSu1iSRYnhABSTwQhnEXt2QELDGq3b+IFQZah n3uwRnCsRDr3T28G+Qzw/acDRyaYlHW+ozyx+/vNfvcpq6CSvv1iUEHGrSyfL6Wx nNZ1s1jqvls1ZrhX442iyC+e985EQ0GzX1EdFhaZxSnr/fkVdT2p0ZsYC74g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663280962; x=1663367362; bh=9QTCDXrg5u80Bz1wxGeCf9CRh+U8 8kViUiqAWTMBckQ=; b=FSrny5H6gZKNTqRVCm7g3lOdVrUtZLYbjlisVhPbxBAr Uk9gLc6t0cTlZn42QrWbFIsrOy2fDBcnp1caopk4m3ZWilssRNaSNKXpPdDfbsq9 ewGXrNA/bMzXtEZtpWiDs1MnFVBOQE657wtemm/MzIOlIkB44apojaNBt2WfzIIJ RPNCrr9llPasroZf3BvKFplR59LRBHtahzNG+hRjiQs4MWgeqxZ2K9w8P81pbcI8 aLlJYqRG4c9ZZd2hZupGGpkWPKzzxoS0r/yCirxNV+NhxB3PTbZbJBEhqmfYJue2 E/WWt0ylUJ7yxjgq8X26Q7kpFFnc3g6Kef8bFpi+Nw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduledgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepffeutedtfedvtdetvefgueefjefggedugfefuddtgeefteek heduvdefjeejieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Sep 2022 18:29:21 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 8AC5B7F16C1; Thu, 15 Sep 2022 15:29:20 -0700 (MST) From: Sean Whitton In-Reply-To: <83czbwziqp.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 15 Sep 2022 19:48:30 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <83sfkt26r4.fsf@gnu.org> <87leqlshld.fsf@melete.silentflame.com> <83fsgt19tf.fsf@gnu.org> <87bkrg392y.fsf@melete.silentflame.com> <83czbwziqp.fsf@gnu.org> Date: Thu, 15 Sep 2022 15:29:20 -0700 Message-ID: <87pmfw1dbz.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Thu 15 Sep 2022 at 07:48PM +03, Eli Zaretskii wrote: >> From: Sean Whitton >> Date: Thu, 15 Sep 2022 09:18:13 -0700 >> >> Hello, >> >> On Thu 15 Sep 2022 at 08:33AM +03, Eli Zaretskii wrote: >> >> > So the difference is that what you want to see is all the branches up >> > to their HEAD, and not just branches merged into the current branch, >> > is that right? >> > >> > If so, I guess some optional feature of "C-x v L" could do that. >> > However, if the repository has many branches (and ours, for example, >> > does), wouldn't that make for a crowded and hard-t-read log buffer? >> > Perhaps asking the user for a name of one branch will be enough? More >> > than one branch could be problematic on display, I think. >> >> Not all branches, as indeed that would quickly become unreadable. The >> user has to say exactly which branches they would like to be included. >> And usually you wouldn't type more than two or three. > > I think 3 is already too much for the largely unidimensional display > we (and Git) provide. Fair enough, but I find it useful and Magit having this feature suggests others do too. -- Sean Whitton From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Sep 2022 22:31:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov , 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.16632810065277 (code B ref 57807); Thu, 15 Sep 2022 22:31:01 +0000 Received: (at 57807) by debbugs.gnu.org; 15 Sep 2022 22:30:06 +0000 Received: from localhost ([127.0.0.1]:59461 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYxN0-0001N2-66 for submit@debbugs.gnu.org; Thu, 15 Sep 2022 18:30:06 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:52895) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYxMy-0001Lv-Ek for 57807@debbugs.gnu.org; Thu, 15 Sep 2022 18:30:05 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id CA1E63200A96; Thu, 15 Sep 2022 18:29:58 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Thu, 15 Sep 2022 18:29:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663280998; x=1663367398; bh=uJC1+rNXXJ nqjte2rQLM6QKhetojQuqPv9XoxgCdTao=; b=LkkiDO5YaM57bWY6JSvRgEW/Cg j2d94Qrue2SLSnaGYij1gLhn9tz5TAhoODbQABAZKHmSukuxpYQapxvE36vpNTao g/Ug06SpaSdq4QXuQ7ssUbl+DUitgotrJWZ3mn1eVRhe0FK3lu5vHhbBWxvOVUr8 abU3UZpiSNfDRvGZU8vTEj6Y5TU0n20z0tg2/5p/K5BlFqQx90VuAes9UvC53uc5 /HPmDqRaH23zJogJEgTSoQyuaMepFszsvVEDt7QH7LOplrFG3bUIoyIlnqpwqCOK rynJNKL0LeEcKibtae8vfII9OvYjsZHYCHQIlCLkhefCnrORNenNnXPhf4TQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663280998; x=1663367398; bh=uJC1+rNXXJnqjte2rQLM6QKhetoj QuqPv9XoxgCdTao=; b=W7WRCt9EUiwZ9TUzp7sS1rWH7CnHUbVWXXgZU+Wtb0/l k0ic9BPR9Jc0yPVvCZPhlbqYIcFbHQBaUeR1mJ8b9SqxUVawJWDmvQ8XciGXofo7 hhkrBjlQBPvv6r0NnKxZANHgpdylP0CpaWGJi+o36125ysrZiAKqcIPnE3O5aCLN C6Ouv9CGTxUFNOFPN7mbDpufPLVMMf5JjkaX6LVB918nhW9LQBrowgymPnH+4Iac 86CrsRf/lX5MUBxLdW9hnNzm3Qjm4YpAWGtw+bBGzg091Dt1wInjPsKP0bZdx1+9 3THI8BKJmRltFhm9IxzBHQcFh29ZSKJoxqpMIEjmfg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduledguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepffeutedtfedvtdetvefgueefjefggedugfefuddtgeefteek heduvdefjeejieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 15 Sep 2022 18:29:58 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 314CF7F16C1; Thu, 15 Sep 2022 15:29:57 -0700 (MST) From: Sean Whitton In-Reply-To: <8635cs8s59.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 15 Sep 2022 20:27:30 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> Date: Thu, 15 Sep 2022 15:29:57 -0700 Message-ID: <87leqk1day.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Thu 15 Sep 2022 at 08:27PM +03, Juri Linkov wrote: >>>>> Is this equivalent to `M-& git log origin/scratch/posix-spawn 4b2ca6bfc0`, >>>>> then enabling vc-git-log-view-mode in the output buffer? >>>> >>>> It's not, because vc-git-log-view-mode requires you pass four or five >>>> options to git-log to get output it can properly display. That >>>> knowledge is locked up in vc-git.el right now. >>> >>> This part is clear, but I also wanted to know what git command >>> corresponds to this feature. Is it just `git log` with two >>> branch names on the command line? What additional options >>> are required? Maybe `--graph --oneline`? Also I see that >>> git documentation mentions `--branches[=]`. >> >> It's something along these lines: >> >> git log -100 --graph --decorate --date=short \ >> --pretty="tformat:%d%h..: %an %ad %s" --abbrev-commit \ >> BRANCH1 BRANCH2 > > This is what I proposed a long ago, maybe it makes sense here. > After invoking a vc command with a prefix argument it could pop up > the minibuffer with the command line that you can edit to add or delete > more arguments for the git command. So e.g. after 'C-u C-x v b l BRANCH1 RET' > it will insert in the minibuffer the default command `git log ... BRANCH1`, > where you can add BRANCH2 and modify any other option. Then it runs > this command and displays the output in the vc-git-log-view-mode buffer. That would be enough for me. vc-push already works that way. Shall I look into preparing a patch? -- Sean Whitton From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Sep 2022 07:11:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166331225310957 (code B ref 57807); Fri, 16 Sep 2022 07:11:01 +0000 Received: (at 57807) by debbugs.gnu.org; 16 Sep 2022 07:10:53 +0000 Received: from localhost ([127.0.0.1]:41362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ5Uz-0002qf-B0 for submit@debbugs.gnu.org; Fri, 16 Sep 2022 03:10:53 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:37541) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ5Uw-0002qL-Ht for 57807@debbugs.gnu.org; Fri, 16 Sep 2022 03:10:51 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 53AA3C0015; Fri, 16 Sep 2022 07:10:41 +0000 (UTC) From: Juri Linkov In-Reply-To: <87leqk1day.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 15 Sep 2022 15:29:57 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> Date: Fri, 16 Sep 2022 09:59:09 +0300 Message-ID: <86o7vfpzya.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>>>>> Is this equivalent to `M-& git log origin/scratch/posix-spawn 4b2ca6bfc0`, >>>>>> then enabling vc-git-log-view-mode in the output buffer? >>>>> >>>>> It's not, because vc-git-log-view-mode requires you pass four or five >>>>> options to git-log to get output it can properly display. That >>>>> knowledge is locked up in vc-git.el right now. >>>> >>>> This part is clear, but I also wanted to know what git command >>>> corresponds to this feature. Is it just `git log` with two >>>> branch names on the command line? What additional options >>>> are required? Maybe `--graph --oneline`? Also I see that >>>> git documentation mentions `--branches[=]`. >>> >>> It's something along these lines: >>> >>> git log -100 --graph --decorate --date=short \ >>> --pretty="tformat:%d%h..: %an %ad %s" --abbrev-commit \ >>> BRANCH1 BRANCH2 >> >> This is what I proposed a long ago, maybe it makes sense here. >> After invoking a vc command with a prefix argument it could pop up >> the minibuffer with the command line that you can edit to add or delete >> more arguments for the git command. So e.g. after 'C-u C-x v b l BRANCH1 RET' >> it will insert in the minibuffer the default command `git log ... BRANCH1`, >> where you can add BRANCH2 and modify any other option. Then it runs >> this command and displays the output in the vc-git-log-view-mode buffer. > > That would be enough for me. vc-push already works that way. Shall I > look into preparing a patch? Yes, please try to prepare a patch, preferably without changing the established backend API, maybe by using a global variable that later could be reused to confirm and edit other commands. From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 18 Sep 2022 21:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov , 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166353770519742 (code B ref 57807); Sun, 18 Sep 2022 21:49:02 +0000 Received: (at 57807) by debbugs.gnu.org; 18 Sep 2022 21:48:25 +0000 Received: from localhost ([127.0.0.1]:51443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oa29I-00058M-IC for submit@debbugs.gnu.org; Sun, 18 Sep 2022 17:48:25 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:53463) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oa29C-000581-MH for 57807@debbugs.gnu.org; Sun, 18 Sep 2022 17:48:22 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 4B73D5C01DD; Sun, 18 Sep 2022 17:48:13 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Sun, 18 Sep 2022 17:48:13 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663537693; x=1663624093; bh=Nvps1yzig+ T5oeIUAZz6AUsR4rzJX33uf1pRXQyMQnk=; b=S4HApyYjbVeQTq80w+q85inqfB QbFxkxpdjiagskAZFeAtp6DLDN67wbB4sQvPeJPm7U1Wl1Y3g2QSrpXqKsnPuw5t tO/iCc64DZDvr0wlkXlw7ghcAhp731gZEn1iaAWFNzo2rtDFBvpRM8iTupzcrIuR 2vax0UB/MtfdDePduNZEqkccuKt26Ig0ceUFP7tN4XsBsLnYU/63uWA0YLiU3Dhw 4L3wF38GyWel4IASRkD56ha2lhQrIZpuU4DcEnLVSB5NZ6Fr2m8slnwJGA3nz5ug VZ4M5xFDTVElJ7Mxub6PLxU+WFLtK8T265J0A2xjIG7WiAuM2prFuv0W0Uig== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663537693; x=1663624093; bh=Nvps1yzig+T5oeIUAZz6AUsR4rzJ X33uf1pRXQyMQnk=; b=Tg8nrOQFLQj4cW7/9BMi+0Zuwx/VIDuiMMadPhtUXBm/ WNY71W9RAg0/ZZQjEYMRuwMzRMSe9PBv//+1uiQHgp245fcuI/UhrK4JGn74S1gQ Ti98zNA4E/CXBuj+H8U3Dh/zau4u2khEo3mh6/xUi289+2lAIFnsYphsCkf47PIn 57ucJl4HGbq1FeR+cYzd8gmaT7FWeib1ds5B7wxZuBJtbLx5u9H4qODTh+MjUN4q EOQFlrfm6adM/HcrWBcST9l+mCfXD8iHu9w1Tc/rAUrczreGZFGQO0mjyGMQRK3U p3b5xxP9c3P174vPWyiq7BhOL1wfINDiuH9/WyiinQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedviedgtdefucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtsehmtddtredtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepkeevleffheetleehteeludetjeehfeehgfetteeftddtjeej jedvveevgfeghfehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun, 18 Sep 2022 17:48:12 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 8EE107F2357; Sun, 18 Sep 2022 14:48:11 -0700 (MST) From: Sean Whitton In-Reply-To: <86o7vfpzya.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 16 Sep 2022 09:59:09 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> Date: Sun, 18 Sep 2022 14:48:11 -0700 Message-ID: <87sfkos6as.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello, On Fri 16 Sep 2022 at 09:59AM +03, Juri Linkov wrote: > Yes, please try to prepare a patch, preferably without changing the > established backend API, maybe by using a global variable that later > could be reused to confirm and edit other commands. Here's my attempt. Let me know what you think. -- Sean Whitton --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-support-for-user-edits-to-VC-command-arguments.patch >From db5cbe0a693d4f231141576b07ba68e3287ca645 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Sun, 18 Sep 2022 14:47:23 -0700 Subject: [PATCH] Add support for user edits to VC command arguments * lisp/vc/vc-dispatcher.el (vc-want-edit-command-p): New variable. (vc-do-command): If vc-want-edit-command-p is non-nil, prompt the user to edit the arguments to the VC command before execution. * lisp/vc/vc-git.el (vc-git--pushpull): Drop prompting code. Bind vc-want-edit-command-p so that vc-do-command handles the prompting. * lisp/vc/vc.el (vc-print-branch-log): A non-nil prefix argument now means vc-want-edit-command-p is bound to a non-nil value (bug#57807). --- lisp/vc/vc-dispatcher.el | 35 +++++++++++++++++++++++++++++------ lisp/vc/vc-git.el | 25 +++++++------------------ lisp/vc/vc.el | 14 ++++++++++---- 3 files changed, 46 insertions(+), 28 deletions(-) diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el index 88bf6627ae..d83db53dc8 100644 --- a/lisp/vc/vc-dispatcher.el +++ b/lisp/vc/vc-dispatcher.el @@ -156,6 +156,9 @@ vc-parent-buffer (defvar vc-parent-buffer-name nil) (put 'vc-parent-buffer-name 'permanent-local t) +(defvar vc-want-edit-command-p nil + "If non-nil, let user edit the VC shell command before running it.") + ;; Common command execution logic (defun vc-process-filter (p s) @@ -296,15 +299,16 @@ vc-do-command files or be nil (to execute commands that don't expect a file name or set of files). If an optional list of FLAGS is present, that is inserted into the command line before the filename. + +If `vc-want-edit-command-p' is non-nil, prompt the user to edit +FLAGS before execution. + Return the return value of the slave command in the synchronous case, and the process object in the asynchronous case." - (when vc-tor - (push command flags) - (setq command "torsocks")) - ;; FIXME: file-relative-name can return a bogus result because - ;; it doesn't look at the actual file-system to see if symlinks - ;; come into play. (let* ((files + ;; FIXME: file-relative-name can return a bogus result + ;; because it doesn't look at the actual file-system to see + ;; if symlinks come into play. (mapcar (lambda (f) (file-relative-name (expand-file-name f))) (if (listp file-or-list) file-or-list (list file-or-list)))) ;; Keep entire commands in *Messages* but avoid resizing the @@ -312,6 +316,22 @@ vc-do-command ;; a such way that the important parts are at the beginning, ;; due to potential truncation of long messages. (message-truncate-lines t) + (files-separator-p (string= "--" (car (last flags)))) + (flags (if vc-want-edit-command-p + (append + (split-string-and-unquote + (read-shell-command + (format "Edit VC command arguments%s: %s " + (if files + " (files list to be appended)" + "") + command) + (combine-and-quote-strings + (remq nil (if files-separator-p + (butlast flags) + flags))))) + (and files-separator-p (list "--"))) + flags)) (full-command (concat (if (string= (substring command -1) "\n") (substring command 0 -1) @@ -321,6 +341,9 @@ vc-do-command (vc-inhibit-message (or (eq vc-command-messages 'log) (eq (selected-window) (active-minibuffer-window))))) + (when vc-tor + (push command flags) + (setq command "torsocks")) (save-current-buffer (unless (or (eq buffer t) (and (stringp buffer) diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index a5d12f03bc..91951d3277 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1089,35 +1089,24 @@ vc-git-error-regexp-alist (declare-function vc-compilation-mode "vc-dispatcher" (backend)) (defvar compilation-directory) (defvar compilation-arguments) +(defvar vc-want-edit-command-p) (defun vc-git--pushpull (command prompt extra-args) "Run COMMAND (a string; either push or pull) on the current Git branch. If PROMPT is non-nil, prompt for the Git command to run." (let* ((root (vc-git-root default-directory)) (buffer (format "*vc-git : %s*" (expand-file-name root))) - (git-program vc-git-program) - args) - ;; If necessary, prompt for the exact command. - ;; TODO if pushing, prompt if no default push location - cf bzr. - (when prompt - (setq args (split-string - (read-shell-command - (format "Git %s command: " command) - (format "%s %s" git-program command) - 'vc-git-history) - " " t)) - (setq git-program (car args) - command (cadr args) - args (cddr args))) - (setq args (nconc args extra-args)) + ;; TODO if pushing, prompt if no default push location - cf bzr. + (vc-want-edit-command-p prompt)) (require 'vc-dispatcher) - (apply #'vc-do-async-command buffer root git-program command args) + (apply #'vc-do-async-command + buffer root vc-git-program command extra-args) (with-current-buffer buffer (vc-run-delayed (vc-compilation-mode 'git) (setq-local compile-command - (concat git-program " " command " " - (mapconcat #'identity args " "))) + (concat vc-git-program " " command " " + (mapconcat #'identity extra-args " "))) (setq-local compilation-directory root) ;; Either set `compilation-buffer-name-function' locally to nil ;; or use `compilation-arguments' to set `name-function'. diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index c67dad69fc..027dfc72ea 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -1046,6 +1046,7 @@ log-view-vc-backend (defvar log-edit-vc-backend) (defvar diff-vc-backend) (defvar diff-vc-revisions) +(defvar vc-want-edit-command-p) (defun vc-deduce-backend () (cond ((derived-mode-p 'vc-dir-mode) vc-dir-backend) @@ -2744,17 +2745,22 @@ vc-print-root-log (setq vc-parent-buffer-name nil))) ;;;###autoload -(defun vc-print-branch-log (branch) - "Show the change log for BRANCH root in a window." +(defun vc-print-branch-log (branch &optional arg) + "Show the change log for BRANCH root in a window. +Optional prefix ARG non-nil requests an opportunity for the user +to edit the VC shell command that will be run to generate the +log." (interactive (let* ((backend (vc-responsible-backend default-directory)) (rootdir (vc-call-backend backend 'root default-directory))) (list - (vc-read-revision "Branch to log: " (list rootdir) backend)))) + (vc-read-revision "Branch to log: " (list rootdir) backend) + current-prefix-arg))) (when (equal branch "") (error "No branch specified")) (let* ((backend (vc-responsible-backend default-directory)) - (rootdir (vc-call-backend backend 'root default-directory))) + (rootdir (vc-call-backend backend 'root default-directory)) + (vc-want-edit-command-p arg)) (vc-print-log-internal backend (list rootdir) branch t (when (> vc-log-show-limit 0) vc-log-show-limit)))) -- 2.30.2 --=-=-=-- From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 19 Sep 2022 07:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166357402328947 (code B ref 57807); Mon, 19 Sep 2022 07:54:02 +0000 Received: (at 57807) by debbugs.gnu.org; 19 Sep 2022 07:53:43 +0000 Received: from localhost ([127.0.0.1]:52194 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaBb5-0007Wo-CV for submit@debbugs.gnu.org; Mon, 19 Sep 2022 03:53:43 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:41835) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oaBb2-0007WU-8r for 57807@debbugs.gnu.org; Mon, 19 Sep 2022 03:53:42 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3E8FA10000B; Mon, 19 Sep 2022 07:53:31 +0000 (UTC) From: Juri Linkov In-Reply-To: <87sfkos6as.fsf@melete.silentflame.com> (Sean Whitton's message of "Sun, 18 Sep 2022 14:48:11 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> Date: Mon, 19 Sep 2022 09:42:59 +0300 Message-ID: <86bkrb7qt8.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Yes, please try to prepare a patch, preferably without changing the >> established backend API, maybe by using a global variable that later >> could be reused to confirm and edit other commands. > > Here's my attempt. Let me know what you think. Thanks, this would be one of the most useful vc features. I tried it out, and it works nicely. Only minor details: Previously 'git-pull' asked for a full command including command name "git". I know there is no need to edit the command name "git", but splitting the command between the prompt and the minibuffer looks a little odd. Also the previous version of 'vc-git--pushpull' sets 'compile-command' to the edited command. It seems this is implemented to be able to repeat the pull command with 'g' that is bound to 'recompile'. I don't have a good idea how to fix this. Maybe by setting another global variable, e.g. 'vc-last-command' after editing the command in 'vc-do-command'. And also 'vc-do-async-command' reports the initial unedited command with its "Running" message string. From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 20 Sep 2022 22:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov , 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166371449220084 (code B ref 57807); Tue, 20 Sep 2022 22:55:02 +0000 Received: (at 57807) by debbugs.gnu.org; 20 Sep 2022 22:54:52 +0000 Received: from localhost ([127.0.0.1]:59947 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oam8i-0005Dq-2S for submit@debbugs.gnu.org; Tue, 20 Sep 2022 18:54:52 -0400 Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:49429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oam8e-0005Da-KM for 57807@debbugs.gnu.org; Tue, 20 Sep 2022 18:54:51 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.west.internal (Postfix) with ESMTP id 8695F32009A7; Tue, 20 Sep 2022 18:54:41 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 20 Sep 2022 18:54:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663714481; x=1663800881; bh=P10Bt3D8Ja 4yapDiB6lskW8Vv40olvxKNwgpF+5ZQok=; b=id0bRnlA5HEJTVBwkQJHe2fJIo y+nAoMiV/J7N7jVNf/bjnmHAjZ2Uo+XRicpKh6Xpqhdzzh/n4aG5ovluudx/Pgdp Ku6O8Iw3VtHAoQzWcKpQ0SyXBVnvCxnqWwcI5nQ7GL9q2TCtOFt4ZWMeoe33Gn/j tYH0lpaI4kcKCO6I13JU/0VINAyQcjtoe3OKy40VHbpZrAWZfnmXwlIruu/r5I3j EOJisblWKY/XucUbadTELZRAUgzISsUizdLt652MLfGYUTykTEmzq5007kfeDXp5 664oO8cr1SfQCLZkKL1ZwavR+iJ2gZTWR5w/M5kkvuKVLugXYbPlIMIhVwMw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663714481; x=1663800881; bh=P10Bt3D8Ja4yapDiB6lskW8Vv40o lvxKNwgpF+5ZQok=; b=J518SxMN2yUfMWLX8K8+e6fO11CwCF+xidNGRyi9/v1J fhYDUmrxKRkwXYMeweFXxhC2V/jI06Pffy4LKl0BuUAVzP59O3W4uNLuXf5cM4Ow 11myYN0ldwG7GEDvdQEu5LvAqYoeyR8byRO/ZYvmtjiQXP3bPPyq+5jStT3Q4Tk+ 4NbSJ5VujdInV5oSeZ9d9DGdXjfo/9dwX2PzuWn9OWBNQavbflmEysKtWbpQcvW5 pt0X8EpWoDqO+NWNpn2BoqBzQKy8WTeBlw4GT3OM+6Yq1FUJULWkfHMYDSsbLAYw XVdETprz7Un6EFox7H4gjL+bqQQ6xL9Xgz9E+HuRMA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeeftddgudeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufgjfhffkfgfgggtsehmtddtredtredtnecuhfhrohhmpefuvggrnhcu hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne cuggftrfgrthhtvghrnhepkeevleffheetleehteeludetjeehfeehgfetteeftddtjeej jedvveevgfeghfehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 20 Sep 2022 18:54:40 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 7CA9C7EF4EB; Tue, 20 Sep 2022 15:54:39 -0700 (MST) From: Sean Whitton In-Reply-To: <86bkrb7qt8.fsf@mail.linkov.net> (Juri Linkov's message of "Mon, 19 Sep 2022 09:42:59 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> Date: Tue, 20 Sep 2022 15:54:39 -0700 Message-ID: <8735clu05s.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello, On Mon 19 Sep 2022 at 09:42AM +03, Juri Linkov wrote: > Thanks, this would be one of the most useful vc features. > I tried it out, and it works nicely. Only minor details: > > Previously 'git-pull' asked for a full command including command name "git". > I know there is no need to edit the command name "git", but splitting > the command between the prompt and the minibuffer looks a little odd. > > Also the previous version of 'vc-git--pushpull' sets 'compile-command' > to the edited command. It seems this is implemented to be able to > repeat the pull command with 'g' that is bound to 'recompile'. > I don't have a good idea how to fix this. Maybe by setting > another global variable, e.g. 'vc-last-command' after editing > the command in 'vc-do-command'. > > And also 'vc-do-async-command' reports the initial unedited command > with its "Running" message string. I've done something about all these in the attached. What do you think? -- Sean Whitton --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=v2-0001-Add-support-for-user-edits-to-VC-command-argument.patch >From 181241f981dce0610807f42e50a89713fafb9af0 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Sun, 18 Sep 2022 14:47:23 -0700 Subject: [PATCH v2] Add support for user edits to VC command arguments * lisp/vc/vc-dispatcher.el (vc-pre-command-functions): New hook. (vc-want-edit-command-p): New variable. (vc-do-command): If vc-want-edit-command-p is non-nil, prompt the user to edit the VC command and arguments command before execution. Run the new hook. (vc-do-async-command): Use the new hook to insert into BUFFER the command that's next to be run. * lisp/vc/vc-git.el (vc-git--pushpull): Drop prompting code. Bind vc-want-edit-command-p so that vc-do-command handles the prompting. Use the new hook to update compile-command with the edited command. * lisp/vc/vc.el (vc-print-branch-log): A non-nil prefix argument now means vc-want-edit-command-p is bound to a non-nil value (bug#57807). --- lisp/vc/vc-dispatcher.el | 55 ++++++++++++++++++++++++++++++++-------- lisp/vc/vc-git.el | 31 ++++++++++------------ lisp/vc/vc.el | 18 ++++++++++--- 3 files changed, 71 insertions(+), 33 deletions(-) diff --git a/lisp/vc/vc-dispatcher.el b/lisp/vc/vc-dispatcher.el index 88bf6627ae..459c2ae103 100644 --- a/lisp/vc/vc-dispatcher.el +++ b/lisp/vc/vc-dispatcher.el @@ -156,6 +156,9 @@ vc-parent-buffer (defvar vc-parent-buffer-name nil) (put 'vc-parent-buffer-name 'permanent-local t) +(defvar vc-want-edit-command-p nil + "If non-nil, let user edit the VC shell command before running it.") + ;; Common command execution logic (defun vc-process-filter (p s) @@ -262,6 +265,12 @@ vc-run-delayed (declare (indent 0) (debug (def-body))) `(vc-exec-after (lambda () ,@body))) +(defvar vc-pre-command-functions nil + "Hook run at the beginning of `vc-do-command'. +Each function is called inside the buffer in which the command +will be run and is passed 3 arguments: the COMMAND, the FILES and +the FLAGS.") + (defvar vc-post-command-functions nil "Hook run at the end of `vc-do-command'. Each function is called inside the buffer in which the command was run @@ -296,8 +305,27 @@ vc-do-command files or be nil (to execute commands that don't expect a file name or set of files). If an optional list of FLAGS is present, that is inserted into the command line before the filename. + +If `vc-want-edit-command-p' is non-nil, prompt the user to edit +COMMAND and FLAGS before execution. + Return the return value of the slave command in the synchronous case, and the process object in the asynchronous case." + (when vc-want-edit-command-p + (let* ((files-separator-p (string= "--" (car (last flags)))) + (edited (split-string-and-unquote + (read-shell-command + (format "Edit VC command & arguments%s: " + (if file-or-list + " (files list to be appended)" + "")) + (combine-and-quote-strings + (cons command (remq nil (if files-separator-p + (butlast flags) + flags)))))))) + (setq command (car edited) + flags (nconc (cdr edited) + (and files-separator-p '("--")))))) (when vc-tor (push command flags) (setq command "torsocks")) @@ -327,6 +355,8 @@ vc-do-command (string= (buffer-name) buffer)) (eq buffer (current-buffer))) (vc-setup-buffer buffer)) + (run-hook-with-args 'vc-pre-command-functions + command file-or-list flags) ;; If there's some previous async process still running, just kill it. (let ((squeezed (remq nil flags)) (inhibit-read-only t) @@ -386,22 +416,25 @@ vc-do-async-command of a buffer, which is created. ROOT should be the directory in which the command should be run. Display the buffer in some window, but don't select it." - (let* ((dir default-directory) - (inhibit-read-only t) - window new-window-start) + (letrec ((dir default-directory) + (inhibit-read-only t) + (fun (lambda (command _ args) + (remove-hook 'vc-pre-command-functions fun) + (goto-char (point-max)) + (unless (eq (point) (point-min)) + (insert " \n")) + (setq new-window-start (point)) + (insert "Running \"" command) + (dolist (arg args) + (insert " " arg)) + (insert "\"...\n"))) + (window nil) (new-window-start nil)) (setq buffer (get-buffer-create buffer)) (if (get-buffer-process buffer) (error "Another VC action on %s is running" root)) (with-current-buffer buffer (setq default-directory root) - (goto-char (point-max)) - (unless (eq (point) (point-min)) - (insert " \n")) - (setq new-window-start (point)) - (insert "Running \"" command) - (dolist (arg args) - (insert " " arg)) - (insert "\"...\n") + (add-hook 'vc-pre-command-functions fun) ;; Run in the original working directory. (let ((default-directory dir)) (apply #'vc-do-command t 'async command nil args))) diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el index a5d12f03bc..2228cf8665 100644 --- a/lisp/vc/vc-git.el +++ b/lisp/vc/vc-git.el @@ -1089,35 +1089,30 @@ vc-git-error-regexp-alist (declare-function vc-compilation-mode "vc-dispatcher" (backend)) (defvar compilation-directory) (defvar compilation-arguments) +(defvar vc-want-edit-command-p) (defun vc-git--pushpull (command prompt extra-args) "Run COMMAND (a string; either push or pull) on the current Git branch. If PROMPT is non-nil, prompt for the Git command to run." (let* ((root (vc-git-root default-directory)) (buffer (format "*vc-git : %s*" (expand-file-name root))) - (git-program vc-git-program) - args) - ;; If necessary, prompt for the exact command. - ;; TODO if pushing, prompt if no default push location - cf bzr. - (when prompt - (setq args (split-string - (read-shell-command - (format "Git %s command: " command) - (format "%s %s" git-program command) - 'vc-git-history) - " " t)) - (setq git-program (car args) - command (cadr args) - args (cddr args))) - (setq args (nconc args extra-args)) + ;; TODO if pushing, prompt if no default push location - cf bzr. + (vc-want-edit-command-p prompt)) (require 'vc-dispatcher) - (apply #'vc-do-async-command buffer root git-program command args) + (when vc-want-edit-command-p + (with-current-buffer (get-buffer-create buffer) + (add-hook 'vc-pre-command-functions + (pcase-lambda (_ _ `(,new-command . ,new-args)) + (setq command new-command extra-args new-args)) + nil t))) + (apply #'vc-do-async-command + buffer root vc-git-program command extra-args) (with-current-buffer buffer (vc-run-delayed (vc-compilation-mode 'git) (setq-local compile-command - (concat git-program " " command " " - (mapconcat #'identity args " "))) + (concat vc-git-program " " command " " + (mapconcat #'identity extra-args " "))) (setq-local compilation-directory root) ;; Either set `compilation-buffer-name-function' locally to nil ;; or use `compilation-arguments' to set `name-function'. diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index c67dad69fc..76e577d682 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -1046,6 +1046,7 @@ log-view-vc-backend (defvar log-edit-vc-backend) (defvar diff-vc-backend) (defvar diff-vc-revisions) +(defvar vc-want-edit-command-p) (defun vc-deduce-backend () (cond ((derived-mode-p 'vc-dir-mode) vc-dir-backend) @@ -2744,17 +2745,26 @@ vc-print-root-log (setq vc-parent-buffer-name nil))) ;;;###autoload -(defun vc-print-branch-log (branch) - "Show the change log for BRANCH root in a window." +(defun vc-print-branch-log (branch &optional arg) + "Show the change log for BRANCH root in a window. +Optional prefix ARG non-nil requests an opportunity for the user +to edit the VC shell command that will be run to generate the +log." + ;; The original motivation for ARG was to make it possible to + ;; produce a log of more than one Git branch without modifying the + ;; print-log VC API. The user can append the other branches to the + ;; command line arguments to 'git log'. See bug#57807. (interactive (let* ((backend (vc-responsible-backend default-directory)) (rootdir (vc-call-backend backend 'root default-directory))) (list - (vc-read-revision "Branch to log: " (list rootdir) backend)))) + (vc-read-revision "Branch to log: " (list rootdir) backend) + current-prefix-arg))) (when (equal branch "") (error "No branch specified")) (let* ((backend (vc-responsible-backend default-directory)) - (rootdir (vc-call-backend backend 'root default-directory))) + (rootdir (vc-call-backend backend 'root default-directory)) + (vc-want-edit-command-p arg)) (vc-print-log-internal backend (list rootdir) branch t (when (> vc-log-show-limit 0) vc-log-show-limit)))) -- 2.30.2 --=-=-=-- From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 21 Sep 2022 18:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.16637866857681 (code B ref 57807); Wed, 21 Sep 2022 18:59:02 +0000 Received: (at 57807) by debbugs.gnu.org; 21 Sep 2022 18:58:05 +0000 Received: from localhost ([127.0.0.1]:35257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ob4v6-0001zo-UW for submit@debbugs.gnu.org; Wed, 21 Sep 2022 14:58:05 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:59285) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ob4v6-0001zL-4T for 57807@debbugs.gnu.org; Wed, 21 Sep 2022 14:58:04 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id AD438FF809; Wed, 21 Sep 2022 18:57:56 +0000 (UTC) From: Juri Linkov In-Reply-To: <8735clu05s.fsf@melete.silentflame.com> (Sean Whitton's message of "Tue, 20 Sep 2022 15:54:39 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> Date: Wed, 21 Sep 2022 21:52:28 +0300 Message-ID: <864jx0o903.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > I've done something about all these in the attached. What do you think? Adding vc-pre-command-functions as a counterpart of the existing vc-post-command-functions is a nice solution. I tested everything, and there are no more problems. Thanks for implementing this feature. After you will push it, it would be good also to try to generalize it to other vc commands. The problem is that some commands already use C-u for other purposes, such as 'C-u C-x v L' asks for a limit. What would be a possible way to set vc-want-edit-command-p without using a prefix arg? Maybe to add a new command that will only set vc-want-edit-command-p for the next vc command, and bind it to e.g. 'C-x v c'. Then 'C-x v c C-x v L' will allow editing the root log command. From unknown Mon Aug 18 17:54:34 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Sean Whitton Subject: bug#57807: closed (Re: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches) Message-ID: References: <87o7v8ple4.fsf@melete.silentflame.com> <87czbxub4b.fsf@melete.silentflame.com> X-Gnu-PR-Message: they-closed 57807 X-Gnu-PR-Package: emacs Reply-To: 57807@debbugs.gnu.org Date: Wed, 21 Sep 2022 19:40:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1663789201-11606-1" This is a multi-part message in MIME format... ------------=_1663789201-11606-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #57807: 29.0.50; Make vc-print-branch-log able to log multiple branches which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 57807@debbugs.gnu.org. --=20 57807: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D57807 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1663789201-11606-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 57807-done) by debbugs.gnu.org; 21 Sep 2022 19:39:40 +0000 Received: from localhost ([127.0.0.1]:35281 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ob5ZM-00030Z-2m for submit@debbugs.gnu.org; Wed, 21 Sep 2022 15:39:40 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:37953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ob5ZK-00030L-0o for 57807-done@debbugs.gnu.org; Wed, 21 Sep 2022 15:39:39 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id C0A145C0174; Wed, 21 Sep 2022 15:39:32 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 21 Sep 2022 15:39:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to; s=fm1; t=1663789172; x=1663875572; bh=wvbOkIPAyM juoB0La3aU2BsBUeYR3FxIcBsRdPlFhSw=; b=ovT9j/Y4uWzzN1I3T4EF5nE1uu l4mdDkfvWAjgzJKcGiwOiGwQLLUVaU70/22TxJ1moLWfAyd+YWoQFkKlEI8VLGON DrerGumfv9D5MUU6ryn24kyA7E8EvEGT96JWJHA5r06QvDVlfTtQxiByLZz00BJ0 8lzz9p0KT5NLXKErposiJ/HL8XB/zqSYZuukG6M0+pjdO2ejiQIXRaegZldSch0Y yJJjD1Ucf0xOsFL6Gi7EFSty/uLH+dqfXeM36gEnqtB3V7w8FctDoVfznCakROfC JlpHBiPVF4oVXsWO8/75MM4aAnWQ1uUqqcQNlP5GuPXMp2Nl5tV5mK06ZF9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663789172; x=1663875572; bh=wvbOkIPAyMjuoB0La3aU2BsBUeYR 3FxIcBsRdPlFhSw=; b=nNpdKmCK86/k/S1mt7KoXAjfQtgmbOgrsRc6i/xj3NEs GlbLRBcRSRW8oNcRPC7HjdKktysB9Mc4DGoW0RxRavneSlQW2NoIovQIzsJNYXE+ SJKGrJbEthhixpfILZ2vk92pRXEzcysVYdmHB/ZntMLTeGrS/e/gf1qwqBaBVvNx NjB/vAndn6Gg/RYDVVjX+dI8qvSu1jTphj4PDwV4K5JM8XW+04Y7GNrbKmgy9Vtg Qdz1z5CO0GuTE1Q9q7thaGGqjp3gXkKG7hg6OrFAcwEpCVljz9wLRaSTduqolHHf RsclvS8ihAJnNvwlO3uX6zrdw9abFh5zGyd7Q3N4dQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefuddgudegvdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeffueettdefvddtteevgfeufeejgfegudfgfedutdegfeet keehuddvfeejjeeifeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 21 Sep 2022 15:39:32 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 8E5D17F2FD9; Wed, 21 Sep 2022 12:39:31 -0700 (MST) From: Sean Whitton To: Juri Linkov , 57807-done@debbugs.gnu.org Subject: Re: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches In-Reply-To: <864jx0o903.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 21 Sep 2022 21:52:28 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> Date: Wed, 21 Sep 2022 12:39:31 -0700 Message-ID: <87o7v8ple4.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57807-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed 21 Sep 2022 at 09:52PM +03, Juri Linkov wrote: > Adding vc-pre-command-functions as a counterpart of the existing > vc-post-command-functions is a nice solution. I tested everything, > and there are no more problems. Thanks for implementing this feature. Thank you for testing it. > After you will push it, it would be good also to try to generalize it > to other vc commands. The problem is that some commands already use > C-u for other purposes, such as 'C-u C-x v L' asks for a limit. What > would be a possible way to set vc-want-edit-command-p without using a > prefix arg? Maybe to add a new command that will only set > vc-want-edit-command-p for the next vc command, and bind it to > e.g. 'C-x v c'. Then 'C-x v c C-x v L' will allow editing the root > log command. Right. It would be good to find a way to make all this consistent. It's unfortunate that C-x v l and C-x v P were different to begin with. Regarding your idea, how about 'C-x V V'? It's easier to type, won't clash with another command we might want to put on 'c', and feels a bit like C-x 4 4, C-x 5 5 etc. Though, to be honest, I'd prefer it if we could come up with something involving multiple 'C-u'. -- Sean Whitton ------------=_1663789201-11606-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 14 Sep 2022 17:20:01 +0000 Received: from localhost ([127.0.0.1]:55972 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYW3N-0000FG-84 for submit@debbugs.gnu.org; Wed, 14 Sep 2022 13:20:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:33242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYW3J-0000F5-Pn for submit@debbugs.gnu.org; Wed, 14 Sep 2022 13:19:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYW3F-0007CK-Tv for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 13:19:55 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60839) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYW3D-0007CD-E4 for bug-gnu-emacs@gnu.org; Wed, 14 Sep 2022 13:19:53 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id B00E75C00F0 for ; Wed, 14 Sep 2022 13:19:49 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Wed, 14 Sep 2022 13:19:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:content-type:date:date:from:from:in-reply-to:message-id :mime-version:reply-to:sender:subject:subject:to:to; s=fm1; t= 1663175989; x=1663262389; bh=UnqKUoO930WCqRlYsPk7Ql4dq7u+dWw5WMK T/ZTUrBY=; b=e4j9/qMDfF45Wt5dGUC74+Gv4ugZxvDfyqvAKz2a9cPMG9eBt6l CrTuQJ/enfIKoPT9TGyVPkkqfUkngtjRmu/6k0R3tkkFpIMO4xFFSaZt+uTOVsnx 9D0o+IRwXBC01OIqJ7x6kHqiBovTV+rYT0i2xMNS+CPm6b8umgROQyVIeeHKCvz+ NpsfwJf7WM0WT4RBOeuNi2REDuWXgUGdgAP/wLXHvCkuIAs1CVroiwm3bEbWIUBc peu+XTSTS2Z621ZVLsmzKO36VXA87zAwk/qpP0lRlzwAk2oFqTK7pEF27A0wY0Er Ekduq/+/P7urYhX7kTpjf94j6xZn7Q0pNhQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:message-id:mime-version :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1663175989; x= 1663262389; bh=UnqKUoO930WCqRlYsPk7Ql4dq7u+dWw5WMKT/ZTUrBY=; b=b q/jHc9rlt4IDnmeiKLQZeuaxDjodl9xEcl9/S0qqlGwgKvf14repdmydXaBdN6qa tmYqF1p3D9IBBA+bL03kg+mu1wwEppDCE0977XS3uyXP5wkAqG0W3gWCoUTol9uF sZfB7Hnl3qn8ifKarr6tv93nHhwuOWxpV9c3BJhSIqKuLxsuaESJNPf8b3Y85Fk1 qAVHRgh99pLhPg3b6OWuDFeF4LhARjCrdX7LkZ5MgEHVWf1WXPTAdIOrAYXb5QVt oUD9eHwJgIbi0YSqMfvvJlnM7NgTGWFYMq13AItCBzbukZSu2fBUfyBuf5Bbuf+L mY3hnhQZDu7ZiOahD3/wg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeduiedguddugecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgfgggtsehttddttd dtredtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehs phifhhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepfffgheeggffgheeuvd ethfekuddtgffgtdeukeegkedttefftdeghfdvgfdtjeelnecuvehluhhsthgvrhfuihii vgeptdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhih htthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA for ; Wed, 14 Sep 2022 13:19:49 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id BF8BF7F1678; Wed, 14 Sep 2022 10:19:48 -0700 (MST) From: Sean Whitton To: bug-gnu-emacs@gnu.org Subject: 29.0.50; Make vc-print-branch-log able to log multiple branches Date: Wed, 14 Sep 2022 10:19:48 -0700 Message-ID: <87czbxub4b.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=66.111.4.27; envelope-from=spwhitton@spwhitton.name; helo=out3-smtp.messagingengine.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) Hello, vc-git-log-edit-mode is already able to properly understand git-log(1) output which logs multiple branches. Here's a hack to demonstrate that: (let ((default-directory "~/src/emacs/") (vc-git-log-switches (cons "origin/scratch/posix-spawn" vc-git-log-switches))) (call-process-shell-command "git branch -f tmp 4b2ca6bfc0") (vc-print-branch-log "tmp")) (4b2ca6bfc0 is an old tip of master close to scratch/posix-spawn.) An example of a case in which it is useful to produce logs like this is when you're trying to figure out how several feature branches relate to each other and to the trunk. I don't think the idea of producing a log showing more than one branch at once is fundamentally git-specific. So I would like to extend vc-print-branch-log to allow logging more than one branch, or alternatively, add a vc-print-branch-logs command. I believe that there are two design issues, on which I'm requesting review/input: (1) Extending the VC history functions API to permit expressing a request for the backend to print a log of multiple branches. We could allow the START-REVISION argument to `print-log' to take a list of branches, or add an additional optional argument ADDITIONAL-START-REVISIONS. The latter seems more robust to me. (2) How could vc-print-branch-log prompt the user for multiple branch names? Magit has the user separate branch names with commas, offering completion for each branch name. But I suppose commas never appearing in branch names is git-specific. So the command could prompt the user repeatedly for branch names, until the user hits RET to input a zero-length branch name, indicating they've input them all. -- Sean Whitton ------------=_1663789201-11606-1-- From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Sep 2022 06:43:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166382895930163 (code B ref 57807); Thu, 22 Sep 2022 06:43:01 +0000 Received: (at 57807) by debbugs.gnu.org; 22 Sep 2022 06:42:39 +0000 Received: from localhost ([127.0.0.1]:35982 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obFuw-0007qQ-Sx for submit@debbugs.gnu.org; Thu, 22 Sep 2022 02:42:39 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:45315) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obFur-0007q9-Tl for 57807@debbugs.gnu.org; Thu, 22 Sep 2022 02:42:37 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 7DCCE100008; Thu, 22 Sep 2022 06:42:25 +0000 (UTC) From: Juri Linkov In-Reply-To: <87o7v8ple4.fsf@melete.silentflame.com> (Sean Whitton's message of "Wed, 21 Sep 2022 12:39:31 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> Date: Thu, 22 Sep 2022 09:39:33 +0300 Message-ID: <86illgc542.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> After you will push it, it would be good also to try to generalize it >> to other vc commands. The problem is that some commands already use >> C-u for other purposes, such as 'C-u C-x v L' asks for a limit. What >> would be a possible way to set vc-want-edit-command-p without using a >> prefix arg? Maybe to add a new command that will only set >> vc-want-edit-command-p for the next vc command, and bind it to >> e.g. 'C-x v c'. Then 'C-x v c C-x v L' will allow editing the root >> log command. > > Right. It would be good to find a way to make all this consistent. > It's unfortunate that C-x v l and C-x v P were different to begin with. > > Regarding your idea, how about 'C-x V V'? It's easier to type, won't > clash with another command we might want to put on 'c', and feels a bit > like C-x 4 4, C-x 5 5 etc. It's easier to type the same letter again, but holding the Shift key for V V after typing Control-X is more hard to type in a key sequence 'C-x V V C-x v L'. It's a pity that 'C-x v v' is not available. > Though, to be honest, I'd prefer it if we could come up with something > involving multiple 'C-u'. Another variant is to bind 'C-x v c' to a command that uses 'read-key-sequence' to read a key sequence from the vc keymap, then call a command with call-interactively while let-binding vc-want-edit-command-p, like project--switch-project-command does. Then e.g. 'C-x v c L' will have mnemonic "vc command for root log". From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Sep 2022 16:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.16638630359860 (code B ref 57807); Thu, 22 Sep 2022 16:11:02 +0000 Received: (at 57807) by debbugs.gnu.org; 22 Sep 2022 16:10:35 +0000 Received: from localhost ([127.0.0.1]:38303 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obOmZ-0002Yy-13 for submit@debbugs.gnu.org; Thu, 22 Sep 2022 12:10:35 -0400 Received: from wout5-smtp.messagingengine.com ([64.147.123.21]:51311) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obOmW-0002YX-3j for 57807@debbugs.gnu.org; Thu, 22 Sep 2022 12:10:33 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.west.internal (Postfix) with ESMTP id 5521132005CA; Thu, 22 Sep 2022 12:10:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 22 Sep 2022 12:10:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1663863025; x=1663949425; bh=1t VMzWFMp4YvMEb5OFlL2TTHbTiTtk9mfbamW0vBbEc=; b=oBwqW1UC6T8d52LlZ0 Y5kG5kEahHxOqNVT5hPdzuaCgxYY0jOxa/amBhurBErn1dnWeExZbJWgH7WQgMoy RtOvViLS8ScWfoQ1Ke5yJMFbK6WAWFpNJAUTtXPsvJTcpmFx9sWjponAp/nl1wxa QvLp5ogjEpSASJ2f87Ln0zP52DhrZRpMTJ+U6q2iwD1LgWBNFSnMWLN3TmLLdSk1 L+PPLgDtqFg8Qk9jUPURZIawPuusG5nWUkwgNik+9pd/P/HHEF6pETi9dvvirdor VNHU7TsrDmVGQ/2nT/KP+JvGHeFAVG7ZU8oyWVkQULPg/a/rcAl4T6mjBO/A6mj3 tfvQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663863025; x=1663949425; bh=1tVMzWFMp4YvMEb5OFlL2TTHbTiT tk9mfbamW0vBbEc=; b=nfK/opZH+Hhlf5pGY80eL14Zp6uiIsva5X8ck0XVQ4g/ EFF/M5qsGLzS/nj1HbpY+VYQjKCV0vwQ5kQ1PgvcyjT8Uk0W82AAo70xOO1v+RV5 nflRWkEzhXFdgwqUdcapA2b3RyTu79TUs1YqO4BGHlMmeQ4iMtSECoGC72sAdrNH 3XEpLw9nD257vxjKQc5/17MtiqVvAeN69uigzft6nT/qwTMxoJyoU/7UT4x/8Oyw SN7q3fhD414Sj+PcF9MiCMAcMsozrqQdTsQ7dDbFErmN2INzPQu+Ps/ruiYGlNSA AaDYbWhzlEYl8drBhN6KHaOdI44iY24T71KDMX8JWw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefgedgfeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Sep 2022 12:10:25 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id D2F847F3187; Thu, 22 Sep 2022 09:10:24 -0700 (MST) From: Sean Whitton In-Reply-To: <86illgc542.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 22 Sep 2022 09:39:33 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> Date: Thu, 22 Sep 2022 09:10:24 -0700 Message-ID: <875yhfo0en.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Thu 22 Sep 2022 at 09:39AM +03, Juri Linkov wrote: > Another variant is to bind 'C-x v c' to a command that uses > 'read-key-sequence' to read a key sequence from the vc keymap, > then call a command with call-interactively while let-binding > vc-want-edit-command-p, like project--switch-project-command does. > Then e.g. 'C-x v c L' will have mnemonic "vc command for root log". That seems alright. Maybe we could use some symbol, e.g. '$' or '#', instead of a letter 'c', to distinguish its special status. -- Sean Whitton From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Sep 2022 18:47:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166387240925119 (code B ref 57807); Thu, 22 Sep 2022 18:47:01 +0000 Received: (at 57807) by debbugs.gnu.org; 22 Sep 2022 18:46:49 +0000 Received: from localhost ([127.0.0.1]:38540 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obRDk-0006X5-Pe for submit@debbugs.gnu.org; Thu, 22 Sep 2022 14:46:48 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:60791) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obRDi-0006Wp-I1 for 57807@debbugs.gnu.org; Thu, 22 Sep 2022 14:46:47 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 2CCCCFF805; Thu, 22 Sep 2022 18:46:37 +0000 (UTC) From: Juri Linkov In-Reply-To: <875yhfo0en.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 22 Sep 2022 09:10:24 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> Date: Thu, 22 Sep 2022 21:44:00 +0300 Message-ID: <86h70zp8br.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Another variant is to bind 'C-x v c' to a command that uses >> 'read-key-sequence' to read a key sequence from the vc keymap, >> then call a command with call-interactively while let-binding >> vc-want-edit-command-p, like project--switch-project-command does. >> Then e.g. 'C-x v c L' will have mnemonic "vc command for root log". > > That seems alright. Maybe we could use some symbol, e.g. '$' or '#', > instead of a letter 'c', to distinguish its special status. I see that 'c' might clash with a possible future command. For example, git has a lot of commands whose names start with the letter 'c': checkout, cherry-pick, clone, commit, ... So the probability of the need to use 'c' is high. OTOH, what key would keep the mnemonic of a prefix arg? Maybe 'C-x v C-u'? From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Sep 2022 21:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.16638816347331 (code B ref 57807); Thu, 22 Sep 2022 21:21:02 +0000 Received: (at 57807) by debbugs.gnu.org; 22 Sep 2022 21:20:34 +0000 Received: from localhost ([127.0.0.1]:38714 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obTcX-0001uB-Lz for submit@debbugs.gnu.org; Thu, 22 Sep 2022 17:20:33 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:58831) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obTcV-0001tp-Su for 57807@debbugs.gnu.org; Thu, 22 Sep 2022 17:20:32 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id D0BCC5C00DB; Thu, 22 Sep 2022 17:20:26 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Thu, 22 Sep 2022 17:20:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1663881626; x=1663968026; bh=EF DhNEffskStLxUpSzViXV6VTGNUxBbK/Sx2hkFryfo=; b=ZhEqfgt5GTlcmit9Y2 I92ZTrkXdXSrYM4dogk2Pbe1vg6ijz5ifhRZuBbhyrzCZpQZt9o4OKEIQy0BlKME t0zq0pz5O8ic6Y6tgEaWp9YN3cy4uF7ghe+ILHCHqqgiKOLBk7qKrWgtNRdz5htw W/N55E5cX5upOvO7MHvhN1vWnSaVOeeUogQM7+t4gOCN971USQBr2dcXqdIiLsWA YAaGHyVWxQui07tsb9jrE+50oDUTmDlWyniX9IirQB+vMiNntP6q6ZKuiQId+xQD dpdHxkaCKswyyy32KX7lym3cDSnmIYu7q4m7empKctkXSPnvI33zswYD2xRS0Jvf vv9g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663881626; x=1663968026; bh=EFDhNEffskStLxUpSzViXV6VTGNU xBbK/Sx2hkFryfo=; b=Qn27Jv+Nv4GzEeUVKT1u3YJV2lVY7mnisDgCZkDUswRd bu2bAb2B0dfwxFYfATc2KzgO1fuEv7FiUV5gvj1AvFwINPflysUhhEaST6kP2zD2 YZoY8q3FQnTEBMe3/Oq3iCGQXlxCts8vm7S4Lr1MnUThAZmrmzRuIq99sISjJZ3N 2GSpiHDHFtKD/XjS6QrO9ehSD6ot5islr86TqWv/BnGf+bWUUqri4GYV4Gj+XtSH GdhrHmUr3DFejTLJCe+xQoHmZm6cenYyRLmfVB6C+UaSssFvu0ovl+4dfYL+rb6G tDemIM+5Cr9tssKVj8zJPhevFiBICVh3hwDtfZuzqQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefgedguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Sep 2022 17:20:26 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id D03B97F2CA5; Thu, 22 Sep 2022 14:20:25 -0700 (MST) From: Sean Whitton In-Reply-To: <86h70zp8br.fsf@mail.linkov.net> (Juri Linkov's message of "Thu, 22 Sep 2022 21:44:00 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> Date: Thu, 22 Sep 2022 14:20:25 -0700 Message-ID: <87wn9vjecm.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Thu 22 Sep 2022 at 09:44PM +03, Juri Linkov wrote: >>> Another variant is to bind 'C-x v c' to a command that uses >>> 'read-key-sequence' to read a key sequence from the vc keymap, >>> then call a command with call-interactively while let-binding >>> vc-want-edit-command-p, like project--switch-project-command does. >>> Then e.g. 'C-x v c L' will have mnemonic "vc command for root log". >> >> That seems alright. Maybe we could use some symbol, e.g. '$' or '#', >> instead of a letter 'c', to distinguish its special status. > > I see that 'c' might clash with a possible future command. > For example, git has a lot of commands whose names start > with the letter 'c': checkout, cherry-pick, clone, commit, ... > So the probability of the need to use 'c' is high. > > OTOH, what key would keep the mnemonic of a prefix arg? > Maybe 'C-x v C-u'? Might be confusing if you need to do C-u C-x v C-u C-x v b l ... '$' and '!' have shell command mnemonics. -- Sean Whitton From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2022 06:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.16639157046758 (code B ref 57807); Fri, 23 Sep 2022 06:49:02 +0000 Received: (at 57807) by debbugs.gnu.org; 23 Sep 2022 06:48:24 +0000 Received: from localhost ([127.0.0.1]:39214 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obcU4-0001kw-BI for submit@debbugs.gnu.org; Fri, 23 Sep 2022 02:48:24 -0400 Received: from relay9-d.mail.gandi.net ([217.70.183.199]:51451) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obcU0-0001kh-Mg for 57807@debbugs.gnu.org; Fri, 23 Sep 2022 02:48:22 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 50086FF805; Fri, 23 Sep 2022 06:48:12 +0000 (UTC) From: Juri Linkov In-Reply-To: <87wn9vjecm.fsf@melete.silentflame.com> (Sean Whitton's message of "Thu, 22 Sep 2022 14:20:25 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> <87wn9vjecm.fsf@melete.silentflame.com> Date: Fri, 23 Sep 2022 09:42:11 +0300 Message-ID: <86y1uad298.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> That seems alright. Maybe we could use some symbol, e.g. '$' or '#', >>> instead of a letter 'c', to distinguish its special status. >> >> I see that 'c' might clash with a possible future command. >> For example, git has a lot of commands whose names start >> with the letter 'c': checkout, cherry-pick, clone, commit, ... >> So the probability of the need to use 'c' is high. >> >> OTOH, what key would keep the mnemonic of a prefix arg? >> Maybe 'C-x v C-u'? > > Might be confusing if you need to do C-u C-x v C-u C-x v b l ... > > '$' and '!' have shell command mnemonics. I didn't recognize '$' and '#' as shell-related symbols here because in Emacs they have another semantics: e.g. 'C-x #' is 'server-edit', 'M-$' is ispell-checking, etc. But 'M-!' has a clear connection with editing a shell command. So 'C-x v !' looks like the best candidate among all considered so far. From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 23 Sep 2022 16:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166395084911753 (code B ref 57807); Fri, 23 Sep 2022 16:35:01 +0000 Received: (at 57807) by debbugs.gnu.org; 23 Sep 2022 16:34:09 +0000 Received: from localhost ([127.0.0.1]:41623 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oblcv-00033U-C6 for submit@debbugs.gnu.org; Fri, 23 Sep 2022 12:34:09 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:55475) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oblcu-00033J-7b for 57807@debbugs.gnu.org; Fri, 23 Sep 2022 12:34:08 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 2BC255C010D; Fri, 23 Sep 2022 12:34:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Fri, 23 Sep 2022 12:34:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1663950843; x=1664037243; bh=dj UrvlQgSjcd/T9+qVWaMuuFRRrJ1H+PfBAWShKsxHU=; b=B07zRzKLNRwU3ZKrGw 4W313bKulSE4qRx/De+XEs0cqsd7zQuHBhI9VSZfLLywOjFbl0y0fGcI5xUXVGxZ hrXPfmPnpbavbJcJ9/1sG65QDZ/1tRCp4k3tL62A14aSXJp36OG+Gs91ipo3vJ0i 5t2/IGAfCpVxK9ORkmwN76YvcS9kGhxx+ZQd6yfGVfQTiiSag4Ai6SV507ExpUNf kde1xqd+EYCY6tjmbw1hYARzmqSuml0Or96mO+TzsJwI8qfnr/0QPNuMJuhK6kSq RVJLpkm4R8UWAYqtJ541akHCsEXpnCP/XxiDrLF/QMlzZmwQOSVo7Hlr8kjv7Wwt SUiQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1663950843; x=1664037243; bh=djUrvlQgSjcd/T9+qVWaMuuFRRrJ 1H+PfBAWShKsxHU=; b=SzLEsTDVdcsCrmWAUeI/wbypRCoRZHVouOpFMKrjxPsd eM44zeu8zcTq9dMqX6Qd92CbY+if/0UwOu5nkZXZAn0knS1Oz6wjOeWYFtw3NvLv NKcV7HHxAG83uxUdRcam/YcP+pj3WlRr67oOzIdKn9P3GVvhCHe3KBG8TQKxsNiH nJ4c+H4dPyP7P0F8WU05qqCUHDhb+KR0wrJKLm/hE7vDMqYLn0bzJqdAsmd8BSb+ H4uP5v1Wb4bz8wIQBd80KwwMS1/ddMjcSAcOzDiInUhl3AQ1yut+8WEqxlqPiFqz D67czSkh//N26NxTI4nhY2j8md0ddiEsh13PsFhsrQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefiedguddthecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 23 Sep 2022 12:34:02 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 4BC237F32D5; Fri, 23 Sep 2022 09:34:02 -0700 (MST) From: Sean Whitton In-Reply-To: <86y1uad298.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 23 Sep 2022 09:42:11 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> <87wn9vjecm.fsf@melete.silentflame.com> <86y1uad298.fsf@mail.linkov.net> Date: Fri, 23 Sep 2022 09:34:02 -0700 Message-ID: <87bkr62gp1.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Fri 23 Sep 2022 at 09:42AM +03, Juri Linkov wrote: > I didn't recognize '$' and '#' as shell-related symbols here > because in Emacs they have another semantics: e.g. > 'C-x #' is 'server-edit', 'M-$' is ispell-checking, etc. > > But 'M-!' has a clear connection with editing a shell command. So > 'C-x v !' looks like the best candidate among all considered so far. I'll look into implementing the prefix command, then, though I will need to complete the refactoring in response to Stefan's comments first. -- Sean Whitton From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Sep 2022 19:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166404726314965 (code B ref 57807); Sat, 24 Sep 2022 19:22:01 +0000 Received: (at 57807) by debbugs.gnu.org; 24 Sep 2022 19:21:03 +0000 Received: from localhost ([127.0.0.1]:45297 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocAhz-0003tJ-20 for submit@debbugs.gnu.org; Sat, 24 Sep 2022 15:21:03 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:33963) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocAhu-0003sS-QO for 57807@debbugs.gnu.org; Sat, 24 Sep 2022 15:21:01 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id BDD455C007E; Sat, 24 Sep 2022 15:20:52 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Sat, 24 Sep 2022 15:20:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1664047252; x=1664133652; bh=X+ 4Ao9nzrzeSxgboYW4sGlhunWLNCvSV8IPhrC4k1MI=; b=SGc6rJr+jtyIg6N9Sy lLRLE1U8w1a22VllU4J+k1bX185mFLSDZNmuYDwPQ8BCM6RojYCaHGOfJtAezrv3 fF5et9ofuHxjLNARWk5HyrLmV15q/UfTZqSU+eHPqU6ta9BlSmEP7WwdAL8Fm/Hf soyrzau61/Y8UkA7fSwrUkWl3kt47kLjNXofK5O84lbFchtratbsWNtAgoHUKMEC QfgEefBMAp1BSLz+Mss8tgg3zQLfSrGGlGXTHUEJiA51El2cylXU95cpCMRrq2EU eIthmyzrL4sTz0xohGBR/WzgjtXGVdDXKN3Rb1aRfWf6bJbO03mRUUSo3NboTOSw 8gFg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664047252; x=1664133652; bh=X+4Ao9nzrzeSxgboYW4sGlhunWLN CvSV8IPhrC4k1MI=; b=YKcogHBDkmqr0VadDCBu0AHu3v0a498s41Aq3GluSyNI NxCMFWcDKtvYMgiYa6Z0ZrSLrvdurT+R+DbZtPAAZ2LOcXG77RKd4JIy5USkjdn1 91ipzesOlhx251qDSqWU6VAdNqXOdo6tR757lIOFAqlBSZ57wXQi73pwkNWXFMhE hXB8JcVmKyDGV0NBNQrpNCYdUzXMmZ8RHXpiy37qoDgNWaKz9vTxZ76+CfxPurYk H8gfo6i8qxKXIjUuZpsYNlVhZMDaZltE+wTaGIpl0BFR4yj/3RjwvSYx1woV3cPj qMtKRKzvLYq/3MC1vnJoOrCzupJ8KqlfG4E/VniVhQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefkedgudefjecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Sep 2022 15:20:52 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id DB85C7F30F5; Sat, 24 Sep 2022 12:20:50 -0700 (MST) From: Sean Whitton In-Reply-To: <86y1uad298.fsf@mail.linkov.net> (Juri Linkov's message of "Fri, 23 Sep 2022 09:42:11 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> <87wn9vjecm.fsf@melete.silentflame.com> <86y1uad298.fsf@mail.linkov.net> Date: Sat, 24 Sep 2022 12:20:50 -0700 Message-ID: <87fsggd1f1.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Fri 23 Sep 2022 at 09:42AM +03, Juri Linkov wrote: >>>> That seems alright. Maybe we could use some symbol, e.g. '$' or '#', >>>> instead of a letter 'c', to distinguish its special status. >>> >>> I see that 'c' might clash with a possible future command. >>> For example, git has a lot of commands whose names start >>> with the letter 'c': checkout, cherry-pick, clone, commit, ... >>> So the probability of the need to use 'c' is high. >>> >>> OTOH, what key would keep the mnemonic of a prefix arg? >>> Maybe 'C-x v C-u'? >> >> Might be confusing if you need to do C-u C-x v C-u C-x v b l ... >> >> '$' and '!' have shell command mnemonics. > > I didn't recognize '$' and '#' as shell-related symbols here > because in Emacs they have another semantics: e.g. > 'C-x #' is 'server-edit', 'M-$' is ispell-checking, etc. > > But 'M-!' has a clear connection with editing a shell command. So > 'C-x v !' looks like the best candidate among all considered so far. I'm running into the problem that you pointed out in another thread. How do we apply vc-filter-command-function to the final VC command that's to be run without also applying it to intermediate VC commands, e.g. in vc-read-revision? -- Sean Whitton From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Sep 2022 20:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166405012919663 (code B ref 57807); Sat, 24 Sep 2022 20:09:01 +0000 Received: (at 57807) by debbugs.gnu.org; 24 Sep 2022 20:08:49 +0000 Received: from localhost ([127.0.0.1]:45333 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocBSD-000575-9x for submit@debbugs.gnu.org; Sat, 24 Sep 2022 16:08:49 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:40955) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocBSA-00056q-Tj for 57807@debbugs.gnu.org; Sat, 24 Sep 2022 16:08:47 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 3FE10C0005; Sat, 24 Sep 2022 20:08:37 +0000 (UTC) From: Juri Linkov In-Reply-To: <87fsggd1f1.fsf@melete.silentflame.com> (Sean Whitton's message of "Sat, 24 Sep 2022 12:20:50 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> <87wn9vjecm.fsf@melete.silentflame.com> <86y1uad298.fsf@mail.linkov.net> <87fsggd1f1.fsf@melete.silentflame.com> Date: Sat, 24 Sep 2022 22:57:16 +0300 Message-ID: <86v8pc5yff.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> But 'M-!' has a clear connection with editing a shell command. So >> 'C-x v !' looks like the best candidate among all considered so far. > > I'm running into the problem that you pointed out in another thread. > How do we apply vc-filter-command-function to the final VC command > that's to be run without also applying it to intermediate VC commands, > e.g. in vc-read-revision? Maybe there is no problem to apply the editing filter to all commands, I don't know. First need to try to see how it really works. From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Sep 2022 23:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166406155314325 (code B ref 57807); Sat, 24 Sep 2022 23:20:01 +0000 Received: (at 57807) by debbugs.gnu.org; 24 Sep 2022 23:19:13 +0000 Received: from localhost ([127.0.0.1]:45438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocEQS-0003iz-MV for submit@debbugs.gnu.org; Sat, 24 Sep 2022 19:19:13 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:37267) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocEQO-0003ik-CN for 57807@debbugs.gnu.org; Sat, 24 Sep 2022 19:19:11 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id D46DA5C007F; Sat, 24 Sep 2022 19:19:00 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Sat, 24 Sep 2022 19:19:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1664061540; x=1664147940; bh=1q NlNDOdqBSn/R66j5Bh9eTc7qzVvyC6YdtWInhgb7Q=; b=2n+OTHmOAV9KpWN8zv zh6LAry6cKoN27ziYptu5LEA/pEj4IBz1TxDJHAFW2HKOcvwIkueWNjnGqlGwTzc cZjpSRFncFYJJCgx42ETjdGvRMO6bBtnTEV8BpG+VCoBUIhSy2znVx5/2NOb/A/p d0lI3uV2QseLMwqBRC/EjWAxwK9NGx48aEStZ1dC0+1f+ABUR/FjJmUIOnywwcHE YeWUFBX3bJ/AoJCD5DLJUuv51nr2Xtk6mdfafPsM8fgE9ZLjrV3Se0qJ2M3Ygupi 21JbjrFy4fM2pQTv0R8Bj9XYr6nrOcqA2FDzbOqbDvUQEta2jqr1dMOVkz9m6UAW T3Ug== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664061540; x=1664147940; bh=1qNlNDOdqBSn/R66j5Bh9eTc7qzV vyC6YdtWInhgb7Q=; b=jpw16lez5MKTIvrFw17TFT+ASYBhFa3vQ1B+KnabCqh+ OM6IHMQTgasLwCK/o75ILDOdf8T3QnLmOyYFDTaHC3Ik7hdwJy2pz4wXYNI8M5Ho +4Jwa93Sd60AnuUbNl2lKz4m1S8pY6B+87FF8buQjLCZEHAGIe51Oax07O3JtjYC ZtQ3IaTbbVFI2Daz9V39eWRMPBus3q2pF3w1pCzwZJgkaAmymK3znLxYJkK7+2D6 J/jmBjlye70LxUjw/9kUGpk5/FxfNBJLEN5pyh2A2cLmgOD/G8HA3jFzpD6IvZdz 4DR6NLDW6DDmxpnpysPkwbBCVNHY/K64GN/hbeLq1Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeefledgudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesmhdttdertdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeffveeuhfeludfhfeegjeefhefhfeeludejueehfeevtdfh hfettedtfeelleetudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 24 Sep 2022 19:19:00 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id A68837F2CDC; Sat, 24 Sep 2022 16:18:59 -0700 (MST) From: Sean Whitton In-Reply-To: <86v8pc5yff.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 24 Sep 2022 22:57:16 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> <87wn9vjecm.fsf@melete.silentflame.com> <86y1uad298.fsf@mail.linkov.net> <87fsggd1f1.fsf@melete.silentflame.com> <86v8pc5yff.fsf@mail.linkov.net> Date: Sat, 24 Sep 2022 16:18:59 -0700 Message-ID: <87r100bbto.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello, On Sat 24 Sep 2022 at 10:57PM +03, Juri Linkov wrote: >>> But 'M-!' has a clear connection with editing a shell command. So >>> 'C-x v !' looks like the best candidate among all considered so far. >> >> I'm running into the problem that you pointed out in another thread. >> How do we apply vc-filter-command-function to the final VC command >> that's to be run without also applying it to intermediate VC commands, >> e.g. in vc-read-revision? > > Maybe there is no problem to apply the editing filter to all commands, > I don't know. First need to try to see how it really works. Here's the WIP patch, hopefully it works well enough for testing. I think it's considerably worse than C-u C-x v b l tbh. -- Sean Whitton --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-WIP-Add-vc-edit-next-command.patch >From 8521996056c980d096f1ec935c34345f265d3665 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Sat, 24 Sep 2022 16:17:56 -0700 Subject: [PATCH] WIP Add vc-edit-next-command. --- lisp/vc/vc-hooks.el | 3 ++- lisp/vc/vc.el | 25 +++++++++++++++++++++++++ 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el index 7f0d9e4d86..6ad26cfe67 100644 --- a/lisp/vc/vc-hooks.el +++ b/lisp/vc/vc-hooks.el @@ -882,7 +882,8 @@ vc-prefix-map "=" #'vc-diff "D" #'vc-root-diff "~" #'vc-revision-other-window - "x" #'vc-delete-file) + "x" #'vc-delete-file + "!" #'vc-edit-next-command) (fset 'vc-prefix-map vc-prefix-map) (define-key ctl-x-map "v" 'vc-prefix-map) diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 4950a1a32d..595288d30f 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -3244,6 +3244,31 @@ vc-update-change-log (vc-call-backend (vc-responsible-backend default-directory) 'update-changelog args)) +(defvar vc-filter-command-function) + +;;;###autoload +(defun vc-edit-next-command () + "Request editing the next VC shell command before execution. +This is a prefix command. It affects only a VC command executed +immediately after this one." + (interactive) + (letrec ((command this-command) + (keys (key-description (this-command-keys))) + (old vc-filter-command-function) + (echofun (lambda () keys)) + (postfun + (lambda () + (unless (eq this-command command) + (remove-hook 'post-command-hook postfun) + (remove-hook 'prefix-command-echo-keystrokes-functions + echofun) + (setq vc-filter-command-function old))))) + (add-hook 'post-command-hook postfun) + (add-hook 'prefix-command-echo-keystrokes-functions echofun) + (setq vc-filter-command-function + (lambda (&rest args) + (apply #'vc-user-edit-command (apply old args)))))) + (defun vc-default-responsible-p (_backend _file) "Indicate whether BACKEND is responsible for FILE. The default is to return nil always." -- 2.30.2 --=-=-=-- From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Sep 2022 07:38:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.16640914398305 (code B ref 57807); Sun, 25 Sep 2022 07:38:02 +0000 Received: (at 57807) by debbugs.gnu.org; 25 Sep 2022 07:37:19 +0000 Received: from localhost ([127.0.0.1]:45771 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocMCV-00029t-FU for submit@debbugs.gnu.org; Sun, 25 Sep 2022 03:37:19 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:58437) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocMCS-00029b-Dt for 57807@debbugs.gnu.org; Sun, 25 Sep 2022 03:37:17 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 31770100002; Sun, 25 Sep 2022 07:37:07 +0000 (UTC) From: Juri Linkov In-Reply-To: <87r100bbto.fsf@melete.silentflame.com> (Sean Whitton's message of "Sat, 24 Sep 2022 16:18:59 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> <86v8ppn5b2.fsf@mail.linkov.net> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> <87wn9vjecm.fsf@melete.silentflame.com> <86y1uad298.fsf@mail.linkov.net> <87fsggd1f1.fsf@melete.silentflame.com> <86v8pc5yff.fsf@mail.linkov.net> <87r100bbto.fsf@melete.silentflame.com> Date: Sun, 25 Sep 2022 10:29:39 +0300 Message-ID: <86o7v3kj30.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >>> I'm running into the problem that you pointed out in another thread. >>> How do we apply vc-filter-command-function to the final VC command >>> that's to be run without also applying it to intermediate VC commands, >>> e.g. in vc-read-revision? >> >> Maybe there is no problem to apply the editing filter to all commands, >> I don't know. First need to try to see how it really works. > > Here's the WIP patch, hopefully it works well enough for testing. Thanks, I'm going to try it out. > I think it's considerably worse than C-u C-x v b l tbh. Undoubtedly, it's worse. But it solves the problem that all vc commands can't use C-u. From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Sep 2022 22:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166423161814421 (code B ref 57807); Mon, 26 Sep 2022 22:34:02 +0000 Received: (at 57807) by debbugs.gnu.org; 26 Sep 2022 22:33:38 +0000 Received: from localhost ([127.0.0.1]:51984 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocwfP-0003kV-Lj for submit@debbugs.gnu.org; Mon, 26 Sep 2022 18:33:38 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:48863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ocwfK-0003kC-2P for 57807@debbugs.gnu.org; Mon, 26 Sep 2022 18:33:34 -0400 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 213265C0053; Mon, 26 Sep 2022 18:33:24 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Mon, 26 Sep 2022 18:33:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1664231604; x=1664318004; bh=Rh Yr3iZP84rIkSTHWVB8iYTZHKouv4Ycsr65yEXUGsc=; b=uTI/LVjfsN6nvSEKxm 4hSzmPD96N8pS/5FQSNhNuyzFgjPI4XH9Kn8sYpOIsp2SPaNB8tBqQKcfdWhnxLm Gfy5qeFkOc8KXfpEvr2ep74kUXGUm2vvY4ynYSqkAf9hi2XFGsZ9lYU7jPN+4s1V /oRiqKSJRD1WsQ7DUnvzbx63tgn2kovkC7CmSAvg0H6CSzvbo5EI3f95pzmlUpCx nH8O6zqRRHWgGKPqWxsldswmPXiF/UW+7ilCp/m9qGkE7l9cj66E38Um15dUqgbN +XEMoPfVfmAZTRi34Isj3uGl399bWS2HswqqljhO1VLunroZpkYqOXgyvJ5rypXp aNJg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664231604; x=1664318004; bh=RhYr3iZP84rIkSTHWVB8iYTZHKou v4Ycsr65yEXUGsc=; b=y+p1CbulSezw+RHET5d6eHlLn1EaVi2nWqsbcqoMCP4o 0BjARnA31LsuqmjD585LjpgF9Ue8SdRqVdNdMh6eJR6UFV/cHUWSe1LcwYxTrGDb K/RG54Dc8Xih2VZFPoBBkfJTt77Xpdtu5W5Wb/IohNKMCCiDfV4Ifslu9aEKRcWZ VFyxLlzMGwZWJea1Q2B/QLnOmrTGujAvgcTzven5cbW+CVWm6Wnk2tCIvem6GsYk YEi90Iri7euXlP4rBUKkUejSIfQBbnHrDHi7ijZ7UUbx/mtX3cwNqTS9t3TVluid SHgdfHmyzp/R3EB+Fhu7jJJ7+5vW81rDqxeeJteV+w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegfedguddvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesmhdttdertdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeffveeuhfeludfhfeegjeefhefhfeeludejueehfeevtdfh hfettedtfeelleetudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 26 Sep 2022 18:33:23 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 7AFDD7E032C; Mon, 26 Sep 2022 15:33:22 -0700 (MST) From: Sean Whitton In-Reply-To: <86o7v3kj30.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 25 Sep 2022 10:29:39 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <87h719shi6.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> <87wn9vjecm.fsf@melete.silentflame.com> <86y1uad298.fsf@mail.linkov.net> <87fsggd1f1.fsf@melete.silentflame.com> <86v8pc5yff.fsf@mail.linkov.net> <87r100bbto.fsf@melete.silentflame.com> <86o7v3kj30.fsf@mail.linkov.net> Date: Mon, 26 Sep 2022 15:33:22 -0700 Message-ID: <87r0zxlqa5.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello, On Sun 25 Sep 2022 at 10:29AM +03, Juri Linkov wrote: >>>> I'm running into the problem that you pointed out in another thread. >>>> How do we apply vc-filter-command-function to the final VC command >>>> that's to be run without also applying it to intermediate VC commands, >>>> e.g. in vc-read-revision? >>> >>> Maybe there is no problem to apply the editing filter to all commands, >>> I don't know. First need to try to see how it really works. >> >> Here's the WIP patch, hopefully it works well enough for testing. > > Thanks, I'm going to try it out. It looks like I need to call (minibuffer-depth) like display-buffer-override-next-command does. Updated patch attached. >> I think it's considerably worse than C-u C-x v b l tbh. > > Undoubtedly, it's worse. But it solves the problem that > all vc commands can't use C-u. Just to be clear, the thing that I think is much worse is being prompted for multiple intermediate commands, not the longer key sequence. I realised that we could add an override inside vc-read-revision, and potentially other places, which makes it considerably less annoying. Done in the attached. -- Sean Whitton --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=v2-0001-WIP-Add-vc-edit-next-command.patch >From 7115ae59cf5f263dbc1b1a208fce974d790d8cae Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Sat, 24 Sep 2022 16:17:56 -0700 Subject: [PATCH v2] WIP Add vc-edit-next-command. --- lisp/vc/vc-hooks.el | 3 ++- lisp/vc/vc.el | 34 ++++++++++++++++++++++++++++++++-- 2 files changed, 34 insertions(+), 3 deletions(-) diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el index 7f0d9e4d86..6ad26cfe67 100644 --- a/lisp/vc/vc-hooks.el +++ b/lisp/vc/vc-hooks.el @@ -882,7 +882,8 @@ vc-prefix-map "=" #'vc-diff "D" #'vc-root-diff "~" #'vc-revision-other-window - "x" #'vc-delete-file) + "x" #'vc-delete-file + "!" #'vc-edit-next-command) (fset 'vc-prefix-map vc-prefix-map) (define-key ctl-x-map "v" 'vc-prefix-map) diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 4950a1a32d..76554d2340 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -1918,8 +1918,11 @@ vc-read-revision (setq files (cadr vc-fileset)) (setq backend (car vc-fileset)))) ((null backend) (setq backend (vc-backend (car files))))) - (let ((completion-table - (vc-call-backend backend 'revision-completion-table files))) + ;; Override any `vc-filter-command-function' value, as user probably + ;; doesn't want to edit the command to get the completions. + (let* ((vc-filter-command-function #'list) + (completion-table + (vc-call-backend backend 'revision-completion-table files))) (if completion-table (completing-read prompt completion-table nil nil initial-input 'vc-revision-history default) @@ -3244,6 +3247,33 @@ vc-update-change-log (vc-call-backend (vc-responsible-backend default-directory) 'update-changelog args)) +(defvar vc-filter-command-function) + +;;;###autoload +(defun vc-edit-next-command () + "Request editing the next VC shell command before execution. +This is a prefix command. It affects only a VC command executed +immediately after this one." + (interactive) + (letrec ((minibuffer-depth (minibuffer-depth)) + (command this-command) + (keys (key-description (this-command-keys))) + (old vc-filter-command-function) + (echofun (lambda () keys)) + (postfun + (lambda () + (unless (or (eq this-command command) + (> (minibuffer-depth) minibuffer-depth)) + (remove-hook 'post-command-hook postfun) + (remove-hook 'prefix-command-echo-keystrokes-functions + echofun) + (setq vc-filter-command-function old))))) + (add-hook 'post-command-hook postfun) + (add-hook 'prefix-command-echo-keystrokes-functions echofun) + (setq vc-filter-command-function + (lambda (&rest args) + (apply #'vc-user-edit-command (apply old args)))))) + (defun vc-default-responsible-p (_backend _file) "Indicate whether BACKEND is responsible for FILE. The default is to return nil always." -- 2.30.2 --=-=-=-- From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 27 Sep 2022 19:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166430840020189 (code B ref 57807); Tue, 27 Sep 2022 19:54:02 +0000 Received: (at 57807) by debbugs.gnu.org; 27 Sep 2022 19:53:20 +0000 Received: from localhost ([127.0.0.1]:56862 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odGdr-0005FZ-LR for submit@debbugs.gnu.org; Tue, 27 Sep 2022 15:53:19 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:33163) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odGdi-0005F1-OM for 57807@debbugs.gnu.org; Tue, 27 Sep 2022 15:53:11 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 55D102000D; Tue, 27 Sep 2022 19:52:58 +0000 (UTC) From: Juri Linkov In-Reply-To: <87r0zxlqa5.fsf@melete.silentflame.com> (Sean Whitton's message of "Mon, 26 Sep 2022 15:33:22 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> <861qsdktqo.fsf@mail.linkov.net> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> <87wn9vjecm.fsf@melete.silentflame.com> <86y1uad298.fsf@mail.linkov.net> <87fsggd1f1.fsf@melete.silentflame.com> <86v8pc5yff.fsf@mail.linkov.net> <87r100bbto.fsf@melete.silentflame.com> <86o7v3kj30.fsf@mail.linkov.net> <87r0zxlqa5.fsf@melete.silentflame.com> Date: Tue, 27 Sep 2022 21:59:04 +0300 Message-ID: <861qrwocbb.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) >> Thanks, I'm going to try it out. > > It looks like I need to call (minibuffer-depth) like > display-buffer-override-next-command does. Updated patch attached. I tested your latest patch with many vc commands, and everything works nicely, even M-x for vc commands without a keybinding and with a prefix arg is supported like in C-x v ! C-u M-x vc-log-search RET (C-u is not needed for vc-log-search anymore, it's just for testing a prefix arg here). > I realised that we could add an override inside vc-read-revision, and > potentially other places, which makes it considerably less annoying. > Done in the attached. Maybe it's fine to disable editing for vc-read-revision, but I'm not sure about other commands, such as e.g. vc-git-log-incoming that runs two git commands: vc-git-command fetch vc-git-command log I see no problem to type an extra RET even for a secondary git command. But it helps in case when someone really wants to edit it. From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: vc-edit-next-command (was bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches) Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Sep 2022 01:16:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov , emacs-devel@gnu.org Cc: 57807@debbugs.gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166432771226739 (code B ref 57807); Wed, 28 Sep 2022 01:16:01 +0000 Received: (at 57807) by debbugs.gnu.org; 28 Sep 2022 01:15:12 +0000 Received: from localhost ([127.0.0.1]:57057 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odLfL-0006xC-8b for submit@debbugs.gnu.org; Tue, 27 Sep 2022 21:15:11 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:33349) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odLfJ-0006ww-1J for 57807@debbugs.gnu.org; Tue, 27 Sep 2022 21:15:09 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 0246D5C0148; Tue, 27 Sep 2022 21:15:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Tue, 27 Sep 2022 21:15:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1664327702; x=1664414102; bh=M2 JXL1NqYAxHWd0/exwAZHgUkmdz5Jo9oaqwLZa9r70=; b=xESDja2vfAxTf1Et2+ Ix6oyrXUk3YGaTgIlr/TioN+mXkNbKlGsTlSC1BGr/47xlC2XOQ/TrDNvGbsbF1n Qjdh5/W9TW7pHFPdRjQv+tUkbTXCzhGfpeDAExK0LtNeyDfGoNiQv0amJ6N7Lwl6 dzJKZCgav7EEoRUrbPrKkTWoLeOxvFK2Jnd9e8rKham/RBhrYxwei3S39w5ROkX6 49wMAebQXPwhTwY9oOvDD3LA4U81mKVUDUGn1NknKgm0geoFBsvKHaGuVUMDqeZL uyvTg8QwAXBSfSTXl+RESECUUHzbqWcxw16XtyllGkaRI0MtlN/GpyIeweAkNcNh jBTw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664327702; x=1664414102; bh=M2JXL1NqYAxHWd0/exwAZHgUkmdz 5Jo9oaqwLZa9r70=; b=dy8OPPbv/ZzyeJLoqOd6WgLIZDqHbEqJwhoQ/w18iMnn PEZSXiwD2SBjgGeS3FND8nPasKI67Rxy2f7rjb9mSqemeY1+laZshL6h0vYCqaRz TJEOFJHupXCz1k3SEL/cTwDispWDpOBZym/gMUGzRVtFNEhD5PPSeDy4IZMvJbPV Sy7hS20yH2a9QmHxvS7XVnbXPGe4kLmLAo2jvbzPfebGNsjQAbdZTLtu89s+8D0U 0H0LoxbQLKuGe3gWPynsj7k/0rvE7zTSV93wxUyOOB5UHJ812oYGoX8eu8oDpHTd DuM63PX+zYi/4pWC43meikm0sIkvGfoM+yQtzpTMxQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegjedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvvefujghffffkfgggtgesmhdttdertdertdenucfhrhhomhepufgvrghn ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe enucggtffrrghtthgvrhhnpeffveeuhfeludfhfeegjeefhefhfeeludejueehfeevtdfh hfettedtfeelleetudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 27 Sep 2022 21:15:02 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 083DC7E14CC; Tue, 27 Sep 2022 18:15:02 -0700 (MST) From: Sean Whitton In-Reply-To: <861qrwocbb.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 27 Sep 2022 21:59:04 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <87fsgs396r.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> <87wn9vjecm.fsf@melete.silentflame.com> <86y1uad298.fsf@mail.linkov.net> <87fsggd1f1.fsf@melete.silentflame.com> <86v8pc5yff.fsf@mail.linkov.net> <87r100bbto.fsf@melete.silentflame.com> <86o7v3kj30.fsf@mail.linkov.net> <87r0zxlqa5.fsf@melete.silentflame.com> <861qrwocbb.fsf@mail.linkov.net> Date: Tue, 27 Sep 2022 18:15:01 -0700 Message-ID: <87k05ofgfe.fsf_-_@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Hello, On Tue 27 Sep 2022 at 09:59PM +03, Juri Linkov wrote: >>> Thanks, I'm going to try it out. >> >> It looks like I need to call (minibuffer-depth) like >> display-buffer-override-next-command does. Updated patch attached. > > I tested your latest patch with many vc commands, and everything > works nicely, even M-x for vc commands without a keybinding > and with a prefix arg is supported like in > > C-x v ! C-u M-x vc-log-search RET > > (C-u is not needed for vc-log-search anymore, > it's just for testing a prefix arg here). Thank you for the through testing. Here is a more formal patch, including manual updates. >> I realised that we could add an override inside vc-read-revision, and >> potentially other places, which makes it considerably less annoying. >> Done in the attached. > > Maybe it's fine to disable editing for vc-read-revision, > but I'm not sure about other commands, such as e.g. > vc-git-log-incoming that runs two git commands: > > vc-git-command fetch > vc-git-command log > > I see no problem to type an extra RET even for a secondary git command. > But it helps in case when someone really wants to edit it. Yeah, we should be conservative. I've done it for only vc-read-revision for now, and perhaps I'll raise some others later. -- Sean Whitton --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=v3-0001-Add-vc-edit-next-command.patch >From 381c04afb4f741fbbf2f4dfcda3973c3738d0442 Mon Sep 17 00:00:00 2001 From: Sean Whitton Date: Sat, 24 Sep 2022 16:17:56 -0700 Subject: [PATCH v3] Add vc-edit-next-command * lisp/vc/vc.el (vc-read-revision): Override vc-filter-command-function back to its default value. (vc-print-branch-log): Remove recently-added prefix argument. (vc-edit-next-command): New command. * lisp/vc/vc-hooks.el (vc-prefix-map): Bind it to 'C-x v !'. * etc/NEWS: * doc/emacs/vc1-xtra.texi (Editing Shell Commands): Document it. --- doc/emacs/vc1-xtra.texi | 26 ++++++++++++++++---- etc/NEWS | 7 ++++++ lisp/vc/vc-hooks.el | 3 ++- lisp/vc/vc.el | 53 ++++++++++++++++++++++++++++------------- 4 files changed, 67 insertions(+), 22 deletions(-) diff --git a/doc/emacs/vc1-xtra.texi b/doc/emacs/vc1-xtra.texi index 3ccad50715..1266873c4b 100644 --- a/doc/emacs/vc1-xtra.texi +++ b/doc/emacs/vc1-xtra.texi @@ -11,10 +11,11 @@ Miscellaneous VC This section explains the less-frequently-used features of VC. @menu -* Change Logs and VC:: Generating a change log file from log entries. -* VC Delete/Rename:: Deleting and renaming version-controlled files. -* Revision Tags:: Symbolic names for revisions. -* Version Headers:: Inserting version control headers into working files. +* Change Logs and VC:: Generating a change log file from log entries. +* VC Delete/Rename:: Deleting and renaming version-controlled files. +* Revision Tags:: Symbolic names for revisions. +* Version Headers:: Inserting version control headers into working files. +* Editing Shell Commands:: Editing the VC shell commands that Emacs will run. @end menu @node Change Logs and VC @@ -263,6 +264,23 @@ Version Headers part of the version header. A @samp{%s} in @var{format} is replaced with the file's version control type. +@node Editing Shell Commands +@subsubsection Editing Shell Commands + +@findex vc-edit-next-command +@kindex C-x v ! +You can use the @kbd{C-x v !} (@code{vc-edit-next-command}) prefix +command to request an opportunity to edit the VC shell commands that +Emacs will run. This is primarily intended to make it possible to +access version control system-specific functionality without +complexifying either the VC command set or the backend API. + +For example, Git can produce logs of more than one branch, but +@kbd{C-x v b l} (@code{vc-print-branch-log}) prompts for the name of +just one branch. To obtain a log of more than one branch, you can +type @kbd{C-x v ! C-x v b l} and then append the names of additional +branches to the end of the 'git log' command that VC prepares. + @node Customizing VC @subsection Customizing VC diff --git a/etc/NEWS b/etc/NEWS index 5b15e9dcb6..d1d3fc6f89 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -1722,6 +1722,13 @@ commands. This command marks files based on a regexp. If given a prefix argument, unmark instead. ++++ +*** New command 'C-x v !' ('vc-edit-next-command') +This prefix command requests editing of the next VC shell command +before execution. For example, in a Git repository, you can produce a +log of more than one branch by typing 'C-x v ! C-x v b l' and then +appending additional branch names to the 'git log' command. + --- *** 'C-x v v' in a diffs buffer allows to commit only some of the changes. This command is intended to allow you to commit only some of the diff --git a/lisp/vc/vc-hooks.el b/lisp/vc/vc-hooks.el index 7f0d9e4d86..6ad26cfe67 100644 --- a/lisp/vc/vc-hooks.el +++ b/lisp/vc/vc-hooks.el @@ -882,7 +882,8 @@ vc-prefix-map "=" #'vc-diff "D" #'vc-root-diff "~" #'vc-revision-other-window - "x" #'vc-delete-file) + "x" #'vc-delete-file + "!" #'vc-edit-next-command) (fset 'vc-prefix-map vc-prefix-map) (define-key ctl-x-map "v" 'vc-prefix-map) diff --git a/lisp/vc/vc.el b/lisp/vc/vc.el index 4950a1a32d..e18fd6f5c8 100644 --- a/lisp/vc/vc.el +++ b/lisp/vc/vc.el @@ -1918,8 +1918,11 @@ vc-read-revision (setq files (cadr vc-fileset)) (setq backend (car vc-fileset)))) ((null backend) (setq backend (vc-backend (car files))))) - (let ((completion-table - (vc-call-backend backend 'revision-completion-table files))) + ;; Override any `vc-filter-command-function' value, as user probably + ;; doesn't want to edit the command to get the completions. + (let* ((vc-filter-command-function #'list) + (completion-table + (vc-call-backend backend 'revision-completion-table files))) (if completion-table (completing-read prompt completion-table nil nil initial-input 'vc-revision-history default) @@ -2745,28 +2748,17 @@ vc-print-root-log (setq vc-parent-buffer-name nil))) ;;;###autoload -(defun vc-print-branch-log (branch &optional arg) - "Show the change log for BRANCH root in a window. -Optional prefix ARG non-nil requests an opportunity for the user -to edit the VC shell command that will be run to generate the -log." - ;; The original motivation for ARG was to make it possible to - ;; produce a log of more than one Git branch without modifying the - ;; print-log VC API. The user can append the other branches to the - ;; command line arguments to 'git log'. See bug#57807. +(defun vc-print-branch-log (branch) + "Show the change log for BRANCH root in a window." (interactive (let* ((backend (vc-responsible-backend default-directory)) (rootdir (vc-call-backend backend 'root default-directory))) (list - (vc-read-revision "Branch to log: " (list rootdir) backend) - current-prefix-arg))) + (vc-read-revision "Branch to log: " (list rootdir) backend)))) (when (equal branch "") (error "No branch specified")) (let* ((backend (vc-responsible-backend default-directory)) - (rootdir (vc-call-backend backend 'root default-directory)) - (vc-filter-command-function (if arg - #'vc-user-edit-command - vc-filter-command-function))) + (rootdir (vc-call-backend backend 'root default-directory))) (vc-print-log-internal backend (list rootdir) branch t (when (> vc-log-show-limit 0) vc-log-show-limit)))) @@ -3244,6 +3236,33 @@ vc-update-change-log (vc-call-backend (vc-responsible-backend default-directory) 'update-changelog args)) +(defvar vc-filter-command-function) + +;;;###autoload +(defun vc-edit-next-command () + "Request editing the next VC shell command before execution. +This is a prefix command. It affects only a VC command executed +immediately after this one." + (interactive) + (letrec ((minibuffer-depth (minibuffer-depth)) + (command this-command) + (keys (key-description (this-command-keys))) + (old vc-filter-command-function) + (echofun (lambda () keys)) + (postfun + (lambda () + (unless (or (eq this-command command) + (> (minibuffer-depth) minibuffer-depth)) + (remove-hook 'post-command-hook postfun) + (remove-hook 'prefix-command-echo-keystrokes-functions + echofun) + (setq vc-filter-command-function old))))) + (add-hook 'post-command-hook postfun) + (add-hook 'prefix-command-echo-keystrokes-functions echofun) + (setq vc-filter-command-function + (lambda (&rest args) + (apply #'vc-user-edit-command (apply old args)))))) + (defun vc-default-responsible-p (_backend _file) "Indicate whether BACKEND is responsible for FILE. The default is to return nil always." -- 2.30.2 --=-=-=-- From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: vc-edit-next-command (was bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches) Resent-From: Juri Linkov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Sep 2022 17:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Sean Whitton Cc: 57807@debbugs.gnu.org, emacs-devel@gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.166438790026991 (code B ref 57807); Wed, 28 Sep 2022 17:59:02 +0000 Received: (at 57807) by debbugs.gnu.org; 28 Sep 2022 17:58:20 +0000 Received: from localhost ([127.0.0.1]:34554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odbK8-00071H-Bi for submit@debbugs.gnu.org; Wed, 28 Sep 2022 13:58:20 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:59373) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1odbK6-000712-DR for 57807@debbugs.gnu.org; Wed, 28 Sep 2022 13:58:19 -0400 Received: (Authenticated sender: juri@linkov.net) by mail.gandi.net (Postfix) with ESMTPSA id 6250B1C0005; Wed, 28 Sep 2022 17:58:10 +0000 (UTC) From: Juri Linkov In-Reply-To: <87k05ofgfe.fsf_-_@melete.silentflame.com> (Sean Whitton's message of "Tue, 27 Sep 2022 18:15:01 -0700") Organization: LINKOV.NET References: <87czbxub4b.fsf@melete.silentflame.com> <8635cs8s59.fsf@mail.linkov.net> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> <87wn9vjecm.fsf@melete.silentflame.com> <86y1uad298.fsf@mail.linkov.net> <87fsggd1f1.fsf@melete.silentflame.com> <86v8pc5yff.fsf@mail.linkov.net> <87r100bbto.fsf@melete.silentflame.com> <86o7v3kj30.fsf@mail.linkov.net> <87r0zxlqa5.fsf@melete.silentflame.com> <861qrwocbb.fsf@mail.linkov.net> <87k05ofgfe.fsf_-_@melete.silentflame.com> Date: Wed, 28 Sep 2022 20:53:00 +0300 Message-ID: <86pmff5qtf.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) > @menu > +* Change Logs and VC:: Generating a change log file from log entries. > +* VC Delete/Rename:: Deleting and renaming version-controlled files. > +* Revision Tags:: Symbolic names for revisions. > +* Version Headers:: Inserting version control headers into working files. > +* Editing Shell Commands:: Editing the VC shell commands that Emacs will run. > @end menu The Info node name "Editing Shell Commands" might not be obvious to everyone when displayed in the Info completion list with 'g edit TAB'. Maybe a better unambiguous node name while keeping it short would be "Editing VC Commands"? From unknown Mon Aug 18 17:54:34 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57807: vc-edit-next-command (was bug#57807: 29.0.50; Make vc-print-branch-log able to log multiple branches) Resent-From: Sean Whitton Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 28 Sep 2022 20:42:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57807 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Juri Linkov Cc: 57807@debbugs.gnu.org, emacs-devel@gnu.org Received: via spool by 57807-submit@debbugs.gnu.org id=B57807.16643976824214 (code B ref 57807); Wed, 28 Sep 2022 20:42:02 +0000 Received: (at 57807) by debbugs.gnu.org; 28 Sep 2022 20:41:22 +0000 Received: from localhost ([127.0.0.1]:34895 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oddru-00015t-Bz for submit@debbugs.gnu.org; Wed, 28 Sep 2022 16:41:22 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:47251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oddrs-00015g-P2 for 57807@debbugs.gnu.org; Wed, 28 Sep 2022 16:41:21 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.west.internal (Postfix) with ESMTP id 0DA1D3200313; Wed, 28 Sep 2022 16:41:14 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Wed, 28 Sep 2022 16:41:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm1; t=1664397674; x=1664484074; bh=zs npiaDRQQjWnNDARSQ8AuuJp9ABUsg7fjYFSEa0BS4=; b=1U7BQFivI8atU9sVcg +NdGdIFPMkkcP8KIQbrBuITNjZLM6/nWeRaI3Gdu/4S6jxY8tXWUnPTR9QQczpoR D7rA5zb1eM8S5SwrYOV/BvRNhDLND4c7irLNHQPYB0cqOb7IR/Ip8knULJxPe74I N4xKqcOPzJxJlwEQrZv24iXKhX8ECmaEFhQJbs6KIShOkVgv0yfmkTCpdkbh7LA8 vObx+B5p8tju1RcIBhttbICjxLovdmDGytbFpydQdbhMlVa4WAGkODksxXx8u1X7 BGtyjNEuoo8GVf1Ii6mCkVi6XqxdaCqwd9F52zxUNDaMOmRTcsJA8NtxJWfbrVWg jMgw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm2; t=1664397674; x=1664484074; bh=zsnpiaDRQQjWnNDARSQ8AuuJp9AB Usg7fjYFSEa0BS4=; b=LhuNSeS3gxSAxys7cKYUFJAtPOTgJUBuwOWEvEW3al4H xpFKA3oTLBjyOrA/ehjdAmWVA3/TMWIMFi9rYEq3K+Lmso6WCsngXdEVAJMlnt42 UamwKTi8ii5MPt0bO/T0RYp/GfW2BnI6pf7f5YxpytC2lz0t2opeYDirKaiP6kPP ojEZqH1xOBNlO1aSf6UStmBc70k9F43xqUNamn2ldkSupLDxKxVGkJlunML84LHp cH4I82fI/2oE6T/z/2AftuDI5LD8AtewQ7aV9Fl1xA8WSVA8p9e6AOPxqK+UYvC2 tYqRhfhOrRNC8HU1wBsxOevA/4P+CG4dVzUB1TlKAA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfeegkedgudehgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggr nhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg eqnecuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedu keeggeelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrg hilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv X-ME-Proxy: Feedback-ID: i23c04076:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 28 Sep 2022 16:41:14 -0400 (EDT) Received: by melete.silentflame.com (Postfix, from userid 1000) id 9E1DD7E0346; Wed, 28 Sep 2022 13:41:13 -0700 (MST) From: Sean Whitton In-Reply-To: <86pmff5qtf.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 28 Sep 2022 20:53:00 +0300") References: <87czbxub4b.fsf@melete.silentflame.com> <87leqk1day.fsf@melete.silentflame.com> <86o7vfpzya.fsf@mail.linkov.net> <87sfkos6as.fsf@melete.silentflame.com> <86bkrb7qt8.fsf@mail.linkov.net> <8735clu05s.fsf@melete.silentflame.com> <864jx0o903.fsf@mail.linkov.net> <87o7v8ple4.fsf@melete.silentflame.com> <86illgc542.fsf@mail.linkov.net> <875yhfo0en.fsf@melete.silentflame.com> <86h70zp8br.fsf@mail.linkov.net> <87wn9vjecm.fsf@melete.silentflame.com> <86y1uad298.fsf@mail.linkov.net> <87fsggd1f1.fsf@melete.silentflame.com> <86v8pc5yff.fsf@mail.linkov.net> <87r100bbto.fsf@melete.silentflame.com> <86o7v3kj30.fsf@mail.linkov.net> <87r0zxlqa5.fsf@melete.silentflame.com> <861qrwocbb.fsf@mail.linkov.net> <87k05ofgfe.fsf_-_@melete.silentflame.com> <86pmff5qtf.fsf@mail.linkov.net> Date: Wed, 28 Sep 2022 13:41:13 -0700 Message-ID: <87k05np6za.fsf@melete.silentflame.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hello, On Wed 28 Sep 2022 at 08:53PM +03, Juri Linkov wrote: >> @menu >> +* Change Logs and VC:: Generating a change log file from log entries. >> +* VC Delete/Rename:: Deleting and renaming version-controlled files. >> +* Revision Tags:: Symbolic names for revisions. >> +* Version Headers:: Inserting version control headers into working files. >> +* Editing Shell Commands:: Editing the VC shell commands that Emacs will run. >> @end menu > > The Info node name "Editing Shell Commands" might not be obvious to > everyone when displayed in the Info completion list with 'g edit TAB'. > Maybe a better unambiguous node name while keeping it short > would be "Editing VC Commands"? Thanks, yes. -- Sean Whitton