GNU bug report logs - #57805
[PATCH] gnu: podman: Install shell completions.

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#57805: closed ([PATCH] gnu: podman: Install shell completions.)
Date: Wed, 14 Sep 2022 21:28:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Wed, 14 Sep 2022 23:27:13 +0200
with message-id <87v8pptzny.fsf <at> gnu.org>
and subject line Re: bug#57805: [PATCH] gnu: podman: Install shell completions.
has caused the debbugs.gnu.org bug report #57805,
regarding [PATCH] gnu: podman: Install shell completions.
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
57805: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57805
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: podman: Install shell completions.
Date: Wed, 14 Sep 2022 17:40:57 +0200

* gnu/packages/containers.scm (podman)[arguments]: Add 'install-completions
phase to install shell completions.
---
 gnu/packages/containers.scm | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/containers.scm b/gnu/packages/containers.scm
index 1f962ddfd6..029f0d4ba4 100644
--- a/gnu/packages/containers.scm
+++ b/gnu/packages/containers.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2021 Timmy Douglas <mail <at> timmydouglas.com>
 ;;; Copyright © 2022 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2022 Zhu Zihao <all_but_last <at> 163.com>
+;;; Copyright © 2022 Michael Rohleder <mike <at> rohleder.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -323,7 +324,11 @@ (define-public podman
                 (("/usr/local/libexec/cni")
                  (string-append #$(this-package-input "cni-plugins")
                                 "/bin"))
-                (("/usr/bin/crun") (which "crun"))))))))
+                (("/usr/bin/crun") (which "crun")))))
+          (add-after 'install 'install-completions
+            (lambda _
+              (invoke "make" "install.completions"
+                      (string-append "PREFIX=" #$output)))))))
     (inputs
      (list btrfs-progs
            cni-plugins
-- 
2.37.3

[Message part 3 (message/rfc822, inline)]

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 57805-done <at> debbugs.gnu.org
Subject: Re: bug#57805: [PATCH] gnu: podman: Install shell completions.
Date: Wed, 14 Sep 2022 23:27:13 +0200

Michael Rohleder <mike <at> rohleder.de> skribis:

> * gnu/packages/containers.scm (podman)[arguments]: Add 'install-completions
> phase to install shell completions.

Applied, thanks!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.