Subject: bug#57760: closed (Re: bug#57760: [PATCH] system: install: Do not load amdgpu in the installer image.)

From: [email-masked] (GNU bug Tracking System)
Date: Fri, 16 Sep 2022 08:17:02 +0000

Your bug report

#57760: [PATCH] system: install: Do not load amdgpu in the installer image.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
57760: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=57760
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: bug#57760: [PATCH] system: install: Do not load amdgpu in the installer image.
From: Mathieu Othacehe <[email-masked]>
To: "pelzflorian (Florian Pelz)" <[email-masked]>
Cc: Josselin Poiret <[email-masked]>, Antero Mejr <[email-masked]>, [email-masked]
Date: Fri, 16 Sep 2022 10:16:19 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hey Florian,

Thanks for sharing your thoughts.

> What Denis 'GNUtoo' Carikli wrote at
> <https://issues.guix.gnu.org/36786#9> indicates that non-3d graphics
> works for some radeon/amdgpu GPUs, because the code that prevents
> booting could be removed from linux-libre for these GPUs.  If so (and it
> didn’t work for one GPU of mine even though it is listed as freed at
> libreplanet), these amdgpu ones would get a lower screen resolution from
> uvesafb if this patch were added.  But it is worth the trade-off.

Agreed.

> Back then when we blacklisted radeon, we chose to wait for a report of
> amdgpu not working instead of adding amdgpu to the blacklist right away.
> Maybe booting is not broken there?

Yeah, plus the corresponding hardware is way less common. So let's
proceed with this patch as-is. Pushed as
d0376f6718b57be90b2f7697c90e4ecbe0090e0f.

Thanks,

Mathieu

Subject: [PATCH] system: install: Do not load amdgpu in the installer image.
From: Antero Mejr <[email-masked]>
To: [email-masked]
Cc: Antero Mejr <[email-masked]>
Date: Tue, 13 Sep 2022 02:42:48 +0000
List-Id: <debbugs-submit.debbugs.gnu.org>

* gnu/system/install.scm (installation-os): Add amdgpu to
modprobe.blacklist.
---
Booting the installer OS will fail when it fails to load blobs for amdgpu.
This will allow the installer OS to boot on systems with affected hardware.

 gnu/system/install.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/system/install.scm b/gnu/system/install.scm
index a7b7c246bf..003c49a3e7 100644
--- a/gnu/system/install.scm
+++ b/gnu/system/install.scm
@@ -476,7 +476,7 @@ (define installation-os
     ;; non-functional:
     ;; <https://lists.gnu.org/archive/html/guix-devel/2019-03/msg00441.html>.
     ;; Thus, blacklist it.
-    (kernel-arguments '("quiet" "modprobe.blacklist=radeon"))
+    (kernel-arguments '("quiet" "modprobe.blacklist=radeon,amdgpu"))
 
     (file-systems
      ;; Note: the disk image build code overrides this root file system with
-- 
2.37.3