From unknown Tue Jun 17 01:28:12 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57760] [PATCH] system: install: Do not load amdgpu in the installer image. Resent-From: Antero Mejr Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 13 Sep 2022 02:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57760 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 57760@debbugs.gnu.org Cc: Antero Mejr X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.166303699912961 (code B ref -1); Tue, 13 Sep 2022 02:44:02 +0000 Received: (at submit) by debbugs.gnu.org; 13 Sep 2022 02:43:19 +0000 Received: from localhost ([127.0.0.1]:48448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXvtP-0003Mz-5P for submit@debbugs.gnu.org; Mon, 12 Sep 2022 22:43:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:53484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXvtK-0003Mn-L4 for submit@debbugs.gnu.org; Mon, 12 Sep 2022 22:43:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXvtK-0000pe-G5 for guix-patches@gnu.org; Mon, 12 Sep 2022 22:43:14 -0400 Received: from mout-p-102.mailbox.org ([80.241.56.152]:44096) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1oXvtH-0001rq-V8 for guix-patches@gnu.org; Mon, 12 Sep 2022 22:43:13 -0400 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4MRSSW2ph9z9sW5 for ; Tue, 13 Sep 2022 04:43:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1663036987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0ACVTPztys0JFUg5X/6k+bZ1NUA0zNoQhhI2vw6LlU4=; b=OaJWHZT3L3ofLCUdxr5lG4u+zohr3Yp/nt334claTB8AzNg+A7FPNzzguX998UDnenImzx R47bnwyxcBW3mnJe8XvGqt8Ov55Ad1+12/KfW1UG6MFVlO9zJALY6WZpjpTyV5d7yQxpnK nHa7vjwa3xy+x4oCOW2KTv6dSChmMwkIDmjwxA29+D50EVJzhwyoewbOgs59sPj0+FVMI+ YQofhFZjwvluIuOiMVrP3GSDxVSVNrzn6seiXfpf23nebWMGv5O6qxAJLoRGZdYYiaYBhF 4XGbVAuKVxjaFUkC+lETrA/cG0vJ8GLcE4VHa7qTfRWE+d6JZCKMLdqmD/Xc0Q== From: Antero Mejr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1663036985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0ACVTPztys0JFUg5X/6k+bZ1NUA0zNoQhhI2vw6LlU4=; b=row24U3UzlJYjD3D7nCcAm+Yke2lVm00sSPYmIvMlab1D1eQ+TAW2PQFcBW0fBQadVccmE uruRN/+xnKt5c+G7fQQZ3Jln3WOLG4rCZTr81AIxDjqV74Bgy0DsGu6oQzO9D9h2XqIumX Kuy6XrSqVd7dlOYZPz0xSKVVYe58XGa/XNLdgucBvcJ7IHo3lS5mIfli0WrWnUZKGYeupU rMETa8xDtlLf4qSDdoj5jINYwv4+nVhRcHCi7L6+PE80/9LAKl8Iz0PIMUuAbLZ9U6Y1wP fnPT815IveTcfXSFuC8YazqVN6CYMwH64D6vChRZQ+CKRj3vviVfo48Pz2ecBw== Date: Tue, 13 Sep 2022 02:42:48 +0000 Message-Id: <20220913024248.2183-1-antero@mailbox.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MBO-RS-META: 76qdtappxjpiyufw4igykpmwdo3z38ud X-MBO-RS-ID: 08cba89df19b4d129b4 X-Rspamd-Queue-Id: 4MRSSW2ph9z9sW5 Received-SPF: pass client-ip=80.241.56.152; envelope-from=antero@mailbox.org; helo=mout-p-102.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/system/install.scm (installation-os): Add amdgpu to modprobe.blacklist. --- Booting the installer OS will fail when it fails to load blobs for amdgpu. This will allow the installer OS to boot on systems with affected hardware. gnu/system/install.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/system/install.scm b/gnu/system/install.scm index a7b7c246bf..003c49a3e7 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -476,7 +476,7 @@ (define installation-os ;; non-functional: ;; . ;; Thus, blacklist it. - (kernel-arguments '("quiet" "modprobe.blacklist=radeon")) + (kernel-arguments '("quiet" "modprobe.blacklist=radeon,amdgpu")) (file-systems ;; Note: the disk image build code overrides this root file system with -- 2.37.3 From unknown Tue Jun 17 01:28:12 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57760] [PATCH] system: install: Do not load amdgpu in the installer image. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Sep 2022 07:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57760 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Antero Mejr Cc: Josselin Poiret , Florian Pelz , 57760@debbugs.gnu.org Received: via spool by 57760-submit@debbugs.gnu.org id=B57760.166314108517791 (code B ref 57760); Wed, 14 Sep 2022 07:39:02 +0000 Received: (at 57760) by debbugs.gnu.org; 14 Sep 2022 07:38:05 +0000 Received: from localhost ([127.0.0.1]:53571 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYMyD-0004ct-Kj for submit@debbugs.gnu.org; Wed, 14 Sep 2022 03:38:05 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYMy8-0004cB-Lx for 57760@debbugs.gnu.org; Wed, 14 Sep 2022 03:38:04 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60278) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYMy1-0006hH-7y; Wed, 14 Sep 2022 03:37:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=kvXo6ae7C8TgF6pFaUIbPi97ifTMCai9qdXAaSzQH+w=; b=m8ypOJi++68peUGdDMUO gek6dnMWB+geRaSfQ5ZnKhYhXETG4LpXgNdcXdzaARDgonUzgOnIrHMX8C61/iM3lZH3rlKo8Dfem jsAUvvB9088BGt0Eq5AyRoZF5x7Sb7smsDBhnrNgblcWyED+WrCZXsVcQrB/HujgLDU+6r0enOi+A 28oUs8M1PtetO18/ks0h12nICHtxt1bFLZwwXRSR99YGOfNEQJ50LWSZ6I36xbpa1du3oL1TUG+NK gq4tl51IUg4PniILcgH6S5C2Yy78jrj+MSYJLdTD0K/JqWt0vtNoI5QSYQQ9FFGWRFcQDIR/aq0y6 oIoWwgFaBD67Vw==; Received: from [195.167.26.149] (port=51418 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYMxz-0004CV-T1; Wed, 14 Sep 2022 03:37:52 -0400 From: Mathieu Othacehe References: <20220913024248.2183-1-antero@mailbox.org> Date: Wed, 14 Sep 2022 09:37:48 +0200 In-Reply-To: <20220913024248.2183-1-antero@mailbox.org> (Antero Mejr's message of "Tue, 13 Sep 2022 02:42:48 +0000") Message-ID: <878rmmcsoj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, > Booting the installer OS will fail when it fails to load blobs for amdgpu. > This will allow the installer OS to boot on systems with affected hardware. Seems reasonable to me. Florian, Josselin, any take on that? Thanks, Mathieu From unknown Tue Jun 17 01:28:12 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57760] [PATCH] system: install: Do not load amdgpu in the installer image. Resent-From: Josselin Poiret Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 14 Sep 2022 10:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57760 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe , Antero Mejr Cc: Florian Pelz , 57760@debbugs.gnu.org Received: via spool by 57760-submit@debbugs.gnu.org id=B57760.16631499868549 (code B ref 57760); Wed, 14 Sep 2022 10:07:02 +0000 Received: (at 57760) by debbugs.gnu.org; 14 Sep 2022 10:06:26 +0000 Received: from localhost ([127.0.0.1]:53792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYPHm-0002Dp-BP for submit@debbugs.gnu.org; Wed, 14 Sep 2022 06:06:26 -0400 Received: from jpoiret.xyz ([206.189.101.64]:48824) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYPHj-0002Db-8E for 57760@debbugs.gnu.org; Wed, 14 Sep 2022 06:06:24 -0400 Received: from authenticated-user (jpoiret.xyz [206.189.101.64]) by jpoiret.xyz (Postfix) with ESMTPA id C001E185308; Wed, 14 Sep 2022 10:06:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jpoiret.xyz; s=dkim; t=1663149979; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=zq7KW+UDBCCp4jkSKLfrowwIL/tBgssHOA0MmyuaDDg=; b=dZOegYj0yzlPD8+hAk4rg1ehxPmh/qB+svgEnAN7RLqSCPtReUtOyGyEI9Uokn8utWW7M/ IcxQOVSpcq98dz4jT2AJV13lIuSTQQSpIrCU+Z2lL2qx7zNR9hOvjvxn9xg6uxoYpbJQR5 KNsNt5DO1d8JXXWCVIxmdeRhw/hANWs/I6Ut0nHkLUXUMzv/974p9Bi48DmgG6D4j1R3Qx JJOasClson981nmAOWymAyT1vfLipJ+N+LVxvSZk6Vm3VTEklma4n6VF0EjAH3D7AZSW2C ywbMci1Amp5AqrSUKtoJSN+tvmJ89jn3vS/U1tYKCFmGVK08i6i0ZyItYozMjw== From: Josselin Poiret In-Reply-To: <878rmmcsoj.fsf@gnu.org> References: <20220913024248.2183-1-antero@mailbox.org> <878rmmcsoj.fsf@gnu.org> Date: Wed, 14 Sep 2022 12:06:17 +0200 Message-ID: <87y1um5kyu.fsf@jpoiret.xyz> MIME-Version: 1.0 Content-Type: text/plain Authentication-Results: jpoiret.xyz; auth=pass smtp.auth=jpoiret@jpoiret.xyz smtp.mailfrom=dev@jpoiret.xyz X-Spamd-Bar: / X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Mathieu and Antero, First of all, thanks for your investigation and ensuing patch! Mathieu Othacehe writes: > Seems reasonable to me. Florian, Josselin, any take on that? Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 2.0 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Hi Mathieu and Antero, First of all, thanks for your investigation and ensuing patch! Mathieu Othacehe writes: > Seems reasonable to me. Florian, Josselin, any take on that? Content analysis details: (2.0 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_PASS SPF: sender matches SPF record -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 2.0 PDS_OTHER_BAD_TLD Untrustworthy TLDs [URI: jpoiret.xyz (xyz)] 1.0 BULK_RE_SUSP_NTLD Precedence bulk and RE: from a suspicious TLD -0.0 T_SCC_BODY_TEXT_LINE No description available. 0.0 FROM_SUSPICIOUS_NTLD From abused NTLD -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager Hi Mathieu and Antero, First of all, thanks for your investigation and ensuing patch! Mathieu Othacehe writes: > Seems reasonable to me. Florian, Josselin, any take on that? Seems good to me. I'm still pretty uneducated about DRM, the framebuffers and whatnot though. IIUC, we require either DRI or FB for kmscon to work (which is better than just FB for the kernel's default fb console). Also, are there other DRM drivers that we could blacklist because they may try to load non-free blobs? Do some specific systems *require* non-free blobs in order to display anything? Best, -- Josselin Poiret From unknown Tue Jun 17 01:28:12 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57760] [PATCH] system: install: Do not load amdgpu in the installer image. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Sep 2022 13:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57760 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Josselin Poiret Cc: Antero Mejr , Florian Pelz , 57760@debbugs.gnu.org Received: via spool by 57760-submit@debbugs.gnu.org id=B57760.166324942930048 (code B ref 57760); Thu, 15 Sep 2022 13:44:01 +0000 Received: (at 57760) by debbugs.gnu.org; 15 Sep 2022 13:43:49 +0000 Received: from localhost ([127.0.0.1]:57529 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYp9g-0007oZ-TZ for submit@debbugs.gnu.org; Thu, 15 Sep 2022 09:43:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYp9d-0007oL-MT for 57760@debbugs.gnu.org; Thu, 15 Sep 2022 09:43:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:34658) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYp9X-0005cR-DL; Thu, 15 Sep 2022 09:43:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=1SAU3OfwBI46lmgJMB2uSkER9OrNStx5C1xpbvP0IMA=; b=A1BHXVmQ36Sy1epeoW2S CGaEKJAiV9k+u+REnarqjmRR6t3L0aQ1y1Tcv1BVsMeD1KZHP4p3VFQmTm0IIeKgJ4AzsOmNBLgMx oSVVfNMvgCB/L5lxBUn2C84n+2J+aau+K0i2HDYdSw5hVhcbP+mizPBvevMvXtnG5sCGtrHiI4yVI 9mJManIEyIJZO0wlMS2JD4M04SRehZFMUeUl4uQUquOF3DgdxUyr7LgQcYglfjxZb5Q4lULOH3hLk 5xmzHuCEyyEWYoRE5Sv7vqjDFrVFbl/hRgC3ynTQBmQZeoO70x9S2mwKUR6tJ/XfUDtIDLLtyCyD5 VBnv6/v7wRIMWw==; Received: from adsl-133.37.6.76.tellas.gr ([37.6.76.133]:46024 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYp9W-00083C-Sg; Thu, 15 Sep 2022 09:43:39 -0400 From: Mathieu Othacehe References: <20220913024248.2183-1-antero@mailbox.org> <878rmmcsoj.fsf@gnu.org> <87y1um5kyu.fsf@jpoiret.xyz> Date: Thu, 15 Sep 2022 15:43:35 +0200 In-Reply-To: <87y1um5kyu.fsf@jpoiret.xyz> (Josselin Poiret's message of "Wed, 14 Sep 2022 12:06:17 +0200") Message-ID: <871qscn46w.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Josselin, > Seems good to me. I'm still pretty uneducated about DRM, the > framebuffers and whatnot though. IIUC, we require either DRI or FB for > kmscon to work (which is better than just FB for the kernel's default fb > console). Same here. > Also, are there other DRM drivers that we could blacklist because they > may try to load non-free blobs? Do some specific systems *require* > non-free blobs in order to display anything? According to this command: --8<---------------cut here---------------start------------->8--- mathieu@meije ~/linux/drivers/gpu/drm$ grep FW_LOADER Kconfig -B 5 source "drivers/gpu/drm/arm/Kconfig" config DRM_RADEON tristate "ATI Radeon" depends on DRM && PCI && MMU select FW_LOADER -- source "drivers/gpu/drm/radeon/Kconfig" config DRM_AMDGPU tristate "AMD GPU" depends on DRM && PCI && MMU select FW_LOADER -- graphics card. If M is selected, the module will be called tdfx. config DRM_R128 tristate "ATI Rage 128" depends on DRM && PCI select FW_LOADER -- for this driver to work. config DRM_MGA tristate "Matrox g200/g400" depends on DRM && PCI select FW_LOADER --8<---------------cut here---------------end--------------->8--- the radeon, amdgpu, r128 and mga DRM drivers are probably relying on firmware loading. So we should maybe extend this patch and add the latter two drivers, even though they are supporting really old hardware. Thanks, Mathieu From unknown Tue Jun 17 01:28:12 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57760] [PATCH] system: install: Do not load amdgpu in the installer image. Resent-From: "pelzflorian (Florian Pelz)" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 15 Sep 2022 21:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57760 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Mathieu Othacehe Cc: Josselin Poiret , Antero Mejr , 57760@debbugs.gnu.org Received: via spool by 57760-submit@debbugs.gnu.org id=B57760.16632790362228 (code B ref 57760); Thu, 15 Sep 2022 21:58:01 +0000 Received: (at 57760) by debbugs.gnu.org; 15 Sep 2022 21:57:16 +0000 Received: from localhost ([127.0.0.1]:59431 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYwrD-0000Zs-NI for submit@debbugs.gnu.org; Thu, 15 Sep 2022 17:57:16 -0400 Received: from relay.yourmailgateway.de ([188.68.63.101]:54709) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYwrB-0000Zi-2M for 57760@debbugs.gnu.org; Thu, 15 Sep 2022 17:57:14 -0400 Received: from mors-relay-2502.netcup.net (localhost [127.0.0.1]) by mors-relay-2502.netcup.net (Postfix) with ESMTPS id 4MT9yf0BBJz53Vg; Thu, 15 Sep 2022 23:56:42 +0200 (CEST) Authentication-Results: mors-relay-2502.netcup.net; dkim=permerror (bad message/signature format) Received: from policy02-mors.netcup.net (unknown [46.38.225.53]) by mors-relay-2502.netcup.net (Postfix) with ESMTPS id 4MT9yd6mskz4yf8; Thu, 15 Sep 2022 23:56:41 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at policy02-mors.netcup.net X-Spam-Flag: NO X-Spam-Score: -2.899 X-Spam-Level: X-Spam-Status: No, score=-2.899 required=6.31 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from mxe217.netcup.net (unknown [10.243.12.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by policy02-mors.netcup.net (Postfix) with ESMTPS id 4MT9yc6bNlz8sZS; Thu, 15 Sep 2022 23:56:39 +0200 (CEST) Received: from florianrock64 (ip5b40552a.dynamic.kabel-deutschland.de [91.64.85.42]) by mxe217.netcup.net (Postfix) with ESMTPSA id 334CE9E8F5; Thu, 15 Sep 2022 23:56:35 +0200 (CEST) From: "pelzflorian (Florian Pelz)" References: <20220913024248.2183-1-antero@mailbox.org> <878rmmcsoj.fsf@gnu.org> <87y1um5kyu.fsf@jpoiret.xyz> <871qscn46w.fsf_-_@gnu.org> Date: Thu, 15 Sep 2022 23:56:30 +0200 In-Reply-To: <871qscn46w.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Thu, 15 Sep 2022 15:43:35 +0200") Message-ID: <87r10cl2sx.fsf@pelzflorian.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 334CE9E8F5 X-Spamd-Result: default: False [-2.14 / 15.00]; BAYES_HAM(-2.04)[95.29%]; MIME_GOOD(-0.10)[text/plain]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; ASN(0.00)[asn:3209, ipnet:91.64.0.0/14, country:DE]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; NEURAL_HAM(-0.00)[-0.867]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; ARC_NA(0.00)[] X-Rspamd-Server: rspamd-worker-8404 X-NC-CID: DGh+J0gj8EJ7Sa25EtNmds9TgT+e0J7iVFsP13LsSY3tewQZx7sbj3XL X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi all, So the issue was that the installer=E2=80=99s display gets stuck at boot wh= en not blacklisting radeon. This patch means the same apparently goes for probably goes for amdgpu? If there are amdgpu systems that cannot boot the installer otherwise, this is enough reason for this patch and this patch is a good idea. What Denis 'GNUtoo' Carikli wrote at indicates that non-3d graphics works for some radeon/amdgpu GPUs, because the code that prevents booting could be removed from linux-libre for these GPUs. If so (and it didn=E2=80=99t work for one GPU of mine even though it is listed as freed at libreplanet), these amdgpu ones would get a lower screen resolution from uvesafb if this patch were added. But it is worth the trade-off. However, Mathieu Othacehe writes: > the radeon, amdgpu, r128 and mga DRM drivers are probably relying on > firmware loading. So we should maybe extend this patch and add the > latter two drivers, even though they are supporting really old > hardware. Back then when we blacklisted radeon, we chose to wait for a report of amdgpu not working instead of adding amdgpu to the blacklist right away. Maybe booting is not broken there? Regards, Florian From unknown Tue Jun 17 01:28:12 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Antero Mejr Subject: bug#57760: closed (Re: bug#57760: [PATCH] system: install: Do not load amdgpu in the installer image.) Message-ID: References: <87pmfvhgz0.fsf@gnu.org> <20220913024248.2183-1-antero@mailbox.org> X-Gnu-PR-Message: they-closed 57760 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 57760@debbugs.gnu.org Date: Fri, 16 Sep 2022 08:17:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1663316222-18038-1" This is a multi-part message in MIME format... ------------=_1663316222-18038-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #57760: [PATCH] system: install: Do not load amdgpu in the installer image. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 57760@debbugs.gnu.org. --=20 57760: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D57760 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1663316222-18038-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 57760-done) by debbugs.gnu.org; 16 Sep 2022 08:16:37 +0000 Received: from localhost ([127.0.0.1]:41557 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ6Wb-0004gF-3f for submit@debbugs.gnu.org; Fri, 16 Sep 2022 04:16:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33580) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZ6WY-0004g0-Ar for 57760-done@debbugs.gnu.org; Fri, 16 Sep 2022 04:16:36 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45282) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ6WR-0004Yi-Ju; Fri, 16 Sep 2022 04:16:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=5ElHt9TIYLPRKEDgFXRbXqC8zEXexMjhoRmD8uNQjPk=; b=htJ8RZ3LYS5Q2rHOCSvk U08zK9g0uCJ7RRXzKzPd00wDwteH24XTU1ab7BWH5u7PZiMVbIR4PXKte/NIyefRfLQ4cwZ/yK392 UnKg3gR8ECZ8GfmWsnWL8Bkqeqd3tNoIzVCKXSCTAnqzkgzQ3X3cSevB61E9Oubs9khwaVCP1flK1 m6BNB3Zz8njN0HQ1dFXOkWvAdvW6ZQKw5PSQAsmCxLDbjoIuNqrjmoaH3DBgl+pA9hvBi0PXCqQem 9a21KgsUm+9EB+pzhxn8yALt0zB+9gpqDmUrnS1dnzjnz5aWfAx0HnE0Ro6xLVnIiklS53QRlDzY4 6OqSAqW1TBSHHg==; Received: from polydeuk.static.otenet.gr ([212.205.214.27]:46052 helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oZ6WQ-0002Gy-2D; Fri, 16 Sep 2022 04:16:27 -0400 From: Mathieu Othacehe To: "pelzflorian (Florian Pelz)" Subject: Re: bug#57760: [PATCH] system: install: Do not load amdgpu in the installer image. References: <20220913024248.2183-1-antero@mailbox.org> <878rmmcsoj.fsf@gnu.org> <87y1um5kyu.fsf@jpoiret.xyz> <871qscn46w.fsf_-_@gnu.org> <87r10cl2sx.fsf@pelzflorian.de> Date: Fri, 16 Sep 2022 10:16:19 +0200 In-Reply-To: <87r10cl2sx.fsf@pelzflorian.de> (pelzflorian@pelzflorian.de's message of "Thu, 15 Sep 2022 23:56:30 +0200") Message-ID: <87pmfvhgz0.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57760-done Cc: Josselin Poiret , Antero Mejr , 57760-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Florian, Thanks for sharing your thoughts. > What Denis 'GNUtoo' Carikli wrote at > indicates that non-3d graphics > works for some radeon/amdgpu GPUs, because the code that prevents > booting could be removed from linux-libre for these GPUs. If so (and it > didn=E2=80=99t work for one GPU of mine even though it is listed as freed= at > libreplanet), these amdgpu ones would get a lower screen resolution from > uvesafb if this patch were added. But it is worth the trade-off. Agreed. > Back then when we blacklisted radeon, we chose to wait for a report of > amdgpu not working instead of adding amdgpu to the blacklist right away. > Maybe booting is not broken there? Yeah, plus the corresponding hardware is way less common. So let's proceed with this patch as-is. Pushed as d0376f6718b57be90b2f7697c90e4ecbe0090e0f. Thanks, Mathieu ------------=_1663316222-18038-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 13 Sep 2022 02:43:19 +0000 Received: from localhost ([127.0.0.1]:48448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXvtP-0003Mz-5P for submit@debbugs.gnu.org; Mon, 12 Sep 2022 22:43:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:53484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXvtK-0003Mn-L4 for submit@debbugs.gnu.org; Mon, 12 Sep 2022 22:43:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXvtK-0000pe-G5 for guix-patches@gnu.org; Mon, 12 Sep 2022 22:43:14 -0400 Received: from mout-p-102.mailbox.org ([80.241.56.152]:44096) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1oXvtH-0001rq-V8 for guix-patches@gnu.org; Mon, 12 Sep 2022 22:43:13 -0400 Received: from smtp102.mailbox.org (smtp102.mailbox.org [IPv6:2001:67c:2050:b231:465::102]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-102.mailbox.org (Postfix) with ESMTPS id 4MRSSW2ph9z9sW5 for ; Tue, 13 Sep 2022 04:43:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1663036987; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0ACVTPztys0JFUg5X/6k+bZ1NUA0zNoQhhI2vw6LlU4=; b=OaJWHZT3L3ofLCUdxr5lG4u+zohr3Yp/nt334claTB8AzNg+A7FPNzzguX998UDnenImzx R47bnwyxcBW3mnJe8XvGqt8Ov55Ad1+12/KfW1UG6MFVlO9zJALY6WZpjpTyV5d7yQxpnK nHa7vjwa3xy+x4oCOW2KTv6dSChmMwkIDmjwxA29+D50EVJzhwyoewbOgs59sPj0+FVMI+ YQofhFZjwvluIuOiMVrP3GSDxVSVNrzn6seiXfpf23nebWMGv5O6qxAJLoRGZdYYiaYBhF 4XGbVAuKVxjaFUkC+lETrA/cG0vJ8GLcE4VHa7qTfRWE+d6JZCKMLdqmD/Xc0Q== From: Antero Mejr DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1663036985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=0ACVTPztys0JFUg5X/6k+bZ1NUA0zNoQhhI2vw6LlU4=; b=row24U3UzlJYjD3D7nCcAm+Yke2lVm00sSPYmIvMlab1D1eQ+TAW2PQFcBW0fBQadVccmE uruRN/+xnKt5c+G7fQQZ3Jln3WOLG4rCZTr81AIxDjqV74Bgy0DsGu6oQzO9D9h2XqIumX Kuy6XrSqVd7dlOYZPz0xSKVVYe58XGa/XNLdgucBvcJ7IHo3lS5mIfli0WrWnUZKGYeupU rMETa8xDtlLf4qSDdoj5jINYwv4+nVhRcHCi7L6+PE80/9LAKl8Iz0PIMUuAbLZ9U6Y1wP fnPT815IveTcfXSFuC8YazqVN6CYMwH64D6vChRZQ+CKRj3vviVfo48Pz2ecBw== To: guix-patches@gnu.org Subject: [PATCH] system: install: Do not load amdgpu in the installer image. Date: Tue, 13 Sep 2022 02:42:48 +0000 Message-Id: <20220913024248.2183-1-antero@mailbox.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-MBO-RS-META: 76qdtappxjpiyufw4igykpmwdo3z38ud X-MBO-RS-ID: 08cba89df19b4d129b4 X-Rspamd-Queue-Id: 4MRSSW2ph9z9sW5 Received-SPF: pass client-ip=80.241.56.152; envelope-from=antero@mailbox.org; helo=mout-p-102.mailbox.org X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Antero Mejr X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/system/install.scm (installation-os): Add amdgpu to modprobe.blacklist. --- Booting the installer OS will fail when it fails to load blobs for amdgpu. This will allow the installer OS to boot on systems with affected hardware. gnu/system/install.scm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gnu/system/install.scm b/gnu/system/install.scm index a7b7c246bf..003c49a3e7 100644 --- a/gnu/system/install.scm +++ b/gnu/system/install.scm @@ -476,7 +476,7 @@ (define installation-os ;; non-functional: ;; . ;; Thus, blacklist it. - (kernel-arguments '("quiet" "modprobe.blacklist=radeon")) + (kernel-arguments '("quiet" "modprobe.blacklist=radeon,amdgpu")) (file-systems ;; Note: the disk image build code overrides this root file system with -- 2.37.3 ------------=_1663316222-18038-1--