GNU bug report logs - #57757
[PATCH] * gnu/packages/wm.scm: Add sbcl-stumpwm-pamixer

Previous Next

Full log

Message #11 received at 57757 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Trevor Richards <trev <at> trevdev.ca>
Cc: 57757 <at> debbugs.gnu.org
Subject: Re: [bug#57757] [PATCH] gnu: Add sbcl-stumpwm-pamixer
Date: Fri, 16 Sep 2022 07:50:18 +0000

[Message part 1 (text/plain, inline)]

Trevor Richards <trev <at> trevdev.ca> skribis:

> ---
>  gnu/packages/wm.scm | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 451dfce516..3f2258db52 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -1986,6 +1986,31 @@ (define-public stumpish
>      (description "This package provides a StumpWM interactive shell.")
>      (license (list license:gpl2+ license:gpl3+ license:bsd-2))))
>  
> +(define-public sbcl-stumpwm-pamixer
> [...]
> +      (inputs `(("stumpwm" ,stumpwm "lib")))
> +      (propagated-inputs (list pamixer))
> [...]

Hi.

Instead of propagating pamixer, it would be better to put pamixer in
'inputs' and fix the path to the pamixer program in the 'run' function
in "pamixer.lisp". For example, take a look at the 'fix-paths' phase of
the sbcl-trivial-clipboard package.

Could you send an updated patch?

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.