GNU bug report logs -
#57756
[PATCH 0/2] Add sbcl-xml-emitter
Previous Next
Reported by: Trevor Richards <trev <at> trevdev.ca>
Date: Mon, 12 Sep 2022 21:34:02 UTC
Severity: normal
Tags: patch
Done: Guillaume Le Vaillant <glv <at> posteo.net>
Bug is archived. No further changes may be made.
Full log
Message #14 received at 57756 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Trevor Richards <trev <at> trevdev.ca> writes:
> ---
> gnu/packages/wm.scm | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
Hi Trevor,
The commit message for adding a package like this one would generally
look like:
gnu: Add sbcl-stumpwm-notify.
* gnu/packages/wm.scm (sbcl-stumpwm-notify): New variable.
You're mostly there.
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 451dfce516..6ae0135a64 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -56,6 +56,7 @@
> ;;; Copyright © 2022 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
> ;;; Copyright © 2022 muradm <mail <at> muradm.net>
> ;;; Copyright © 2022 Elais Player <elais <at> fastmail.com>
> +;;; Copyright © 2022 Trevor Richards <trev <at> trevdev.ca>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -2256,6 +2257,29 @@ (define-public sbcl-stumpwm-screenshot
> PNG files.")
> (license license:gpl3+)))
>
> +(define-public sbcl-stumpwm-notify
> + (package
> + (inherit stumpwm-contrib)
> + (name "sbcl-stumpwm-notify")
> + (build-system asdf-build-system/sbcl)
> + (inputs
> + `(("stumpwm" ,stumpwm "lib")
> + ("xml-emitter" ,sbcl-xml-emitter)
> + ("dbus" ,sbcl-dbus)
> + ("bordeaux-threads" ,sbcl-bordeaux-threads)))
> + (arguments
> + '(#:asd-systems '("notify")
> + #:tests? #f
Why aren't the tests being run? If they can be run, that would be
good. If there's a reason why they can't or shouldn't be run, it would
be good to note that in a comment.
> + #:phases
> + (modify-phases %standard-phases
> + (add-after 'unpack 'chdir
> + (lambda _ (chdir "util/notify") #t)))))
> + (home-page "https://github.com/stumpwm/stumpwm-contrib")
> + (synopsis "Notifications server for StumpWM")
> + (description "Implements org.freedesktop.Notifications
> +interface[fn:dbus-spec]. Shows notifications using stumpwm:message by default.")
> + (license license:gpl3)))
> +
> (define-public lemonbar
> (package
> (name "lemonbar")
[signature.asc (application/pgp-signature, inline)]
This bug report was last modified 2 years and 307 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.