GNU bug report logs - #57755
29.0.50; [PATCH] Fallout 816106b

Previous Next

Package: emacs;

Reported by: dick <dick.r.chiang <at> gmail.com>

Date: Mon, 12 Sep 2022 20:46:03 UTC

Severity: normal

Tags: patch

Found in version 29.0.50

Fixed in version 29.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 57755 <at> debbugs.gnu.org, dick <dick.r.chiang <at> gmail.com>
Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b
Date: Tue, 13 Sep 2022 13:59:00 +0200

Po Lu <luangruo <at> yahoo.com> writes:

>> + call2 (intern ("string-trim-right"), build_string (err->message),
>
> What coding system is err->message?

We had a make_string here before, so that's not really a change.  But,
yes, it should probably do some encoding here.

> And calling intern with a static string is IMHO an anti-pattern that
> should not be introduced further into our code.

Fixed.
This bug report was last modified 2 years and 310 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.