From unknown Sat Aug 16 21:23:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b Resent-From: dick Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Sep 2022 20:46:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 57755@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs Received: via spool by submit@debbugs.gnu.org id=B.16630155339438 (code B ref -1); Mon, 12 Sep 2022 20:46:03 +0000 Received: (at submit) by debbugs.gnu.org; 12 Sep 2022 20:45:33 +0000 Received: from localhost ([127.0.0.1]:48154 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXqJA-0002S5-4w for submit@debbugs.gnu.org; Mon, 12 Sep 2022 16:45:33 -0400 Received: from lists.gnu.org ([209.51.188.17]:45650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXqBT-0002D3-6S for submit@debbugs.gnu.org; Mon, 12 Sep 2022 16:37:36 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48382) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXqBS-0005YE-Vo for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 16:37:35 -0400 Received: from mail-qk1-x732.google.com ([2607:f8b0:4864:20::732]:36781) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXqBQ-0002a3-8z for bug-gnu-emacs@gnu.org; Mon, 12 Sep 2022 16:37:34 -0400 Received: by mail-qk1-x732.google.com with SMTP id i3so2283648qkl.3 for ; Mon, 12 Sep 2022 13:37:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:message-id:date:subject:to:from:from:to:cc:subject :date; bh=sIG3HA5M7fNo9UkABJAtHUv5K80wgyYIwb58SWhuvZE=; b=EdaUFAQjsXxpXcW78R1zi0/9lt/GAlre3zfvMzeV7qwxBmNGuXf9AHFb67gSWDWSHx 5/lfk4HcVyWYYDCwjHmNC/lSTKgV8+xb6jBjfMhNdLpaNW+3l7PyqbOWxOmQFhPDM8i6 Hu2Bp30pYIR9AwfspWBuEsknq7DV/U22EFraBK0bEjTBlm0jY9SYoTqt/K5giJD4SG/D 3Uy0RrJvJySJD/q9gxMt/31WkKCYTPJiQDXNmOVcGRYLZjJWEsOrdz1+hYqjYdY0Xy+T O6XrX/SeVfgOSBdXvvlTw3hB7sjPboTtxYbILHVKQnrOrxMCyx4189F8ZKlVVH5Mav3e 6eeQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:message-id:date:subject:to:from:x-gm-message-state :from:to:cc:subject:date; bh=sIG3HA5M7fNo9UkABJAtHUv5K80wgyYIwb58SWhuvZE=; b=X5QCT5XOu3um7a8OkQTLtVOPjFWo+9aFybTjrNIFnre3IdAyP5eQLldZudecm6d0p3 wDGW8BGaaMNWdbNkQNPYCWGo/8HYgqKFqHImpsHrVVHALDEf9HeUjTkXea6wHNZorGNy 5awRbnGjcIJkk1Ict4EI7bmA3RY48ibwPJOYwjYd73aKc/qfywZ5N9/u3/ftMKWXlL+c 1RkEmWdIyI76hQDJ9CJwbcnoPoeBHbx/P1+hAZ8YUjde19RYDjU0ybMOTDLuvJ6rOdsh le8e4pyHMvlje3JEshcDSUsWzTqdlFTt1HpIzm68EuQrt/7YQe27kfUrwwe0gEEuLu7N YNDQ== X-Gm-Message-State: ACgBeo2czDFKLziFaOV4GVHdtb2wRJA9hvYh2Kujn7acbd279hKtoiaP SXnW5lyiUeH5k/jh0f7mGiQPXvH4qDU= X-Google-Smtp-Source: AA6agR6nN/g/b1GMt/JeU15pWckfdAqXQ562oe4dKdJrSqK4VVqyPF8jkDqvuTOwiCTf/ufjD22BHQ== X-Received: by 2002:a05:620a:4694:b0:6ce:4f6d:e31 with SMTP id bq20-20020a05620a469400b006ce4f6d0e31mr2731339qkb.151.1663015050289; Mon, 12 Sep 2022 13:37:30 -0700 (PDT) Received: from localhost (pool-173-56-234-28.nycmny.fios.verizon.net. [173.56.234.28]) by smtp.gmail.com with ESMTPSA id cn13-20020a05622a248d00b0035bbc29b3c9sm346226qtb.60.2022.09.12.13.37.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 13:37:29 -0700 (PDT) From: dick Date: Mon, 12 Sep 2022 16:37:29 -0400 Message-ID: <87edwgib1y.fsf@dick> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=2607:f8b0:4864:20::732; envelope-from=dick.r.chiang@gmail.com; helo=mail-qk1-x732.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Mailman-Approved-At: Mon, 12 Sep 2022 16:45:31 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain src/emacs -Q --eval \ "(let ((max-image-size 0)) \ (find-file (plist-get \ (cdr (find-image (quote ((:file \"splash.svg\" :type svg))))) \ :file)))" --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fallout-816106b.patch >From 8777430afbd57d0a055f7fbb57c6e576441c9ace Mon Sep 17 00:00:00 2001 From: dickmao Date: Mon, 12 Sep 2022 16:33:43 -0400 Subject: [PATCH] Fallout 816106b * src/image.c (init_svg_functions, g_clear_error): Disregard youthful indiscretions Bug#21641. (svg_load_image): Avoid segfault and double reporting errors. * test/manual/image-tests.el (image-tests-load-image/svg-too-big, image-tests-load-image/svg-invalid): Test it. --- src/image.c | 22 +++++++++++++--------- test/manual/image-tests.el | 19 ++++++++++++++++++- 2 files changed, 31 insertions(+), 10 deletions(-) diff --git a/src/image.c b/src/image.c index 549fe30ef7c..f0cecc1ffec 100644 --- a/src/image.c +++ b/src/image.c @@ -10907,7 +10907,6 @@ DEF_DLL_FN (int, gdk_pixbuf_get_bits_per_sample, (const GdkPixbuf *)); DEF_DLL_FN (void, g_type_init, (void)); # endif DEF_DLL_FN (void, g_object_unref, (gpointer)); -DEF_DLL_FN (void, g_clear_error, (GError **)); static bool init_svg_functions (void) @@ -10967,7 +10966,6 @@ init_svg_functions (void) LOAD_DLL_FN (gobject, g_type_init); # endif LOAD_DLL_FN (gobject, g_object_unref); - LOAD_DLL_FN (glib, g_clear_error); return 1; } @@ -10983,7 +10981,6 @@ init_svg_functions (void) # undef gdk_pixbuf_get_pixels # undef gdk_pixbuf_get_rowstride # undef gdk_pixbuf_get_width -# undef g_clear_error # undef g_object_unref # undef g_type_init # if LIBRSVG_CHECK_VERSION (2, 52, 1) @@ -11019,7 +11016,6 @@ init_svg_functions (void) # define gdk_pixbuf_get_pixels fn_gdk_pixbuf_get_pixels # define gdk_pixbuf_get_rowstride fn_gdk_pixbuf_get_rowstride # define gdk_pixbuf_get_width fn_gdk_pixbuf_get_width -# define g_clear_error fn_g_clear_error # define g_object_unref fn_g_object_unref # if ! GLIB_CHECK_VERSION (2, 36, 0) # define g_type_init fn_g_type_init @@ -11353,7 +11349,7 @@ svg_load_image (struct frame *f, struct image *img, char *contents, if (! check_image_size (f, width, height)) { image_size_error (); - goto rsvg_error; + goto done_error; } /* We are now done with the unmodified data. */ @@ -11536,9 +11532,21 @@ svg_load_image (struct frame *f, struct image *img, char *contents, image_put_x_image (f, img, ximg, 0); } + eassume (err == NULL); return true; rsvg_error: + if (err == NULL) + image_error ("Error parsing SVG image"); + else + { + image_error ("Error parsing SVG image: %s", + call2 (intern ("string-trim-right"), build_string (err->message), + Qnil)); + g_error_free (err); + } + + done_error: if (rsvg_handle) g_object_unref (rsvg_handle); if (wrapped_contents) @@ -11547,10 +11555,6 @@ svg_load_image (struct frame *f, struct image *img, char *contents, if (css && !STRINGP (lcss)) xfree (css); #endif - image_error ("Error parsing SVG image: %s", - /* The -1 removes an extra newline. */ - make_string (err->message, strlen (err->message) - 1)); - g_clear_error (&err); return false; } diff --git a/test/manual/image-tests.el b/test/manual/image-tests.el index f867047d08e..76a22c25718 100644 --- a/test/manual/image-tests.el +++ b/test/manual/image-tests.el @@ -79,6 +79,21 @@ image-tests-make-load-image-test (image-tests-make-load-image-test 'xbm) (image-tests-make-load-image-test 'xpm) +(ert-deftest image-tests-load-image/svg-too-big () + (with-temp-buffer + (let* ((max-image-size 0) + (messages-buffer-name (buffer-name (current-buffer))) + (img (cdr (assq 'svg image-tests--images))) + (file (if (listp img) + (plist-get (cdr img) :file) + img))) + (save-excursion (find-file file)) + (should (string-match-p "invalid image size" (buffer-string))) + ;; no annoying newlines + (should-not (string-match-p "^[ \t\n\r]+$" (buffer-string))) + ;; no annoying double error reporting + (should-not (string-match-p "error parsing" (buffer-string)))))) + (ert-deftest image-tests-load-image/svg-invalid () (with-temp-buffer (let ((messages-buffer-name (buffer-name (current-buffer)))) @@ -90,7 +105,9 @@ image-tests-load-image/svg-invalid :type svg))) (redisplay)) ;; librsvg error: "... Start tag expected, '<' not found [3 times]" - (should (string-match "[Ee]rror.+Start tag expected" (buffer-string)))))) + (should (string-match-p "[Ee]rror.+Start tag expected" (buffer-string))) + ;; no annoying newlines + (should-not (string-match-p "^[ \t\n\r]+$" (buffer-string)))))) ;;;; image-test-size -- 2.36.1 --=-=-= Content-Type: text/plain In Commercial Emacs 0.3.1snapshot c9ee64c in dev (upstream 29.0.50, x86_64-pc-linux-gnu) built on dick Repository revision: c9ee64c7a26563b203f5eab6b9898202cc79ae91 Repository branch: dev Windowing system distributor 'The X.Org Foundation', version 11.0.12013000 System Description: Ubuntu 20.04.4 LTS Configured using: 'configure WERROR_CFLAGS=-Werror --prefix=/home/dick/.local --with-tree-sitter' Configured features: CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON TREE_SITTER LCMS2 LIBSELINUX LIBXML2 MODULES NOTIFY INOTIFY PDUMPER PNG RSVG SECCOMP SOUND THREADS TIFF TOOLKIT_SCROLL_BARS WEBP X11 XDBE XIM XINPUT2 XPM GTK3 ZLIB Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ELisp/l Minor modes in effect: tree-sitter-lock-mode: t shell-dirtrack-mode: t bug-reference-prog-mode: t paredit-mode: t projectile-mode: t flx-ido-mode: t override-global-mode: t global-hl-line-mode: t hl-line-mode: t winner-mode: t tooltip-mode: t global-eldoc-mode: t eldoc-mode: t show-paren-mode: t mouse-wheel-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t column-number-mode: t line-number-mode: t transient-mark-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t Load-path shadows: /home/dick/gomacro-mode/gomacro-mode hides /home/dick/.emacs.d/elpa/gomacro-mode-20200326.1103/gomacro-mode /home/dick/.emacs.d/elpa/go-rename-20190805.2101/go-rename hides /home/dick/.emacs.d/elpa/go-mode-1.6.0/go-rename /home/dick/.emacs.d/elpa/go-guru-20181012.330/go-guru hides /home/dick/.emacs.d/elpa/go-mode-1.6.0/go-guru /home/dick/org-gcal.el/org-gcal hides /home/dick/.emacs.d/elpa/org-gcal-0.3/org-gcal /home/dick/.emacs.d/elpa/request-deferred-0.2.0/request-deferred hides /home/dick/.emacs.d/elpa/request-0.3.3/request-deferred /home/dick/.emacs.d/elpa/chess-2.0.5/_pkg hides /home/dick/.local/share/emacs/site-lisp/_pkg /home/dick/.emacs.d/elpa/chess-2.0.5/chess-pos hides /home/dick/.local/share/emacs/site-lisp/chess-pos /home/dick/.emacs.d/elpa/chess-2.0.5/chess-module hides /home/dick/.local/share/emacs/site-lisp/chess-module /home/dick/.emacs.d/elpa/chess-2.0.5/chess-ucb hides /home/dick/.local/share/emacs/site-lisp/chess-ucb /home/dick/.emacs.d/elpa/chess-2.0.5/chess-scid hides /home/dick/.local/share/emacs/site-lisp/chess-scid /home/dick/.emacs.d/elpa/chess-2.0.5/chess-puzzle hides /home/dick/.local/share/emacs/site-lisp/chess-puzzle /home/dick/.emacs.d/elpa/chess-2.0.5/chess-irc hides /home/dick/.local/share/emacs/site-lisp/chess-irc /home/dick/.emacs.d/elpa/chess-2.0.5/chess-network hides /home/dick/.local/share/emacs/site-lisp/chess-network /home/dick/.emacs.d/elpa/chess-2.0.5/chess-autosave hides /home/dick/.local/share/emacs/site-lisp/chess-autosave /home/dick/.emacs.d/elpa/chess-2.0.5/chess-engine hides /home/dick/.local/share/emacs/site-lisp/chess-engine /home/dick/.emacs.d/elpa/chess-2.0.5/chess-tutorial hides /home/dick/.local/share/emacs/site-lisp/chess-tutorial /home/dick/.emacs.d/elpa/chess-2.0.5/chess-german hides /home/dick/.local/share/emacs/site-lisp/chess-german /home/dick/.emacs.d/elpa/chess-2.0.5/chess-file hides /home/dick/.local/share/emacs/site-lisp/chess-file /home/dick/.emacs.d/elpa/chess-2.0.5/chess-random hides /home/dick/.local/share/emacs/site-lisp/chess-random /home/dick/.emacs.d/elpa/chess-2.0.5/chess-stockfish hides /home/dick/.local/share/emacs/site-lisp/chess-stockfish /home/dick/.emacs.d/elpa/chess-2.0.5/chess-pgn hides /home/dick/.local/share/emacs/site-lisp/chess-pgn /home/dick/.emacs.d/elpa/chess-2.0.5/chess-kibitz hides /home/dick/.local/share/emacs/site-lisp/chess-kibitz /home/dick/.emacs.d/elpa/chess-2.0.5/chess-eco hides /home/dick/.local/share/emacs/site-lisp/chess-eco /home/dick/.emacs.d/elpa/chess-2.0.5/chess-display hides /home/dick/.local/share/emacs/site-lisp/chess-display /home/dick/.emacs.d/elpa/chess-2.0.5/chess-var hides /home/dick/.local/share/emacs/site-lisp/chess-var /home/dick/.emacs.d/elpa/chess-2.0.5/chess-test hides /home/dick/.local/share/emacs/site-lisp/chess-test /home/dick/.emacs.d/elpa/chess-2.0.5/chess-ply hides /home/dick/.local/share/emacs/site-lisp/chess-ply /home/dick/.emacs.d/elpa/chess-2.0.5/chess-message hides /home/dick/.local/share/emacs/site-lisp/chess-message /home/dick/.emacs.d/elpa/chess-2.0.5/chess-ics1 hides /home/dick/.local/share/emacs/site-lisp/chess-ics1 /home/dick/.emacs.d/elpa/chess-2.0.5/chess-phalanx hides /home/dick/.local/share/emacs/site-lisp/chess-phalanx /home/dick/.emacs.d/elpa/chess-2.0.5/chess-game hides /home/dick/.local/share/emacs/site-lisp/chess-game /home/dick/.emacs.d/elpa/chess-2.0.5/chess-log hides /home/dick/.local/share/emacs/site-lisp/chess-log /home/dick/.emacs.d/elpa/chess-2.0.5/chess-plain hides /home/dick/.local/share/emacs/site-lisp/chess-plain /home/dick/.emacs.d/elpa/chess-2.0.5/chess-perft hides /home/dick/.local/share/emacs/site-lisp/chess-perft /home/dick/.emacs.d/elpa/chess-2.0.5/chess-glaurung hides /home/dick/.local/share/emacs/site-lisp/chess-glaurung /home/dick/.emacs.d/elpa/chess-2.0.5/chess-ai hides /home/dick/.local/share/emacs/site-lisp/chess-ai /home/dick/.emacs.d/elpa/chess-2.0.5/chess-fruit hides /home/dick/.local/share/emacs/site-lisp/chess-fruit /home/dick/.emacs.d/elpa/chess-2.0.5/chess-uci hides /home/dick/.local/share/emacs/site-lisp/chess-uci /home/dick/.emacs.d/elpa/chess-2.0.5/chess-epd hides /home/dick/.local/share/emacs/site-lisp/chess-epd /home/dick/.emacs.d/elpa/chess-2.0.5/chess-database hides /home/dick/.local/share/emacs/site-lisp/chess-database /home/dick/.emacs.d/elpa/chess-2.0.5/chess-link hides /home/dick/.local/share/emacs/site-lisp/chess-link /home/dick/.emacs.d/elpa/chess-2.0.5/chess-transport hides /home/dick/.local/share/emacs/site-lisp/chess-transport /home/dick/.emacs.d/elpa/chess-2.0.5/chess-none hides /home/dick/.local/share/emacs/site-lisp/chess-none /home/dick/.emacs.d/elpa/chess-2.0.5/chess-polyglot hides /home/dick/.local/share/emacs/site-lisp/chess-polyglot /home/dick/.emacs.d/elpa/chess-2.0.5/chess-crafty hides /home/dick/.local/share/emacs/site-lisp/chess-crafty /home/dick/.emacs.d/elpa/chess-2.0.5/chess-chat hides /home/dick/.local/share/emacs/site-lisp/chess-chat /home/dick/.emacs.d/elpa/chess-2.0.5/chess hides /home/dick/.local/share/emacs/site-lisp/chess /home/dick/.emacs.d/elpa/chess-2.0.5/chess-images hides /home/dick/.local/share/emacs/site-lisp/chess-images /home/dick/.emacs.d/elpa/chess-2.0.5/chess-gnuchess hides /home/dick/.local/share/emacs/site-lisp/chess-gnuchess /home/dick/.emacs.d/elpa/chess-2.0.5/chess-fen hides /home/dick/.local/share/emacs/site-lisp/chess-fen /home/dick/.emacs.d/elpa/chess-2.0.5/chess-ics hides /home/dick/.local/share/emacs/site-lisp/chess-ics /home/dick/.emacs.d/elpa/chess-2.0.5/chess-ics2 hides /home/dick/.local/share/emacs/site-lisp/chess-ics2 /home/dick/.emacs.d/elpa/chess-2.0.5/chess-common hides /home/dick/.local/share/emacs/site-lisp/chess-common /home/dick/.emacs.d/elpa/chess-2.0.5/chess-input hides /home/dick/.local/share/emacs/site-lisp/chess-input /home/dick/.emacs.d/elpa/chess-2.0.5/chess-announce hides /home/dick/.local/share/emacs/site-lisp/chess-announce /home/dick/.emacs.d/elpa/chess-2.0.5/chess-clock hides /home/dick/.local/share/emacs/site-lisp/chess-clock /home/dick/.emacs.d/elpa/chess-2.0.5/chess-sound hides /home/dick/.local/share/emacs/site-lisp/chess-sound /home/dick/.emacs.d/elpa/chess-2.0.5/chess-sjeng hides /home/dick/.local/share/emacs/site-lisp/chess-sjeng /home/dick/.emacs.d/elpa/chess-2.0.5/chess-algebraic hides /home/dick/.local/share/emacs/site-lisp/chess-algebraic /home/dick/.emacs.d/elpa/transient-0.3.7snapshot/transient hides /home/dick/.local/share/emacs/0.3.1/lisp/transient Features: (shadow sort footnote mail-extr gnus-msg emacsbug vc sh-script executable blamer a misearch multi-isearch tree-sitter tramp-archive tramp-gvfs tramp-cache time-stamp zeroconf tramp tramp-loaddefs trampver tramp-integration cus-start files-x tramp-compat shell ls-lisp shr-color textsec uni-scripts idna-mapping ucs-normalize uni-confusable textsec-check url-http url-gw network-stream nsm url-cache url-auth vc-git diff-mode vc-dispatcher bug-reference org-element avl-tree ol-eww eww xdg url-queue ol-rmail ol-mhe ol-irc ol-info ol-gnus nnselect gnus-art mm-uu mml2015 mm-view mml-smime smime gnutls dig gnus-sum gnus-group mm-url gnus-undo gnus-start gnus-dbus dbus gnus-cloud nnimap nnmail mail-source utf7 nnoo parse-time gnus-spec gnus-int gnus-range message sendmail yank-media rfc822 mml mml-sec epa epg rfc6068 epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mailabbrev gmm-utils gnus-win ol-docview doc-view jka-compr image-mode exif dired-x dired dired-loaddefs ol-bibtex ol-bbdb ol-w3m ol-doi org-link-doi org-tempo tempo org org-macro org-footnote org-pcomplete pcomplete org-list org-faces org-entities org-version ob-R ob-emacs-lisp ob-ein ein-cell ein-shared-output ein-output-area shr pixel-fill kinsoku url-file puny svg dom xml ein-kernel ein-ipdb ein-query ein-events ein-websocket websocket bindat ein-node ewoc ein-log ein-classes ein-core request mailheader anaphora ein ein-utils deferred cc-mode cc-fonts cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs ob ob-tangle org-src ob-ref ob-lob ob-table ob-exp ob-comint ob-core ob-eval org-table oc-basic bibtex iso8601 ol org-keys oc org-compat org-macs org-loaddefs cal-menu calendar cal-loaddefs paredit-ext paredit inf-ruby ruby-mode smie company pcase haskell-interactive-mode haskell-presentation-mode haskell-process haskell-session haskell-compile haskell-mode haskell-cabal haskell-utils haskell-font-lock haskell-indentation haskell-string haskell-sort-imports haskell-lexeme haskell-align-imports haskell-complete-module haskell-ghc-support noutline outline flymake-proc flymake warnings etags fileloop generator dabbrev haskell-customize hydra lv use-package-ensure solarized-theme solarized-definitions projectile lisp-mnt ibuf-ext ibuffer ibuffer-loaddefs thingatpt magit-autorevert autorevert filenotify magit-git magit-base magit-section format-spec crm dash rx compat-27 compat-26 compat grep compile comint ansi-color gnus nnheader range mail-utils mm-util mail-prsvr gnus-util text-property-search time-date flx-ido flx google-translate-default-ui google-translate-core-ui facemenu color ido google-translate-core google-translate-tk google-translate-backend use-package-bind-key bind-key auto-complete easy-mmode advice edmacro kmacro popup cus-edit pp cus-load icons wid-edit emms-player-mplayer emms-player-simple emms emms-compat cl-extra help-mode xref project use-package-core derived hl-line winner ring acm-autoloads debbugs-autoloads eglot-autoloads elpaso-disc-autoloads elpaso-autoloads find-func finder-inf go-mode-autoloads json-reformat-autoloads json-snatcher-autoloads lsp-bridge-autoloads magit-autoloads posframe-autoloads projectile-autoloads markdown-mode-autoloads rust-mode-autoloads sml-mode-autoloads epl-autoloads tornado-template-mode-autoloads typescript-mode-autoloads request-autoloads info wordnut-autoloads yasnippet-autoloads package browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie generate-lisp-file url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs password-cache json subr-x map byte-opt gv bytecomp byte-compile cconv cldefs url-vars cl-loaddefs cl-lib rmc iso-transl tooltip eldoc paren electric uniquify ediff-hook vc-hooks lisp-float-type elisp-mode mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock font-lock syntax font-core term/tty-colors frame minibuffer nadvice seq simple cl-generic indonesian philippine cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite emoji-zwj charscript charprop case-table epa-hook jka-cmpr-hook help abbrev obarray oclosure cl-preloaded button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget keymap hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo move-toolbar gtk x-toolkit xinput2 x multi-tty make-network-process emacs) Memory information: ((conses 16 902810 21728) (symbols 48 39295 0) (strings 32 178416 20945) (string-bytes 1 5055753) (vectors 16 106644) (vector-slots 8 1967351 89879) (floats 8 454 288) (intervals 56 41865 0) (buffers 1008 16)) --=-=-=-- From unknown Sat Aug 16 21:23:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b Resent-From: dick Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 07:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 57755@debbugs.gnu.org Received: via spool by 57755-submit@debbugs.gnu.org id=B57755.16630540571383 (code B ref 57755); Tue, 13 Sep 2022 07:28:02 +0000 Received: (at 57755) by debbugs.gnu.org; 13 Sep 2022 07:27:37 +0000 Received: from localhost ([127.0.0.1]:48656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY0KW-0000MD-Eg for submit@debbugs.gnu.org; Tue, 13 Sep 2022 03:27:37 -0400 Received: from mail-qt1-f172.google.com ([209.85.160.172]:39674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXqmn-0003P7-OR for 57755@debbugs.gnu.org; Mon, 12 Sep 2022 17:16:12 -0400 Received: by mail-qt1-f172.google.com with SMTP id s18so4290544qtx.6 for <57755@debbugs.gnu.org>; Mon, 12 Sep 2022 14:16:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:to:from:from:to:cc:subject:date; bh=kcZTH8aUAPPspLLutaHIXeV/xE3YbWl2+WuJsJU8d9E=; b=RFUeF9Ups73Q9sSEvOtO0opZi7h8R72OV74SfHqeYmdPBulhrgPC2SEOkHar8OGCxo CZxgWZnImvRag2B1vO825i2W+DWypBopaV8oP8xFKHv7oqCvWC8I033yA8QSq1dvCvSd FfePSm/lEHF9+2Ms3HhA9Bdmy2TR4xyorwo1mQO4s1swMvmP8Jvgp+CJJDj4EZaD7Nng zeq+MTqzm0LLWQRQABIohGngjKZR4zK6QGTdEaf9HXXnckL34wkW0lejbbLvIAFOI1f1 lDRX343P3c5jMS4ofY2bnWcWmqWgVZfPcxhBw+WJNJH8vDagV5JbCiJjLyuFK06qo+3q Tctw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:to:from:x-gm-message-state:from:to:cc:subject:date; bh=kcZTH8aUAPPspLLutaHIXeV/xE3YbWl2+WuJsJU8d9E=; b=odFkZ9M0pY6KVn5m94ANYpU0XEjcc85KW7qQPJ97pE7IfSY8cPMeUzZHkk17kC3ZtX G5BlRXxbHZ5jjBw1WG+hfFdGG4O6N/Q3klJFxFl7u8nW773UW4+8kNATCgO01pfCh4KV HJi8AO1PhT+7+qiBv777ueP7P0uAF/VT5oFkcaz/PIBw8Ntdlkk7xEJOQw8RrD2LGgqs UuQ0az35PKOiA4tq3f4sqoofhhjtdEbmqITrF96s4fGw8jAX09E0fBKkpnn+HN4fLgI2 ncB+AzsAh+/Sfu2jqczC8cr7lcvsT8xtKCE6qoidVk1WQFBSMsfllCunJPYvueVkt/sx cx3g== X-Gm-Message-State: ACgBeo1u5JkbJFVgJW+x3aidtNkP6LzGqLaDJLCYgHrMptJv7CD+sNXw iYRR28cKviAOWtSzdNX3Cf0isoT3Mn0= X-Google-Smtp-Source: AA6agR4M0suXKehdA+6H5R4cxsAzel0DrMqgtuGx5RfI6e4JcKIPNVKbPnhOIlLPZdRGA6cc04+khg== X-Received: by 2002:a05:622a:4204:b0:344:e16c:e597 with SMTP id cp4-20020a05622a420400b00344e16ce597mr25480861qtb.592.1663017363892; Mon, 12 Sep 2022 14:16:03 -0700 (PDT) Received: from localhost (pool-173-56-234-28.nycmny.fios.verizon.net. [173.56.234.28]) by smtp.gmail.com with ESMTPSA id t12-20020a37ea0c000000b006bc6aef46basm8194587qkj.114.2022.09.12.14.16.02 for <57755@debbugs.gnu.org> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Sep 2022 14:16:03 -0700 (PDT) From: dick In-Reply-To: <87edwgib1y.fsf@dick> (dick's message of "Mon, 12 Sep 2022 16:37:29 -0400") References: <87edwgib1y.fsf@dick> Date: Mon, 12 Sep 2022 17:16:02 -0400 Message-ID: <87bkrki99p.fsf@dick> User-Agent: Gnus/5.14 (Gnus v5.14) Commercial/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.0 (/) X-Mailman-Approved-At: Tue, 13 Sep 2022 03:27:35 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Oh right, ming wong32. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Fallout-816106b.patch >From 644482da6e69c38b75b461c13a9eb404e014ca78 Mon Sep 17 00:00:00 2001 From: dickmao Date: Mon, 12 Sep 2022 17:08:09 -0400 Subject: [PATCH] Fallout 816106b * src/image.c (init_svg_functions, g_clear_error): Disregard youthful indiscretions Bug#21641. (svg_load_image): Avoid segfault and double reporting errors. * test/manual/image-tests.el (image-tests-load-image/svg-too-big, image-tests-load-image/svg-invalid): Test it. --- src/image.c | 26 +++++++++++++++++--------- test/manual/image-tests.el | 19 ++++++++++++++++++- 2 files changed, 35 insertions(+), 10 deletions(-) diff --git a/src/image.c b/src/image.c index 549fe30ef7c..87ddb19b37e 100644 --- a/src/image.c +++ b/src/image.c @@ -10907,7 +10907,7 @@ DEF_DLL_FN (int, gdk_pixbuf_get_bits_per_sample, (const GdkPixbuf *)); DEF_DLL_FN (void, g_type_init, (void)); # endif DEF_DLL_FN (void, g_object_unref, (gpointer)); -DEF_DLL_FN (void, g_clear_error, (GError **)); +DEF_DLL_FN (void, g_error_free, (GError *)); static bool init_svg_functions (void) @@ -10967,7 +10967,7 @@ init_svg_functions (void) LOAD_DLL_FN (gobject, g_type_init); # endif LOAD_DLL_FN (gobject, g_object_unref); - LOAD_DLL_FN (glib, g_clear_error); + LOAD_DLL_FN (glib, g_error_free); return 1; } @@ -10983,7 +10983,7 @@ init_svg_functions (void) # undef gdk_pixbuf_get_pixels # undef gdk_pixbuf_get_rowstride # undef gdk_pixbuf_get_width -# undef g_clear_error +# undef g_error_free # undef g_object_unref # undef g_type_init # if LIBRSVG_CHECK_VERSION (2, 52, 1) @@ -11019,7 +11019,7 @@ init_svg_functions (void) # define gdk_pixbuf_get_pixels fn_gdk_pixbuf_get_pixels # define gdk_pixbuf_get_rowstride fn_gdk_pixbuf_get_rowstride # define gdk_pixbuf_get_width fn_gdk_pixbuf_get_width -# define g_clear_error fn_g_clear_error +# define g_error_free fn_g_error_free # define g_object_unref fn_g_object_unref # if ! GLIB_CHECK_VERSION (2, 36, 0) # define g_type_init fn_g_type_init @@ -11353,7 +11353,7 @@ svg_load_image (struct frame *f, struct image *img, char *contents, if (! check_image_size (f, width, height)) { image_size_error (); - goto rsvg_error; + goto done_error; } /* We are now done with the unmodified data. */ @@ -11536,9 +11536,21 @@ svg_load_image (struct frame *f, struct image *img, char *contents, image_put_x_image (f, img, ximg, 0); } + eassume (err == NULL); return true; rsvg_error: + if (err == NULL) + image_error ("Error parsing SVG image"); + else + { + image_error ("Error parsing SVG image: %s", + call2 (intern ("string-trim-right"), build_string (err->message), + Qnil)); + g_error_free (err); + } + + done_error: if (rsvg_handle) g_object_unref (rsvg_handle); if (wrapped_contents) @@ -11547,10 +11559,6 @@ svg_load_image (struct frame *f, struct image *img, char *contents, if (css && !STRINGP (lcss)) xfree (css); #endif - image_error ("Error parsing SVG image: %s", - /* The -1 removes an extra newline. */ - make_string (err->message, strlen (err->message) - 1)); - g_clear_error (&err); return false; } diff --git a/test/manual/image-tests.el b/test/manual/image-tests.el index f867047d08e..76a22c25718 100644 --- a/test/manual/image-tests.el +++ b/test/manual/image-tests.el @@ -79,6 +79,21 @@ image-tests-make-load-image-test (image-tests-make-load-image-test 'xbm) (image-tests-make-load-image-test 'xpm) +(ert-deftest image-tests-load-image/svg-too-big () + (with-temp-buffer + (let* ((max-image-size 0) + (messages-buffer-name (buffer-name (current-buffer))) + (img (cdr (assq 'svg image-tests--images))) + (file (if (listp img) + (plist-get (cdr img) :file) + img))) + (save-excursion (find-file file)) + (should (string-match-p "invalid image size" (buffer-string))) + ;; no annoying newlines + (should-not (string-match-p "^[ \t\n\r]+$" (buffer-string))) + ;; no annoying double error reporting + (should-not (string-match-p "error parsing" (buffer-string)))))) + (ert-deftest image-tests-load-image/svg-invalid () (with-temp-buffer (let ((messages-buffer-name (buffer-name (current-buffer)))) @@ -90,7 +105,9 @@ image-tests-load-image/svg-invalid :type svg))) (redisplay)) ;; librsvg error: "... Start tag expected, '<' not found [3 times]" - (should (string-match "[Ee]rror.+Start tag expected" (buffer-string)))))) + (should (string-match-p "[Ee]rror.+Start tag expected" (buffer-string))) + ;; no annoying newlines + (should-not (string-match-p "^[ \t\n\r]+$" (buffer-string)))))) ;;;; image-test-size -- 2.36.1 --=-=-=-- From unknown Sat Aug 16 21:23:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 07:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: dick Cc: 57755@debbugs.gnu.org Received: via spool by 57755-submit@debbugs.gnu.org id=B57755.166305439610323 (code B ref 57755); Tue, 13 Sep 2022 07:34:02 +0000 Received: (at 57755) by debbugs.gnu.org; 13 Sep 2022 07:33:16 +0000 Received: from localhost ([127.0.0.1]:48667 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY0Q0-0002gQ-78 for submit@debbugs.gnu.org; Tue, 13 Sep 2022 03:33:16 -0400 Received: from sonic309-22.consmr.mail.ne1.yahoo.com ([66.163.184.148]:33991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY0Px-0002gC-VN for 57755@debbugs.gnu.org; Tue, 13 Sep 2022 03:33:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663054386; bh=3JWWrq8Aq/wc917sMHFIqVTWTN4UFSuG4/2K32kRm1I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=ZRMwISu+K770M3nQpKf6zo2t4bU62FeWfFeRp1kmstAEpZ6766gXa54HgW915e1uMG02QmfBV49KKcWW2BcXao7M4aHXsob26NsBQxCTqWVq653Qy8Vt8GASYEaL2zE61f/VYjHI3aXyUDnVuLrKRQA8feoOh3Ht9ZsbX6fVQh0oReGfWNeuuXNK3hj7z6/aS0KO9ncMvrpVFU0dju8djhk2Td66qJD8/XosFMsPAUpNKvDXrSLxSeHOlNPvldH5bkqGlz2nX3S13jMCFlptPW9IuPefXhA9Bi/d6LP2mGHhELqBOv7b1DjcK640QJK/k0CnvdlLnSQ7Sh4A2K+5lg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1663054386; bh=feOUtuv05I4fs/Is5FpuULpNlslpA3RcQeIEdHxW2g9=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=c+SiNhyFochWJRn3yMUyL2Celq3+4IW+mztJ8mxCbpf9nJiwx/P1xma2tM2OJf/ibQOwnsL6qbqxvaS/ypcncwHOiRodAv/jvqurgly3pShZxDZQn9Gaqok6ym3P3yeF4/Vpl0Cu//LaPKqJJkS2fzBz1IhMC1BrzK6PZXHeTO4FEnrXM8h+wEoYdGPmiV16qocmVry4G55vy4NCopenSyhQePoR7UKsqsHlPemnJH7e9F1w526crRvLaPyCk0m19u3reiyqkWlanuTQAc5gaQ8Aes+ppEyK7xH80IWj8N3VlCbMgT7ultuwswa5vBr9rsDidKUG4nmkPLgFxbhb8A== X-YMail-OSG: PiYsuF4VM1kGyza0KN0Ew0ajuwL7_8N3tDF8ZOA0x.YafubUkGVA5y2nrATcwRX oHApfA47.9oxfBzs4u7xskWM49kBLPWsOy8QQYFigAUn6S2kuXH1UJUjaiyz9bdVHjPDOrkll6GY A4BFiEUYxg8c.04vYgiQTVNFBVXHQGvjJbDyrBlCHI6pLkzrBxehmxbNmYGqA2lG5sWNinlI1luX ptN6RFVhDJOmvRQKLL54lKnqVub4YpuWO4mmEhQknjtU8.k1WdxuL8IzqDHiaiGMh6AmyaJPgebm qoR0iENtP88v6Bckw6iWZ8hxysapxKOks518zZmb6ijvx9vU4zWXPKFM5tu3oC069XRj7uwK_hn1 UmSkIDQD0s6PXRkO3ukl.27RQ0EqrZIgglbwD4t9dUQ.eJ2ubUbbgmvTbb3xRAFldtrghn1QqCCV RQfF2.BXMVXUCdRcoP2jSzN0oCBCPQ6j5_BYZc8cL13WcXDda4N1_fBoitY0jqDhQZ2RR.9tXj05 da.SrQL7zjyT5STdzR7TezFUYJgL1gGdyw14CbwTbFFc.MbGP0OAeVhGUM01.wg23Uxyj_bfgRP6 p04YUIQLPecmGi2h0.TH62rgmuVaUx_n18t1rtWIOXgoq01f3LjWRj5N95AaV7p2PjV.fp7Cxgv2 BlGOwLuPSYyZXfbyUPQO95Ir3IG7kZmN6P3O2RpzSPOMT36AyiAd.RjmAFk6xgCa4GtWbMSHoT.i SeJ6ZuaI1tcFMU6l4NrzVcxsXcKLzJV38v3c_3H0yQY8SB20zUi74dyWba_l46ai_Ij_iY01rNuz l.kHhCTIa_xYuV8lKVFLhoizZey_VF_vATlI2VUmFojb4FgZVTsmGo9SxvOEkp3.8UL8_DRFgA6s 2CSsCOMRCGJDuMyOtzFCxU1Uqp41tF3LQ9dXHlDZWxaDWfhGf5s.jV76HX1wZitouZ._GMivx3uH Z7ihdQrKrCnsZnhyIE52vp2mvzQpo.tshB3rn1luSFQb.aHgEnLSqrnW875OFO8oVc468AODnt.6 7FpbWTlrq76Vw88ApgmEEeTya7VBbxda2qVRoei5wntyxPVcrEYJtWfVdN7bUWrSaSuHbPYEm6B5 k66XyiALkPdXqGR.chaDTsSDVXF.JdH6g9zMimZd.yucwwnnn5c00ZUQcgeFlUzsSBVtnyLQiLq2 b7sH..5X_NQ1EqEtWDN2aPDuzqlCVPYopOyEMt0wSibFsKn3r0rk0D.ExIDwDs7zMdFhkNRt68tK 5XFZc7Jfcny3uOj0i08sT02qDZmVAfDmCv3K1bSCi7oir9w1dmvE0jPRtV4WfYSK4C3p1_BdnW53 iJZX0sHr7lyI.AM85tdzO2vUABGk4fMO7jJQkuCJ_rZkXtsMJt.1sG2Zfj4NSeDpRMSyuVaf4i_w nrIwg9YezCgWbdF3cvxsjmpcMlP4kzSFoXGHJ06eP_n74kUjLkJYF_4pG4Y6WzPZ0t4Wyg4NdyEi qCWnZJvLjsxw282QET9YMfMjMnoN_7PcoG12JIIEHhd2o5Fwu4eIqw2rgYWZGH68yWZMXxBIZBPi w76dIlo5ODZ_R7TO.P60XVFWa_sZnlB1OC7dJ9Bc3fn18fCktE.WsR6UpKVn76bWgOF2AdxE94PO rNUd8ULm1kwnbbGJd0ON4hfhsN9PaQdlmDqUFg1DO9SicaulYbpjsOV6bG33roDTbD2jsrqqHnXr 63DWBWivNj4KOQ.XdKLPobBjBrl9CcZrOcLfl5yPuN8YjuMO34zsoGaxflCw7eXENe3RK.ck_uw6 2I2.TpwIBcY.44bquz0H6T1ekcMAoPIhS2j_4ef7NI4mIiuwZzc1mOgvbijTqKp.QVyOsY4qChgf TT8CCanT3054FA18oI1cnUnHfmwXhp9l_ujH7yD7BhTwCqPy9vaBDmIzjT71DdI1NsVSXRgxPwCW 6ycyVWFlmj5z_6ilVNJwb74XmHOPoh5iXXJaLTDXtSDngEpR9WeNcDSMT1xGfwmyi4eIrp4RL0IA E0gKjwwkIbjZyqHyMekSLBfXhqrpqTlT4mCk5J5fcLSSIzIXcugdM50FCjd331P3fVuC6lXl4fUI vBrDD2h3cV4yJ3rIChxUMCguDKTaQHyMEmeCjUtZ2BncKCko_6OtY1gxFnap_GAWsPnffJqjvDDz 0TOdAKjvH4TI0TWSzpip6S57EUitvJOnUnj8b3MKGFfrXwDelwW0XKxyLxskGRUYQtFjFsvN8BHQ gEFCmd85dTb0tShCHN_PdiUB0u6eJczrQIb2rA71yiPJiC2CAUlqxivNug2dpV12Dj0hzc81q.P1 8aTMV.IZrgmeV X-Sonic-MF: Received: from sonic.gate.mail.ne1.yahoo.com by sonic309.consmr.mail.ne1.yahoo.com with HTTP; Tue, 13 Sep 2022 07:33:06 +0000 Received: by hermes--canary-production-sg3-6bb8946c47-wlcqj (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 64154758e83393d2f6266711cd916324; Tue, 13 Sep 2022 07:33:01 +0000 (UTC) From: Po Lu References: <87edwgib1y.fsf@dick> <87bkrki99p.fsf@dick> Date: Tue, 13 Sep 2022 15:32:56 +0800 In-Reply-To: <87bkrki99p.fsf@dick> (dick's message of "Mon, 12 Sep 2022 17:16:02 -0400") Message-ID: <87leqn20gn.fsf@yahoo.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Mailer: WebService/1.1.20612 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Content-Length: 269 X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) dick writes: > + call2 (intern ("string-trim-right"), build_string (err->message), What coding system is err->message? And calling intern with a static string is IMHO an anti-pattern that should not be introduced further into our code. From unknown Sat Aug 16 21:23:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 11:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Po Lu Cc: 57755@debbugs.gnu.org, dick.r.chiang@gmail.com Received: via spool by 57755-submit@debbugs.gnu.org id=B57755.166307020621017 (code B ref 57755); Tue, 13 Sep 2022 11:57:01 +0000 Received: (at 57755) by debbugs.gnu.org; 13 Sep 2022 11:56:46 +0000 Received: from localhost ([127.0.0.1]:49098 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY4X0-0005Su-0C for submit@debbugs.gnu.org; Tue, 13 Sep 2022 07:56:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:53334) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY4Ww-0005Sa-55 for 57755@debbugs.gnu.org; Tue, 13 Sep 2022 07:56:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:39856) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oY4Wq-0004VI-PU; Tue, 13 Sep 2022 07:56:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=XiWpsktk3BiGXmWWekaBlkcCP/hTllCYoSgYp6gkV9g=; b=q2BV9SP0/nEF PTx023FZymbbcK4o/O4v7T0drQxFUtuXyAqUAfb8GeoNhYGzXZAVyNXJZTIz7oOZDKjnbmN47ZFVr 7boz3IpCMoIP2TNH8S48pTZ3aeJ+K+PlZwFE1FKJCueI6dlR8Fmuf4WqZFmG9Wm0WpcTsHgzwi2vL PJ+qJ3QqB4ifXZAEDQTDMVKM9mPK23Yv57tet2dKerImVv4B141gooUQL7njDK+lusCVAdbAmwzhl OSDsrRQYWz7ktK4f3CEqHB979WTlhEwE39k8w5vuZXsq4pm6Mjvr6nvdnGXkixP6oFmJE2xS7pfvC mGBCk2Gz5D5tZ9BfxHj96g==; Received: from [87.69.77.57] (port=1778 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oY4Wq-0001Px-3G; Tue, 13 Sep 2022 07:56:36 -0400 Date: Tue, 13 Sep 2022 14:56:23 +0300 Message-Id: <83wna74heg.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87leqn20gn.fsf@yahoo.com> (bug-gnu-emacs@gnu.org) References: <87edwgib1y.fsf@dick> <87bkrki99p.fsf@dick> <87leqn20gn.fsf@yahoo.com> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 57755@debbugs.gnu.org > Date: Tue, 13 Sep 2022 15:32:56 +0800 > From: Po Lu via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > dick writes: > > > + call2 (intern ("string-trim-right"), build_string (err->message), > > What coding system is err->message? That's a good question, but the same question applies to the original code, because build_string is just a thin wrapper around make_string. (My guess would be that the message is either US ASCII or UTF-8, given its type in glib. But if we want to be more defensive about that, it should be a separate change.) > And calling intern with a static string is IMHO an anti-pattern that > should not be introduced further into our code. I actually don't understand the rationale for calling string-trim-right, not at all. Why do we need such heavy artillery to just remove one newline character? As for replacing of g_clear_error with g_error_free: that's just syntactic sugar, right? It is not a mistake to use g_clear_error there. I see no reason to make such a replacement. AFAIU, the useful part of this patch is that it avoids dereferencing NULL. That part should go in, but I don't think we want the rest. From unknown Sat Aug 16 21:23:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 11:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: dick Cc: 57755@debbugs.gnu.org Received: via spool by 57755-submit@debbugs.gnu.org id=B57755.166307029221185 (code B ref 57755); Tue, 13 Sep 2022 11:59:02 +0000 Received: (at 57755) by debbugs.gnu.org; 13 Sep 2022 11:58:12 +0000 Received: from localhost ([127.0.0.1]:49107 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY4YN-0005Vc-TW for submit@debbugs.gnu.org; Tue, 13 Sep 2022 07:58:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35724) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY4YM-0005VN-5t for 57755@debbugs.gnu.org; Tue, 13 Sep 2022 07:58:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=UUww/v3FeR7dp+VKwfS6LjaJ/zK4aQhGOpDqL1IpEFo=; b=paxSsVIXIloWEouHVn2E/d2V9d k+jAZjvdqM0NUmDX28JZxRdwzcTCNdNrLJXytbl0hjrvL+wnUaH1NXK8AlnWnJ/q6F/YqysNis4ih zSk5r7y8QdubJjzGCLLELUi5jewdeUXkOSpaZK9POihx2+rQH8kxxA/J1PELNHFo8yFI=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY4YC-0002KJ-JV; Tue, 13 Sep 2022 13:58:02 +0200 From: Lars Ingebrigtsen In-Reply-To: <87bkrki99p.fsf@dick> (dick's message of "Mon, 12 Sep 2022 17:16:02 -0400") References: <87edwgib1y.fsf@dick> <87bkrki99p.fsf@dick> X-Now-Playing: Hood's _Field Report_: "Field Report a) i An Overcast Sky Part 2" Date: Tue, 13 Sep 2022 13:57:59 +0200 Message-ID: <87sfkv32rc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: dick writes: > * src/image.c (init_svg_functions, g_clear_error): > Disregard youthful indiscretions Bug#21641. > (svg_load_image): Avoid segfault and double reporting errors. > * test/manual/image-tests.el (image [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) dick writes: > * src/image.c (init_svg_functions, g_clear_error): > Disregard youthful indiscretions Bug#21641. > (svg_load_image): Avoid segfault and double reporting errors. > * test/manual/image-tests.el (image-tests-load-image/svg-too-big, > image-tests-load-image/svg-invalid): Test it. Thanks; pushed to Emacs 29. From unknown Sat Aug 16 21:23:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 12:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Po Lu Cc: 57755@debbugs.gnu.org, dick Received: via spool by 57755-submit@debbugs.gnu.org id=B57755.166307035221286 (code B ref 57755); Tue, 13 Sep 2022 12:00:02 +0000 Received: (at 57755) by debbugs.gnu.org; 13 Sep 2022 11:59:12 +0000 Received: from localhost ([127.0.0.1]:49111 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY4ZM-0005XG-87 for submit@debbugs.gnu.org; Tue, 13 Sep 2022 07:59:12 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35740) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY4ZJ-0005Wz-VP for 57755@debbugs.gnu.org; Tue, 13 Sep 2022 07:59:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Jwnqr0GFDIJeidwEVtvQFVVTtaUyU/3JJqLFjyvO3Yg=; b=nlz66Bb3OFZD0sLQG5aDYoOZXh C+kWZXdZBizId7V2F5kmSPqT56xwDBBQ6UsPXYl8oa2fRuYTh/CqAelaFHsEBQibzd/e8NtIVH0Tu jutxVksB9Yg3L5QEq6PJRmgYjLawr9duq58NtNT5eoq0JUR7EFpn5j+htxVYERmtrjrI=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY4ZB-0002Kc-Mx; Tue, 13 Sep 2022 13:59:03 +0200 From: Lars Ingebrigtsen In-Reply-To: <87leqn20gn.fsf@yahoo.com> (Po Lu's message of "Tue, 13 Sep 2022 15:32:56 +0800") References: <87edwgib1y.fsf@dick> <87bkrki99p.fsf@dick> <87leqn20gn.fsf@yahoo.com> X-Now-Playing: Hood's _Field Report_: "Field Report a) i An Overcast Sky Part 2" Date: Tue, 13 Sep 2022 13:59:00 +0200 Message-ID: <87o7vj32pn.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Po Lu writes: >> + call2 (intern ("string-trim-right"), build_string (err->message), > > What coding system is err->message? We had a make_string here before, so that's not really a change. But, yes, it should probably do some encoding here. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Po Lu writes: >> + call2 (intern ("string-trim-right"), build_string (err->message), > > What coding system is err->message? We had a make_string here before, so that's not really a change. But, yes, it should probably do some encoding here. > And calling intern with a static string is IMHO an anti-pattern that > should not be introduced further into our code. Fixed. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 13 07:59:17 2022 Received: (at control) by debbugs.gnu.org; 13 Sep 2022 11:59:17 +0000 Received: from localhost ([127.0.0.1]:49114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY4ZR-0005XV-GQ for submit@debbugs.gnu.org; Tue, 13 Sep 2022 07:59:17 -0400 Received: from quimby.gnus.org ([95.216.78.240]:35756) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY4ZO-0005X4-HX for control@debbugs.gnu.org; Tue, 13 Sep 2022 07:59:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=luSKvRMsG1VcsMgK78xjfjUAq9NqlOt+suoTHY2A79A=; b=XMgaUPr5DWq1LzuT3CxRLevY97 Bp7xpPJ/8U1NvV+zxUFtOcsuxLB+7tclLKbOLJrRVixslvRzRUCPQVU7UsELD1xuzb1A8MHlpecam E0hv/5S2jZowLIpQjbHf8xdKzrqEfCK4FNaeVz/UJNIYquqGREVeGX69alPY/Glm26p4=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY4ZG-0002Ko-TD for control@debbugs.gnu.org; Tue, 13 Sep 2022 13:59:08 +0200 Date: Tue, 13 Sep 2022 13:59:06 +0200 Message-Id: <87mtb332ph.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #57755 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 57755 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 57755 29.1 quit From unknown Sat Aug 16 21:23:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 12:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 57755@debbugs.gnu.org, dick.r.chiang@gmail.com Received: via spool by 57755-submit@debbugs.gnu.org id=B57755.166307109722758 (code B ref 57755); Tue, 13 Sep 2022 12:12:01 +0000 Received: (at 57755) by debbugs.gnu.org; 13 Sep 2022 12:11:37 +0000 Received: from localhost ([127.0.0.1]:49170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY4lN-0005uz-8M for submit@debbugs.gnu.org; Tue, 13 Sep 2022 08:11:37 -0400 Received: from eggs.gnu.org ([209.51.188.92]:40698) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY4lL-0005ui-Dd for 57755@debbugs.gnu.org; Tue, 13 Sep 2022 08:11:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oY4lE-0007Lc-44; Tue, 13 Sep 2022 08:11:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=APRxmWA8dmna6ATlNsMd44PV98/HsEC8RP8F2Q9E+tk=; b=ZEDR5trW6ZYy /5sP6Ln1rEVeFMe/22Rq804F8W+KcmeZXNJ7im7CCJ73fK0gxjQz1NGifvaC6AonM8QL9/4zTBS9H A8YtscJC64G2yBFnZWHn9buwl6kYAxGZ09x2zlPha47SLln9ZUORAN1mD+dIij1N1uvbNucrpeDvc PVULZEXe9+AKZf9ucMXFDfKk4KnpQXvrpK/7gc+1GkyrHPmNy+uSEjKDWDL9ZtOdYYXkbrB+UNrBG /U6DacINX7obxEUjjewAOWlKxUOwpShYTgLn7ZZeRXL14YwiyfsseLpPmT+fskKgOFZ6r1s8YOub/ Cfz58vjsfRvaGM2yPRxirw==; Received: from [87.69.77.57] (port=2685 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oY4l9-0006wk-2A; Tue, 13 Sep 2022 08:11:27 -0400 Date: Tue, 13 Sep 2022 15:11:11 +0300 Message-Id: <83r10f4gps.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <87sfkv32rc.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 13 Sep 2022 13:57:59 +0200) References: <87edwgib1y.fsf@dick> <87bkrki99p.fsf@dick> <87sfkv32rc.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: 57755@debbugs.gnu.org > From: Lars Ingebrigtsen > Date: Tue, 13 Sep 2022 13:57:59 +0200 > > dick writes: > > > * src/image.c (init_svg_functions, g_clear_error): > > Disregard youthful indiscretions Bug#21641. > > (svg_load_image): Avoid segfault and double reporting errors. > > * test/manual/image-tests.el (image-tests-load-image/svg-too-big, > > image-tests-load-image/svg-invalid): Test it. > > Thanks; pushed to Emacs 29. I think calling a Lisp function to remove trailing whitespace from a C string is butt-ugly. Why not fire a Python or Guile interpreter to do that? Yuck! From unknown Sat Aug 16 21:23:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 12:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 57755@debbugs.gnu.org, dick.r.chiang@gmail.com Received: via spool by 57755-submit@debbugs.gnu.org id=B57755.16630725381170 (code B ref 57755); Tue, 13 Sep 2022 12:36:02 +0000 Received: (at 57755) by debbugs.gnu.org; 13 Sep 2022 12:35:38 +0000 Received: from localhost ([127.0.0.1]:49209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY58b-0000Io-Tp for submit@debbugs.gnu.org; Tue, 13 Sep 2022 08:35:38 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY58a-0000IX-HZ for 57755@debbugs.gnu.org; Tue, 13 Sep 2022 08:35:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:Date:References: In-Reply-To:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=N8pnjMJrGmEZaGCQFsCimIgsV60+VyiPy2L5ypSLcX8=; b=qVvan2kYDNYwpn8J/JlCBxGH7b SGJllp1yhrVP705wgSSV0RRjPoGX5cADGHlU6zgXp4RST304uIETq0j453Pi64UBxOwOmBk36lWqm M5mo1oK2Ph35S5UP+GijlfxCRci0RiRG//gckWS+fOA3PB6wpgzyJr+mkEdZVVYev/cU=; Received: from [84.212.220.105] (helo=joga) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oY58S-0002at-4G; Tue, 13 Sep 2022 14:35:30 +0200 From: Lars Ingebrigtsen In-Reply-To: <83r10f4gps.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 13 Sep 2022 15:11:11 +0300") References: <87edwgib1y.fsf@dick> <87bkrki99p.fsf@dick> <87sfkv32rc.fsf@gnus.org> <83r10f4gps.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAMFBMVEX+/v7p6Ont6PSt rK3S0tJjUKlNOZ0vHImrmdfZyvGNeMfKt+4PAHaFdbvl1Pv////mKYd9AAAAAWJLR0QPGLoA2QAA AAd0SU1FB+YJDQwjCErb7qQAAAD7SURBVDjLY2DACRgVMMWYBICEsAOmBIsJkHDBZgxIUAnMEBRy dBQUERQUFFJ0QrbHxcXJxcVRxAVEIBstIqSkKKSkpKgE1CKoyDDUARMOcdb0CmzCjBOW7s65hEWC N2vd7u0FWCQ4V7/o2JaARYLvRejr9gVYJDRnVOxInYRF4vWL6q1V87BIvGzLnNezDouE9vZ1M7cH YbO8bWf39gAsEtIZ71b3YJHQbk29u6KsAVPCY5NuaNjNCdgCi3NHxw4FrKHLhEN8uABGBkUlrBIq jiKOWDWAspQAVi2C2E0C5kQROBOUinHmc2wlAyOoZGDEZiF2R0BtVMAuDgDqGzYM6QrakQAAACV0 RVh0ZGF0ZTpjcmVhdGUAMjAyMi0wOS0xM1QxMjozNTowOCswMDowMOOW+gEAAAAldEVYdGRhdGU6 bW9kaWZ5ADIwMjItMDktMTNUMTI6MzU6MDgrMDA6MDCSy0K9AAAAAElFTkSuQmCC X-Now-Playing: John Zorn's _The Bagatelles (4): Ikue Mori_: "Bagatelle 85" Date: Tue, 13 Sep 2022 14:35:27 +0200 Message-ID: <87zgf31mgg.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I think calling a Lisp function to remove trailing whitespace from a C > string is butt-ugly. Why not fire a Python or Guile interpreter to do > that? Sure, why not? I'll have a patch ready in a few minutes. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Eli Zaretskii writes: > I think calling a Lisp function to remove trailing whitespace from a C > string is butt-ugly. Why not fire a Python or Guile interpreter to do > that? Sure, why not? I'll have a patch ready in a few minutes. From unknown Sat Aug 16 21:23:10 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57755: 29.0.50; [PATCH] Fallout 816106b Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 13 Sep 2022 12:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57755 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: Lars Ingebrigtsen , 57755@debbugs.gnu.org, dick.r.chiang@gmail.com Received: via spool by 57755-submit@debbugs.gnu.org id=B57755.166307333010918 (code B ref 57755); Tue, 13 Sep 2022 12:49:01 +0000 Received: (at 57755) by debbugs.gnu.org; 13 Sep 2022 12:48:50 +0000 Received: from localhost ([127.0.0.1]:49227 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY5LO-0002q2-3u for submit@debbugs.gnu.org; Tue, 13 Sep 2022 08:48:50 -0400 Received: from mail-wr1-f53.google.com ([209.85.221.53]:44860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oY5LK-0002pn-5D for 57755@debbugs.gnu.org; Tue, 13 Sep 2022 08:48:48 -0400 Received: by mail-wr1-f53.google.com with SMTP id c11so20593406wrp.11 for <57755@debbugs.gnu.org>; Tue, 13 Sep 2022 05:48:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=U0pMcKcLkYMQcBl9nJJR5p8nSemOASnKp07zPyICp5c=; b=W2C1E4ZKauTKBK9jEm4uVAvNsgEp22YQAZmHl7RZ4TZxhrI7/BP8cutKg6vPPbV/g1 KGdPdbsxI0/RW29GBpKbCZvFa6LwjXsMnO+H3rOEPXSAW19h0/+Js6nZQo8rfhwhjGkJ WEULT6zxVzEvTZsofdSJZUrFNxNdHsNKkg2gzac5tOEz9sdnpclbZzAxU7pYkIhHVJ0B oQfYXq6LBdNUkk4ZXbBeLQMru4SPo9/TVO7yMgwQpcV6UxkVkfzp1b4Pti1gHiUL1Cfy mc93MEGP+gFIkkZaaPcStAGtLijzVMEVMk68C5wcBa3idFpUmshM6gkEpBsXuAHR5ZcD nOIw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=U0pMcKcLkYMQcBl9nJJR5p8nSemOASnKp07zPyICp5c=; b=wiftsj6yMnGqpynttoNQUQiBwxzo4rcvhUolVytYUW9E9Q/8Dk/ygmIkGkt/qgmvV9 j2SLCQbDi2mVbZ33LsnCoGCSaHlxAmHcxhjIOrd7t8UoZlBx00GDkqpaRSWqaNWKGQoT eduVIAxfEMb0SZo1wWPF+zZ9HKB7RPHbd2m0O7Op38qbnZo87zKP4z0sciEyqL7u1X03 TY+De7dV091zHkMsIkwFAgVzTi0U5rRnNUhyVyJkRY8XRuOAW2s3eMi0Odmvp4U4isxl ZVZhJMRsx70j24dvuwgevXLUsLz8gqOHEsp0ezdF9PRTeLFLIj5m63fiFGSQVCX8hKDa Nz0A== X-Gm-Message-State: ACgBeo2C+AB0GKswQ0uB1K2t2EEQlhaEUc1BrLo8qVT/Cih94nI+u6sp gmv3UVATV2bjX+bFUw4hMJbcVQ== X-Google-Smtp-Source: AA6agR4G2mVdjwJSNJWIUjN1hqNMxHI91BA3yXoV7YxWZ+VQjpp2/hblI1cG1BGwoaTQHFr0LV6KrA== X-Received: by 2002:adf:e112:0:b0:21d:7195:3a8d with SMTP id t18-20020adfe112000000b0021d71953a8dmr18847551wrz.371.1663073320299; Tue, 13 Sep 2022 05:48:40 -0700 (PDT) Received: from localhost ([2a02:587:3228:f1c1:ebfe:b70:909b:bca2]) by smtp.gmail.com with ESMTPSA id d9-20020a5d6449000000b00225307f43fbsm10365561wrw.44.2022.09.13.05.48.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Sep 2022 05:48:39 -0700 (PDT) From: "Basil L. Contovounesios" In-Reply-To: <83r10f4gps.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 13 Sep 2022 15:11:11 +0300") References: <87edwgib1y.fsf@dick> <87bkrki99p.fsf@dick> <87sfkv32rc.fsf@gnus.org> <83r10f4gps.fsf@gnu.org> Date: Tue, 13 Sep 2022 15:48:38 +0300 Message-ID: <87a6737849.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii [2022-09-13 15:11 +0300] wrote: > I think calling a Lisp function to remove trailing whitespace from a C > string is butt-ugly. Why not fire a Python or Guile interpreter to do > that? > > Yuck! I find using butterflies about as efficient, without requiring any extra autoconfiscation. -- Basil