From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 08:35:35 2022 Received: (at submit) by debbugs.gnu.org; 12 Sep 2022 12:35:35 +0000 Received: from localhost ([127.0.0.1]:44517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXif0-0000so-Vx for submit@debbugs.gnu.org; Mon, 12 Sep 2022 08:35:35 -0400 Received: from lists.gnu.org ([209.51.188.17]:42460) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXiey-0000sf-Rb for submit@debbugs.gnu.org; Mon, 12 Sep 2022 08:35:33 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52424) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXiey-0000y6-Hi for bug-guix@gnu.org; Mon, 12 Sep 2022 08:35:32 -0400 Received: from mout.web.de ([212.227.17.11]:33235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXiew-00071Y-Jw for bug-guix@gnu.org; Mon, 12 Sep 2022 08:35:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1662986127; bh=ttZoNXbQ78WyuhocA+mQfuqv/fkYtM35bBiRnMPeOs8=; h=X-UI-Sender-Class:From:To:Subject:Date; b=h9F/bOWHj1OcZyIhzP6AfltUTejtKsh4cBStVz7Ueu6Sl5+8fPFS3fXyFimVsMp5R Bf0OcUk4KrSU4nj+tCz/J4/6GAeACIJxXnZSPqMuiETpg1R5zl6WyGnxPGs81PwnpP M3nJ009fNjdptFRGYlOV9K/N0Sy9CR3fyd1dCvzk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from fluss ([84.153.137.18]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MwR4R-1pNLEw0sKL-00rzyq; Mon, 12 Sep 2022 14:35:27 +0200 User-agent: mu4e 1.8.9; emacs 28.1 From: "Dr. Arne Babenhauserheide" To: bug-guix@gnu.org Subject: [patch] maven: fix build with java-slf4j-simple-source expanded Date: Mon, 12 Sep 2022 14:33:04 +0200 Message-ID: <87sfkw3h4i.fsf@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:Qp3nXzh/w18WKuVb5vf/7UxzPUoehuCaXrI6uA6zcj/RPDJsWxo 2wS9qF4/TZp2HRe9mrJrcq5Xcw7KqwJX3EuUZtkAJC0frXHfYxoRqln1VU5HycSDnZPj6mM Jl/iqQpL7Y1YFDBPjgbwMj0aQ5QWzGKU2lBh4aUXOuyouJsi/iDunPN/GirOhQoU1KaIg15 x+PzFicBTUTMvrpmcTRbw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:bHyPbRClQws=:JakKAwYNVcENBX1S79qF2r xIBKTZxpytF20fFJ6dXg0jVDdXEjJ8yBQbu4LOKTpZSZEFjfVfBL1sxhILPQsiAvGU76DEvQk e2jCVY+l1W0Hh1vt/xjMGAMFw+HuqWCI9S4lrYW3O34HuVrcZELF0Lpch+t34vynf0IytLMOZ rdfZfLHkth8wt0umQ+fPDJjhUBjiTZRgDbuaVIjHCrPc81H83iWQS/BTehfWzyIHn8bGUX2gK P9ONZ2vzxBjtibw1rGVtIfWSnWbR6WGcO2X3zvcq0HhKITClMnFYejwY922JkHB4OtR7Z7y3V OnszqjQMJ3T5EzHj/aXC0NhyZxR66MmauimvrcqQYCBoMu21ka09BYcuFd/igltsfE2kA7Dlm psaAue89S/2pdkCISde3l0KOD/TTx+u7fZymKVxGn9x9GweyjFmR+RQwu5HJCFoxAsVCcEn8a XX025NSAUzG+8EM3jSy4A5643dVpyroh28IwhgU5KZfdwCWBqd2unYD8aRt1HSGusBEHmuvU7 W15wej+IjwiEZljDhnspF4KFhQiJ5SJC3rUbNEuEwtIRRRNuEY/CDTVhxtyBA8TPOuDMmGjC2 sSA9JWvsGulZck+GNCMpvIhdE8LPlRyczjeNjq0upc2WnMrd92R8XT/1oaJm1cKIWLzFmBL5c kWL69/9JqXjLcWbW2Ay87j8/+8eLUqABWqjTMc9Bt3U1LX3Knl9OT/CNxgrPMef42l49UslWw F3rha5nqUuqWBa42U80vlIFJsCP2vKCxueChDUYWd8qQUaw6D6hC6EU4Kbso2PwzwOZJd7XuX ODmliAHbjrrNfnakYjFZ9FOmYvXpopiD6k5RVdPf07IBH7gl7GSXAVYiwpWsN95JZhWOfsJOr UuhEr437CoD84+8PT1YOBqhkKl8WiJzb4xK59AjwT1Q951NMoBZGdnxq6VVqPFZWUxhC3UthW vKZ0eB2t6aCUgeqQe81OUVfArvDaOadg7rs2itf/Y2XEJ2EHAuRsHqgN+e3Tr60zJmobw4+90 22jRjRXpVQiQH3hLApxM3M+RhBNP7pdWq+ju2XgZZT+eND/NMkjvxO3DG05L9AbALkPvrf8ml TiyBtoA+wlH11GPgMx1F+M7ztAf8SL6I6YktK/H3Lnkmpj10+PAWoEssvWQvB1fzXcjmXBb4r B6FPPH86PdiPFJ03GWOvESIkky Received-SPF: pass client-ip=212.227.17.11; envelope-from=arne_bab@web.de; helo=mout.web.de X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain Hi, Maven failed to build for me, because java-slf4j-simple-source is no longer a tarball, but an expanded directory of files. Copying the files from Scheme makes it build. A patch is attached. --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-gnu-maven-fix-build-with-java-slf4j-simple-source-ex.patch Content-Transfer-Encoding: quoted-printable From=20f9ca747f6ecf63d46a41e813c6c4e7b7190e9081 Mon Sep 17 00:00:00 2001 From: Arne Babenhauserheide Date: Mon, 12 Sep 2022 14:31:42 +0200 Subject: [PATCH] gnu: maven: fix build with java-slf4j-simple-source expand= ed * gnu/packages/maven.scm (maven): copy files from source. =2D-- gnu/packages/maven.scm | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm index 28ec4eb9a8..a7d984fef2 100644 =2D-- a/gnu/packages/maven.scm +++ b/gnu/packages/maven.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2019 Bj=C3=B6rn H=C3=B6fling ;;; Copyright =C2=A9 2020 Efraim Flashner ;;; Copyright =C2=A9 2022 Artyom V. Poptsov +;;; Copyright =C2=A9 2022 Arne Babenhauserheide ;;; ;;; This file is part of GNU Guix. ;;; @@ -1787,7 +1788,17 @@ (define-public maven-slf4j-provider (lambda* (#:key inputs #:allow-other-keys) (mkdir-p "generated-sources") (with-directory-excursion "generated-sources" =2D (invoke "tar" "xf" (assoc-ref inputs "java-slf4j-simple-s= ource")) + (let ((input-folder (assoc-ref inputs "java-slf4j-simple-so= urce"))) + ;; copy all files + (for-each (lambda (filename) + (let ((target (string-drop + filename ;; remove one more th= an length: the slash + (1+ (string-length input-folde= r))))) + (when (not (file-exists? (dirname target))) + (mkdir-p (dirname target))) + (copy-file filename target))) + (find-files (assoc-ref inputs "java-slf4j-simpl= e-source")))) + (for-each delete-file (find-files "." "StaticLoggerBinder.j= ava"))) (for-each (lambda (simple) =2D-=20 2.37.3 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Best wishes, Arne =2D-=20 Unpolitisch sein hei=C3=9Ft politisch sein, ohne es zu merken. draketo.de --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEE801qEjXQSQPNItXAE++NRSQDw+sFAmMfJ44QHGFybmVfYmFi QHdlYi5kZQAKCRAT741FJAPD610OD/9gZfUHAxvzaWWdRzhNln/MyEaq5tQueKWR CNWQU657MyiRyRI3cDNmdPB4tP9TfhGutiic9NUSMwnUrGwOjWYPuEQVDrEf1aPW Msq/VI/aak9lZuow0u8PjV+/LQGE3ge5518f8FRyUtLAfYLe3+qzdN2GJWBQ4kWE NdKk8SLOzK/MCiCdAiqDCTh95esM6VtWKSsCRqVEbOpb7jI0WKeqxvS3Aaknspj0 fHnJmZCz3HEFkF5Mom2sxOktaNBt0IgzOu5ayxUjnGF6uJiQueEBzyuKB/BS2oeO 5Vwv4Bd8ETHcf326I90NlpppmLIlVTho8F42KwJEHzik/cUn0L6m6OrIoEmDMSMK 1jwXF55DgaNv2SmmkzXiC68L5DcNBjGart6cIbxgdwSxJGeGGPgY2+aKwYsbwzrf o6FX0L8wuHkENINLqHcpxRI3SLW/oeEwKZ182BPc8cL5WleMLWH0qoEbubsDrbVz 1yYTRUvuwtXCh7QmSB6eJky+t2FRNluTyXOmmG53YhZccCnTaqaH87jQwL+QkXrp GKAAQvcicRTU+9GmOHgPx779EUnbdphvH/CIeMITG6D2kWSJg9qmy7C8Iq15uuSB ny2QKMvZ78Q5y9zZPViOt4jMFZG2YMZa/0t4JdBINL86HTNRylU3PYbG16QuX2xD QHTKrcgkKYjEBAEBCAAuFiEE3Si95tmHXKvOSosd3M8NswvBBUgFAmMfJ44QHGFy bmVfYmFiQHdlYi5kZQAKCRDczw2zC8EFSBzvA/9rHbfVtfVJsUp0NEjM6k4IrwVM Z6aQv9XQYrUCcSTWwkbLOJ56fAWRl+RLmlXzI9X8/xZndls1sRfwZBrdDRbaRHOo vA4ZZBmayl5Ouehl7A0gTqv/+Q0CBFsHHvv1VV1IXKJ2vI5Fgl5h1uFsU0xkEjpD jU/w5zJT/ELpiuAr8w== =GDvL -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 10:13:46 2022 Received: (at 57749) by debbugs.gnu.org; 12 Sep 2022 14:13:46 +0000 Received: from localhost ([127.0.0.1]:47538 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXkC1-0000HC-TM for submit@debbugs.gnu.org; Mon, 12 Sep 2022 10:13:46 -0400 Received: from lepiller.eu ([89.234.186.109]:54242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXkBw-0000Gy-Bt for 57749@debbugs.gnu.org; Mon, 12 Sep 2022 10:13:43 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id b31fc2ff; Mon, 12 Sep 2022 14:13:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:subject:in-reply-to:references:message-id:mime-version :content-type:content-transfer-encoding; s=dkim; bh=o3KoKqsxpnmD N9YBiErrAjPjtlNfv6uq2CTTFFcBydA=; b=MbrlfqdNC9dJNcHh7vaE6vzx0Y4j vJWbvBI2k1i/8dPf1ZZK830pswUVTJ7Q+DsNPqoYW/f+/p6xongctv2FjPMrR4ch unRhtk3J9jr1N34DjfhITZA5EMnHkyxdecB5NpWrUtzwUf4yqFPwPo4DBZOKPzjW P236lB+2mZ1wIahbyrUesM+XPAG0pZh9BP0lSdR1+wCgXb7gCIvIC/I7bbXY3+gn NhBsBwC5Rp/GLg/g9+BEchMFPOhSQ54JoHiJriThDD5MJnV05SnmThc6vM0W6wLX Fxty0TGgiI0Ui2QX8c31P1VhJ9C7TpqHQQKeOd+ARMTAuSiXnn9CHRuogw== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id 50691677 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Mon, 12 Sep 2022 14:13:36 +0000 (UTC) Date: Mon, 12 Sep 2022 16:13:35 +0200 From: Julien Lepiller To: "Dr. Arne Babenhauserheide" , 57749@debbugs.gnu.org Subject: =?US-ASCII?Q?Re=3A_bug=2357749=3A_=5Bpatch=5D_maven=3A_fix_build?= =?US-ASCII?Q?_with_java-slf4j-simple-source_expanded?= User-Agent: K-9 Mail for Android In-Reply-To: <87sfkw3h4i.fsf@web.de> References: <87sfkw3h4i.fsf@web.de> Message-ID: MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=----FZBHMVFX7FF6N455GZF5JUU734XLZ6 Content-Transfer-Encoding: 7bit X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 57749 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) ------FZBHMVFX7FF6N455GZF5JUU734XLZ6 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable I don't think checking for file-exists before mkdir-p makes much sense=2E D= oesn't mkdir-p make the same checks already? I thought find-files required two arguments? Also the first argument could= be simplified to input-folder Otherwise LGTM, but I can't push myself currently=2E Thanks! Le 12 septembre 2022 14:33:04 GMT+02:00, "Dr=2E Arne Babenhauserheide" a =C3=A9crit=C2=A0: >Hi, > >Maven failed to build for me, because java-slf4j-simple-source is no >longer a tarball, but an expanded directory of files=2E > >Copying the files from Scheme makes it build=2E A patch is attached=2E > > ------FZBHMVFX7FF6N455GZF5JUU734XLZ6 Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: quoted-printable I don't think checking for file-exists before mkdi= r-p makes much sense=2E Doesn't mkdir-p make the same checks already?
I thought find-files required two arguments? Also the first argument coul= d be simplified to input-folder

Otherwise LGTM, but I can't push mys= elf currently=2E Thanks!

Le 12 septembre = 2022 14:33:04 GMT+02:00, "Dr=2E Arne Babenhauserheide" <arne_bab@web=2Ed= e> a =C3=A9crit=C2=A0:
Hi,

Maven failed to build for me=
, because java-slf4j-simple-source is no
longer a tarball, but an expand=
ed directory of files=2E

Copying the files from Scheme makes it buil=
d=2E A patch is attached=2E


------FZBHMVFX7FF6N455GZF5JUU734XLZ6-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 11:55:48 2022 Received: (at 57749) by debbugs.gnu.org; 12 Sep 2022 15:55:48 +0000 Received: from localhost ([127.0.0.1]:47641 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXlmm-0002x6-El for submit@debbugs.gnu.org; Mon, 12 Sep 2022 11:55:48 -0400 Received: from mout.web.de ([217.72.192.78]:42029) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXlmj-0002wr-UN for 57749@debbugs.gnu.org; Mon, 12 Sep 2022 11:55:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1662998138; bh=yCyzPbl7HTNC+z+365CCMnNG9t2KOob4nQgz8AVKKGE=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=ee9lfHhU0LtW9cUKZTivtiZ2JDIgp1d6VFPdxZuGREDbD/rAEu26aXCS7YDWdr1gi 9zfbd+6VU6tr5xbfig2kZxbZELipNOee5L6lKVoGby/CzETRqgt8JKGeScM4fKeakZ flKDBmAhSd6np0A7O3rFG7hNvfYU/kwMa7ze+nOk= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from fluss ([84.153.137.18]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1Mty5u-1pLL8A2NAK-00uU5X; Mon, 12 Sep 2022 17:55:38 +0200 References: <87sfkw3h4i.fsf@web.de> User-agent: mu4e 1.8.9; emacs 28.1 From: "Dr. Arne Babenhauserheide" To: Julien Lepiller Subject: Re: bug#57749: [patch] maven: fix build with java-slf4j-simple-source expanded Date: Mon, 12 Sep 2022 17:45:57 +0200 In-reply-to: Message-ID: <87o7vk37uv.fsf@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="==-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:7l/CrbE/2UBiwoCaXVeolSaNa4YZNTV2kjsIgeSAunij0sDF5qM F2Nx6ntTBLScLCwFGdlHvoDNMnVYL1Y2jVvNmgYYhzLH4u2Drwc5cQitMV+CjPYmCvXMeEC mRp+W33jugfPOeFVYDvXmssdfDweo5qnFP2qKo+4+OUN22iAZh300VTwc+t1YVyp4R9aJhF 833jsPMmSxEKTyzu4guLg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:EIngg5cQp8g=:+CNG7Z4HXK+p6NjVC1+9d7 +QIYfxgWn0gtDdDJfqZXoIA9xdlZotNeuREp7ekfkqZlR7WujO9r2s1tvoUQhTtVj8uOBJTG6 /dqAodasTjBDOYjGRw3GjI6Idts8oEdHPDYlx2Khrl/flsGqt4eHOApzDPP27SwOv/qyzfnwz vvkRndxArKc3jQOmfbvw/kqHLKB1A6vWv2TIglyQmhQ97E6d7znfFSpsLchBvr03aiVYBbltl RTXcaPhdwHgv51KriUaigNRlcfiHaTcxvLhCsHio5NMzM6CioQBcTg/bTVwe2irCOy90rPHRw jQzsTKAZcSEEepuGxDnn+Vo/hG0yVutRu56ld49TO4utcglykm76VDrGXBhs6BQSB5NoKVU0N ho8Q2y0N8iwutrjfYRih5QUmvNVPb8Z884Cp8NLzFyqrnYOeKxhuZzcZiu1L5kesGqV5fSX8/ EwF7wKZbBtaXDLGSmlOPbWuUlWkGmnFJepPAJFgIT0VSm4EIO7dNdI7uJSQggFJz8r1K2g70E tXY+Ucg+A7gZhfZD0cPxNmUxc2YDkY7TIBjYM+WwWdy9rt6B6YmyrKp9dYwProqnUVRZ7AGAj avdVmdcVxOXms3404VCNsbxUbFm54U1qfDlLmVapIr1ONrKgZFjzAcdeqQ9K19H5oyjtrSZQv BV8174/wu2ho9Zgz98YYLTbATjAf/n7lDigxWMk6DR5q2FXaVIt8VE1PlqVj3BxUotckX+j5b A2zkQlppkTHVUx6i68I1xCQCsj7ODxctu+3lea39a7Gza+7SIp+Jfe4S0oLmMrgr7iLkKYGpb ykzXqgaiaUDEy2psAOKb/1r8HJYkKYIR1OIC/8Cg73TZu+1VAlPrTMuU4fYGFPPzfaeB4nahI q0QlJ1Kt6j49Dj3nAEXpTRD5qJccU/XgRBwuPKeQOngsPhu6+B85/GX1ACEBJIDoo/0dDyjc5 0UvdwFhN3QF+Jy48K5DX0LNoYM8i2VVENHRtGnZ1uvbIX/T1iZQolWaPjV4/UiDa5LjeKSF4o NZhzyQzgqlJK4sUo2Mgfnj9floSFMGsDumC6F+BIggNSFqhBOQ6qkfwtXMfSuPl7+mT6SuzNO XJlzojy6ofuyDyl6AeS8B260gAkyz2LyP9q8iJqwLcpi8R9gGmgSveIiEtLz4yMaEj27DM1YY wLpWpHpDEpGSo7DsehGw4dglwE X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 57749 Cc: 57749@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --==-=-= Content-Type: multipart/mixed; boundary="=-=-=" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Julien Lepiller writes: > I don't think checking for file-exists before mkdir-p makes much sense. D= oesn't mkdir-p make the same > checks already? You=E2=80=99re right =E2=80=94 thank you! > I thought find-files required two arguments? Also the first argument > could be simplified to input-folder The second argument is #:optional. But yes, it should be input-folder =E2= =80=94 that was the whole point of the first let. Thank you! > Otherwise LGTM, but I can't push myself currently. Thanks! Here=E2=80=99s the updated patch: --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: inline; filename=0001-gnu-maven-fix-build-with-java-slf4j-simple-source-ex.patch Content-Transfer-Encoding: quoted-printable From=2012164a5b46ad0a5c27c42b426ad94df8f9910b48 Mon Sep 17 00:00:00 2001 From: Arne Babenhauserheide Date: Mon, 12 Sep 2022 14:31:42 +0200 Subject: [PATCH] gnu: maven: fix build with java-slf4j-simple-source expand= ed * gnu/packages/maven.scm (maven): copy files from source. =2D-- gnu/packages/maven.scm | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/gnu/packages/maven.scm b/gnu/packages/maven.scm index 28ec4eb9a8..f198c2a475 100644 =2D-- a/gnu/packages/maven.scm +++ b/gnu/packages/maven.scm @@ -4,6 +4,7 @@ ;;; Copyright =C2=A9 2019 Bj=C3=B6rn H=C3=B6fling ;;; Copyright =C2=A9 2020 Efraim Flashner ;;; Copyright =C2=A9 2022 Artyom V. Poptsov +;;; Copyright =C2=A9 2022 Arne Babenhauserheide ;;; ;;; This file is part of GNU Guix. ;;; @@ -1787,7 +1788,16 @@ (define-public maven-slf4j-provider (lambda* (#:key inputs #:allow-other-keys) (mkdir-p "generated-sources") (with-directory-excursion "generated-sources" =2D (invoke "tar" "xf" (assoc-ref inputs "java-slf4j-simple-s= ource")) + (let ((input-folder (assoc-ref inputs "java-slf4j-simple-so= urce"))) + ;; copy all files + (for-each (lambda (filename) + (let ((target ;; remove folder prefix plus sl= ash + (string-drop + filename + (1+ (string-length input-folder))))) + (mkdir-p (dirname target)) + (copy-file filename target))) + (find-files input-folder))) (for-each delete-file (find-files "." "StaticLoggerBinder.j= ava"))) (for-each (lambda (simple) =2D-=20 2.37.3 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Best wishes, Arne =2D-=20 Unpolitisch sein hei=C3=9Ft politisch sein, ohne es zu merken. draketo.de --=-=-=-- --==-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEE801qEjXQSQPNItXAE++NRSQDw+sFAmMfVnkQHGFybmVfYmFi QHdlYi5kZQAKCRAT741FJAPD68OHEAC0pLcYfyXQMPTRQ+FQ2ssmMNsaiUwyac8Z cxUAmR33pYRUp1CPbWQEwR6PjizAEMBLXPsqxmq8+jse6e3u25TzmR1NiKoqjU+y fTzYlaMJ8UnPjClng2NF6C7DJ8oKX0WnUXgLhKNdJ6u9He/uB+cUcd095vlZJCkY VH99grSpA8U+Tum7F7b1x39OfWFMEe6OXHirfM7y86XmIxvYjNBMXv0LL8J1D5mi DTCT2gJaRcHsV0nKWQVY7zqdt5Tag5kOfYJ3CqghYCFrY2W/q4mIbRB9hWpWNMij NZ9zMmULKQxrMI85qtmfBXWehGM9ZGw+VajKuC+GomVTWgWmpLUZ8DVi5dAabuxE hJSlx4C+6oNxMhrQoeCF+pvKBY20WMpVMMeoQmoC0bgbFh4sHDjRQx94RCT82TcK oSTua8B6u0haFr51RH5NEUFgt8C3hXxLlpzpTgROs2OEuwktR6reNWDoGq3voxyp xqyyyrjjOhwc2wPJH86p1jcWcIGCpAWuhBhEhyXw3ZIxfMEIuMEgimCDGW2PZtPh odoJUCmfS7bvp6HLhF5WQTmZdgt/BXGj9KimXqsWrrjLoJYptmgjUMciFpLeY4OG /H/Av2L+wOKo+wNTxZ+wGZXNT+q5WExvooHSXw0DpOxqniWhIXfZHKZm9cPDSUc8 SWvkL74lmojEBAEBCAAuFiEE3Si95tmHXKvOSosd3M8NswvBBUgFAmMfVnkQHGFy bmVfYmFiQHdlYi5kZQAKCRDczw2zC8EFSOQzA/9XiFDPmOBcSeH5eHoyYxmoHl+j tfX+klFgm68CKPiX9gDnq2oCepp4+O62UDMgf3PU7iNYAApWBmM3Lq1pRj7pqNxa 1rY653CH5EW9BlJxq0xa+DT7yAEp9haUpm4LK12nlfDg0+7tH7mMtmgdTxcHYmZj nMNI+bGKWz5+pUXUsQ== =LcLc -----END PGP SIGNATURE----- --==-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Sep 21 17:44:09 2022 Received: (at 57749) by debbugs.gnu.org; 21 Sep 2022 21:44:09 +0000 Received: from localhost ([127.0.0.1]:35371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ob7Vp-00061t-7j for submit@debbugs.gnu.org; Wed, 21 Sep 2022 17:44:09 -0400 Received: from mout.web.de ([212.227.17.11]:47251) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ob7Vk-00061F-BY for 57749@debbugs.gnu.org; Wed, 21 Sep 2022 17:44:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1663796635; bh=7cVOmtVfcmH2/MNB6UPk6l7EI8QSRxRO6tzf+IUG6qg=; h=X-UI-Sender-Class:References:From:To:Cc:Subject:Date:In-reply-to; b=Xp3ymq7Nn0jD9JI5nWzPec4svFJaO5zSYbNeaivnzIiat90rhNyYMJ1wMwASwuBSN hgzrUNMg/gQpjXRm9Q4O2VvpJtVjUUIndPDPMdjngUxdAiu9C+02zL55+Y9xIMCD02 hir2XXTs0MlttwHVx08OPR+n45ZEESsnkdNrb/6Kq6hHuqxYfh0h+40F8nop56PKv3 8Qu+ga5hh1lJztz4HWMSvyErj/zkZFOK9bMS8DdlICYnM1WaXrIaGQuOjJHGvn96+Q DBn8i1Hakw6Ztlu+chaPqbrs5GIOjJ7SlewpIsWli/ehkJc380tomvcIc6QyPa6nnL j8PG9U8UANsBw== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from fluss ([84.153.137.18]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MNwfK-1ov0tv0Vaa-00OkDH; Wed, 21 Sep 2022 23:43:55 +0200 References: <87sfkw3h4i.fsf@web.de> <87o7vk37uv.fsf@web.de> User-agent: mu4e 1.8.9; emacs 28.1 From: "Dr. Arne Babenhauserheide" To: Julien Lepiller Subject: Re: bug#57749: [patch] maven: fix build with java-slf4j-simple-source expanded Date: Wed, 21 Sep 2022 23:42:43 +0200 In-reply-to: <87o7vk37uv.fsf@web.de> Message-ID: <87illgs8ru.fsf@web.de> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Provags-ID: V03:K1:cQb92A0v61AihnrjOH26MJdMmhl9nabCQYHBkfqIsYl26Zeg045 IYAIYDJQPvuevvBCYMB9mrzzN50mIqYHHFjJRpR0Aa4CRnBjLfjbaCVORD0ethoH2qCSxne q9opHwKFChx+LVYklzqIDiQVBPiFox+T7mUXIv1pUswl3/3b+q9rslvthCQWE8n8wafpImd N5xAroBXsS/G394A7ZsDw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:GSAUOeXirHk=:lY23ShYBMt5vdp4BpVIBMS I1VItkPUbDGkA40hzquEIVMCRU5DBoNeQh7KoU5Eupmcz8QHNGxcL/j8oue6Rvx7UUlqdm5zT zfWYPO8Rns3sqb8BayY0cYRktCp+095rsMlBkqAij/W1MFCbYEIehkIQUcpRw/tIrBRmHxK0m skxRmpb2z1op23t58zvvOq27CZdwOQOJx99h26YxRY8gkZD7py6ySUbqran6UPGU/MY9Rg3Yc iJuCgDuY45wUeFr3SlVOkIvT4haTRxqcsjliyFccRb6RpoyJNCbfPzRbKNOF6kyikQJNTxL3O 6FkJyLQPeKSaRbRQ3/QYIfBic1e//Aum7OREnF523bwYHahlBFxvHQ2BDSIn7mq6zKUJcqo0/ QD5X/8Sa6Vd7bHjIVG5kJW6VLPvzG3bR33g1YC2pSXbrM/w4ZWfgciKtbYNvO0NGvptmoiFyH orxZgWD4TNFeiPKQnC8sXLevvKSoakZncqABpRYCSbkKEwEF7gK1rnk8FO7b5EnpuWfyD3VBe gevkoXxCxaq9xlYeWHcnhKuCLJR7bZc6Bl6T1Fgw95L0404BHYR6vjfOGwg3zBURTElYf7BeM D2KFE79+KkeVE+cOJrSAYCAXEB8/FOKmu+7KjisXS1J7oG23qkvjlXOlcHmsQ/kdMoO3lDwuU +ezQ/2zLH5uJvHvkooKdjsZBuw2vf/DlyD+CX/0U2swlKt4BnxuW53ymgQB/4O67t0mG33sek tMykKoN9XrF5uDw3YJrh7MEdBzhl3WQ3n0btziYF2VlcOhqd2PmVT4uKZCsVc3yXtO+uPf7Z2 kWevoBW2kvVbshq3KfQGih2lN3Oq6AS95PrwwTKNIFsmDt5hpZtLXSAYEuNoM9Fx86GdqSAVE M9qSugvLQdFxe1Uw8Mpj/lFt834nbDWzNuYbcAMB5+RRb3WsaXIGdhe719LKbj8Vb6iC4aZNO dz6YFUhf7DlibOiGpBZ4sp+y1tVjNsCk4OrgiMFMPu5Yi/ylHjfgrOCqj5bk58UVgFzwA18SN S9a9QtoTleZ9Tf4pLFuKOCeJnjimFwoPppVhEQAX/YPXZOJkqgJLg0XdDYSshxc2bOgPyGEsj iD4Fy1pSLNtr9pOmybV3M4VHMWk39R5mVB5ukpoFlhHmyxorxjnre850gAUKxXkN4zZZa12gH AmPh49gVMTeOvOuj3D+NywmPGe X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57749 Cc: 57749@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable "Dr. Arne Babenhauserheide" writes: > Julien Lepiller writes: >> Otherwise LGTM, but I can't push myself currently. Thanks! > > Here=E2=80=99s the updated patch: Can you push again? (sorry to come back, I just don=E2=80=99t want this to get lost) Best wishes, Arne =2D-=20 Unpolitisch sein hei=C3=9Ft politisch sein, ohne es zu merken. draketo.de --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQJEBAEBCAAuFiEE801qEjXQSQPNItXAE++NRSQDw+sFAmMrhZcQHGFybmVfYmFi QHdlYi5kZQAKCRAT741FJAPD61I0D/9uJtOzSJTd7lGj3DPQ309D5UUpGK6Je6rQ PMtD9pQ1ifACbx9ABSfsut9vDXD7kVBRWzXDrlmdwA21i7UWF9lbQVtZGqZmM5DZ Swyh844TGUSGzsM+nrJaDBPWdx+y8oip6n/FaK114EGpYbiRhK9GoRFJ41odj6eu ffarR6TKkSmzyTFZ+plxrmn9Mj8+FZnqGgfqabYCcRbcRvQwQd3f7DmguoSEWyjQ r58KzHfS+PMYi07gOd4BzGtKunHChzGFgmfors5HmYT8+VIdByrsnn1eKJWo0PH5 +Y/8dwozAtGmcIzsP4VMYxARwa/hn50gXCq7dWFGD9jdXo1bwI9rJxOXsIDD8bE1 DQ7FuyFBR3ZwMx7Epkb8d3i593ZEtoVyuQkwWxyOpq8AP3vG9UK2FWmmvOJpWbDp jvyOatzCBoRN5AJr4EoNi+oayk0qTUL+2nfrZHOr/DFvrP/ikkLCwPfK41MPH0i2 +cQ702uEtpaX6Ku3xMv//t4hDdqWNoa83kZ9Zd8PBsMVLqDhG7eXnMlCd0/+Z5dn 2+Dt6ULK1HCSbFC/DvR8ySNWIAhYQ2H54YZB7azZDM+dlfheP/W+yyTWcvBXtXo3 CP/FJEr8p1oXNEmLkaNMgMQTM/CBsS58GnSQEkccjYrZjTaW369LhAOxkiEqdWOm ryHW4oHgwojEBAEBCAAuFiEE3Si95tmHXKvOSosd3M8NswvBBUgFAmMrhZoQHGFy bmVfYmFiQHdlYi5kZQAKCRDczw2zC8EFSP2+BACNa+L7fFPByPXcyCBzLAb1WGBI KXrgJoCCLmVueutCdAgsBsOSLtfFAl2GfdeFHQWFxHuM1dXGbolXayj355tTM7El /bd5Z73icVoYiaEdI9SYZWmGQVvyPm7kr1de6FuF1/c+ng3sKXxTTb0cj8bxEDpP jMiwdIHhuIiua9iWSA== =YPLh -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 22 04:20:00 2022 Received: (at 57749) by debbugs.gnu.org; 22 Sep 2022 08:20:00 +0000 Received: from localhost ([127.0.0.1]:36187 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obHRA-0006Lb-IU for submit@debbugs.gnu.org; Thu, 22 Sep 2022 04:20:00 -0400 Received: from mail-yw1-f181.google.com ([209.85.128.181]:36640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obHR8-0006LJ-No for 57749@debbugs.gnu.org; Thu, 22 Sep 2022 04:19:58 -0400 Received: by mail-yw1-f181.google.com with SMTP id 00721157ae682-349c4310cf7so90813837b3.3 for <57749@debbugs.gnu.org>; Thu, 22 Sep 2022 01:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:from:mime-version:from:to:cc:subject :date; bh=Cel7lStWGfmB49KjJjo+WscqPKLEUXRPC6sVuG04ico=; b=iK3dnvz66s4JRq/GWBiqjUy2DYOmUqFkbaTHz1v61Y9kIiWNQuChY4dVG9LhHjFgQc XZiyvorWRilAz9+9yTCJMpVgXMW5F1sSjQbAItx5YozUzXaeLA7btrcgMd9sCD3E9zDX xKZBEKDPTH+34cvXi4gkykKsJnxLSYW2Md0DXtiOBdF2O1OEmMPTRKD6ZEL7ZKLXsdbz hogf2lxp+hWgzMurJCVZBWFe2I17fFHJ4llW4IG+rXzT5ckLEAU94glJUyrLQIN1U+U1 2GDiRurA43cs7vm4xdp6P2X7X7pkkIm61rGqoTkC0/56XOyKgIlYQU6/MPdnOHRlKl9G ZEww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:from:mime-version:x-gm-message-state :from:to:cc:subject:date; bh=Cel7lStWGfmB49KjJjo+WscqPKLEUXRPC6sVuG04ico=; b=yUxxxgop9THjRrCqrMlWAwqROWuNNh8gkNkt6YR7qkb8ViKkxN7nOMoN6wIBYKOVXX CMip/RnZj83LAEzEMa6bgW/24U1KvN3jvnR+x8eQczm2T+ZiN7Iu+iamlUxY8IBqd1Fu GBG9kyw4sM3NZjzKtaM4Fl0nJ2yj5urnZMGv53kbe3L5hcKV5K/vTxc7qHk2i2mOxoe5 Ug81LEM5Y5rg5suIzNuDm43Dss7TBP6SDelDLH3CuyVS8oNVNxfyhRZf4Pjj0O8+4pT3 BRt2ocxkBiihHQZT9zxW7I9nbVkQYIpJViTv9OPexZFVsz7QFnS/muH6cPzBxlYEbstV Z3ZQ== X-Gm-Message-State: ACrzQf3sqotQ2yUOWsZIDXQ8UElfTuKrUFwvrDW2+3ZRP9qgj+TlOn1l 7LUFM8ybVKmsIErdD/H16TJosDRJen2nmnViKlCd7qAtqrU= X-Google-Smtp-Source: AMsMyM41JOXuli7yW65Sou+7539RX0TJpv3A7Gf9dvEBMFre2IK5YX4Udaxgi7b9TmA+T7MBFR4bkIUTZPKRBR0pB8U= X-Received: by 2002:a81:8644:0:b0:349:1126:97a4 with SMTP id w65-20020a818644000000b00349112697a4mr1882648ywf.333.1663834792725; Thu, 22 Sep 2022 01:19:52 -0700 (PDT) MIME-Version: 1.0 From: Rostislav Svoboda Date: Thu, 22 Sep 2022 10:19:16 +0200 Message-ID: Subject: Re: bug#57749: [patch] maven: fix build with java-slf4j-simple-source expanded To: 57749@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57749 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) It seems like this issue has been resolved by the 79897a37012a9bfbcb460cfe0aaaf32aab79dbe5 if so then please close this issue. Thanks From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 22 15:50:31 2022 Received: (at 57749-close) by debbugs.gnu.org; 22 Sep 2022 19:50:31 +0000 Received: from localhost ([127.0.0.1]:38658 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obSDO-0008AD-Va for submit@debbugs.gnu.org; Thu, 22 Sep 2022 15:50:31 -0400 Received: from lepiller.eu ([89.234.186.109]:55052) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1obSDN-0008A2-6u for 57749-close@debbugs.gnu.org; Thu, 22 Sep 2022 15:50:29 -0400 Received: from lepiller.eu (localhost [127.0.0.1]) by lepiller.eu (OpenSMTPD) with ESMTP id 3d6a3741; Thu, 22 Sep 2022 19:50:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=lepiller.eu; h=date:from :to:cc:subject:message-id:in-reply-to:references:mime-version :content-type:content-transfer-encoding; s=dkim; bh=1/lrMlkMc4JF 1hG0MtiOVaI480BdkcGSgEBd8859xYc=; b=Y3tkV1q+6BXRQEJF9grOOt4kIyMU qaVm7crxOkOWeNYiDPufIlFNJpsLTWsBQHtLfXxg8h/4rzCS0rB2Z7L9S/X0QBVq N1k6xMk3z2MKDSJLIJW0vjjnvLbq14rg3M3p0D10oU/EL3uufN7tBQtXnQZpqWKo EpWmYg6uxJLmYfxwBqD4HxdvyclPoOeiM6gWYzFcOJI4vvwwlzVK+gCiNGlcdyI/ MOlLqRYXFKrL9YZ65XzggGwVQSw6w9P4/TxYaj9agb5ohJ09YrGAVvAcJ7LCz/AR gC/tCVBzRGeVmIOCMpIvLgnI9vgM/XceBHRQbWPToGT3ZrprEGNhO+SaiA== Received: by lepiller.eu (OpenSMTPD) with ESMTPSA id a768d393 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Thu, 22 Sep 2022 19:50:27 +0000 (UTC) Date: Thu, 22 Sep 2022 21:50:26 +0200 From: Julien Lepiller To: Rostislav Svoboda Subject: Re: bug#57749: [patch] maven: fix build with java-slf4j-simple-source expanded Message-ID: <20220922215026.0d69975a@sybil.lepiller.eu> In-Reply-To: References: <87sfkw3h4i.fsf@web.de> X-Mailer: Claws Mail 4.1.0 (GTK 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 57749-close Cc: 57749-close@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Le Thu, 22 Sep 2022 10:19:16 +0200, Rostislav Svoboda a =C3=A9crit : > It seems like this issue has been resolved by the > 79897a37012a9bfbcb460cfe0aaaf32aab79dbe5 if so then please close this > issue. >=20 > Thanks >=20 >=20 >=20 Ah indeed, a similar patch was sent independently and pushed before this. I was hoping another commiter would have pushed this patch, but in the end maven-slf4j-provider was fixed :) Closing this since it's no longer relevant. Thanks again! From unknown Wed Jun 18 23:10:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 21 Oct 2022 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator