From unknown Thu Aug 14 18:33:41 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#57730 <57730@debbugs.gnu.org> To: bug#57730 <57730@debbugs.gnu.org> Subject: Status: [PATCH] syscalls: Adjust for glibc 2.34 and later. Reply-To: bug#57730 <57730@debbugs.gnu.org> Date: Fri, 15 Aug 2025 01:33:41 +0000 retitle 57730 [PATCH] syscalls: Adjust for glibc 2.34 and later. reassign 57730 guix-patches submitter 57730 Marius Bakke severity 57730 normal tag 57730 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 06:51:19 2022 Received: (at submit) by debbugs.gnu.org; 11 Sep 2022 10:51:19 +0000 Received: from localhost ([127.0.0.1]:40850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXKYZ-0002OD-A2 for submit@debbugs.gnu.org; Sun, 11 Sep 2022 06:51:19 -0400 Received: from lists.gnu.org ([209.51.188.17]:43206) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXKYW-0002O5-89 for submit@debbugs.gnu.org; Sun, 11 Sep 2022 06:51:17 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59972) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXKYP-0006dT-M3 for guix-patches@gnu.org; Sun, 11 Sep 2022 06:51:15 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49700) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXKYL-0004G2-VJ for guix-patches@gnu.org; Sun, 11 Sep 2022 06:51:09 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=/Qxredzk5ozggEJNQUcuSOqrF4rgmgtqakyrukl7ZRQ=; b=V4Jr8YSUtzvpVc n8fg4OCrtY3ZPUFR9YXAiwwQhRIwq5kQunMQ6QUsb8eiF4MABvT7PcE+jbrtgqgTMZsT6F+FR+A8Q oG4zuRGCanVWDAZCz9IPFR5Sr1JSp61u9Q9AUK6Ku0s6Xte1cKWaazxqA1EPmAtvlm7JD7T2ul6ix DuvUr5LgD0tdBnieXj8LqELxF+0h6hcKgAn2j9RowpNlm08HMFM9vnbi8TKUpr96UWSnaYz4AurzI IQ9LnvYdgJt8tLg0+JubNISSjxLXwF/AtKG2eLwMQdSWxf98EWFkvU4HC/LxOcZj3XznD5rAV1/go CVWU//M4WIHF9qyH067Q==; Received: from [84.214.173.6] (port=57546 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXKYE-0005kP-Gs for guix-patches@gnu.org; Sun, 11 Sep 2022 06:51:05 -0400 From: Marius Bakke To: guix-patches@gnu.org Subject: [PATCH] syscalls: Adjust for glibc 2.34 and later. Date: Sun, 11 Sep 2022 12:50:51 +0200 Message-Id: <20220911105051.16901-1-marius@gnu.org> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a re-implementation of 3c8b6fd94ceb1e898216929e8768fb518dbf1de9 that works with new and old libc's. * guix/build/syscalls.scm (openpty, login-tty): Wrap in exception handlers and retry with libutil if the first call is unsuccessful. --- guix/build/syscalls.scm | 71 ++++++++++++++++++++++++++--------------- 1 file changed, 45 insertions(+), 26 deletions(-) diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm index b00615d9b7..eee90216eb 100644 --- a/guix/build/syscalls.scm +++ b/guix/build/syscalls.scm @@ -9,6 +9,7 @@ ;;; Copyright © 2021 Chris Marusich ;;; Copyright © 2021 Tobias Geerinckx-Rice ;;; Copyright © 2022 Oleg Pykhalov +;;; Copyright © 2022 Marius Bakke ;;; ;;; This file is part of GNU Guix. ;;; @@ -2339,39 +2340,57 @@ (define* (terminal-rows #:optional (port (current-output-port))) (terminal-dimension window-size-rows port (const 25))) (define openpty - (let ((proc (syscall->procedure int "openpty" '(* * * * *) - #:library "libutil"))) - (lambda () - "Return two file descriptors: one for the pseudo-terminal control side, + (lambda* (#:optional library) + "Return two file descriptors: one for the pseudo-terminal control side, and one for the controlled side." + (let ((proc (syscall->procedure int "openpty" '(* * * * *) + #:library library))) (let ((head (make-bytevector (sizeof int))) (inferior (make-bytevector (sizeof int)))) - (let-values (((ret err) - (proc (bytevector->pointer head) - (bytevector->pointer inferior) - %null-pointer %null-pointer %null-pointer))) - (unless (zero? ret) - (throw 'system-error "openpty" "~A" - (list (strerror err)) - (list err)))) - - (let ((* (lambda (bv) - (bytevector-sint-ref bv 0 (native-endianness) - (sizeof int))))) - (values (* head) (* inferior))))))) + (catch 'system-error + (lambda () + (let-values (((ret err) + (proc (bytevector->pointer head) + (bytevector->pointer inferior) + %null-pointer %null-pointer %null-pointer))) + (unless (zero? ret) + (throw 'system-error "openpty" "~A" + (list (strerror err)) + (list err))) + + (let ((* (lambda (bv) + (bytevector-sint-ref bv 0 (native-endianness) + (sizeof int))))) + (values (* head) (* inferior))))) + (lambda args + (if (and (= (system-error-errno args) 38) + (not library)) + ;; Prior to glibc 2.34, openpty resided in libutil. + ;; Try again, fingers crossed! + (openpty "libutil") + (apply throw args)))))))) (define login-tty - (let* ((proc (syscall->procedure int "login_tty" (list int) - #:library "libutil"))) - (lambda (fd) - "Make FD the controlling terminal of the current process (with the + (lambda* (fd #:optional library) + "Make FD the controlling terminal of the current process (with the TIOCSCTTY ioctl), redirect standard input, standard output and standard error output to this terminal, and close FD." - (let-values (((ret err) (proc fd))) - (unless (zero? ret) - (throw 'system-error "login-pty" "~A" - (list (strerror err)) - (list err))))))) + (let ((proc (syscall->procedure int "login_tty" (list int) + #:library library))) + (catch 'system-error + (lambda () + (let-values (((ret err) (proc fd))) + (unless (zero? ret) + (throw 'system-error "login-pty" "~A" + (list (strerror err)) + (list err))))) + (lambda args + (if (and (= (system-error-errno args) 38) + (not library)) + ;; Prior to glibc 2.34, login-pty resided in libutil. + ;; Try again, fingers crossed! + (login-tty fd "libutil") + (apply throw args))))))) ;;; -- 2.37.3 From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 11 07:01:24 2022 Received: (at 57730) by debbugs.gnu.org; 11 Sep 2022 11:01:24 +0000 Received: from localhost ([127.0.0.1]:40868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXKiK-0002f4-Jm for submit@debbugs.gnu.org; Sun, 11 Sep 2022 07:01:24 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35416) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXKiI-0002ep-JP for 57730@debbugs.gnu.org; Sun, 11 Sep 2022 07:01:22 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55584) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXKiD-0005lO-Cs for 57730@debbugs.gnu.org; Sun, 11 Sep 2022 07:01:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=QbGn4bP2AXvkVk0/V+UmNUhHScOF4ZyNyWjxrAgbLWA=; b=mEsPsfR2YIiYh0MsfY/d nxn2HhhFSWEdUgTT4332NlFUsuwByLgpvHDutNUafXbWTek0tdrZRG3fWMb5andgykKarEcZHfXTc llxZ5+exhu/W/NgCe2kwqEeXjuW1tD3UP163NxJD2Jr07SRJ1Iuq15CSK4mOLjgx6ukc7IARyZ+cr maJwahxQCdPFRvjN+dEv6sHawBorb0X9fuy4m9YEqlURu/IA9EqrcvwnOQoZvZv5pchD/Jsi1IvPn rEI9vbs0cS+NZGJ6Q+irYUPM7J1xvL7k0PcgbwyVFA6KcFzBG51GnIbBME4G3zI+evFy7hg2uHkZY wOckQuUsQ3uQow==; Received: from [84.214.173.6] (port=38412 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXKiA-0001AC-5B for 57730@debbugs.gnu.org; Sun, 11 Sep 2022 07:01:17 -0400 From: Marius Bakke To: 57730@debbugs.gnu.org Subject: Re: [bug#57730] [PATCH] syscalls: Adjust for glibc 2.34 and later. In-Reply-To: <20220911105051.16901-1-marius@gnu.org> References: <20220911105051.16901-1-marius@gnu.org> Date: Sun, 11 Sep 2022 13:01:01 +0200 Message-ID: <871qsi18gi.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57730 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Marius Bakke skriver: > This is a re-implementation of 3c8b6fd94ceb1e898216929e8768fb518dbf1de9 that > works with new and old libc's. > > * guix/build/syscalls.scm (openpty, login-tty): Wrap in exception handlers and > retry with libutil if the first call is unsuccessful. An alternative approach could be to use this helper: (define gnu-get-libc-version (let ((proc (syscall->procedure '* "gnu_get_libc_version" '()))) (lambda () (let-values (((ret err) (proc))) (if (zero? err) (pointer->string ret) (throw 'system-error "gnu-get-libc-version" "gnu-get-libc-version: ~A" (list (strerror err)) (list err))))))) ...and maybe set a %glibc-version variable that can be used as needed. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYx2/7Q8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHcIcQEAjec35em4r4A0aqT2dnyEjvs3XlmKpEbEWTmJ eUT9z0kBAMMh3KBrIEHocErzBYutpg329cA2cLt1LSXyV24muo4K =Ri3d -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 12 17:46:03 2022 Received: (at 57730) by debbugs.gnu.org; 12 Sep 2022 21:46:03 +0000 Received: from localhost ([127.0.0.1]:48217 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXrFi-0004In-Lc for submit@debbugs.gnu.org; Mon, 12 Sep 2022 17:46:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57180) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXrFg-0004I2-QI for 57730@debbugs.gnu.org; Mon, 12 Sep 2022 17:46:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49946) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXrFa-0003rh-HX for 57730@debbugs.gnu.org; Mon, 12 Sep 2022 17:45:55 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=JZEAG3yXPEHu8b37aradw06Cko7c68P3XkvVFTe3mKg=; b=e70Em7y/ejj2VGn6r65r s43h9mNASIIHPaKkdVzMk10Rg/LeUW/1LJbfwvvlmytVATYvhdfyy1EMOVoA7494Iqtum4/HRGxwE SSjMY0MT41vXFb2pv/Mr+GNBMagkMiZB5wZ5mTCP5g33VpdXGofkDP5kKDqSt36lRjnK9t6AF04ne dxAvvcCUgL43/93Ekx6cZtJhTwL5hkAXXKyK0RFfhwjyq1rjfYC2LZ14wj/syELaJNuTc5tvxxwbQ oDZf/YA/akAAQiswzimP0HsLOWglUnNutCNm0qS/Sz5PpOGDvMcLL3HOd7KkWQ7hdM+rcjiPgI83k AMUczfD7Wh/vqA==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:56508 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXrFV-000324-V0; Mon, 12 Sep 2022 17:45:50 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Marius Bakke Subject: Re: bug#57730: [PATCH] syscalls: Adjust for glibc 2.34 and later. References: <20220911105051.16901-1-marius@gnu.org> Date: Mon, 12 Sep 2022 23:45:47 +0200 In-Reply-To: <20220911105051.16901-1-marius@gnu.org> (Marius Bakke's message of "Sun, 11 Sep 2022 12:50:51 +0200") Message-ID: <87illsb71w.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 57730 Cc: 57730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi, Marius Bakke skribis: > This is a re-implementation of 3c8b6fd94ceb1e898216929e8768fb518dbf1de9 t= hat > works with new and old libc's. > > * guix/build/syscalls.scm (openpty, login-tty): Wrap in exception handler= s and > retry with libutil if the first call is unsuccessful. [...] > (define openpty > - (let ((proc (syscall->procedure int "openpty" '(* * * * *) > - #:library "libutil"))) > - (lambda () > - "Return two file descriptors: one for the pseudo-terminal control = side, > + (lambda* (#:optional library) > + "Return two file descriptors: one for the pseudo-terminal control si= de, > and one for the controlled side." > + (let ((proc (syscall->procedure int "openpty" '(* * * * *) > + #:library library))) In general, we must ensure that =E2=80=98syscall->procedure=E2=80=99 is cal= led only once per procedure, because it=E2=80=99s expensive compared to the function we= =E2=80=99re wrapping (it=E2=80=99s doing dlopen, dlsym, and all that). Anyway, I think this should work: --=-=-= Content-Type: text/x-patch Content-Disposition: inline diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm index 7842b0a9fc..e081aaca44 100644 --- a/guix/build/syscalls.scm +++ b/guix/build/syscalls.scm @@ -445,9 +445,14 @@ (define* (syscall->procedure return-type name argument-types the returned procedure is called." (catch #t (lambda () + ;; Note: When #:library is set, try it first and fall back to libc + ;; proper. This is because libraries like libutil.so have been subsumed + ;; by libc.so with glibc >= 2.34. (let ((ptr (dynamic-func name (if library - (dynamic-link library) + (or (false-if-exception + (dynamic-link library)) + (dynamic-link)) (dynamic-link))))) ;; The #:return-errno? facility was introduced in Guile 2.0.12. (pointer->procedure return-type ptr argument-types --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable WDYT? Thanks, Ludo=E2=80=99. --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 15 11:26:33 2022 Received: (at 57730) by debbugs.gnu.org; 15 Sep 2022 15:26:33 +0000 Received: from localhost ([127.0.0.1]:58933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYql7-0005EB-DW for submit@debbugs.gnu.org; Thu, 15 Sep 2022 11:26:33 -0400 Received: from eggs.gnu.org ([209.51.188.92]:56822) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oYql5-0005Dc-4n for 57730@debbugs.gnu.org; Thu, 15 Sep 2022 11:26:32 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:49494) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYqkx-0007P2-FO; Thu, 15 Sep 2022 11:26:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=j1yD50YoaILd2bEb/QzUitULU8DxNmwfDnRqzGjoNlQ=; b=bGbus0mwuoPpGNSI45GK 7+fVMt7Ya9YEgkbCNx08jbH+KiCCbGpIhamA7SIviNz0dCTtFT7VpJronvolulYCqcUTBRNiGfrSt GC3sMGbKIQ7cdkcZ07AIlyol/0k5Df7j5QML7uiTUMuRlnabc7A9Qq2gbTcnoF4JRZeZCpR/w6iTm 4FRPtlO6pqhdkCyXgHzSGvQM6DI/ZBoMNAzPesqBemKP5XSpoDPSRSX89wqVf9vDmVfzPr6fhRPvB qBp9ZjheyWYx4igekDrvTrjTIA86R+yvXNrD9xM4DkpV8NuCGYZTyQoHKzUaZ+7mgiZ2p/C4Gs2S1 GXrAFrKbSaW2gg==; Received: from [84.214.173.6] (port=42502 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oYqkw-0000OM-Qr; Thu, 15 Sep 2022 11:26:23 -0400 From: Marius Bakke To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#57730: [PATCH] syscalls: Adjust for glibc 2.34 and later. In-Reply-To: <87illsb71w.fsf@gnu.org> References: <20220911105051.16901-1-marius@gnu.org> <87illsb71w.fsf@gnu.org> Date: Thu, 15 Sep 2022 17:26:19 +0200 Message-ID: <877d24zmjo.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.6 (/) X-Debbugs-Envelope-To: 57730 Cc: 57730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.6 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s skriver: >> (define openpty >> - (let ((proc (syscall->procedure int "openpty" '(* * * * *) >> - #:library "libutil"))) >> - (lambda () >> - "Return two file descriptors: one for the pseudo-terminal control= side, >> + (lambda* (#:optional library) >> + "Return two file descriptors: one for the pseudo-terminal control s= ide, >> and one for the controlled side." >> + (let ((proc (syscall->procedure int "openpty" '(* * * * *) >> + #:library library))) > > In general, we must ensure that =E2=80=98syscall->procedure=E2=80=99 is c= alled only once > per procedure, because it=E2=80=99s expensive compared to the function we= =E2=80=99re > wrapping (it=E2=80=99s doing dlopen, dlsym, and all that). That makes sense. > Anyway, I think this should work: > > diff --git a/guix/build/syscalls.scm b/guix/build/syscalls.scm > index 7842b0a9fc..e081aaca44 100644 > --- a/guix/build/syscalls.scm > +++ b/guix/build/syscalls.scm > @@ -445,9 +445,14 @@ (define* (syscall->procedure return-type name argume= nt-types > the returned procedure is called." > (catch #t > (lambda () > + ;; Note: When #:library is set, try it first and fall back to libc > + ;; proper. This is because libraries like libutil.so have been su= bsumed > + ;; by libc.so with glibc >=3D 2.34. > (let ((ptr (dynamic-func name > (if library > - (dynamic-link library) > + (or (false-if-exception > + (dynamic-link library)) > + (dynamic-link)) > (dynamic-link))))) > ;; The #:return-errno? facility was introduced in Guile 2.0.12. > (pointer->procedure return-type ptr argument-types > > WDYT? I can confirm this works after reverting 3c8b6fd94ceb1e89821. Can you commit it, or should I do it on your behalf? I think we should try to get it in 1.4.0 so Guix works when linked against system libc on foreign distributions. I'll revert 3c8b6fd94ce once this lands on 'core-updates'. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIUEARYKAC0WIQRNTknu3zbaMQ2ddzTocYulkRQQdwUCYyNEGw8cbWFyaXVzQGdu dS5vcmcACgkQ6HGLpZEUEHdscAEArgD9eQZXqHs8qzg8r5/P5IhN7gCdsBtnRMO5 KMwd1yMBAI38lXHEpblnLuO8ZOlap6ihiT2XPjjjcDkiNoUhfVIM =rUKz -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 20 11:12:02 2022 Received: (at control) by debbugs.gnu.org; 20 Oct 2022 15:12:02 +0000 Received: from localhost ([127.0.0.1]:35945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1olXDG-0001Aq-7r for submit@debbugs.gnu.org; Thu, 20 Oct 2022 11:12:02 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1olXDE-0001AK-0D for control@debbugs.gnu.org; Thu, 20 Oct 2022 11:12:01 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33320) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olXD8-0003k0-GD for control@debbugs.gnu.org; Thu, 20 Oct 2022 11:11:54 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=ORiVC/kPhyR1mlAt9FEzTjMRWhDQAjT0W66lfE2zCZ4=; b=Dn/l4p7ClptCL1 RADnLKhhyb4VZcBgHA9M+jZevP6DbZDt4zQO6G+qgrow6xjzM9l8GKiVNaJrb77lAyDFTp0hWjdgl IJ/r1uDJnlLOgH7k9cTphRIsXtSbpcSLb3fwXGlMepwheVMSy/od34gQ5od50XEyHPA1O4ieh+h9b detEbrvkjItQ/DJEWk5Z3z05wO2e+tR329RURPfBvmND+kPvZ3pmFX/csSXbPLBDL/1T7+1K/2bLi NU0oYqD6sDg6ATpwvw8hYHJqZd9EXcjqLC5u8haofLEFIWhJ8xh+HwNh1m7tDIYsD5IcSqKIbyTeY NJ2TUvn+SoGA9aZjESKA==; Received: from [84.211.203.64] (port=59320 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1olXD6-00037v-Td for control@debbugs.gnu.org; Thu, 20 Oct 2022 11:11:54 -0400 From: Marius Bakke To: control@debbugs.gnu.org Subject: Date: Thu, 20 Oct 2022 17:11:49 +0200 Message-ID: <87mt9qttqi.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.3 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) block 53214 by 57730 block 53214 by 58661 thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 01 13:54:36 2022 Received: (at 57730) by debbugs.gnu.org; 1 Nov 2022 17:54:36 +0000 Received: from localhost ([127.0.0.1]:44193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opvTA-0005BI-0F for submit@debbugs.gnu.org; Tue, 01 Nov 2022 13:54:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:59028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1opvT8-0005B6-Gs for 57730@debbugs.gnu.org; Tue, 01 Nov 2022 13:54:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opvT2-0007sB-E6; Tue, 01 Nov 2022 13:54:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=2FaSGkZrUBq8HrjgVhLVQ1weyHeOtAjzZl4EVDD24xM=; b=ELSXKnNZC2+SFaeqiYBb NAKosZ/YHU0m3VWKJJh4tALivwrGXCZ0eLnS0xIguDyUZlAow7K793iZvMd7O/MBBi8cf8zV5nWGu Qm5ELudhDqIRbIm5fNwgC2A7GbJz37EnXue1MWdWsRoTTTGXPF+4n7JXZ9b+AH9ymPHnchKPAYC9i QyeXcbInlGjbGX/N2IdOImFdFYtdlWhwdyXmzArJW+a5NZavtyY1WoQSbPl0pvnMYwJC9fcGxieyI KjMnWOzf/igrkQgl7cZvoWQbJ5YJBaKa5S1vpDG/yBBl9xZNoWfXCsGrPpTcihw65Jz9OYTBlUCbM k4x/ZV29aa5MTA==; Received: from 2a02-8429-81d2-3d01-94c9-8097-ea5c-2774.rev.sfr.net ([2a02:8429:81d2:3d01:94c9:8097:ea5c:2774] helo=meije) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opvT1-00041Y-TA; Tue, 01 Nov 2022 13:54:28 -0400 From: Mathieu Othacehe To: Marius Bakke Subject: Re: bug#57730: [PATCH] syscalls: Adjust for glibc 2.34 and later. References: <20220911105051.16901-1-marius@gnu.org> <87illsb71w.fsf@gnu.org> <877d24zmjo.fsf@gnu.org> Date: Tue, 01 Nov 2022 18:54:24 +0100 In-Reply-To: <877d24zmjo.fsf@gnu.org> (Marius Bakke's message of "Thu, 15 Sep 2022 17:26:19 +0200") Message-ID: <87pme6lfvz.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57730 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 57730@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > Can you commit it, or should I do it on your behalf? I think we should > try to get it in 1.4.0 so Guix works when linked against system libc on > foreign distributions. This indeed seems like the right thing to do :) Marius or Ludo, I think you can go ahead :) Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 07 16:30:32 2022 Received: (at 57730-done) by debbugs.gnu.org; 7 Nov 2022 21:30:32 +0000 Received: from localhost ([127.0.0.1]:35578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os9hQ-00041i-5q for submit@debbugs.gnu.org; Mon, 07 Nov 2022 16:30:32 -0500 Received: from eggs.gnu.org ([209.51.188.92]:42934) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1os9hN-0003hs-OA for 57730-done@debbugs.gnu.org; Mon, 07 Nov 2022 16:30:30 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1os9hI-0006AU-CV for 57730-done@debbugs.gnu.org; Mon, 07 Nov 2022 16:30:24 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=EEX99SZGNuFx8U6lVUBAwAHsKtG0l5HRRoHoczKcy9k=; b=LiH4s3ALhk3CrIR8a5JO 5p/KuPesPSsP2BA2mXZ727Id14x8m+wIAEYGN2/nc5iA/A5kZRRnhVYAQy5/0tQ8fTOuE6RuPS3/4 V2i5jJl5aoJyrEhqkNcj77aE1IcPmGem58HCwiIzip8X6uVMV2pjZ1bX97CA+gNXALHDu22nbGj2/ le33Ku4ggdSVORdHt9DL09gKct2UtVRakgKam9EcMFfX6HDwIr8UPul0OAWUtpZd4FvCxlbPx8uU9 GlRT5M8CqbTslWEKY6e+rZoGXbYC1+Qhfm0MleVaLu0mXNqOk3j0OH8t5FAOu20ABmEJS0de7WlVJ s5hRPF7ZFsjhyQ==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201] helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1os9hH-0002K6-Ag; Mon, 07 Nov 2022 16:30:23 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#57730: [PATCH] syscalls: Adjust for glibc 2.34 and later. References: <20220911105051.16901-1-marius@gnu.org> <87illsb71w.fsf@gnu.org> <877d24zmjo.fsf@gnu.org> <87pme6lfvz.fsf_-_@gnu.org> Date: Mon, 07 Nov 2022 22:30:20 +0100 In-Reply-To: <87pme6lfvz.fsf_-_@gnu.org> (Mathieu Othacehe's message of "Tue, 01 Nov 2022 18:54:24 +0100") Message-ID: <87r0yesb9v.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 57730-done Cc: 57730-done@debbugs.gnu.org, Marius Bakke X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Mathieu Othacehe skribis: > Hey, > >> Can you commit it, or should I do it on your behalf? I think we should >> try to get it in 1.4.0 so Guix works when linked against system libc on >> foreign distributions. > > This indeed seems like the right thing to do :) Marius or Ludo, I think > you can go ahead :) Pushed on =E2=80=98core-updates=E2=80=99 as 3f6c32a88fc7a4d707ae1ed8ef3f7bd= 995461aff! Ludo=E2=80=99. From unknown Thu Aug 14 18:33:41 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 06 Dec 2022 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator