From unknown Sat Aug 16 13:42:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: joaotavora@gmail.com, bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2022 07:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 57725@debbugs.gnu.org Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= X-Debbugs-Original-To: bug-gnu-emacs@gnu.org X-Debbugs-Original-Xcc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Received: via spool by submit@debbugs.gnu.org id=B.166287978110983 (code B ref -1); Sun, 11 Sep 2022 07:04:02 +0000 Received: (at submit) by debbugs.gnu.org; 11 Sep 2022 07:03:01 +0000 Received: from localhost ([127.0.0.1]:40662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXGzd-0002qx-9l for submit@debbugs.gnu.org; Sun, 11 Sep 2022 03:03:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:34890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXGzX-0002ql-Uy for submit@debbugs.gnu.org; Sun, 11 Sep 2022 03:03:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXGzX-0005Pq-LV for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 03:02:55 -0400 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]:35388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXGzV-0000pA-VZ for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 03:02:55 -0400 Received: by mail-ej1-x630.google.com with SMTP id go34so13411600ejc.2 for ; Sun, 11 Sep 2022 00:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date; bh=bgkWE3UNUJzYYCH3SSn80o9ux6kLomFLAYicw9dWN+8=; b=UUe8jUCrtP3ChAq1y8uVsKNVGZ30fZe+sqCj26VSj3EJZjCaCaipNEvYOVptQCl1k/ SqZ80p0caGAD7hc1AV7gd2c1ZO9F5B20mPupwMzNjQ9V232eZFl8Y6kFIPbeNQ80xg3A ymims+NpPFbVKjZPoy4rUlSXwTZlu/NuZAUe2nVArG524+c0mpS+wTY0KxJa9bi2u3jS 3aMzq4DEBUODhNACOgqljpEC3pkIzOR3ylHvlzttqxp4YGeEtllhGIckbNhiwAVOqILj daE1xk3FUfrc5WdC/SCSPSNO9iIPDqdcwRzhHp8QXUCUrQYoglE4KjYnCx4k0KMBW/dk KqJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=bgkWE3UNUJzYYCH3SSn80o9ux6kLomFLAYicw9dWN+8=; b=O1gtcERdbq7UGvH/OdBcsZhDExX9fFELnfJMzDGa1epyPWnh6Z4w9xhXXHET7vRIL1 YM7nxAaI1OcUcf8Rr7tenOYMgtvMl+2XbLc7L0N83FRT0GAWWcg8maD3R6U1xQ2GB2I2 5mrRIIoxvfJRsvuWLxqCST0nuTVJhmLlbG9BLLG86b5mBscvb/AofgIAtabg1Jt1ArGZ R8WoMo8kK7ArPbO82irtfHwVZd8Mw7U0FMKmI7+/v3KAY7JXyL23eVgD4oj2oq4nVC7X p+s/xR93Vsq/VqvbtVntuXvN/5zC50aRkh4o3p7lH7iowpmVSD0CXs7Js0a2NyaWN2lG Xwgg== X-Gm-Message-State: ACgBeo2pzMfK1uXkMA2sL1Z1keEZjnuayAb1hBnWTQrsZlRFYJiTTUuE azWX8BTxFQUdc95pnAYFB96R8oFkk/Q= X-Google-Smtp-Source: AA6agR5Iy89MM1srzBMVMNr43SFT9Gy/RaXzgchR58RLtw9kdYKxAQSUeCxW+jI67uqIOcoSA27Qzw== X-Received: by 2002:a17:907:75c7:b0:779:bf7:9be7 with SMTP id jl7-20020a17090775c700b007790bf79be7mr9152267ejc.432.1662879771427; Sun, 11 Sep 2022 00:02:51 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::157b]) by smtp.gmail.com with ESMTPSA id g2-20020a50ec02000000b0043bea0a48d0sm3472434edr.22.2022.09.11.00.02.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 00:02:50 -0700 (PDT) From: Augusto Stoffel Date: Sun, 11 Sep 2022 09:02:49 +0200 Message-ID: <87sfky9yw6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) If I attempt to pass :initializationOptions to a server like so: (setf (alist-get 'python-mode eglot-server-programs) '("jedi-language-server" :initializationOptions eglot--{})) I get an error: Debugger entered--Lisp error: (invalid-slot-name "#" :initializationOptions) A workaround is to add this to the eglot-lsp-server defclass: @@ -788,6 +788,7 @@ treated as in `eglot-dbind'." (managed-buffers :documentation "List of buffers managed by server." :accessor eglot--managed-buffers) + (_ :initarg :initializationOptions) (saved-initargs :documentation "Saved initargs for reconnection purposes." :accessor eglot--saved-initargs) I can also confirm that after the workaround, the options are passed correctly to the server upon initialization. From unknown Sat Aug 16 13:42:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Resent-From: "Basil L. Contovounesios" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2022 15:14:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Augusto Stoffel Cc: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 57725@debbugs.gnu.org Received: via spool by 57725-submit@debbugs.gnu.org id=B57725.166290922911318 (code B ref 57725); Sun, 11 Sep 2022 15:14:02 +0000 Received: (at 57725) by debbugs.gnu.org; 11 Sep 2022 15:13:49 +0000 Received: from localhost ([127.0.0.1]:43188 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXOeb-0002wT-A4 for submit@debbugs.gnu.org; Sun, 11 Sep 2022 11:13:49 -0400 Received: from mail-wm1-f49.google.com ([209.85.128.49]:45810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXOeT-0002wA-UE for 57725@debbugs.gnu.org; Sun, 11 Sep 2022 11:13:47 -0400 Received: by mail-wm1-f49.google.com with SMTP id bd26-20020a05600c1f1a00b003a5e82a6474so5412088wmb.4 for <57725@debbugs.gnu.org>; Sun, 11 Sep 2022 08:13:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=xj3b9UZ3l1CWFqUvdXq/h4wf17i13S5Y/u4Sk0YNylI=; b=ZNh3rtg+HTbWwX9CfvBVCi7wCTsYKD2ISprKREV9KZK8WJLIeSKamo9y8wmqvnhZZe aVlHLMuKxOyPwX3quX/ONG/BvcvPn93VRHEjvlmqBXrSRzQ65uFOoP3sQZZuh+9xHj2i 3bQoJtWRDhKicmnTnNgM1t/47Q6MUiUIlVO233Y/QcNu5wAPBfLTWhc6D2z7wgOEra8B hr8o71G4E7c6cLuz8BoHTRiIvBgpaRC7jjvjjdEHWziyP13KM2UYYhM1LYg2494g0hWj 0vDKKLISKgM2RORsItnt4eNXXhI3atVQ5uD4KWnxudfZ4gwJw6a3DxiFvbJh/2ioZWkp zj6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=xj3b9UZ3l1CWFqUvdXq/h4wf17i13S5Y/u4Sk0YNylI=; b=zvERoPwLDt/ctnm5e02ZkPxsdJkRZRHB6IPerYtWO7evSDtN1oSTx5pLv/QsuW2dkM L1xo92l4ym2PM+xypAdSlsI6LkJaXxQDcQ6M5s9hvqA+KhMxPU3vUKITfGX7c1WSoFVq Jonc8ZjMdXnknoZ9TLzN9nkgprVF7yoQN15d+n8vGLql6ISmdNgy2pmd9BGDo56xysv/ 3jRCXyy/rBBNj0SEr6DjcvzXV5SCxbfwHUP8I3Mt8xIo9/Qo8qXXWafKVixgqMysk9MN IA7VTbQZbu6K+/S/7bcBCnga0UQqovAtrNqB4Ffqmiu8TfBscujfAwczoPeMkvD5afkf /Knw== X-Gm-Message-State: ACgBeo3X+VaR50stqbPXa0DCSwsjqtwz4mIqIxKEAz/wVGV4XAGy2OZU JjZMCa3QByFgCHvIY6hFdXm3aA== X-Google-Smtp-Source: AA6agR7V4W7Bgz/NWOO4PJA/huC2hSPnWIfKz+36eZK0ZrajXuQHrV+2U7OYd1lXB/45uXF51dtrxw== X-Received: by 2002:a05:600c:358f:b0:3b4:8602:7c43 with SMTP id p15-20020a05600c358f00b003b486027c43mr1023052wmq.60.1662909215558; Sun, 11 Sep 2022 08:13:35 -0700 (PDT) Received: from localhost ([2a02:587:3200:150d:2f83:21d:71a9:8f84]) by smtp.gmail.com with ESMTPSA id l128-20020a1c2586000000b003b340f00f10sm6926087wml.31.2022.09.11.08.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 08:13:35 -0700 (PDT) From: "Basil L. Contovounesios" In-Reply-To: <87sfky9yw6.fsf@gmail.com> (Augusto Stoffel's message of "Sun, 11 Sep 2022 09:02:49 +0200") References: <87sfky9yw6.fsf@gmail.com> Date: Sun, 11 Sep 2022 18:13:33 +0300 Message-ID: <87v8pueyg2.fsf@tcd.ie> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Augusto Stoffel [2022-09-11 09:02 +0200] wrote: > If I attempt to pass :initializationOptions to a server like so: > > (setf (alist-get 'python-mode eglot-server-programs) > '("jedi-language-server" :initializationOptions eglot--{})) > > I get an error: > > Debugger entered--Lisp error: (invalid-slot-name "#" :initializationOptions) > > A workaround is to add this to the eglot-lsp-server defclass: > > @@ -788,6 +788,7 @@ treated as in `eglot-dbind'." > (managed-buffers > :documentation "List of buffers managed by server." > :accessor eglot--managed-buffers) > + (_ :initarg :initializationOptions) > (saved-initargs > :documentation "Saved initargs for reconnection purposes." > :accessor eglot--saved-initargs) > > I can also confirm that after the workaround, the options are passed > correctly to the server upon initialization. Nice. Closing this ticket will also close https://github.com/joaotavora/eglot/issues/940. Thanks, -- Basil From unknown Sat Aug 16 13:42:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2022 16:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: "Basil L. Contovounesios" Cc: Augusto Stoffel , 57725@debbugs.gnu.org Received: via spool by 57725-submit@debbugs.gnu.org id=B57725.166291323517926 (code B ref 57725); Sun, 11 Sep 2022 16:21:02 +0000 Received: (at 57725) by debbugs.gnu.org; 11 Sep 2022 16:20:35 +0000 Received: from localhost ([127.0.0.1]:43253 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXPhD-0004f4-6V for submit@debbugs.gnu.org; Sun, 11 Sep 2022 12:20:35 -0400 Received: from mail-il1-f179.google.com ([209.85.166.179]:40736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXPhA-0004ei-6Q for 57725@debbugs.gnu.org; Sun, 11 Sep 2022 12:20:33 -0400 Received: by mail-il1-f179.google.com with SMTP id s11so3390043ilt.7 for <57725@debbugs.gnu.org>; Sun, 11 Sep 2022 09:20:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=QBQmHx+iw8T9n9F8TcTw245OYw4hOhIYJS3y29RaSsk=; b=dpFsSTXBHAqZ8RnPM3lf9R5oeJi3F3RZ8ovQyassTi+3a98sw0TSn0dpw7jpDhZpdn t6WiwZAomTeK5+PGbGJWb/qXBNn0sK+cinY6XiHzPozdOA+r7bR/njBaZgcEU7CiDL9c j5Rg9x1+yCw8+onwrBfNdZtnvyx3JvTVqg1sKqY1CYIwUabYTOyw5N22YYxBNWeUQxGs S899C07jY1jbRnffcjbmCcY1Inunr+XRXqKVPtw6KCyyVV2cVv7pykwK9INKddwy41PJ 6KOUvzVKn+fqIP4bubHl7EtUg1uA6u5YwI/aiCE3fHQQSitxPZtsIMu0K29RNRutaoc3 wCig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=QBQmHx+iw8T9n9F8TcTw245OYw4hOhIYJS3y29RaSsk=; b=wx9ktCCb44y5AbN3f15EqiE1SXrbRKXZaxKXNE7AqgDhknX6R/gPpqfir1h3gJ9aB0 0Png+C2+xreuPkfRtmnsy3Kl7qCHycWeGS9q+JLbL7U641grRzzCVBr5GWnEGVWug1H5 oJ3pNWCNXw4NtMWb092gpe1AQXoS0zUC48o4ur6JNuOs59P8lsPb/DQ2XEYYEfxXHF4q lIN97FFc0yjZbwVeJiCf6Xzf641IJxHYufid4FMJ/NbKvviCKAZCFB30wQyHzLKsbW+E K0fkQ4sIiPOCLOlKbsONTO5e3gyNtbLK1C7JQEY3c68Z80cJSSQOiMQa3+C9lg/ISb60 Su3Q== X-Gm-Message-State: ACgBeo1JVN7rAv39KFlGhhZe6VJzPhl4n6cXxbuNkvr04Okkw1h789jQ srD6Zu1pr7Ta4Swzdnj929CV+EwEvn2Fm42xfv0= X-Google-Smtp-Source: AA6agR7U+Zov6szdkia43q5COQ9vZ676nYQrq+XGfpRTFZjCSAqW839d8sOSJCPVgrd58pwgOVNObEKzrutZhpglPPg= X-Received: by 2002:a92:c24a:0:b0:2f1:a3dd:f502 with SMTP id k10-20020a92c24a000000b002f1a3ddf502mr8210726ilo.293.1662913226583; Sun, 11 Sep 2022 09:20:26 -0700 (PDT) MIME-Version: 1.0 References: <87sfky9yw6.fsf@gmail.com> <87v8pueyg2.fsf@tcd.ie> In-Reply-To: <87v8pueyg2.fsf@tcd.ie> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sun, 11 Sep 2022 17:20:13 +0100 Message-ID: Content-Type: multipart/alternative; boundary="00000000000029b24e05e869287a" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000029b24e05e869287a Content-Type: text/plain; charset="UTF-8" I almost agree with this fix as is, but maybe we should name the slot. What happens if my the connection is restarted, shouldn't the previous initializationOptions be reused? On Sun, Sep 11, 2022, 16:13 Basil L. Contovounesios wrote: > Augusto Stoffel [2022-09-11 09:02 +0200] wrote: > > > If I attempt to pass :initializationOptions to a server like so: > > > > (setf (alist-get 'python-mode eglot-server-programs) > > '("jedi-language-server" :initializationOptions eglot--{})) > > > > I get an error: > > > > Debugger entered--Lisp error: (invalid-slot-name "# eglot-lsp-server-92f0c8>" :initializationOptions) > > > > A workaround is to add this to the eglot-lsp-server defclass: > > > > @@ -788,6 +788,7 @@ treated as in `eglot-dbind'." > > (managed-buffers > > :documentation "List of buffers managed by server." > > :accessor eglot--managed-buffers) > > + (_ :initarg :initializationOptions) > > (saved-initargs > > :documentation "Saved initargs for reconnection purposes." > > :accessor eglot--saved-initargs) > > > > I can also confirm that after the workaround, the options are passed > > correctly to the server upon initialization. > > Nice. > > Closing this ticket will also close > https://github.com/joaotavora/eglot/issues/940. > > Thanks, > > -- > Basil > --00000000000029b24e05e869287a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
I almost agree with this fix as is, but maybe we should n= ame the slot. What happens if my the connection is restarted, shouldn't= the previous initializationOptions be reused?

On Sun, Sep 11, 2022, 16:13 B= asil L. Contovounesios <contovob@tcd.ie> wrote:
Augusto Stoffel [2022-09-11 09:02 +0200] wrote:

> If I attempt to pass :initializationOptions to a server like so:
>
>=C2=A0 =C2=A0 =C2=A0(setf (alist-get 'python-mode eglot-server-prog= rams)
>=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0'("jedi-language-serv= er" :initializationOptions eglot--{}))
>
> I get an error:
>
>=C2=A0 =C2=A0 =C2=A0Debugger entered--Lisp error: (invalid-slot-name &q= uot;#<eglot-lsp-server eglot-lsp-server-92f0c8>" :initialization= Options)
>
> A workaround is to add this to the eglot-lsp-server defclass:
>
> @@ -788,6 +788,7 @@ treated as in `eglot-dbind'."
>=C2=A0 =C2=A0 =C2=A0(managed-buffers
>=C2=A0 =C2=A0 =C2=A0 :documentation "List of buffers managed by se= rver."
>=C2=A0 =C2=A0 =C2=A0 :accessor eglot--managed-buffers)
> +=C2=A0 =C2=A0(_ :initarg :initializationOptions)
>=C2=A0 =C2=A0 =C2=A0(saved-initargs
>=C2=A0 =C2=A0 =C2=A0 :documentation "Saved initargs for reconnecti= on purposes."
>=C2=A0 =C2=A0 =C2=A0 :accessor eglot--saved-initargs)
>
> I can also confirm that after the workaround, the options are passed > correctly to the server upon initialization.

Nice.

Closing this ticket will also close
https://github.com/joaotavora/eg= lot/issues/940.

Thanks,

--
Basil
--00000000000029b24e05e869287a-- From unknown Sat Aug 16 13:42:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2022 16:27:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: "Basil L. Contovounesios" , 57725@debbugs.gnu.org Received: via spool by 57725-submit@debbugs.gnu.org id=B57725.166291357318441 (code B ref 57725); Sun, 11 Sep 2022 16:27:01 +0000 Received: (at 57725) by debbugs.gnu.org; 11 Sep 2022 16:26:13 +0000 Received: from localhost ([127.0.0.1]:43257 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXPmf-0004nN-2V for submit@debbugs.gnu.org; Sun, 11 Sep 2022 12:26:13 -0400 Received: from mail-oa1-f52.google.com ([209.85.160.52]:45005) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXPmd-0004nB-UJ for 57725@debbugs.gnu.org; Sun, 11 Sep 2022 12:26:12 -0400 Received: by mail-oa1-f52.google.com with SMTP id 586e51a60fabf-11eab59db71so17317804fac.11 for <57725@debbugs.gnu.org>; Sun, 11 Sep 2022 09:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=4VoATzac1Zzgbe8l9SCrIp9BbxuajQ11s2fQIAm30Wo=; b=etNPrhYZ6pZiONazC6kZwJPnZyQm0eBLnjzZ5iSAAPhwmzwSmiVaAff68l5+hAPEKB sVUGE1/8OzmQHZg8N77uZZwpCZcNGY3cHfeJNE3I4gjHZJZ1PFJZoio8Jyv+QZs3wSPt /MnqP+fm0ova0FVcj+UFP8SWCKh1CAYciSKyNXMeCZ5VbBgZKyz398idq7O1H9TlcFy2 2PnxCYo6FNEalNlMyKP3TDwIBNObWrvsKN+pA9lBIruBgrUTC4cZC+7q6VKzoTe/QDME FFoP6b8t9W0DyqzT3sN9qwFD5rPx2WCSuigMiBENMYKyBHExWHmqAjTbpXTwY1gXud4S uhjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=4VoATzac1Zzgbe8l9SCrIp9BbxuajQ11s2fQIAm30Wo=; b=y5ysI6dJ+7wl7gos/43i0hrLGGtgmbPrMgD07Yv1mmH13lmelCan4vQSXvpL3ZKf3/ JdrdzPmXCt8DE2hP0NkdKlIQep7J08ugf9Kk+xdULOR4EpfmLZiEGzrvdLHV+klgMz2S i5W0Tt6G9ZhpPE6GpRVor284KgxicnpmL3pymnVFCu8bJOBDcB8k7DvhIW5c9moLk2CR 8NtOu7yjsUQKlhoobT2SMAl3mkEe7MxbtMqpMW5LN8OlA6hu4LtmfdFAUGPsoxDPgxHD g58UN7LRCvHgn06vQuT/OXfzy7GYBODu8ggGnUA69IW1MCXkBWvAEbOi4hKsU6t8tUvc gjQg== X-Gm-Message-State: ACgBeo0b4KVRVgAwyKhGPBQVuziYz78nmahEnesr5gFdkj27ryJexh2O s7v84Nr0dNszjztlL+PY2Elky3W/fJcZJ99todU= X-Google-Smtp-Source: AA6agR4sJp1ht1jsODnG8hBklF4p5gV3zjf3fEh6R1laGZKBoktQyx8fgnw/eoH+N5aYLltR0gPdGBVH3ICRjezYcQ4= X-Received: by 2002:a05:6808:124e:b0:345:b825:fe9f with SMTP id o14-20020a056808124e00b00345b825fe9fmr7784941oiv.142.1662913566307; Sun, 11 Sep 2022 09:26:06 -0700 (PDT) MIME-Version: 1.0 References: <87sfky9yw6.fsf@gmail.com> <87v8pueyg2.fsf@tcd.ie> In-Reply-To: From: Augusto Stoffel Date: Sun, 11 Sep 2022 18:25:55 +0200 Message-ID: Content-Type: multipart/alternative; boundary="00000000000069795805e8693c6f" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000069795805e8693c6f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sun, Sep 11, 2022, 18:20 Jo=C3=A3o T=C3=A1vora wr= ote: > I almost agree with this fix as is, but maybe we should name the slot. > What happens if my the connection is restarted, shouldn't the previous > initializationOptions be reused? > Most certainly. --00000000000069795805e8693c6f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Sun, Sep 11, 2022, 18:20 Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.com> wrote:
I almost agree with thi= s fix as is, but maybe we should name the slot. What happens if my the conn= ection is restarted, shouldn't the previous initializationOptions be re= used?

Most certainly.
--00000000000069795805e8693c6f-- From unknown Sat Aug 16 13:42:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2022 16:29:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Augusto Stoffel Cc: "Basil L. Contovounesios" , 57725@debbugs.gnu.org Received: via spool by 57725-submit@debbugs.gnu.org id=B57725.166291368918626 (code B ref 57725); Sun, 11 Sep 2022 16:29:01 +0000 Received: (at 57725) by debbugs.gnu.org; 11 Sep 2022 16:28:09 +0000 Received: from localhost ([127.0.0.1]:43262 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXPoX-0004qM-G3 for submit@debbugs.gnu.org; Sun, 11 Sep 2022 12:28:09 -0400 Received: from mail-io1-f51.google.com ([209.85.166.51]:41620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXPoV-0004q7-Nw for 57725@debbugs.gnu.org; Sun, 11 Sep 2022 12:28:08 -0400 Received: by mail-io1-f51.google.com with SMTP id r134so5241960iod.8 for <57725@debbugs.gnu.org>; Sun, 11 Sep 2022 09:28:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=4bxOhhcoRxyc4R/EdON394oP1Chb7/4Y52kjc5jIKv0=; b=OZSYsRntDAeL9eaU1RyRBeB4/x5UFMBunayHwyS45+jLDH7tkWR7IgqIxQYfkzwSmq g/KibeFbnr2rtfkcuqJJx6me90FKC/oymS80AJiX9CiYFtgoICermpmcR4grPfflYAyA w0yshvFoJhniAjZez8y1Q4nIyfdwiC8//etQeoIyeGhWuWyg+VVBBuW/9lbdhzEV6ehQ gqvIYgWxrBVfMBMSfl1bk0/iGPgTUOakZUquherO8xIsfg/Ppnqdz9XUrIp+s65+9Lml 5hq1RFZim//5JUK5YSGeDLnW545wIPJgEUf+ozdtG5C7IzJ6NZu+OcU2gdmBCEnFKD2h sTMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=4bxOhhcoRxyc4R/EdON394oP1Chb7/4Y52kjc5jIKv0=; b=laDoSMfE0I8IRwXD65FQBp1DaLCSf7DSQew/OW0y7oKz5ZMy614zvwAPohl72amGxg x7SDmN5gA+OrtsvSK/ynaUPGjRREgVboAz6yoPTCbQpkTC3RC2mKmZQxy8Nv1dSdufgg U+Qe/8BMsTFTFIN6M7IikynRBeJ/hkLAwqXzHKNl6tKXFJhACrskCplfILll5zE58iuc XQftmbglKVl6zKrjMXVicIMWGzn8p8c9P81DPPHQdxSY/SeBGBWChX0YV2xiupZt9Ao5 YRInZrfS9xfDjCKxJ/MvflUs0ZYQkxbclpkeL1ILEsWAGhR3aPQp2VZlMpcIh10hGnlQ NQAg== X-Gm-Message-State: ACgBeo2R4fEG6MbmQOS8sbm2HHaPg8qlHm6pAfZPR2QeYrGZlp62U8M+ t//rDO24+oSH8RaSov6Q0tHJnyHVf0Ia1axWpTs= X-Google-Smtp-Source: AA6agR6vjF5YAOU6p0+YirQ7/OoE795O03Dnl/d/Mtn0LCtbBQeabimDdjxRo6ROKhqMh7/GBUwM88DW5XndkO3IFAs= X-Received: by 2002:a05:6602:1482:b0:6a1:375e:9fb6 with SMTP id a2-20020a056602148200b006a1375e9fb6mr745114iow.40.1662913682303; Sun, 11 Sep 2022 09:28:02 -0700 (PDT) MIME-Version: 1.0 References: <87sfky9yw6.fsf@gmail.com> <87v8pueyg2.fsf@tcd.ie> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sun, 11 Sep 2022 17:27:49 +0100 Message-ID: Content-Type: multipart/alternative; boundary="000000000000536ffd05e8694362" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000536ffd05e8694362 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Can you suggest an alternative patch so that that second effect also happens? Jo=C3=A3o On Sun, Sep 11, 2022, 17:26 Augusto Stoffel wrote: > On Sun, Sep 11, 2022, 18:20 Jo=C3=A3o T=C3=A1vora = wrote: > >> I almost agree with this fix as is, but maybe we should name the slot. >> What happens if my the connection is restarted, shouldn't the previous >> initializationOptions be reused? >> > > Most certainly. > --000000000000536ffd05e8694362 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Can you suggest an alternative patch so that that second = effect also happens?

Jo=C3=A3o=

On Sun, Sep 11, 2022, 17:26 Augusto Stoffel <arstoffel@gmail.com> wrote:
On Sun, Sep 11, 2022, 18:20 Jo=C3=A3o T=C3= =A1vora <joaotavora@gmail.com> wrote:
I almost agree with this fix as is, but = maybe we should name the slot. What happens if my the connection is restart= ed, shouldn't the previous initializationOptions be reused?

Most certa= inly.
--000000000000536ffd05e8694362-- From unknown Sat Aug 16 13:42:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2022 16:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: "Basil L. Contovounesios" , 57725@debbugs.gnu.org Received: via spool by 57725-submit@debbugs.gnu.org id=B57725.166291400619241 (code B ref 57725); Sun, 11 Sep 2022 16:34:02 +0000 Received: (at 57725) by debbugs.gnu.org; 11 Sep 2022 16:33:26 +0000 Received: from localhost ([127.0.0.1]:43276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXPte-00050F-HH for submit@debbugs.gnu.org; Sun, 11 Sep 2022 12:33:26 -0400 Received: from mail-ej1-f50.google.com ([209.85.218.50]:35792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXPtc-000503-LO for 57725@debbugs.gnu.org; Sun, 11 Sep 2022 12:33:24 -0400 Received: by mail-ej1-f50.google.com with SMTP id go34so15053800ejc.2 for <57725@debbugs.gnu.org>; Sun, 11 Sep 2022 09:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=fLZueThSTF6F8o7pvPJV+82T/CLiyzvfv2Vu2HXV4nM=; b=Fv+cW4VtK0TOwR8NxRI4v0l9EgI46TD96GaPd9RxzviVw6XSPIuJUarncLlj3rnGO1 9RIHHwUdaXJzRoz27+bqAowTleqLEJya+Jg42D7PLrOAZ+EoCl2TWbeE89QHgdf0aved by8JqmIuWUNZQrAMM0TpT71MpP+p8Uo+E6FgebKoVp7yHh6+26E+M9Cst5zz3+Wt6UnX CkUnnq4C9xzq+YLExcHBC4wO66wbPImJib3EqzcTDd+VGcpMhLQ5cK+dGP5XpEqB9Xiw 3S7QDrLtl4xLaKHeAm8EYHAp04paRu66Y336tPPd351Mzc7l7x2d8/iPN8bRa4slJBLz iEKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=fLZueThSTF6F8o7pvPJV+82T/CLiyzvfv2Vu2HXV4nM=; b=S1tXMo4jfcmeQUV7wE8pPs3U8hEynhdNyx/NvJupteTJQFipXF1lrY6ris9TLQjUcv VcNTGUYA/KIeloTJzPEwLYXJnCu7m0Kj0XTgBgB6sO1fL93QGxSIJsI4g1ZF0QmBgiVn Nm8NuBq015cuPrIVxA+cTXVrSi0pjoch/dWUWZsBrWFO2WwvDFHd2MvEFkz6UtSFUuQY DyXjtcsuzs9iRi1w3ENUagNTBm2Be6q9C4ml4gKGO8OweFuNbuOiR66uC1+e4yMbdATw FQtlnhevybCI/ET5QKt+JmdgzguZ7b9XCiDL7yHtdGEgFU7eZPw2oFILWNIgRF3EMnic 3P5A== X-Gm-Message-State: ACgBeo3TF0fJCs9MJW66ciqW1IqjxpexFOY4JcYzAiGTy257syOMZtTC JEsbrreiy+fZ+adX2wZ78NWumaeLeUQ= X-Google-Smtp-Source: AA6agR4UYWbqxEpqd3ykxOpwAITPRUrKOhOBw/8FO2+xvESisxcGVikdUYF0+EE2KHfB1GRI8oAJTw== X-Received: by 2002:a17:907:7242:b0:741:770b:dfc6 with SMTP id ds2-20020a170907724200b00741770bdfc6mr16348303ejc.203.1662913998517; Sun, 11 Sep 2022 09:33:18 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::157b]) by smtp.gmail.com with ESMTPSA id q16-20020a170906541000b0073d7b876621sm3120508ejo.205.2022.09.11.09.33.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 09:33:17 -0700 (PDT) From: Augusto Stoffel In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 11 Sep 2022 17:27:49 +0100") References: <87sfky9yw6.fsf@gmail.com> <87v8pueyg2.fsf@tcd.ie> Date: Sun, 11 Sep 2022 18:33:16 +0200 Message-ID: <87bkrlq3ar.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sun, 11 Sep 2022 at 17:27, Jo=C3=A3o T=C3=A1vora wrote: > Can you suggest an alternative patch so that that second effect also happ= ens? > > Jo=C3=A3o > > On Sun, Sep 11, 2022, 17:26 Augusto Stoffel wrote: > > On Sun, Sep 11, 2022, 18:20 Jo=C3=A3o T=C3=A1vora = wrote: > > I almost agree with this fix as is, but maybe we should name the slot. W= hat > happens if my the connection is restarted, shouldn't the previous > initializationOptions be reused? > > Most certainly. Actually, I'm not so sure what the best behavior is. I think reusing the original :initializationOptions is consistent with other behavior in Eglot (is it?), but there's also merit in recomputing/using the current user settings =E2=80=94 for instance, if you need to debug the :initializationOptions. From unknown Sat Aug 16 13:42:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 11 Sep 2022 16:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Augusto Stoffel Cc: "Basil L. Contovounesios" , 57725@debbugs.gnu.org Received: via spool by 57725-submit@debbugs.gnu.org id=B57725.166291430919701 (code B ref 57725); Sun, 11 Sep 2022 16:39:01 +0000 Received: (at 57725) by debbugs.gnu.org; 11 Sep 2022 16:38:29 +0000 Received: from localhost ([127.0.0.1]:43288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXPyX-00057h-0W for submit@debbugs.gnu.org; Sun, 11 Sep 2022 12:38:29 -0400 Received: from mail-io1-f50.google.com ([209.85.166.50]:46077) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXPyV-00057U-L9 for 57725@debbugs.gnu.org; Sun, 11 Sep 2022 12:38:28 -0400 Received: by mail-io1-f50.google.com with SMTP id v128so5229240ioe.12 for <57725@debbugs.gnu.org>; Sun, 11 Sep 2022 09:38:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=XwgCKZelKZblzlPYiEl7SjJd7ryme+yN+BFID8sVgVE=; b=O6Sht9qjlZzfqQBBTcdSRR/W8GM/o7faNn8hpGyCa6uyOMGfBM3Z3ciUhTffyC+b79 FBNjarMWwMZukaqPWT8Q7w0K6KCl4jWIlzAeaHaARxFya+WefxiowegU3OoCOnCA+NX2 P4dGk34J8sqTnWNoROH7u+RjR40L0Q7A/vYEnImkbZilKGgaTApjqqFZ51++ExXh9PFu kl9r1IoizKSJPpVaPB+Xy05f5GTnmp0q5WrG7XRkQ0jAzdDOfelpQvAKQj7ifuJvcMX9 2gacuM5X8vA11l2bwBxpy2WN61DfjNCeSqKQbzC5rmIBAa5JylX9orPWJC7Dkc/CASvL WrDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=XwgCKZelKZblzlPYiEl7SjJd7ryme+yN+BFID8sVgVE=; b=RWOfTx/X9WRywZKxPDW0Ey2qAho6IGaQgXBlXKEx5WihUoTn8dS/OWWV4203Wd+L3d qa1EkyfAP+g/eWq1FV2NfdJtT/2fo0xbANnzBECVimcbQ8WJgnKsHWaZkRIFdio9xxwK mrlD2qLdsyU3uZj2jijSWZdO8GWDHcWOfhGmCrqPQoaSmmlij3jJVQu/le50HC8GBsR0 RaCGfFL8xM0faENDeSPjmYeposWt0yXKXpoAhIEVsZyrm08FfR0fhcdgC+uUne316eqT IluUIAImkLmaz/MGIbyMeaf4eV3UwT4pQUvUpsQbZ6qF+iasq8I5GFMjk/EChE/ix5WV 2y6w== X-Gm-Message-State: ACgBeo3/JDdjaCKNV9/wAf800OyY42yHPlDFETssYIvsexKz1BOvzHXj dOe70I4WZXlYbxdMRIA9VFMXZrJX7tsg0ez2xTA= X-Google-Smtp-Source: AA6agR7UPqJTtXjzvrq6hqI1rNSC98vD6SknYR6hxHtzMNskrIz4rbd07t2JwaeplEl61me9Tre2kHq40YcatailXsc= X-Received: by 2002:a05:6638:3f1a:b0:35a:3ae2:5906 with SMTP id ck26-20020a0566383f1a00b0035a3ae25906mr608959jab.181.1662914302069; Sun, 11 Sep 2022 09:38:22 -0700 (PDT) MIME-Version: 1.0 References: <87sfky9yw6.fsf@gmail.com> <87v8pueyg2.fsf@tcd.ie> <87bkrlq3ar.fsf@gmail.com> In-Reply-To: <87bkrlq3ar.fsf@gmail.com> From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sun, 11 Sep 2022 17:38:09 +0100 Message-ID: Content-Type: multipart/alternative; boundary="00000000000044534605e8696837" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --00000000000044534605e8696837 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Yes, makes sense, but there is another piece of initialization -- good ol command line params -- that are also treated the way i described (i'm almost sure, but better confirm). So it's good to be consistent. If this kind of refreshing from user options is needed for debug purposes, the user can simply shutdown and restart instead of eglot-reconnect. At least this is what I figured at the time. On Sun, Sep 11, 2022, 17:33 Augusto Stoffel wrote: > On Sun, 11 Sep 2022 at 17:27, Jo=C3=A3o T=C3=A1vora wrote: > > > Can you suggest an alternative patch so that that second effect also > happens? > > > > Jo=C3=A3o > > > > On Sun, Sep 11, 2022, 17:26 Augusto Stoffel wrote= : > > > > On Sun, Sep 11, 2022, 18:20 Jo=C3=A3o T=C3=A1vora wrote: > > > > I almost agree with this fix as is, but maybe we should name the slot. > What > > happens if my the connection is restarted, shouldn't the previous > > initializationOptions be reused? > > > > Most certainly. > > Actually, I'm not so sure what the best behavior is. I think reusing > the original :initializationOptions is consistent with other behavior in > Eglot (is it?), but there's also merit in recomputing/using the current > user settings =E2=80=94 for instance, if you need to debug the > :initializationOptions. > --00000000000044534605e8696837 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Yes, makes sense, but there is another = piece of initialization -- good ol command line params -- that are also tre= ated the way i described (i'm almost sure, but better confirm).

So it's good to be consistent. If= this kind of refreshing from user options is needed for debug purposes, th= e user can simply shutdown and restart instead of eglot-reconnect. At least= this is what I figured at the time.

On Sun, Sep 11, 2022, 17:33 Augus= to Stoffel <arst= offel@gmail.com> wrote:
On S= un, 11 Sep 2022 at 17:27, Jo=C3=A3o T=C3=A1vora wrote:

> Can you suggest an alternative patch so that that second effect also h= appens?
>
> Jo=C3=A3o
>
> On Sun, Sep 11, 2022, 17:26 Augusto Stoffel <arstoffel@gmail.com> wr= ote:
>
>=C2=A0 On Sun, Sep 11, 2022, 18:20 Jo=C3=A3o T=C3=A1vora <joaotavora@gmail.= com> wrote:
>
>=C2=A0 I almost agree with this fix as is, but maybe we should name the= slot. What
>=C2=A0 happens if my the connection is restarted, shouldn't the pre= vious
>=C2=A0 initializationOptions be reused?
>
>=C2=A0 Most certainly.

Actually, I'm not so sure what the best behavior is.=C2=A0 I think reus= ing
the original :initializationOptions is consistent with other behavior in Eglot (is it?), but there's also merit in recomputing/using the current=
user settings =E2=80=94 for instance, if you need to debug the
:initializationOptions.
--00000000000044534605e8696837-- From unknown Sat Aug 16 13:42:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Sep 2022 11:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Cc: "Basil L. Contovounesios" , 57725@debbugs.gnu.org Received: via spool by 57725-submit@debbugs.gnu.org id=B57725.166341347822131 (code B ref 57725); Sat, 17 Sep 2022 11:18:02 +0000 Received: (at 57725) by debbugs.gnu.org; 17 Sep 2022 11:17:58 +0000 Received: from localhost ([127.0.0.1]:45259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZVpe-0005ks-AV for submit@debbugs.gnu.org; Sat, 17 Sep 2022 07:17:58 -0400 Received: from mail-ej1-f47.google.com ([209.85.218.47]:37421) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZVpa-0005kH-VZ for 57725@debbugs.gnu.org; Sat, 17 Sep 2022 07:17:55 -0400 Received: by mail-ej1-f47.google.com with SMTP id a26so25968803ejc.4 for <57725@debbugs.gnu.org>; Sat, 17 Sep 2022 04:17:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date; bh=cqZDRWbrqsQkOnF1D4FYABapmAWTwPw0dJixUfftMOI=; b=Gv2v8a+iRqn8iguYZ2zNqRFkL41WuiheG0pgGR2CMwk9THsh97vqz6oUqvx25+vvwr pTIjJOGc7Edbi/HVAlSkM30NLwYGBUq5hPjDmsUm8YTcbSEmvbxxq045muUj+/8Rgl0o LTPDf6HGsRUddXskdLENkqU7xwNRJqgpXohY4dbArYe6YY4IjW6sYmOTAbOO1zPy2oM0 i1IqTDE2mcNQ64mbnp3SZGnD+7jdk6DAf+CYT8vMw8CPL3opiC9zwDoVRFqnvv9sY1tE iPl7HE6ffCsdKhycJAlmGukd0mXY5ODCF3cEAgbUKaLf0u8YZ3yp25IpN+2SAKDGeSqj uS5g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date; bh=cqZDRWbrqsQkOnF1D4FYABapmAWTwPw0dJixUfftMOI=; b=fU7mDDWKZkFb9anjKPLaXpQW6PpYgq546ohVXymqsRln7kSF+xOCrVa5v1XVk2nCv0 XzcVzW9h7EaC7tJFv9XleX57hneGQzCIqeAUe1WElhgrpcQcT57aoxYt+O7sNnbyOVbB KkFwBFysZmkLwwSfrWoMN3lkeWM8XPaiu5cnjWYwiD8n/ozbpNs710TYL367jbKD8OY5 4g9fFzYaavSwVSF7zxU46jPNj9KK+nOyQS9LEkj0LU9qklw+wQ4kWSIWIBKVs9/+K3Qa 8DgAEi2BW97NPp5SaczQU/jnyxMmGNP0ujhKUSxM2wv2oKDuIEa0ENjGFN2+qrvg1Xir vhKA== X-Gm-Message-State: ACrzQf15HG581AME/OsRhe5wy1C6OymPiQvPyEjJNkhp9ywnzDg81ye5 mgXPn05E3ElcYgmNZR6hr+qy9ptZMX20Aw== X-Google-Smtp-Source: AMsMyM6qvLDf25E1dLBwnrNQzKMnnIzuLQBEYUx5gZ0zvr+WJnKx5MMOp5t1DtuNY4YswoeZkIhUlQ== X-Received: by 2002:a17:907:eaa:b0:772:b571:bd7c with SMTP id ho42-20020a1709070eaa00b00772b571bd7cmr6277126ejc.563.1663413468597; Sat, 17 Sep 2022 04:17:48 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::8510]) by smtp.gmail.com with ESMTPSA id d18-20020a170906305200b0073d81b0882asm11989946ejd.7.2022.09.17.04.17.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Sep 2022 04:17:48 -0700 (PDT) From: Augusto Stoffel In-Reply-To: ("=?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?="'s message of "Sun, 11 Sep 2022 17:38:09 +0100") References: <87sfky9yw6.fsf@gmail.com> <87v8pueyg2.fsf@tcd.ie> <87bkrlq3ar.fsf@gmail.com> Date: Sat, 17 Sep 2022 13:17:47 +0200 Message-ID: <875yhmckro.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) I just submitted a pull request on Github, so that we can see the CI test results. https://github.com/joaotavora/eglot/pull/1038 I guess we can close the ticket there and continue the discussion there. On Sun, 11 Sep 2022 at 17:38, Jo=C3=A3o T=C3=A1vora wrote: > Yes, makes sense, but there is another piece of initialization -- good ol= command line > params -- that are also treated the way i described (i'm almost sure, but= better confirm). > > So it's good to be consistent. If this kind of refreshing from user optio= ns is needed for > debug purposes, the user can simply shutdown and restart instead of eglot= -reconnect. At > least this is what I figured at the time. > > On Sun, Sep 11, 2022, 17:33 Augusto Stoffel wrote: > > On Sun, 11 Sep 2022 at 17:27, Jo=C3=A3o T=C3=A1vora wrote: > > > Can you suggest an alternative patch so that that second effect also h= appens? > > > > Jo=C3=A3o > > > > On Sun, Sep 11, 2022, 17:26 Augusto Stoffel wrot= e: > > > > On Sun, Sep 11, 2022, 18:20 Jo=C3=A3o T=C3=A1vora wrote: > > > > I almost agree with this fix as is, but maybe we should name the slot= . What > > happens if my the connection is restarted, shouldn't the previous > > initializationOptions be reused? > > > > Most certainly. > > Actually, I'm not so sure what the best behavior is. I think reusing > the original :initializationOptions is consistent with other behavior in > Eglot (is it?), but there's also merit in recomputing/using the current > user settings =E2=80=94 for instance, if you need to debug the > :initializationOptions. From unknown Sat Aug 16 13:42:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Sep 2022 16:34:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Augusto Stoffel Cc: "Basil L. Contovounesios" , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 57725@debbugs.gnu.org Received: via spool by 57725-submit@debbugs.gnu.org id=B57725.166343243814854 (code B ref 57725); Sat, 17 Sep 2022 16:34:01 +0000 Received: (at 57725) by debbugs.gnu.org; 17 Sep 2022 16:33:58 +0000 Received: from localhost ([127.0.0.1]:47009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZalS-0003rV-EQ for submit@debbugs.gnu.org; Sat, 17 Sep 2022 12:33:58 -0400 Received: from mail-oa1-f42.google.com ([209.85.160.42]:41968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZalR-0003rK-Ak for 57725@debbugs.gnu.org; Sat, 17 Sep 2022 12:33:57 -0400 Received: by mail-oa1-f42.google.com with SMTP id 586e51a60fabf-12803ac8113so56320563fac.8 for <57725@debbugs.gnu.org>; Sat, 17 Sep 2022 09:33:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=tNDD9Ggy59/splx0bammnlinzGK8re5TbryRcmpyzJI=; b=isq9BUZ8wIGMTyJXozvz6YBtahjC40RbKTLK/iZIFoBlx94ZZgR5VvGq9j60iVqc/6 hfZZq0nkRC4jd8N6pIukl5oSFX/vzr03pq6oJXFBdX6DBVYgG+reVbvUEeddMcL4xJAV ixpovxOwyECgnOgDMImKAnVZ770qOAZVUIjr1umpyffLcWFcHTLM5mDC5AxrYRvAeo// 0xOPtN25k5XdLq66mZwxQvLvL156daqBapMdgHD67TA8c0GllNEmNw2YZS9vhfPwnDin lYlN8sXxsYpTQ9PbST034IiOOZHrc25NcEKrzKJgypWLZTcpD2kK5yMl72iFlJEk7iNS nRcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=tNDD9Ggy59/splx0bammnlinzGK8re5TbryRcmpyzJI=; b=C6R2bph5jUIvk/X3YxedF1fB/M0G3d4qSGxR90EMgK7NJgKulzePlbN6bDKQS0SXE+ rtNSzmXyvSCUrsXJhi0GwMgS/KuyMZhdWvGi8HSR60e1j0MjB4Mfu5Di+zcfchLJDjPL FoAiMmhq7qdnMcjyThtic208HAPTmZHEe8wKBHUDq5J1Doo3KvfhfSDwuZUc5JbfGWAS WGRwAbGjWf+DIWJiTESL/LobaFFvBk2w6N7SrcSlgdGH+aR/2sIyRn4ktmGDZ1z9jCJC 9bRTdlcBfnjeOhxqrTlLdOctzmBOx1LZBidEyB3PkjMKu7+z51K0LotQfBfZWHsEC0eT GErQ== X-Gm-Message-State: ACgBeo0VKtfr6ZDcsRupTY8sJojl2ckrlY411UKBxCkC/JIsGg8a4Z5W 5liUG2Zdzl7j/Dj5xhqzpzHGfTkjVjcwDN7Uc6orIVNw9Pg= X-Google-Smtp-Source: AA6agR6GOa4qTVncrWLhkhMwUWByIV9ipghTGrK8NQQVwfjJLcHTGhL/5PguPhvVuYJ5DnSI4tHiGABhE6S8C8Qghfw= X-Received: by 2002:a05:6870:5581:b0:11e:300:8189 with SMTP id n1-20020a056870558100b0011e03008189mr11488437oao.199.1663432431827; Sat, 17 Sep 2022 09:33:51 -0700 (PDT) MIME-Version: 1.0 References: <87sfky9yw6.fsf@gmail.com> <87v8pueyg2.fsf@tcd.ie> <87bkrlq3ar.fsf@gmail.com> <875yhmckro.fsf@gmail.com> In-Reply-To: <875yhmckro.fsf@gmail.com> From: Stefan Kangas Date: Sat, 17 Sep 2022 18:33:40 +0200 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Augusto Stoffel : > I guess we can close the ticket there and continue the discussion there. ^^^^^ ^^^^^ Should one of the above be a "here"? From unknown Sat Aug 16 13:42:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Resent-From: Augusto Stoffel Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Sep 2022 16:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: "Basil L. Contovounesios" , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= , 57725@debbugs.gnu.org Received: via spool by 57725-submit@debbugs.gnu.org id=B57725.166343276615354 (code B ref 57725); Sat, 17 Sep 2022 16:40:02 +0000 Received: (at 57725) by debbugs.gnu.org; 17 Sep 2022 16:39:26 +0000 Received: from localhost ([127.0.0.1]:47018 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZaqk-0003za-7a for submit@debbugs.gnu.org; Sat, 17 Sep 2022 12:39:26 -0400 Received: from mail-ed1-f41.google.com ([209.85.208.41]:37775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZaqg-0003zK-Q8 for 57725@debbugs.gnu.org; Sat, 17 Sep 2022 12:39:24 -0400 Received: by mail-ed1-f41.google.com with SMTP id a41so23760538edf.4 for <57725@debbugs.gnu.org>; Sat, 17 Sep 2022 09:39:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date; bh=bWwiVguE7O9peaR8mma4Zs3pS2Vzla/EvK+TMXjTCaU=; b=hIt8YybsFQzNJixnjkJpsqh+sc5hUpCrQl/k3r16yVAgC9h22/sNM9G6I4At08pCzg YQfoqU1m683YsN0f60SlDEL56yDAYTGRqdJedKqBGBuYGGk3Bs1K4FEMYTHi8ylhQRp4 kRWPn5TAwri0a7GxZIbxsJoucekqJzcz6RbAAtaElNSZlIQ1tA7qnlku6UPg7A28mIvM u3OiR2Y8/Nj7ISSBZriq2RXC+SLtGzYX4tTiwh7p5Wzz4QFpaqZTqrPtNtMu6EpBS7b7 ePppomnIxeqaJoJg/vhay+e4+lGUgl8SoAdEGAj/BWNvIE87082qCT7D8FlGInKmqT6f wLmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date; bh=bWwiVguE7O9peaR8mma4Zs3pS2Vzla/EvK+TMXjTCaU=; b=oz4/MgwO5UMjN693YVWVwzZlQdLIMVaKhP+zwn7oCXNnjNJU3SHXdIUu7A3SCPePxl WtuzbwQSzJP6QWthlCe/GQeLsKOytvhtj/VflYSLOGnXj8DqVTpmFlTQ6boVZ0ur0EOC TvZgUINi8PwRf++lp2Tof6bDeJIIxckow/b7WEBZTVs6SdWTGKXSXom5YLHL2qVmJlWK ec2XwcIQvh8pF6EMG+t5nNyQHZQ1aCnI7uX/x5EJRChhga3Xp75t5iTJuOaTdme3XcEk AzMVqF95VVkOZ6yD9o83MBaPT+cASa/ZbU4siKjZNdPQZ/1s7EeWBjqt+QemkAuqnhhW iVgQ== X-Gm-Message-State: ACrzQf1mkgKP18e9BbL2OoD8Fv0LUu7d8aSwDLsYZHRhkaUIFxuxi2WT 68tzH2LIasJ26LBjSee7Abfefojg1WDjLw== X-Google-Smtp-Source: AMsMyM5e8748rCfNqgjE5wjfEkR2q9ZsYJOnpfPc0dV8sk3j+C1litZnvF9ErUL5xOPF3B6BYk9/yQ== X-Received: by 2002:aa7:c3cd:0:b0:453:8808:c7fb with SMTP id l13-20020aa7c3cd000000b004538808c7fbmr4670447edr.426.1663432756594; Sat, 17 Sep 2022 09:39:16 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::8510]) by smtp.gmail.com with ESMTPSA id n26-20020aa7c45a000000b0044f1e64e9f4sm16093290edr.17.2022.09.17.09.39.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 17 Sep 2022 09:39:15 -0700 (PDT) From: Augusto Stoffel In-Reply-To: (Stefan Kangas's message of "Sat, 17 Sep 2022 18:33:40 +0200") References: <87sfky9yw6.fsf@gmail.com> <87v8pueyg2.fsf@tcd.ie> <87bkrlq3ar.fsf@gmail.com> <875yhmckro.fsf@gmail.com> Date: Sat, 17 Sep 2022 18:39:14 +0200 Message-ID: <87edwaarbh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) On Sat, 17 Sep 2022 at 18:33, Stefan Kangas wrote: > Augusto Stoffel : > >> I guess we can close the ticket there and continue the discussion there. > ^^^^^ ^^^^^ > > Should one of the above be a "here"? Yes, please close this ticket here at the Emacs tracker. From unknown Sat Aug 16 13:42:01 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Augusto Stoffel Subject: bug#57725: closed (Re: bug#57725: 29.0.50; eglot: Error when using :initializationOptions) Message-ID: References: <87sfky9yw6.fsf@gmail.com> X-Gnu-PR-Message: they-closed 57725 X-Gnu-PR-Package: emacs Reply-To: 57725@debbugs.gnu.org Date: Sat, 17 Sep 2022 16:42:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1663432922-15662-1" This is a multi-part message in MIME format... ------------=_1663432922-15662-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #57725: 29.0.50; eglot: Error when using :initializationOptions which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 57725@debbugs.gnu.org. --=20 57725: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D57725 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1663432922-15662-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 57725-done) by debbugs.gnu.org; 17 Sep 2022 16:41:37 +0000 Received: from localhost ([127.0.0.1]:47033 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZasq-00043z-LT for submit@debbugs.gnu.org; Sat, 17 Sep 2022 12:41:36 -0400 Received: from mail-ot1-f44.google.com ([209.85.210.44]:39863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZaso-00043n-U4 for 57725-done@debbugs.gnu.org; Sat, 17 Sep 2022 12:41:35 -0400 Received: by mail-ot1-f44.google.com with SMTP id br15-20020a056830390f00b0061c9d73b8bdso16958444otb.6 for <57725-done@debbugs.gnu.org>; Sat, 17 Sep 2022 09:41:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=mlM+JTx7bdzOBmY0XdlMD8nY7LKHac3yrgAZYBL8GGM=; b=PB1+InwGdbyyeWZ6sqTfUZgu6y9l+Z96aNbeQF5Vx3K0J0VS7qaqspy9hmT5c+dahs rlPw7zN5gQlYQnoB+23UqQ3m978Q4FnLUoZ3BqppaZ7nEav1LfLebGIRCgldb856Pf/A 8jeD+YDOCyTBsjPyWIpD1OgoX5AL6/Qy1NGXayF0fkgxq72h6q4Irn+wGPDSgDng+SRY fMvzm5lP7aQzUJEw74NS+yOl1PYSJA/J7K57vAFZpVgwR8LqLybaBsusfxQsamTdr3v9 Sj8q0TsPeJZnstYyyoHdXhZxy3EmkTw3ZKiSepPTqYpIVQGvkKTbK3FI6N7nEHUVWyCg 2QYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=mlM+JTx7bdzOBmY0XdlMD8nY7LKHac3yrgAZYBL8GGM=; b=NpqlJRobSUC1uyJvaiiFW1FwqV/BYW60c2YIxo3OC8EmyWgt0AchLojvoaNNLmzLFG KaWfOhExstS0VkPHIyTcDaQ4IOmvpiQyS2RFkJsqbuT5V8FwVnn6aInEP8KPa8BVRLvt 4nD3y/jIpjsCUQwnHC/Ai8j2Xep6Dr+wY88sp3Zf0PeJKYAdwqd7zBeDcNguf0ksAwhF LqLVzT0i6Poy0sigpsgPxBV8YkODNSjGyKdVQYFp6wx08IC9Xsk/B3Zsh/RC7x3S2PKj 7liIkhnT4C3435BxLGjeyihcSfvIoYHMCUc0+SynduLD8EMON92tWa1N394WCse8guaL K6Sw== X-Gm-Message-State: ACrzQf2ZeCIdu9nZ2MXa1r+P5BwKf1nWEb0GjouXMWA35slM4eZQMETg ChKtLOoXgS3BCMow9rw8Bbn1PiNV1hkjkzinISJcdb0R X-Google-Smtp-Source: AMsMyM6/pIRKircQkllGJUN82WpvFK8Oj6h7ZQW/jE0h2lcoXg4gKJlod0I2xdocY2qzdErO4oc3mhYNnC3Q9NNKMHA= X-Received: by 2002:a05:6830:3c1:b0:637:28be:7920 with SMTP id p1-20020a05683003c100b0063728be7920mr4624679otc.105.1663432889418; Sat, 17 Sep 2022 09:41:29 -0700 (PDT) MIME-Version: 1.0 References: <87sfky9yw6.fsf@gmail.com> <87v8pueyg2.fsf@tcd.ie> <87bkrlq3ar.fsf@gmail.com> <875yhmckro.fsf@gmail.com> <87edwaarbh.fsf@gmail.com> In-Reply-To: <87edwaarbh.fsf@gmail.com> From: Stefan Kangas Date: Sat, 17 Sep 2022 18:41:17 +0200 Message-ID: Subject: Re: bug#57725: 29.0.50; eglot: Error when using :initializationOptions To: Augusto Stoffel Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 57725-done Cc: "Basil L. Contovounesios" , 57725-done@debbugs.gnu.org, =?UTF-8?B?Sm/Do28gVMOhdm9yYQ==?= X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Augusto Stoffel writes: > Yes, please close this ticket here at the Emacs tracker. Done. ------------=_1663432922-15662-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 11 Sep 2022 07:03:01 +0000 Received: from localhost ([127.0.0.1]:40662 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXGzd-0002qx-9l for submit@debbugs.gnu.org; Sun, 11 Sep 2022 03:03:01 -0400 Received: from lists.gnu.org ([209.51.188.17]:34890) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXGzX-0002ql-Uy for submit@debbugs.gnu.org; Sun, 11 Sep 2022 03:03:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46168) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXGzX-0005Pq-LV for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 03:02:55 -0400 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]:35388) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oXGzV-0000pA-VZ for bug-gnu-emacs@gnu.org; Sun, 11 Sep 2022 03:02:55 -0400 Received: by mail-ej1-x630.google.com with SMTP id go34so13411600ejc.2 for ; Sun, 11 Sep 2022 00:02:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from:from:to:cc :subject:date; bh=bgkWE3UNUJzYYCH3SSn80o9ux6kLomFLAYicw9dWN+8=; b=UUe8jUCrtP3ChAq1y8uVsKNVGZ30fZe+sqCj26VSj3EJZjCaCaipNEvYOVptQCl1k/ SqZ80p0caGAD7hc1AV7gd2c1ZO9F5B20mPupwMzNjQ9V232eZFl8Y6kFIPbeNQ80xg3A ymims+NpPFbVKjZPoy4rUlSXwTZlu/NuZAUe2nVArG524+c0mpS+wTY0KxJa9bi2u3jS 3aMzq4DEBUODhNACOgqljpEC3pkIzOR3ylHvlzttqxp4YGeEtllhGIckbNhiwAVOqILj daE1xk3FUfrc5WdC/SCSPSNO9iIPDqdcwRzhHp8QXUCUrQYoglE4KjYnCx4k0KMBW/dk KqJQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:date:subject:to:from :x-gm-message-state:from:to:cc:subject:date; bh=bgkWE3UNUJzYYCH3SSn80o9ux6kLomFLAYicw9dWN+8=; b=O1gtcERdbq7UGvH/OdBcsZhDExX9fFELnfJMzDGa1epyPWnh6Z4w9xhXXHET7vRIL1 YM7nxAaI1OcUcf8Rr7tenOYMgtvMl+2XbLc7L0N83FRT0GAWWcg8maD3R6U1xQ2GB2I2 5mrRIIoxvfJRsvuWLxqCST0nuTVJhmLlbG9BLLG86b5mBscvb/AofgIAtabg1Jt1ArGZ R8WoMo8kK7ArPbO82irtfHwVZd8Mw7U0FMKmI7+/v3KAY7JXyL23eVgD4oj2oq4nVC7X p+s/xR93Vsq/VqvbtVntuXvN/5zC50aRkh4o3p7lH7iowpmVSD0CXs7Js0a2NyaWN2lG Xwgg== X-Gm-Message-State: ACgBeo2pzMfK1uXkMA2sL1Z1keEZjnuayAb1hBnWTQrsZlRFYJiTTUuE azWX8BTxFQUdc95pnAYFB96R8oFkk/Q= X-Google-Smtp-Source: AA6agR5Iy89MM1srzBMVMNr43SFT9Gy/RaXzgchR58RLtw9kdYKxAQSUeCxW+jI67uqIOcoSA27Qzw== X-Received: by 2002:a17:907:75c7:b0:779:bf7:9be7 with SMTP id jl7-20020a17090775c700b007790bf79be7mr9152267ejc.432.1662879771427; Sun, 11 Sep 2022 00:02:51 -0700 (PDT) Received: from ars3 ([2a02:8109:8ac0:56d0::157b]) by smtp.gmail.com with ESMTPSA id g2-20020a50ec02000000b0043bea0a48d0sm3472434edr.22.2022.09.11.00.02.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 11 Sep 2022 00:02:50 -0700 (PDT) From: Augusto Stoffel To: bug-gnu-emacs@gnu.org Subject: 29.0.50; eglot: Error when using :initializationOptions X-Debbugs-CC: =?utf-8?B?Sm/Do28gVMOhdm9yYQ==?= Date: Sun, 11 Sep 2022 09:02:49 +0200 Message-ID: <87sfky9yw6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=2a00:1450:4864:20::630; envelope-from=arstoffel@gmail.com; helo=mail-ej1-x630.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) If I attempt to pass :initializationOptions to a server like so: (setf (alist-get 'python-mode eglot-server-programs) '("jedi-language-server" :initializationOptions eglot--{})) I get an error: Debugger entered--Lisp error: (invalid-slot-name "#" :initializationOptions) A workaround is to add this to the eglot-lsp-server defclass: @@ -788,6 +788,7 @@ treated as in `eglot-dbind'." (managed-buffers :documentation "List of buffers managed by server." :accessor eglot--managed-buffers) + (_ :initarg :initializationOptions) (saved-initargs :documentation "Saved initargs for reconnection purposes." :accessor eglot--saved-initargs) I can also confirm that after the workaround, the options are passed correctly to the server upon initialization. ------------=_1663432922-15662-1-- From unknown Sat Aug 16 13:42:01 2025 X-Loop: help-debbugs@gnu.org Subject: bug#57725: 29.0.50; eglot: Error when using :initializationOptions Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 17 Sep 2022 19:09:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57725 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Stefan Kangas Cc: "Basil L. Contovounesios" , 57725-done@debbugs.gnu.org, Augusto Stoffel Received: via spool by 57725-done@debbugs.gnu.org id=D57725.16634417135939 (code D ref 57725); Sat, 17 Sep 2022 19:09:02 +0000 Received: (at 57725-done) by debbugs.gnu.org; 17 Sep 2022 19:08:33 +0000 Received: from localhost ([127.0.0.1]:47210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZdB2-0001Xj-PN for submit@debbugs.gnu.org; Sat, 17 Sep 2022 15:08:33 -0400 Received: from mail-il1-f173.google.com ([209.85.166.173]:43563) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oZdB0-0001XV-A2 for 57725-done@debbugs.gnu.org; Sat, 17 Sep 2022 15:08:32 -0400 Received: by mail-il1-f173.google.com with SMTP id x2so6690524ill.10 for <57725-done@debbugs.gnu.org>; Sat, 17 Sep 2022 12:08:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=5az4ZKmg+cmL2pHy/D21fSV40k99blOfk2aCDwLpXZY=; b=p+KeRflsCvFHXk/+TMmi7Tlwnl0gWEv5/m82SzyoDn+iuIFLt+zpOcmhINmV+ulnFc GQwkC9c1qqRBBt0XkpXIRYdmQQrV8+6KX3jPaPlk6ZIoRcHewO4/byKTQby+ZY9gHK+6 ELZMmRpAi1fgAAUECfyZl0vyaP7DB+ybawpXNQtQLOQaEqN8q59ttV0paSPogt441p4S 5DefRsRcQM22f8oZcDuqvcR6BE4l3Avl4OIUSFnEcQVyL5SZbeVbeQ5Jts48WQhxHCY1 ybPUZZWnW/Rz/cmYKkosE/QlLbey6ZLq5uC6bGypM1kMi4aRXX7dWoY+GOzmc+QI0h6L JlTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=5az4ZKmg+cmL2pHy/D21fSV40k99blOfk2aCDwLpXZY=; b=FykSwaLAM5zTds+SGaElFSoy3yH1dBJtocxAF86+bgnrJys2Osaf6Rq+Pmxffv7YTp x+DX2wHgpEeAjE8eMCiEO3kq3bHu6b0f8j9aq5Cu2sXUjjDwUjkIeGA7cTTkNbBq1gsa TV8ka5T3RRBkeZDqRnysg3rSa9YsJ2rLnxuMANLRyfw7+kgsmOdmBLL7YJnaMXeLg7w/ cFelfpCO7Q5Xx697TZplbBvgkZfm1x/f4zptPkiYXz4LK98Huu0HOTWmXaX8uIzEkOc2 u2nns8+mRsLNsoaxPXLNpnNoo5YVpnbwITM0SjHIhfpGblq1nfRj20eKJi+3wfCvwwVp R1gw== X-Gm-Message-State: ACrzQf1n4r/e+ZoSZaAHwrgx3GKSDmYbj5oOv270T9uh+Q50sKbs52aG 6VXLDiYdRsdP5mIKk0allw0tpFLZSCA3nfXaoFE= X-Google-Smtp-Source: AMsMyM7Puu3rwBo+b3DXB5EQDBx0B79s563KcvYouyx2iJGkr+uA/cxsew4h7z8LNW3arAAb0ytsZ5ch7WFccoYHFDs= X-Received: by 2002:a05:6e02:164d:b0:2f1:9b43:9157 with SMTP id v13-20020a056e02164d00b002f19b439157mr4540075ilu.94.1663441704723; Sat, 17 Sep 2022 12:08:24 -0700 (PDT) MIME-Version: 1.0 References: <87sfky9yw6.fsf@gmail.com> <87v8pueyg2.fsf@tcd.ie> <87bkrlq3ar.fsf@gmail.com> <875yhmckro.fsf@gmail.com> <87edwaarbh.fsf@gmail.com> In-Reply-To: From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Date: Sat, 17 Sep 2022 20:09:25 +0100 Message-ID: Content-Type: multipart/alternative; boundary="000000000000ea29ec05e8e433ed" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000ea29ec05e8e433ed Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable In the future, I would suggest the other direction. Ask me or Stefan to close the ticket at the Eglot tracker. Anyway, I think this two-liner patch fixes the problem and doesn't have any unintended side-effects for M-x eglot-reconnect. diff --git a/eglot.el b/eglot.el index ff94d5ca5f..3b1b1a9536 100644 --- a/eglot.el +++ b/eglot.el @@ -796,6 +796,8 @@ treated as in `eglot-dbind'." :documentation "Represents a server. Wraps a process for LSP communication.") +(cl-defmethod initialize-instance :before ((_server eglot-lsp-server) &optional args) + (cl-remf args :initializationOptions)) ;;; Process management (defvar eglot--servers-by-project (make-hash-table :test #'equal) On Sat, Sep 17, 2022 at 5:41 PM Stefan Kangas wrote: > Augusto Stoffel writes: > > > Yes, please close this ticket here at the Emacs tracker. > > Done. > --=20 Jo=C3=A3o T=C3=A1vora --000000000000ea29ec05e8e433ed Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
In the future, I would suggest the other direction.= =C2=A0 Ask me or Stefan to close the ticket at the Eglot tracker.

Anyway, I think this two-liner patch fixes the problem and = doesn't have any unintended side-effects for M-x eglot-reconnect.
=

diff --git a/eglot.el b/eglot.el
index ff94d5ca5f..3= b1b1a9536 100644
--- a/eglot.el
+++ b/eglot.el
@@ -796,6 +796,8 @@= treated as in `eglot-dbind'."
=C2=A0 =C2=A0:documentation
= =C2=A0 =C2=A0"Represents a server. Wraps a process for LSP communicati= on.")
=C2=A0
+(cl-defmethod initialize-instance :before ((_serve= r eglot-lsp-server) &optional args)
+ =C2=A0(cl-remf args :initializ= ationOptions))
=C2=A0
=C2=A0;;; Process management
=C2=A0(defvar e= glot--servers-by-project (make-hash-table :test #'equal)
On Sat, S= ep 17, 2022 at 5:41 PM Stefan Kangas <stefankangas@gmail.com> wrote:
Augusto Stoffel <arstoffel@gmail.com> writes:

> Yes, please close this ticket here at the Emacs tracker.

Done.


--
Jo=C3=A3o T=C3=A1vora
--000000000000ea29ec05e8e433ed--