From unknown Sat Jun 14 03:53:56 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57717] [DRAFT PATCH core-updates] build-systems: Pass #:allowed-references and #:disallowed-references to builders. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-CC: ludo@gnu.org, guix-patches@gnu.org Resent-Date: Sat, 10 Sep 2022 15:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 57717 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 57717@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= X-Debbugs-Original-To: guix-patches@gnu.org X-Debbugs-Original-Xcc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by submit@debbugs.gnu.org id=B.166282357211023 (code B ref -1); Sat, 10 Sep 2022 15:27:02 +0000 Received: (at submit) by debbugs.gnu.org; 10 Sep 2022 15:26:12 +0000 Received: from localhost ([127.0.0.1]:40210 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oX2N2-0002rj-Ak for submit@debbugs.gnu.org; Sat, 10 Sep 2022 11:26:12 -0400 Received: from lists.gnu.org ([209.51.188.17]:40254) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oX2Mz-0002rZ-8Z for submit@debbugs.gnu.org; Sat, 10 Sep 2022 11:26:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52636) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oX2Mz-0000H0-33 for guix-patches@gnu.org; Sat, 10 Sep 2022 11:26:09 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36130) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oX2My-00069U-Oq for guix-patches@gnu.org; Sat, 10 Sep 2022 11:26:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:Subject:To:From:in-reply-to: references; bh=ReO0TDOvcb5ioq6B4mcTOYq80LTlejtK2Mu18OOeOB4=; b=dlgcpYmxPZCWfo 7dny03OhiofL8upngwtcM5DcmVdZgUJHwiiiX9Aoi0iyYE0GSljvQiA3LpD13ObnWjqD+GZcrDbgq iQ8T8zAx4hGlBL9/YGLKbWPzZ2Tg2xbON9KqOrKHLzRqKHt7B+0LNHMB4a5EycDrACLFHybqG5pnl B9Fle3snrjYFFo4nYichh7choexZAIk4OSmuPPfa9hGTF0Jn9H2YwDbhnch7bqcGzxwYKc5rRZ+20 bXtcDj+wxr2pBjMzY247SWg6z+ri8TTdbbBn6sTFqwXTsut22pdqzaRbGbnQq9B3PwgB/jhAxSTGP gEA89ZonKX/+C8fEdCSg==; Received: from [84.214.173.6] (port=58818 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oX2My-0001f6-4w for guix-patches@gnu.org; Sat, 10 Sep 2022 11:26:08 -0400 From: Marius Bakke Date: Sat, 10 Sep 2022 17:26:04 +0200 Message-Id: <20220910152604.3459-1-marius@gnu.org> X-Mailer: git-send-email 2.37.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * guix/build-system/gnu.scm (gnu-build, gnu-cross-build)[builder]: Pass along #:allowed-references and #:disallowed-references. * guix/build-system/meson.scm (meson-build, meson-cross-build)[builder]: Likewise. --- Hello Guix, This is an untested patch that makes #:allowed-references and #:disallowed-references available to build-side code. The intention is to make it easier to use these properties directly when e.g. wrapping. Consider the following: --8<---------------cut here---------------start------------->8--- (arguments (list #:disallowed-references (list (gexp-input glib "bin") (gexp-input inkscape/stable)) #:phases #~(modify-phases %standard-phases (replace 'glib-or-gtk-wrap (let ((wrap (assoc-ref %standard-phases 'glib-or-gtk-wrap))) (lambda* (#:key inputs outputs disallowed-references #:allow-other-keys) (wrap #:inputs (filter (match-lambda ((label . output) (not (member output disallowed-references)))) inputs) #:outputs outputs))))))) --8<---------------cut here---------------end--------------->8--- This way we don't have to build the list of disallowed references twice, which is difficult without labels in the case of e.g. `(,glib "bin"). Note: I implemented a variant of this approach using a let-binding in f0114656876dcf2e09874e4ea0c00cacf31f1bb2, perhaps that is "good enough" as this approach is unlikely to be much used. WDYT? I'll implement this for the remaining build systems if this is at all sane. --- diff --git a/guix/build-system/gnu.scm b/guix/build-system/gnu.scm index 8eea1cd4c2..f85a172153 100644 --- a/guix/build-system/gnu.scm +++ b/guix/build-system/gnu.scm @@ -393,6 +393,8 @@ (define builder #:build #$build #:outputs %outputs #:inputs %build-inputs + #:allowed-references #$allowed-references + #:disallowed-references #$disallowed-references #:search-paths '#$(sexp->gexp (map search-path-specification->sexp search-paths)) @@ -531,6 +533,8 @@ (define %outputs #:target #$target #:outputs %outputs #:inputs %build-target-inputs + #:allowed-references #$allowed-references + #:disallowed-references #$disallowed-references #:native-inputs %build-host-inputs #:search-paths '#$(sexp->gexp (map search-path-specification->sexp diff --git a/guix/build-system/meson.scm b/guix/build-system/meson.scm index 9fee6c4570..1bef07230f 100644 --- a/guix/build-system/meson.scm +++ b/guix/build-system/meson.scm @@ -210,6 +210,8 @@ (define build-phases #$(with-build-variables inputs outputs #~(meson-build #:source #+source #:system #$system + #:allowed-references #$allowed-references + #:disallowed-references #$disallowed-references #:outputs %outputs #:inputs %build-inputs #:search-paths '#$(sexp->gexp @@ -318,6 +320,8 @@ (define build-phases #:system #$system #:build #$(nix-system->gnu-triplet system) #:target #$target + #:allowed-references #$allowed-references + #:disallowed-references #$disallowed-references #:outputs #$(outputs->gexp outputs) #:inputs #$inputs #:native-inputs #+(input-tuples->gexp build-inputs) -- 2.37.3 From unknown Sat Jun 14 03:53:56 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57717] [DRAFT PATCH core-updates] build-systems: Pass #:allowed-references and #:disallowed-references to builders. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 10 Sep 2022 16:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57717 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 57717@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 57717-submit@debbugs.gnu.org id=B57717.166282723216813 (code B ref 57717); Sat, 10 Sep 2022 16:28:01 +0000 Received: (at 57717) by debbugs.gnu.org; 10 Sep 2022 16:27:12 +0000 Received: from localhost ([127.0.0.1]:40258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oX3K3-0004N7-VY for submit@debbugs.gnu.org; Sat, 10 Sep 2022 12:27:12 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:43884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oX3K1-0004Mv-Kq for 57717@debbugs.gnu.org; Sat, 10 Sep 2022 12:27:10 -0400 Received: from [192.168.45.79] ([188.189.47.0]) by andre.telenet-ops.be with bizsmtp id JGT42800P00EV6401GT5aS; Sat, 10 Sep 2022 18:27:07 +0200 Message-ID: Date: Sat, 10 Sep 2022 18:27:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US References: <20220910152604.3459-1-marius@gnu.org> From: Maxime Devos In-Reply-To: <20220910152604.3459-1-marius@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------CotzGWE0Xu3skZUaXu2SJp8s" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1662827228; bh=N5/L1NiAsVP726dbSPJpCJuu+qvS2o9ffloPtUJTacA=; h=Date:To:Cc:References:From:Subject:In-Reply-To; b=nRfdR531uqKd3ynAVNt+XQsKSJwhTOYzwp/rc3OoQAy1B37FmpzUkK+kgOUAoauGm Z9gTgXvOnj14y0/mIefFLvJYwQBhdqWEPEepSWut7CUdD9Dk4VNgPnAVeDNaqErJVx X7+UvUQ5p/AFUB0PwcC4xXDXiGlgHR7C6af4ge+JS3zVZNQ8xMrWFfOkRlLDG8r5jj fKd/FVSlY7cUm6DkGZijPY4LZ9BLbovRg85fbt6eKO7TufpnCRMEsCxeJp7E6UwNGc UTFEfLcIEH8r4Jqm9CHgRCWkmKhn0RFoWxMxN5sWOKRdTvxHVIBV8MNSHig0pYxM1x 2owOmlO8ncU3g== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------CotzGWE0Xu3skZUaXu2SJp8s Content-Type: multipart/mixed; boundary="------------7spnG0s3nzOa20BTfjYkiNch"; protected-headers="v1" From: Maxime Devos To: Marius Bakke , 57717@debbugs.gnu.org Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Message-ID: Subject: Re: [bug#57717] [DRAFT PATCH core-updates] build-systems: Pass #:allowed-references and #:disallowed-references to builders. References: <20220910152604.3459-1-marius@gnu.org> In-Reply-To: <20220910152604.3459-1-marius@gnu.org> --------------7spnG0s3nzOa20BTfjYkiNch Content-Type: multipart/mixed; boundary="------------0w0yowswJSc5MNWdA1exNVb0" --------------0w0yowswJSc5MNWdA1exNVb0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQoNCk9uIDEwLTA5LTIwMjIgMTc6MjYsIE1hcml1cyBCYWtrZSB3cm90ZToNCj4gVGhpcyB3 YXkgd2UgZG9uJ3QgaGF2ZSB0byBidWlsZCB0aGUgbGlzdCBvZiBkaXNhbGxvd2VkIHJlZmVy ZW5jZXMgdHdpY2UsDQo+IHdoaWNoIGlzIGRpZmZpY3VsdCB3aXRob3V0IGxhYmVscyBpbiB0 aGUgY2FzZSBvZiBlLmcuIGAoLGdsaWIgImJpbiIpLg0KPiANCj4gTm90ZTogSSBpbXBsZW1l bnRlZCBhIHZhcmlhbnQgb2YgdGhpcyBhcHByb2FjaCB1c2luZyBhIGxldC1iaW5kaW5nIGlu DQo+IGYwMTE0NjU2ODc2ZGNmMmUwOTg3NGU0ZWEwYzAwY2FjZjMxZjFiYjIsIHBlcmhhcHMg dGhhdCBpcyAiZ29vZCBlbm91Z2giDQo+IGFzIHRoaXMgYXBwcm9hY2ggaXMgdW5saWtlbHkg dG8gYmUgbXVjaCB1c2VkLg0KPiANCj4gV0RZVD8gIEknbGwgaW1wbGVtZW50IHRoaXMgZm9y IHRoZSByZW1haW5pbmcgYnVpbGQgc3lzdGVtcyBpZiB0aGlzIGlzIGF0DQo+IGFsbCBzYW5l Lg0KDQpBIGNhdmVhdCB3aXRoIHVzaW5nICM6ZGlzYWxsb3dlZC1yZWZlcmVuY2VzIHRoaXMg d2F5IC0tIEFGQUlLLCBpdCBpcyANCnVuZG9jdW1lbnRlZCB3aGV0aGVyICM6ZGlzYWxsb3dl ZC1yZWZlcmVuY2VzIGdvZXMgZm9yIGEgbmF0aXZlIGJ1aWxkIG9yIA0KYSBjcm9zcy1idWls ZC4gIFRoZSBpbnRlbnRpb24gaXMgdG8gc3RvcCB0aGUgKG5hdGl2ZWx5LSljb21waWxlZCAN CnB5dGhvbi1zb21lLXRlc3RpbmctbGlicmFyeSBmcm9tIGFwcGVhcmluZyBpbiB0aGUgd3Jh cHBlcnMsIHN0b3BwaW5nIGEgDQpjcm9zcy1jb21waWxlZCBweXRob24tc29tZS10ZXN0aW5n LWxpYnJhcnkuDQoNCkRlcGVuZGluZyBvbiB3aGF0LCBleGFjdGx5LCB0aGUgYmVoYXZpb3Vy IG9mICM6ZGlzYWxsb3dlZC1yZWZlcmVuY2VzIGlzLCANCml0IG1heSBiZSBuZWNlc3Nhcnkg dG8g4oCYb3ZlcnJpZGXigJkgd2hldGhlciB0byBkaXNhbGxvdyB0aGUgbmF0aXZlLSBvciB0 aGUgDQpjcm9zcy12ZXJzaW9uLg0KDQpUbyBkbyBzbywgSSB1c2VkICdnZXhwLWlucHV0JyB3 aXRoICM6bmF0aXZlPyAjdHJ1ZSBpbiAoZ251IHBhY2thZ2VzIA0KZ2xpYikgKG1heWJlIHRo YXQgd2FzIHVubmVjZXNzYXJ5LCBidXQgSSB3YXMgdGhpbmtpbmcgYmV0dGVyIGJlIGV4cGxp Y2l0IA0KdGhhbiBpbXBsaWNpdCBoZXJlIC4uLikuDQoNCkFuIGFsdGVybmF0aXZlIHNvbHV0 aW9uIGNvdWxkIGJlIHRvIHNwbGl0ICM6ZGlzYWxsb3dlZC1yZWZlcmVuY2UgaW4gdHdvLCAN CmUuZy4gIzpkaXNhbGxvd2VkLXJlZmVyZW5jZXMvc3lzdGVtIGFuZCAjOmRpc2FsbG93ZWQt cmVmZXJlbmNlcy90YXJnZXQsIA0KdG8gcHJldmVudCBhY2NpZGVudHMuDQoNCkdyZWV0aW5n cywNCk1heGltZS4NCg== --------------0w0yowswJSc5MNWdA1exNVb0 Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------0w0yowswJSc5MNWdA1exNVb0-- --------------7spnG0s3nzOa20BTfjYkiNch-- --------------CotzGWE0Xu3skZUaXu2SJp8s Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYxy61wUDAAAAAAAKCRBJ4+4iGRcl7hEv AQCv9tgwrLpPabO/ibGNODMT+slfPIjvCpu6Ne38UyuouwD/VnqAxXucdJVOhaYy9Gwd4W5neLfi 4R/0gDr6k3/0Ggs= =8hwk -----END PGP SIGNATURE----- --------------CotzGWE0Xu3skZUaXu2SJp8s-- From unknown Sat Jun 14 03:53:56 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57717] [DRAFT PATCH core-updates] build-systems: Pass #:allowed-references and #:disallowed-references to builders. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 10 Sep 2022 16:33:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57717 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 57717@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 57717-submit@debbugs.gnu.org id=B57717.166282755917374 (code B ref 57717); Sat, 10 Sep 2022 16:33:02 +0000 Received: (at 57717) by debbugs.gnu.org; 10 Sep 2022 16:32:39 +0000 Received: from localhost ([127.0.0.1]:40263 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oX3PK-0004WA-Mv for submit@debbugs.gnu.org; Sat, 10 Sep 2022 12:32:38 -0400 Received: from andre.telenet-ops.be ([195.130.132.53]:49594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oX3PI-0004W2-UN for 57717@debbugs.gnu.org; Sat, 10 Sep 2022 12:32:37 -0400 Received: from [192.168.45.79] ([188.189.47.0]) by andre.telenet-ops.be with bizsmtp id JGYX2800100EV6401GYXaQ; Sat, 10 Sep 2022 18:32:34 +0200 Message-ID: <0e685c25-bbd1-13e0-799f-0fa78044e6c4@telenet.be> Date: Sat, 10 Sep 2022 18:32:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US References: <20220910152604.3459-1-marius@gnu.org> From: Maxime Devos In-Reply-To: <20220910152604.3459-1-marius@gnu.org> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------g3KcCKMozYYgYZ6gJUTud77w" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1662827554; bh=Hbgd0XAGsc1KRaBw5FM1e3jrNgv934B8nC/syWNuPvo=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=J3A4C8FIku5YJ2wCeS/Ku+EMYy3ZJ4BPvVe/X/1kkq1UyOph4By8nf0ZNmE+LGexi +ngwUs+DWuxZwimvq2P31a0tdxXpzHHzjXJoveZjxTfjQmHvZ+PiBu8tFtylQrVF+B ZN3AH/Ap77bVhbI4icRjndIVp4yszI8yDwFNlQxf2mjH5BQ3rPq2KlFoSP0ermMUxr tNQl95o24REVEoegjh+Txj8yVjWjKBP7app+QI1WX6s3lx0wz0wCyqLnnsv4jDgYxF lWFHDfq8bFK2CZS4RIixGZyl1pOozB0aU+YMVe1SZAKzAw8iK0mRdaGA0rhYjSrh+c YLwIQ2x8TCncg== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------g3KcCKMozYYgYZ6gJUTud77w Content-Type: multipart/mixed; boundary="------------BmIyTaEAi1KOeQMWP569OX2T"; protected-headers="v1" From: Maxime Devos To: Marius Bakke , 57717@debbugs.gnu.org Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Message-ID: <0e685c25-bbd1-13e0-799f-0fa78044e6c4@telenet.be> Subject: Re: [bug#57717] [DRAFT PATCH core-updates] build-systems: Pass #:allowed-references and #:disallowed-references to builders. References: <20220910152604.3459-1-marius@gnu.org> In-Reply-To: <20220910152604.3459-1-marius@gnu.org> --------------BmIyTaEAi1KOeQMWP569OX2T Content-Type: multipart/mixed; boundary="------------gcPGDKqHmrpEsK2HC8wueKOm" --------------gcPGDKqHmrpEsK2HC8wueKOm Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQoNCk9uIDEwLTA5LTIwMjIgMTc6MjYsIE1hcml1cyBCYWtrZSB3cm90ZToNCj4gKyAgICAg ICAgICAgICAgICAgICAgICAgICAgICM6YWxsb3dlZC1yZWZlcmVuY2VzICMkYWxsb3dlZC1y ZWZlcmVuY2VzDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICAgICAjOmRpc2FsbG93ZWQt cmVmZXJlbmNlcyAjJGRpc2FsbG93ZWQtcmVmZXJlbmNlcw0KDQpVbmxlc3MgSSdtIG1pc3Rh a2VuIChJIGhhdmVuJ3QgdGVzdGVkIHRoaXMpLCB0aGlzIHdpbGwgYmVjb21lIA0KIzphbGxv d2VkLXJlZmVyZW5jZXMgKCIvZ251L3N0b3JlLy4uLiIgLi4uKSAtLSBpdCB0cmllcyB0byB1 c2UgYSBzdHJpbmcgDQphcyBhIHByb2NlZHVyZS4gIFByb3Bvc2FsOg0KDQojOmFsbG93ZWQt cmVmZXJlbmNlcyAobGlzdCAjJGFsbG93ZWQtcmVmZXJlbmNlcykNCiM6ZGlzYWxsb3dlZC1y ZWZlcmVuY2VzIChsaXN0ICMkZGlzYWxsb3dlZC1yZWZlcmVuY2VzKQ0KDQpHcmVldGluZ3Ms DQpNYXhpbWUuDQo= --------------gcPGDKqHmrpEsK2HC8wueKOm Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------gcPGDKqHmrpEsK2HC8wueKOm-- --------------BmIyTaEAi1KOeQMWP569OX2T-- --------------g3KcCKMozYYgYZ6gJUTud77w Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYxy8HgUDAAAAAAAKCRBJ4+4iGRcl7mwg AQC3GeQlYm+UFufBcpdx3aFv90e156QmSR6ACvpvvnZYhwD+PKMpwyhljfQbNpUMC+vJFRZUO2mK nYbTI7i43WGXkA8= =BFD0 -----END PGP SIGNATURE----- --------------g3KcCKMozYYgYZ6gJUTud77w-- From unknown Sat Jun 14 03:53:56 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57717] [DRAFT PATCH core-updates] build-systems: Pass #:allowed-references and #:disallowed-references to builders. Resent-From: Maxime Devos Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 10 Sep 2022 16:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57717 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke , 57717@debbugs.gnu.org Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= Received: via spool by 57717-submit@debbugs.gnu.org id=B57717.166282770417607 (code B ref 57717); Sat, 10 Sep 2022 16:36:02 +0000 Received: (at 57717) by debbugs.gnu.org; 10 Sep 2022 16:35:04 +0000 Received: from localhost ([127.0.0.1]:40270 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oX3Rg-0004Zu-4s for submit@debbugs.gnu.org; Sat, 10 Sep 2022 12:35:04 -0400 Received: from xavier.telenet-ops.be ([195.130.132.52]:40960) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oX3Rd-0004ZJ-Ej for 57717@debbugs.gnu.org; Sat, 10 Sep 2022 12:35:03 -0400 Received: from [192.168.45.79] ([188.189.47.0]) by xavier.telenet-ops.be with bizsmtp id JGay2800400EV6401GazjK; Sat, 10 Sep 2022 18:35:00 +0200 Message-ID: <0ee62f18-2449-6fc8-fbc2-7c897975edaa@telenet.be> Date: Sat, 10 Sep 2022 18:34:57 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Content-Language: en-US From: Maxime Devos References: <20220910152604.3459-1-marius@gnu.org> <0e685c25-bbd1-13e0-799f-0fa78044e6c4@telenet.be> In-Reply-To: <0e685c25-bbd1-13e0-799f-0fa78044e6c4@telenet.be> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------x0O9A3er7o3Znq3ENZiJpG35" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r22; t=1662827700; bh=ORhA4ESBhsiwmZNrXaxNDyb5zzTvmf4AHnOyT44beow=; h=Date:Subject:From:To:Cc:References:In-Reply-To; b=T2NJNaOA80XE6vBn7aHtqnQNooQ2WWj2xJ4Qr9QZWTIYZpOfSoZRiwEa4LziDMD2D xGL0bqEJmoZvwyqoi6Q7LqBhAn48pwABlcfYBA5ReCMvZlvUyhwWbDOzUNZZLTPpEX C9bDiANkSoR/kLFcMUp2l5yOkakWupTynhw5Z9IlB+y5E7srWSywZ5+Gkog08UVnCp Rk54uuhG/bHWihq7i2nqtpKJ8qiN+Q/JOQU9D+hsOsxnQacm4Dn50HpY/ApU8Ac4kb UUpmN4DbHjKS31wPNkzlPVY00ixLNF6ZB8qmcC4QD8rfL98rzQ+BCRCEk67lBAcbpH h/84TeM7dlcxQ== X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------x0O9A3er7o3Znq3ENZiJpG35 Content-Type: multipart/mixed; boundary="------------w6BPGA0IK0xc5GpCfDRUI018"; protected-headers="v1" From: Maxime Devos To: Marius Bakke , 57717@debbugs.gnu.org Cc: =?UTF-8?Q?Ludovic_Court=c3=a8s?= Message-ID: <0ee62f18-2449-6fc8-fbc2-7c897975edaa@telenet.be> Subject: Re: [bug#57717] [DRAFT PATCH core-updates] build-systems: Pass #:allowed-references and #:disallowed-references to builders. References: <20220910152604.3459-1-marius@gnu.org> <0e685c25-bbd1-13e0-799f-0fa78044e6c4@telenet.be> In-Reply-To: <0e685c25-bbd1-13e0-799f-0fa78044e6c4@telenet.be> --------------w6BPGA0IK0xc5GpCfDRUI018 Content-Type: multipart/mixed; boundary="------------nt2QE0Fm6kganyjyv90Cx0Pp" --------------nt2QE0Fm6kganyjyv90Cx0Pp Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 DQoNCk9uIDEwLTA5LTIwMjIgMTg6MzIsIE1heGltZSBEZXZvcyB3cm90ZToNCj4gDQo+IA0K PiBPbiAxMC0wOS0yMDIyIDE3OjI2LCBNYXJpdXMgQmFra2Ugd3JvdGU6DQo+PiArwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAjOmFsbG93 ZWQtcmVmZXJlbmNlcyAjJGFsbG93ZWQtcmVmZXJlbmNlcw0KPj4gK8KgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgIzpkaXNhbGxvd2VkLXJl ZmVyZW5jZXMgDQo+PiAjJGRpc2FsbG93ZWQtcmVmZXJlbmNlcw0KPiANCj4gVW5sZXNzIEkn bSBtaXN0YWtlbiAoSSBoYXZlbid0IHRlc3RlZCB0aGlzKSwgdGhpcyB3aWxsIGJlY29tZSAN Cj4gIzphbGxvd2VkLXJlZmVyZW5jZXMgKCIvZ251L3N0b3JlLy4uLiIgLi4uKSAtLSBpdCB0 cmllcyB0byB1c2UgYSBzdHJpbmcgDQo+IGFzIGEgcHJvY2VkdXJlLsKgIFByb3Bvc2FsOg0K PiANCj4gIzphbGxvd2VkLXJlZmVyZW5jZXMgKGxpc3QgIyRhbGxvd2VkLXJlZmVyZW5jZXMp DQo+ICM6ZGlzYWxsb3dlZC1yZWZlcmVuY2VzIChsaXN0ICMkZGlzYWxsb3dlZC1yZWZlcmVu Y2VzKQ0KDQpDb3JyZWN0aW9uOg0KDQojOmFsbG93ZWQtcmVmZXJlbmNlcw0KIyQoYW5kPT4g YWxsb3dlZC1yZWZlcmVuY2VzIChsYW1iZGEgKHgpICN+KGxpc3QgIyRAeCkpKQ0KIzpkaXNh bGxvd2VkLXJlZmVyZW5jZXMNCihsaXN0ICMkQGRpc2FsbG93ZWQtcmVmZXJlbmNlcykNCg0K KHNwbGljaW5nLCBhbmQgYWxsb3dlZC1yZWZlcmVuY2UgaXMgYnkgZGVmYXVsdCAjZmFsc2Up DQoNCj4gR3JlZXRpbmdzLA0KPiBNYXhpbWUuDQo= --------------nt2QE0Fm6kganyjyv90Cx0Pp Content-Type: application/pgp-keys; name="OpenPGP_0x49E3EE22191725EE.asc" Content-Disposition: attachment; filename="OpenPGP_0x49E3EE22191725EE.asc" Content-Description: OpenPGP public key Content-Transfer-Encoding: quoted-printable -----BEGIN PGP PUBLIC KEY BLOCK----- xjMEX4ch6BYJKwYBBAHaRw8BAQdANPb/d6MrGnGi5HyvODCkBUJPRjiFQcRU5V+m xvMaAa/NL01heGltZSBEZXZvcyA8bWF4aW1lLmRldm9zQHN0dWRlbnQua3VsZXV2 ZW4uYmU+wpAEExYIADgWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCX4ch6AIbAwUL CQgHAwUVCgkICwUWAgMBAAIeAQIXgAAKCRBJ4+4iGRcl7japAQC3opZ2KGWzWmRc /gIWSu0AAcfMwyinFEEPa/QhUt2CogD/e2RdF4CYAgaRHJJmZ9WU7piKbLZ7llB4 LzgezVDHggzNJU1heGltZSBEZXZvcyA8bWF4aW1lZGV2b3NAdGVsZW5ldC5iZT7C kAQTFggAOBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJf56ycAhsDBQsJCAcDBRUK CQgLBRYCAwEAAh4BAheAAAoJEEnj7iIZFyXujpQBAKV1SwDDl4f24rXciDlB9L8W ycZt30CgbewMSRQk4mvbAP9dFMbVVixYBd6C8cfhR+NsOBGiOJnQABlUmgNuqGFJ Dc44BF+HIegSCisGAQQBl1UBBQEBB0BOlzIWiJzgobMF6/cqwLaLk7jIcFSZ++c0 k9cCNT6YXwMBCAfCeAQYFggAIBYhBMHzPuIMUo/bfdcBH0nj7iIZFyXuBQJfhyHo AhsMAAoJEEnj7iIZFyXuMr0BAJc8cl5PGvVmVuSQVKjleNl4DK1/XAaPAYPe34AE fZJPAP9IqLCQhH/FeJanHqBP8gNdGNI2qn8RnnLVfRJgUjZ1BA=3D=3D =3DOVqp -----END PGP PUBLIC KEY BLOCK----- --------------nt2QE0Fm6kganyjyv90Cx0Pp-- --------------w6BPGA0IK0xc5GpCfDRUI018-- --------------x0O9A3er7o3Znq3ENZiJpG35 Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- wnsEABYIACMWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYxy8sQUDAAAAAAAKCRBJ4+4iGRcl7qnZ AQDMMMpskl1dGGi80uxaA7LMlfa246lb8RaiaLzW0uVbKgD/WN6NaRF0cEHdtsvZ2ekVMBkWGvUx PVNctZ17QuZArw4= =vFv0 -----END PGP SIGNATURE----- --------------x0O9A3er7o3Znq3ENZiJpG35-- From unknown Sat Jun 14 03:53:56 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#57717] [DRAFT PATCH core-updates] build-systems: Pass #:allowed-references and #:disallowed-references to builders. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 11 Sep 2022 14:13:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57717 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Marius Bakke Cc: 57717@debbugs.gnu.org Received: via spool by 57717-submit@debbugs.gnu.org id=B57717.16629055742901 (code B ref 57717); Sun, 11 Sep 2022 14:13:02 +0000 Received: (at 57717) by debbugs.gnu.org; 11 Sep 2022 14:12:54 +0000 Received: from localhost ([127.0.0.1]:43059 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXNhe-0000kj-2n for submit@debbugs.gnu.org; Sun, 11 Sep 2022 10:12:54 -0400 Received: from eggs.gnu.org ([209.51.188.92]:57888) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oXNhc-0000kR-ES for 57717@debbugs.gnu.org; Sun, 11 Sep 2022 10:12:52 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44970) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXNhX-0002dB-8a for 57717@debbugs.gnu.org; Sun, 11 Sep 2022 10:12:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:In-Reply-To:Date:References:Subject:To: From; bh=MR1zo65SGFyuaZG6xO7/oDMPU3pohVWVDs5tKjzqm7M=; b=DUI+08UUNk0hu+KBnG5n VJ4yb0xQNWhNoAaP2SCbo1Skm761xdizZLsnO06n9ELsH+oYWkp4JviKtWClwDacMMGAO9VVCC/79 mYNUUxfLnaxef6UDSJ84DZHUnZw7yoLjtyxFVvbzILZcM4rI/aFYIoUPnooXa89pK9OlEzboTQZes KDGVi+tpHXhH4b1ck6tRRLr8M2dNqCiHcab+BHyWlsh+9yMcUgS2n0GoRI9W7q5G3nnO3GZ/uLr0j yBbRleeWqCaZ7tQ1CUxjiM1GRfPw0zr3K+R3tex4Q4RJAH+qRBQaKmfvDAfivtxh2/qaxJvSjMKOC n1ymVCuTON/RZw==; Received: from 91-160-117-201.subs.proxad.net ([91.160.117.201]:51204 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oXNhW-0003Mp-RG; Sun, 11 Sep 2022 10:12:47 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20220910152604.3459-1-marius@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Quintidi 25 Fructidor an 230 de la =?UTF-8?Q?R=C3=A9volution,?= jour de =?UTF-8?Q?l'=C3=89crevisse?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 11 Sep 2022 16:12:44 +0200 In-Reply-To: <20220910152604.3459-1-marius@gnu.org> (Marius Bakke's message of "Sat, 10 Sep 2022 17:26:04 +0200") Message-ID: <87bkrmyp7n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Marius Bakke skribis: > * guix/build-system/gnu.scm (gnu-build, gnu-cross-build)[builder]: Pass > along #:allowed-references and #:disallowed-references. > * guix/build-system/meson.scm (meson-build, meson-cross-build)[builder]: = Likewise. > --- > Hello Guix, > > This is an untested patch that makes #:allowed-references > and #:disallowed-references available to build-side code. > > The intention is to make it easier to use these properties directly when > e.g. wrapping. Consider the following: > > (arguments > (list > #:disallowed-references (list (gexp-input glib "bin") > (gexp-input inkscape/stable)) > #:phases > #~(modify-phases %standard-phases > (replace 'glib-or-gtk-wrap > (let ((wrap (assoc-ref %standard-phases 'glib-or-gtk-wrap))) > (lambda* (#:key inputs outputs disallowed-references > #:allow-other-keys) > (wrap #:inputs (filter (match-lambda > ((label . output) > (not (member output > disallowed-refere= nces)))) > inputs) > #:outputs outputs))))))) > > > This way we don't have to build the list of disallowed references twice, > which is difficult without labels in the case of e.g. `(,glib "bin"). Why not. The only possible drawback I can think of is that it could hide errors: since things listed in #:disallowed-references are automatically removed from wrappers, you could end up successfully building a wrapper that lacks items without noticing. But yeah, maybe that=E2=80=99s a questionable scenario. > + #:allowed-references #$allowed-references > + #:disallowed-references #$disallowed-referenc= es Maxime raised a good point on this one, but I think you can write: #:disallowed-references '#$disallowed-references This will work whether =E2=80=98disallowed-references=E2=80=99 is #f or a l= ist. Thanks! Ludo=E2=80=99.