GNU bug report logs - #57702
[PATCH 0/8] Update rust-clap-3 to 3.2.17

Previous Next

Full log

Message #38 received at 57702 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "VesselWave" <VesselWave <at> protonmail.com>, "57702 <at> debbugs.gnu.org"
 <57702 <at> debbugs.gnu.org>
Subject: Re: [bug#57702] [PATCH v2 1/8] gnu: Add rust-unic-emoji-char-0.9.
Date: Fri, 09 Sep 2022 21:30:22 +0100

Hi VesselWave,

On Fri Sep 9, 2022 at 5:03 PM BST, VesselWave via Guix-patches via wrote:
> +(define-public rust-unic-emoji-char-0.9
> + (package
> + (name "rust-unic-emoji-char")
> + (version "0.9.0")
> + (source (origin
> + (method url-fetch)
> + (uri (crate-uri "unic-emoji-char" version))
> + (file-name (string-append name "-" version ".tar.gz"))
> + (sha256
> + (base32
> + "0ka9fr7s6lv0z43r9xphg9injn35pfxf9g9q18ki0wl9d0g241qb"))))
> + (build-system cargo-build-system)
> + (arguments
> + `(#:skip-build? #t
> + #:cargo-inputs (("rust-unic-property-char" ,rust-unic-char-property-0.9)
> + ("rust-unic-char-range" ,rust-unic-char-range-0.9)
> + ("rust-unic-ucd-version" ,rust-unic-ucd-version-0.9))))
> + (home-page "https://github.com/open-i18n/rust-unic/")
> + (synopsis "Emoji character properties for UNIC")
> + (description "This package provides emoji character properties and for
> +the Unicode and Internationalization Crates (UNIC) project.")
> + (license (list license:expat license:asl2.0))))

That's some... interesting indentation you've got going on there :)
Could you please change this patchset to match the project standard
like this?

> +(define-public rust-unic-emoji-char-0.9
> +  (package
> +    (name "rust-unic-emoji-char")
> +    (version "0.9.0")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (crate-uri "unic-emoji-char" version))
> +              (file-name (string-append name "-" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "0ka9fr7s6lv0z43r9xphg9injn35pfxf9g9q18ki0wl9d0g241qb"))))
> +    (build-system cargo-build-system)
> +    (arguments
> +     (list #:skip-build? #t
         ^^^^ note change of `(...) to (list ...), which is now the standard
> +           #:cargo-inputs `(("rust-unic-property-char" ,rust-unic-char-property-0.9)
                             ^ note the quoting of cargo-inputs, due to the change
                             ^ to (list ...)
> +                            ("rust-unic-char-range" ,rust-unic-char-range-0.9)
> +                            ("rust-unic-ucd-version" ,rust-unic-ucd-version-0.9))))
> +    (home-page "https://github.com/open-i18n/rust-unic")
> +    (synopsis "Emoji character properties for UNIC")
> +    (description
> +     "This package provides emoji character properties and for
> +the Unicode and Internationalization Crates (UNIC) project.")
> +    (license (list license:expat license:asl2.0))))

    -- (

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.