GNU bug report logs - #577
23.0.60; editing image files in non-X frames

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Markus Triska <markus.triska <at> gmx.at>
Subject: bug#577 closed by Chong Yidong <cyd <at> stupidchicken.com> (Re: 
 23.0.60; editing image files in non-X frames)

[Message part 1 (text/plain, inline)]

This is an automatic notification regarding your bug report
which was filed against the emacs package:

#577: 23.0.60; editing image files in non-X frames

It has been closed by Chong Yidong <cyd <at> stupidchicken.com>.

Their explanation is attached below along with your original report.
If this explanation is unsatisfactory and you have not received a
better one in a separate message then please contact Chong Yidong <cyd <at> stupidchicken.com> by
replying to this email.


-- 
577: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=577
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Markus Triska <markus.triska <at> gmx.at>
Cc: 577-done <at> debbugs.gnu.org
Subject: Re: 23.0.60; editing image files in non-X frames
Date: Wed, 30 Jul 2008 09:35:19 -0400

> When I do "emacs -Q -nw sample.png", I cannot use C-n etc. on the
> image data. The following patch fixes this.

Checked in.  Thanks.

[Message part 3 (message/rfc822, inline)]

From: Markus Triska <markus.triska <at> gmx.at>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; editing image files in non-X frames
Date: Sat, 19 Jul 2008 13:39:38 +0200 (CEST)

When I do "emacs -Q -nw sample.png", I cannot use C-n etc. on the
image data. The following patch fixes this.


2008-07-19  Markus Triska  <markus.triska <at> gmx.at>

	* image-mode.el (image-mode): Set image-mode-text-map when image
	cannot be displayed.


diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index 5ffbfe1..fb2eaf1 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -333,13 +333,14 @@ to toggle between display as an image and display as text."
   (image-mode-setup-winprops)
 
   (add-hook 'change-major-mode-hook 'image-toggle-display-text nil t)
-  (if (and (display-images-p)
-	   (not (image-get-display-property)))
-      (image-toggle-display)
-    ;; Set next vars when image is already displayed but local
-    ;; variables were cleared by kill-all-local-variables
-    (use-local-map image-mode-map)
-    (setq cursor-type nil truncate-lines t))
+  (if (display-images-p)
+      (if (not (image-get-display-property))
+	  (image-toggle-display)
+	;; Set next vars when image is already displayed but local
+	;; variables were cleared by kill-all-local-variables
+	(use-local-map image-mode-map)
+	(setq cursor-type nil truncate-lines t))
+    (use-local-map image-mode-text-map))
   (run-mode-hooks 'image-mode-hook)
   (if (display-images-p)
       (message "%s" (concat

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.