GNU bug report logs - #577
23.0.60; editing image files in non-X frames

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (Emacs bug Tracking System)
To: Chong Yidong <cyd <at> stupidchicken.com>
Subject: bug#577: marked as done (23.0.60; editing image files in non-X 
 frames)

[Message part 1 (text/plain, inline)]

Your message dated Wed, 30 Jul 2008 09:35:19 -0400
with message-id <87iqun8pgo.fsf <at> stupidchicken.com>
and subject line Re: 23.0.60; editing image files in non-X frames
has caused the Emacs bug report #577,
regarding 23.0.60; editing image files in non-X frames
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact don <at> donarmstrong.com
immediately.)


-- 
577: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=577
Emacs Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Markus Triska <markus.triska <at> gmx.at>
To: emacs-pretest-bug <at> gnu.org
Subject: 23.0.60; editing image files in non-X frames
Date: Sat, 19 Jul 2008 13:39:38 +0200 (CEST)

When I do "emacs -Q -nw sample.png", I cannot use C-n etc. on the
image data. The following patch fixes this.


2008-07-19  Markus Triska  <markus.triska <at> gmx.at>

	* image-mode.el (image-mode): Set image-mode-text-map when image
	cannot be displayed.


diff --git a/lisp/image-mode.el b/lisp/image-mode.el
index 5ffbfe1..fb2eaf1 100644
--- a/lisp/image-mode.el
+++ b/lisp/image-mode.el
@@ -333,13 +333,14 @@ to toggle between display as an image and display as text."
   (image-mode-setup-winprops)
 
   (add-hook 'change-major-mode-hook 'image-toggle-display-text nil t)
-  (if (and (display-images-p)
-	   (not (image-get-display-property)))
-      (image-toggle-display)
-    ;; Set next vars when image is already displayed but local
-    ;; variables were cleared by kill-all-local-variables
-    (use-local-map image-mode-map)
-    (setq cursor-type nil truncate-lines t))
+  (if (display-images-p)
+      (if (not (image-get-display-property))
+	  (image-toggle-display)
+	;; Set next vars when image is already displayed but local
+	;; variables were cleared by kill-all-local-variables
+	(use-local-map image-mode-map)
+	(setq cursor-type nil truncate-lines t))
+    (use-local-map image-mode-text-map))
   (run-mode-hooks 'image-mode-hook)
   (if (display-images-p)
       (message "%s" (concat

[Message part 3 (message/rfc822, inline)]

From: Chong Yidong <cyd <at> stupidchicken.com>
To: Markus Triska <markus.triska <at> gmx.at>
Cc: 577-done <at> debbugs.gnu.org
Subject: Re: 23.0.60; editing image files in non-X frames
Date: Wed, 30 Jul 2008 09:35:19 -0400

> When I do "emacs -Q -nw sample.png", I cannot use C-n etc. on the
> image data. The following patch fixes this.

Checked in.  Thanks.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.