GNU bug report logs - #57688
[PATCH] gnu: Add wiggle.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Thu, 8 Sep 2022 23:16:02 UTC

Severity: normal

Tags: patch

Done: Liliana Marie Prikler <liliana.prikler <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: "(" <paren <at> disroot.org>
To: "jgart" <jgart <at> dismail.de>, <57688 <at> debbugs.gnu.org>
Cc: Maxime Devos <maximedevos <at> telenet.be>
Subject: [bug#57688] [PATCH v5] gnu: Add wiggle.
Date: Sat, 10 Sep 2022 00:03:02 +0100

Hello! :D

On Fri Sep 9, 2022 at 3:06 PM BST, jgart via Guix-patches via wrote:
> +(define-public wiggle
> +    (package
     ^^
Unnecessary indentation here.

> +      (name "wiggle")
> +      (version "1.3")
> +      (source
> +       (origin
         ^^^^^^^^
Change to `(source (origin'.

> +         (method git-fetch)
> +         (uri
> +          (git-reference
            ^^^^^^^^^^^^^^^
Change to `(uri (git-reference'.

> +      (inputs
> +        (list ncurses))
         ^^^^^^^
Change to `(inputs (list ...))'.

> +      (arguments
> +        (list #:make-flags
          ^
This extra indentation isn't the norm.

> +              #~(list "-I. -O3"
> +                      (string-append "CC=" #$(cc-for-target))
> +                      "INSTALL=\"install\""
> +                      "STRIP=-s"
> +                      (string-append "BINDIR=" #$output "/bin")
> +                      (string-append "MANDIR=" #$output "/share/man")
> +                      (string-append "CC=" #$(cc-for-target))
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Duplicate `CC' definition.

> +                      (string-append "PREFIX=" #$output))
> +               #:phases
> +               #~(modify-phases %standard-phases
> +                   (delete 'configure)
> +                   (replace 'check
> +                     (lambda* (#:key inputs ouputs tests? #:allow-other-keys)
                                        ^^^^^^^^^^^^^
These two are unnecessary, and the latter has a typo anyway.

> +      (home-page "http://neil.brown.name/wiggle/")
> +      (synopsis "Tool for applying patches with conflicts")
> +      (description
> +"@code{wiggle} attempts to apply patches to a target file even if the
   ^^^^^^^^
Add indentation here.

    -- (
This bug report was last modified 2 years and 255 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.